livepilot 1.23.4 → 1.23.5

package/CHANGELOG.md

@@ -1,5 +1,22 @@
 # Changelog
 
+## v1.23.5 — 2026-04-30
+
+### Fixed (Remote Script reliability — credit: PR #35 reporter)
+
+Two production-blocking bugs in the Remote Script that ship into the Ableton process. Reported by @juancarlosaxtro-hash in [PR #35](https://github.com/dreamrec/LivePilot/pull/35); reimplemented cleanly here with regression tests because the originally-submitted patch contained Python indentation errors that broke `transport.py` parse.
+
+- **TCP server now replaces stale clients instead of rejecting new connections.** Previously, when the MCP server restarted uncleanly (e.g. user relaunched Claude Desktop), the Remote Script's `recv()` loop didn't notice the disconnect for up to a second. During that window, the legitimate reconnect attempt was rejected with `STATE_ERROR("Another client is already connected")` — often requiring a full Ableton restart to recover. New behavior: when the accept loop sees a new connection while one is "active", it closes the stale socket from the accept loop, joins the old client thread (with 2 s timeout, OUTSIDE the lock so the thread's `finally` block can acquire it), then accepts the new connection. Single-client architecture means a new connection is proof the old one is dead. New `_current_client` field tracks the active socket so the accept loop can kick it; the `_run_client_session` finally only nulls `_current_client` if it still points at the closing client (the accept loop may have already replaced it). (`remote_script/LivePilot/server.py`)
+- **`get_session_info` no longer crashes on Group tracks.** `song.tracks` includes Group tracks, which raise a `RuntimeError` on `arm` / `has_midi_input` / `has_audio_input` access. `hasattr()` returns `True` regardless because Live's LOM doesn't use `AttributeError` — only try/except on the actual access works. Without the guard, any session with a Group track failed the entire session-info call with *"Main and Return Tracks have no 'Arm' state!"* Surgical try/except around the three LOM-fragile properties only; other fields (`name`, `color_index`, `mute`, `solo`) populate normally; the fragile ones return `None` on Group tracks. (`remote_script/LivePilot/transport.py`)
+
+### Tests
+- `tests/test_remote_server_single_client.py` — rewrote `test_second_client_gets_explicit_state_error` → `test_second_client_replaces_stale_connection` for the new kick-stale semantics.
+- `tests/test_remote_transport_group_tracks.py` — new file, 4 tests covering normal-track baseline, mixed Group+normal sessions, all-Group edge case, and non-fragile-field preservation. Hermetic loader stubs the Ableton-only `Live` module + `version_detect` helpers; autouse fixture restores `sys.modules` to prevent test pollution.
+- Total: **3407 passing**, 1 skipped, 0 failed (up from 3403 in v1.23.4).
+
+### CI green check
+- All 9 jobs green on commit `4aec8e6` (run `25174868624`): metadata-drift, js-entrypoint, amxd-freeze-drift, python-tests × {macos, ubuntu, windows} × {3.11, 3.12}.
+
 ## v1.23.4 — 2026-04-30
 
 ### Fixed (2026-04-30 live-test wave — 38 bugs surfaced, 36 fixed, 2 deferred to v1.23.5)

package/m4l_device/livepilot_bridge.js

@@ -34,7 +34,7 @@ outlets = 2; // 0: to udpsend (responses), 1: to buffer~/status
 // Single source of truth for the bridge version — bumped alongside the
 // rest of the release manifest. Surfaced in the UI via messnamed("livepilot_version", ...)
 // so the frozen .amxd visibly reports which build it was last exported from.
-var VERSION = "1.23.4";
+var VERSION = "1.23.5";
 
 // ── State ──────────────────────────────────────────────────────────────────
 

package/mcp_server/__init__.py

@@ -1,2 +1,2 @@
 """LivePilot MCP Server — bridges MCP protocol to Ableton Live."""
-__version__ = "1.23.4"
+__version__ = "1.23.5"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "livepilot",
-  "version": "1.23.4",
+  "version": "1.23.5",
   "mcpName": "io.github.dreamrec/livepilot",
   "description": "Agentic production system for Ableton Live 12 \u2014 453 tools, 54 domains, 44 semantic moves. Device atlas (5264 devices, 120 enriched, 7 indexes), Splice intelligence (gRPC + GraphQL describe-a-sound + preview + collections + presets), 9-band spectral perception auto-loaded via ensure_analyzer_on_master, Creative Director skill, technique memory, 12 creative intelligence engines",
   "author": "Pilot Studio",

package/remote_script/LivePilot/__init__.py

@@ -5,7 +5,7 @@ Entry point for the ControlSurface. Ableton calls create_instance(c_instance)
 when this script is selected in Preferences > Link, Tempo & MIDI.
 """
 
-__version__ = "1.23.4"
+__version__ = "1.23.5"
 
 from _Framework.ControlSurface import ControlSurface
 from . import router

package/remote_script/LivePilot/server.py

@@ -86,6 +86,12 @@ class LivePilotServer(object):
         self._command_queue = queue.Queue()
         self._client_lock = threading.Lock()
         self._client_connected = False
+        # Track the active client socket so we can close it from the accept
+        # loop when a new connection arrives. See _server_loop's kick-stale
+        # flow — without this, an unclean MCP-server restart leaves the
+        # Remote Script in a state where new connections get rejected until
+        # the old socket times out (often requiring an Ableton restart).
+        self._current_client = None
 
     # ── Public API ───────────────────────────────────────────────────────
 
@@ -138,30 +144,35 @@ class LivePilotServer(object):
         while self._running:
             try:
                 client, addr = self._server_socket.accept()
+                # Single-client design: a new connection means the previous one
+                # is dead. Close the stale socket and join its thread (outside
+                # the lock so the thread's finally block can acquire it), then
+                # accept the new connection. Without this, the server could
+                # reject reconnections for up to 1s after an unclean MCP-server
+                # restart — the old recv() loop hadn't yet observed EOF.
+                stale_thread = None
+                stale_client = None
+                with self._client_lock:
+                    if self._client_connected and self._current_client is not None:
+                        stale_client = self._current_client
+                        stale_thread = self._client_thread
+                        self._log(
+                            "Replacing stale client with new connection from %s:%d" % addr
+                        )
+                if stale_client is not None:
+                    try:
+                        stale_client.close()
+                    except OSError:
+                        pass
+                if stale_thread is not None and stale_thread.is_alive():
+                    # 2s is generous — the old recv() unblocks the moment we
+                    # close the socket above, then the thread's finally block
+                    # acquires the lock, resets _client_connected, and exits.
+                    stale_thread.join(timeout=2)
+
                 with self._client_lock:
-                    if self._client_connected:
-                        # Reject concurrent clients with an explicit message
-                        self._log("Rejected client from %s:%d (another client is connected)" % addr)
-                        try:
-                            reject = json.dumps({
-                                "id": "system",
-                                "ok": False,
-                                "error": {
-                                    "code": "STATE_ERROR",
-                                    "message": "Another client is already connected. "
-                                               "LivePilot accepts one client at a time. "
-                                               "Disconnect the current client first."
-                                }
-                            }) + "\n"
-                            client.sendall(reject.encode("utf-8"))
-                        except OSError:
-                            pass
-                        try:
-                            client.close()
-                        except OSError:
-                            pass
-                        continue
                     self._client_connected = True
+                    self._current_client = client
                     self._client_thread = threading.Thread(
                         target=self._run_client_session,
                         args=(client, addr),
@@ -194,6 +205,11 @@ class LivePilotServer(object):
                 pass
             with self._client_lock:
                 self._client_connected = False
+                # Only clear _current_client if it still points at us — the
+                # accept loop may have already replaced us with a new client
+                # (in which case _current_client is the new socket).
+                if self._current_client is client:
+                    self._current_client = None
             self._log("Client disconnected")
 
     def _handle_client(self, client):

package/remote_script/LivePilot/transport.py

@@ -11,16 +11,26 @@ def get_session_info(song, params):
     """Return comprehensive session state."""
     tracks_info = []
     for i, track in enumerate(song.tracks):
-        tracks_info.append({
+        track_data = {
             "index": i,
             "name": track.name,
             "color_index": track.color_index,
-            "has_midi_input": track.has_midi_input,
-            "has_audio_input": track.has_audio_input,
             "mute": track.mute,
             "solo": track.solo,
-            "arm": track.arm,
-        })
+        }
+        # Group tracks (and any Return tracks that leak into song.tracks)
+        # don't expose `arm` / `has_midi_input` / `has_audio_input`. The
+        # Live Object Model raises a RuntimeError on access — and crucially
+        # `hasattr()` returns True regardless, so we must use try/except.
+        try:
+            track_data["arm"] = track.arm
+            track_data["has_midi_input"] = track.has_midi_input
+            track_data["has_audio_input"] = track.has_audio_input
+        except Exception:
+            track_data["arm"] = None
+            track_data["has_midi_input"] = None
+            track_data["has_audio_input"] = None
+        tracks_info.append(track_data)
 
     return_tracks_info = []
     for i, track in enumerate(song.return_tracks):

package/server.json

@@ -6,7 +6,7 @@
     "url": "https://github.com/dreamrec/LivePilot",
     "source": "github"
   },
-  "version": "1.23.4",
+  "version": "1.23.5",
   "packages": [
     {
       "registryType": "npm",