livepilot 1.17.4 → 1.17.5

package/CHANGELOG.md

@@ -1,5 +1,47 @@
 # Changelog
 
+## 1.17.5 — Classify error-only commit payloads as failures (April 23 2026)
+
+### Fixed
+
+- **`_classify_commit_result` now catches error-only commit payloads**
+  (`mcp_server/tools/_agent_os_engine/iteration.py`): Codex review on
+  PR #27 caught a gap I shipped in v1.17.3. My docstring listed
+  `{"error": ...}` as a known failure signal, but the implementation
+  never checked for a top-level `error` key. `commit_branch_async` in
+  `mcp_server/experiment/engine.py` returns error-only dicts in 5+
+  paths (`Branch {id} not found`, `Branch has no compiled plan`,
+  `Experiment {id} not found`). These fell through to
+  `"committed"` because they had no explicit `committed: false` /
+  `ok: false` / `status: "failed"` / `steps_ok: 0` signal. Classic
+  truth-gap: the iteration loop could claim success while the commit
+  applied zero steps.
+
+  Fix: if `result.get("error")` is truthy AND `result.get("committed")`
+  is not explicitly `True`, return `"commit_failed"`. The explicit-
+  committed caveat handles the edge case where a payload reports
+  success with a warning in the `error` field.
+
+### Tests
+
+4 new TDD tests in `tests/test_iterate_toward_goal.py`:
+- `{"error": "Experiment not found"}` → `commit_failed`
+- `{"error": "Branch not found"}` (real commit_branch_async shape) →
+  `commit_failed`, with the payload surfaced on `commit_result`
+- Same discipline on the `on_timeout="commit_best"` path
+- Edge case: `{"committed": True, "error": "warning...",
+  steps_ok: 3}` still returns `committed` (explicit success overrides)
+
+2726 → 2730 passing.
+
+### Process note
+
+The fix that shipped in v1.17.3 was itself caught by a subsequent
+review. Writing a docstring listing a failure signal and forgetting
+to implement the check is the classic TDD violation the discipline
+exists to prevent. Codex's automated review acted as the missing
+failing-test-first pass.
+
 ## 1.17.4 — Shape cleanup + memory probe (April 23 2026)
 
 ### Fixed

package/m4l_device/livepilot_bridge.js

@@ -95,7 +95,7 @@ function anything() {
 function dispatch(cmd, args) {
     switch(cmd) {
         case "ping":
-            send_response({"ok": true, "version": "1.17.4"});
+            send_response({"ok": true, "version": "1.17.5"});
             break;
         case "get_params":
             cmd_get_params(args);

package/mcp_server/__init__.py

@@ -1,2 +1,2 @@
 """LivePilot MCP Server — bridges MCP protocol to Ableton Live."""
-__version__ = "1.17.4"
+__version__ = "1.17.5"

package/mcp_server/tools/_agent_os_engine/iteration.py

@@ -102,6 +102,13 @@ def _classify_commit_result(result: Any) -> str:
         return "commit_failed"
     if result.get("status") == "failed":
         return "commit_failed"
+    # v1.17.5 (Codex PR#27 review): a top-level "error" key with no
+    # explicit committed=True is a failure signal. commit_branch_async
+    # returns {"error": "Branch not found"} / {"error": "Branch has no
+    # compiled plan"} / {"error": "Experiment not found"} in several
+    # paths — without this check they'd fall through to "committed".
+    if result.get("error") and result.get("committed") is not True:
+        return "commit_failed"
     steps_ok = result.get("steps_ok")
     steps_failed = result.get("steps_failed")
     if steps_ok == 0 and (steps_failed is None or steps_failed > 0):

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "livepilot",
-  "version": "1.17.4",
+  "version": "1.17.5",
   "mcpName": "io.github.dreamrec/livepilot",
   "description": "Agentic production system for Ableton Live 12 — 427 tools, 52 domains. Device atlas (1305 devices), sample engine (Splice + browser + filesystem), auto-composition, spectral perception, technique memory, creative intelligence (12 engines)",
   "author": "Pilot Studio",

package/remote_script/LivePilot/__init__.py

@@ -5,7 +5,7 @@ Entry point for the ControlSurface. Ableton calls create_instance(c_instance)
 when this script is selected in Preferences > Link, Tempo & MIDI.
 """
 
-__version__ = "1.17.4"
+__version__ = "1.17.5"
 
 from _Framework.ControlSurface import ControlSurface
 from . import router

package/server.json

@@ -6,12 +6,12 @@
     "url": "https://github.com/dreamrec/LivePilot",
     "source": "github"
   },
-  "version": "1.17.4",
+  "version": "1.17.5",
   "packages": [
     {
       "registryType": "npm",
       "identifier": "livepilot",
-      "version": "1.17.4",
+      "version": "1.17.5",
       "transport": {
         "type": "stdio"
       }