livepilot 1.17.3 → 1.17.5

package/CHANGELOG.md

@@ -1,5 +1,95 @@
 # Changelog
 
+## 1.17.5 — Classify error-only commit payloads as failures (April 23 2026)
+
+### Fixed
+
+- **`_classify_commit_result` now catches error-only commit payloads**
+  (`mcp_server/tools/_agent_os_engine/iteration.py`): Codex review on
+  PR #27 caught a gap I shipped in v1.17.3. My docstring listed
+  `{"error": ...}` as a known failure signal, but the implementation
+  never checked for a top-level `error` key. `commit_branch_async` in
+  `mcp_server/experiment/engine.py` returns error-only dicts in 5+
+  paths (`Branch {id} not found`, `Branch has no compiled plan`,
+  `Experiment {id} not found`). These fell through to
+  `"committed"` because they had no explicit `committed: false` /
+  `ok: false` / `status: "failed"` / `steps_ok: 0` signal. Classic
+  truth-gap: the iteration loop could claim success while the commit
+  applied zero steps.
+
+  Fix: if `result.get("error")` is truthy AND `result.get("committed")`
+  is not explicitly `True`, return `"commit_failed"`. The explicit-
+  committed caveat handles the edge case where a payload reports
+  success with a warning in the `error` field.
+
+### Tests
+
+4 new TDD tests in `tests/test_iterate_toward_goal.py`:
+- `{"error": "Experiment not found"}` → `commit_failed`
+- `{"error": "Branch not found"}` (real commit_branch_async shape) →
+  `commit_failed`, with the payload surfaced on `commit_result`
+- Same discipline on the `on_timeout="commit_best"` path
+- Edge case: `{"committed": True, "error": "warning...",
+  steps_ok: 3}` still returns `committed` (explicit success overrides)
+
+2726 → 2730 passing.
+
+### Process note
+
+The fix that shipped in v1.17.3 was itself caught by a subsequent
+review. Writing a docstring listing a failure signal and forgetting
+to implement the check is the classic TDD violation the discipline
+exists to prevent. Codex's automated review acted as the missing
+failing-test-first pass.
+
+## 1.17.4 — Shape cleanup + memory probe (April 23 2026)
+
+### Fixed
+
+- **`get_session_kernel` now probes the memory store** instead of
+  hardcoding `memory_ok=True` (`mcp_server/runtime/tools.py`). If the
+  underlying technique store raises on `list_techniques` (disk full,
+  corrupted index, permissions error), the kernel previously still
+  reported memory as available to orchestration planners. Same
+  truth-gap class as the v1.17.3 web/flucoma fix — should have been
+  caught by the same review pass. Now probed the same way
+  `get_capability_state` does, wrapped in try/except.
+- **`capability_state` flat shape** in session kernel
+  (`mcp_server/runtime/tools.py`): `state.to_dict()` wraps its output as
+  `{"capability_state": {...}}` — that's the right shape for the
+  standalone `get_capability_state` tool, but when stored on the kernel
+  it produced the ugly double-nested
+  `kernel["capability_state"]["capability_state"]["domains"]`. v1.17.3
+  probe tests worked around it with defensive
+  `outer.get("capability_state", outer)`. Fix: unwrap the outer key
+  once before passing to `build_session_kernel`. Consumer path is
+  now `kernel["capability_state"]["domains"]` directly. Standalone
+  `get_capability_state` return shape unchanged.
+
+### Tests
+
+- 4 new TDD tests in `tests/test_runtime_capability_probes.py`:
+  - memory probe raises → kernel reports memory unavailable
+  - memory probe succeeds → kernel reports available
+  - kernel's capability_state has no nested `capability_state` key
+  - end-to-end flat access without defensive fallbacks
+- Consumer updates:
+  - `test_session_kernel.py:203` — removed extra level
+  - `test_runtime_capability_probes.py` (4 places) — removed
+    defensive `outer.get('capability_state', outer)` pattern now that
+    the shape is known-flat
+
+2722 → 2726 passing.
+
+### Known follow-up
+
+Audit while writing this release flagged a third bug in
+`mcp_server/runtime/safety_kernel.py:244`: the safety kernel reads
+`capability_state.get("mode", "normal")` but the actual shape uses
+`overall_mode`, not `mode`. The `.get(..., "normal")` default silently
+falls back, so `read_only` mode gating never kicks in. Separate fix,
+out of scope for this release.
+
 ## 1.17.3 — Truth-gap remediation, for real (April 23 2026)
 
 ### Fixed

package/m4l_device/livepilot_bridge.js

@@ -95,7 +95,7 @@ function anything() {
 function dispatch(cmd, args) {
     switch(cmd) {
         case "ping":
-            send_response({"ok": true, "version": "1.17.3"});
+            send_response({"ok": true, "version": "1.17.5"});
             break;
         case "get_params":
             cmd_get_params(args);

package/mcp_server/__init__.py

@@ -1,2 +1,2 @@
 """LivePilot MCP Server — bridges MCP protocol to Ableton Live."""
-__version__ = "1.17.3"
+__version__ = "1.17.5"

package/mcp_server/runtime/tools.py

@@ -185,11 +185,21 @@ def get_session_kernel(
     web_ok = _probe_web()
     flucoma_ok = _probe_flucoma()
 
+    # v1.17.4: probe memory the same way too. Previously memory_ok=True was
+    # hardcoded — if the store raised, the kernel still reported memory
+    # available. Same truth-gap class as the v1.17.3 web/flucoma fix.
+    memory_ok = False
+    try:
+        _memory_store.list_techniques(limit=1)
+        memory_ok = True
+    except Exception as exc:
+        logger.debug("get_session_kernel memory probe failed: %s", exc)
+
     state = build_capability_state(
         session_ok=session_ok,
         analyzer_ok=analyzer_ok,
         analyzer_fresh=analyzer_fresh,
-        memory_ok=True,
+        memory_ok=memory_ok,
         web_ok=web_ok,
         flucoma_ok=flucoma_ok,
     )
@@ -248,9 +258,18 @@ def get_session_kernel(
     except Exception as e:
         kernel_warnings.append(f"session_memory_unavailable: {e}")
 
+    # v1.17.4: state.to_dict() wraps its output as {"capability_state": {...}}
+    # because that shape is what the standalone get_capability_state tool
+    # returns. When building the session kernel, that wrapper becomes the
+    # ugly double-nested kernel["capability_state"]["capability_state"]["domains"]
+    # path. Unwrap once here so kernel consumers get
+    # kernel["capability_state"]["domains"] directly.
+    _cap_dict = state.to_dict()
+    _cap_flat = _cap_dict.get("capability_state", _cap_dict)
+
     kernel = build_session_kernel(
         session_info=session_info,
-        capability_state=state.to_dict(),
+        capability_state=_cap_flat,
         request_text=request_text,
         mode=mode,
         aggression=aggression,

package/mcp_server/tools/_agent_os_engine/iteration.py

@@ -102,6 +102,13 @@ def _classify_commit_result(result: Any) -> str:
         return "commit_failed"
     if result.get("status") == "failed":
         return "commit_failed"
+    # v1.17.5 (Codex PR#27 review): a top-level "error" key with no
+    # explicit committed=True is a failure signal. commit_branch_async
+    # returns {"error": "Branch not found"} / {"error": "Branch has no
+    # compiled plan"} / {"error": "Experiment not found"} in several
+    # paths — without this check they'd fall through to "committed".
+    if result.get("error") and result.get("committed") is not True:
+        return "commit_failed"
     steps_ok = result.get("steps_ok")
     steps_failed = result.get("steps_failed")
     if steps_ok == 0 and (steps_failed is None or steps_failed > 0):

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "livepilot",
-  "version": "1.17.3",
+  "version": "1.17.5",
   "mcpName": "io.github.dreamrec/livepilot",
   "description": "Agentic production system for Ableton Live 12 — 427 tools, 52 domains. Device atlas (1305 devices), sample engine (Splice + browser + filesystem), auto-composition, spectral perception, technique memory, creative intelligence (12 engines)",
   "author": "Pilot Studio",

package/remote_script/LivePilot/__init__.py

@@ -5,7 +5,7 @@ Entry point for the ControlSurface. Ableton calls create_instance(c_instance)
 when this script is selected in Preferences > Link, Tempo & MIDI.
 """
 
-__version__ = "1.17.3"
+__version__ = "1.17.5"
 
 from _Framework.ControlSurface import ControlSurface
 from . import router

package/server.json

@@ -6,12 +6,12 @@
     "url": "https://github.com/dreamrec/LivePilot",
     "source": "github"
   },
-  "version": "1.17.3",
+  "version": "1.17.5",
   "packages": [
     {
       "registryType": "npm",
       "identifier": "livepilot",
-      "version": "1.17.3",
+      "version": "1.17.5",
       "transport": {
         "type": "stdio"
       }