livekit-client 1.2.7 → 1.2.10

package/src/room/RTCEngine.ts

@@ -180,7 +180,7 @@ export default class RTCEngine extends (EventEmitter as new () => TypedEventEmit
         },
         reject: () => {
           clearTimeout(publicationTimeout);
-          reject('Cancelled publication by calling unpublish');
+          reject(new Error('Cancelled publication by calling unpublish'));
         },
       };
       this.client.sendAddTrack(req);
@@ -452,11 +452,11 @@ export default class RTCEngine extends (EventEmitter as new () => TypedEventEmit
       return;
     }
     const dp = DataPacket.decode(new Uint8Array(buffer));
-    if (dp.speaker) {
+    if (dp.value?.$case === 'speaker') {
       // dispatch speaker updates
-      this.emit(EngineEvent.ActiveSpeakersUpdate, dp.speaker.speakers);
-    } else if (dp.user) {
-      this.emit(EngineEvent.DataPacketReceived, dp.user, dp.kind);
+      this.emit(EngineEvent.ActiveSpeakersUpdate, dp.value.speaker.speakers);
+    } else if (dp.value?.$case === 'user') {
+      this.emit(EngineEvent.DataPacketReceived, dp.value.user, dp.kind);
     }
   };
 

package/src/room/Room.ts

@@ -211,7 +211,8 @@ class Room extends (EventEmitter as new () => TypedEmitter<RoomEventCallbacks>)
 
     if (this.connectFuture) {
       return this.connectFuture.promise;
-    } else if (this.reconnectFuture) {
+    }
+    if (this.reconnectFuture) {
       this.connectFuture = this.reconnectFuture;
       return this.connectFuture.promise;
     }
@@ -398,27 +399,42 @@ class Room extends (EventEmitter as new () => TypedEmitter<RoomEventCallbacks>)
         break;
       case 'speaker':
         req = SimulateScenario.fromPartial({
-          speakerUpdate: 3,
+          scenario: {
+            $case: 'speakerUpdate',
+            speakerUpdate: 3,
+          },
         });
         break;
       case 'node-failure':
         req = SimulateScenario.fromPartial({
-          nodeFailure: true,
+          scenario: {
+            $case: 'nodeFailure',
+            nodeFailure: true,
+          },
         });
         break;
       case 'server-leave':
         req = SimulateScenario.fromPartial({
-          serverLeave: true,
+          scenario: {
+            $case: 'serverLeave',
+            serverLeave: true,
+          },
         });
         break;
       case 'migration':
         req = SimulateScenario.fromPartial({
-          migration: true,
+          scenario: {
+            $case: 'migration',
+            migration: true,
+          },
         });
         break;
       case 'switch-candidate':
         req = SimulateScenario.fromPartial({
-          switchCandidateProtocol: 1,
+          scenario: {
+            $case: 'switchCandidateProtocol',
+            switchCandidateProtocol: 1,
+          },
         });
         postAction = () => {
           this.engine.publisher?.createAndSendOffer({ iceRestart: true });

package/src/room/participant/LocalParticipant.ts

@@ -800,10 +800,13 @@ export default class LocalParticipant extends Participant {
 
     const packet: DataPacket = {
       kind,
-      user: {
-        participantSid: this.sid,
-        payload: data,
-        destinationSids: dest,
+      value: {
+        $case: 'user',
+        user: {
+          participantSid: this.sid,
+          payload: data,
+          destinationSids: dest,
+        },
       },
     };
 

package/src/room/participant/Participant.ts

@@ -69,10 +69,11 @@ export default class Participant extends (EventEmitter as new () => TypedEmitter
   private _connectionQuality: ConnectionQuality = ConnectionQuality.Unknown;
 
   /** @internal */
-  constructor(sid: string, identity: string) {
+  constructor(sid: string, identity: string, name?: string) {
     super();
     this.sid = sid;
     this.identity = identity;
+    this.name = name;
     this.audioTracks = new Map();
     this.videoTracks = new Map();
     this.tracks = new Map();

package/src/room/participant/RemoteParticipant.ts

@@ -24,12 +24,12 @@ export default class RemoteParticipant extends Participant {
 
   /** @internal */
   static fromParticipantInfo(signalClient: SignalClient, pi: ParticipantInfo): RemoteParticipant {
-    return new RemoteParticipant(signalClient, pi.sid, pi.identity);
+    return new RemoteParticipant(signalClient, pi.sid, pi.identity, pi.name);
   }
 
   /** @internal */
-  constructor(signalClient: SignalClient, id: string, name?: string) {
-    super(id, name || '');
+  constructor(signalClient: SignalClient, sid: string, identity?: string, name?: string) {
+    super(sid, identity || '', name);
     this.signalClient = signalClient;
     this.tracks = new Map();
     this.audioTracks = new Map();

package/src/room/participant/publishUtils.test.ts

@@ -93,6 +93,18 @@ describe('computeVideoEncodings', () => {
     expect(encodings![1].maxBitrate).toBe(VideoPresets.h360.encoding.maxBitrate);
   });
 
+  it('returns one encoding if an empty array is provided for custom screen share layers', () => {
+    const encodings = computeVideoEncodings(true, 1920, 1080, {
+      simulcast: true,
+      screenShareSimulcastLayers: [],
+    });
+    expect(encodings).toHaveLength(1);
+
+    // ensure they are what we expect
+    expect(encodings![0].rid).toBe('q');
+    expect(encodings![0].scaleResolutionDownBy).toBe(1);
+  });
+
   it('respects provided min resolution', () => {
     const encodings = computeVideoEncodings(false, 100, 120, {
       simulcast: true,

package/src/room/participant/publishUtils.ts

@@ -136,26 +136,28 @@ export function computeVideoEncodings(
       sortPresets(options?.videoSimulcastLayers) ?? defaultSimulcastLayers(isScreenShare, original);
   }
   let midPreset: VideoPreset | undefined;
-  const lowPreset = presets[0];
-  if (presets.length > 1) {
-    [, midPreset] = presets;
-  }
+  if (presets.length > 0) {
+    const lowPreset = presets[0];
+    if (presets.length > 1) {
+      [, midPreset] = presets;
+    }
 
-  // NOTE:
-  //   1. Ordering of these encodings is important. Chrome seems
-  //      to use the index into encodings to decide which layer
-  //      to disable when CPU constrained.
-  //      So encodings should be ordered in increasing spatial
-  //      resolution order.
-  //   2. ion-sfu translates rids into layers. So, all encodings
-  //      should have the base layer `q` and then more added
-  //      based on other conditions.
-  const size = Math.max(width, height);
-  if (size >= 960 && midPreset) {
-    return encodingsFromPresets(width, height, [lowPreset, midPreset, original]);
-  }
-  if (size >= 480) {
-    return encodingsFromPresets(width, height, [lowPreset, original]);
+    // NOTE:
+    //   1. Ordering of these encodings is important. Chrome seems
+    //      to use the index into encodings to decide which layer
+    //      to disable when CPU constrained.
+    //      So encodings should be ordered in increasing spatial
+    //      resolution order.
+    //   2. ion-sfu translates rids into layers. So, all encodings
+    //      should have the base layer `q` and then more added
+    //      based on other conditions.
+    const size = Math.max(width, height);
+    if (size >= 960 && midPreset) {
+      return encodingsFromPresets(width, height, [lowPreset, midPreset, original]);
+    }
+    if (size >= 480) {
+      return encodingsFromPresets(width, height, [lowPreset, original]);
+    }
   }
   return encodingsFromPresets(width, height, [original]);
 }

package/src/room/track/RemoteAudioTrack.ts

@@ -5,11 +5,10 @@ import { Track } from './Track';
 export default class RemoteAudioTrack extends RemoteTrack {
   private prevStats?: AudioReceiverStats;
 
-  private elementVolume: number;
+  private elementVolume: number | undefined;
 
   constructor(mediaTrack: MediaStreamTrack, sid: string, receiver?: RTCRtpReceiver) {
     super(mediaTrack, sid, Track.Kind.Audio, receiver);
-    this.elementVolume = 1;
   }
 
   /**
@@ -23,10 +22,19 @@ export default class RemoteAudioTrack extends RemoteTrack {
   }
 
   /**
-   * gets the volume for all attached audio elements
+   * gets the volume of attached audio elements (loudest)
    */
   getVolume(): number {
-    return this.elementVolume;
+    if (this.elementVolume) {
+      return this.elementVolume;
+    }
+    let highestVolume = 0;
+    this.attachedElements.forEach((element) => {
+      if (element.volume > highestVolume) {
+        highestVolume = element.volume;
+      }
+    });
+    return highestVolume;
   }
 
   attach(): HTMLMediaElement;
@@ -37,7 +45,9 @@ export default class RemoteAudioTrack extends RemoteTrack {
     } else {
       super.attach(element);
     }
-    element.volume = this.elementVolume;
+    if (this.elementVolume) {
+      element.volume = this.elementVolume;
+    }
     return element;
   }
 

package/src/room/track/RemoteTrackPublication.ts

@@ -134,6 +134,7 @@ export default class RemoteTrackPublication extends TrackPublication {
       prevTrack.off(TrackEvent.VideoDimensionsChanged, this.handleVideoDimensionsChange);
       prevTrack.off(TrackEvent.VisibilityChanged, this.handleVisibilityChange);
       prevTrack.off(TrackEvent.Ended, this.handleEnded);
+      prevTrack.detach();
     }
     super.setTrack(track);
     if (track) {