livedesk 0.1.549 → 0.1.551

package/README.md

@@ -4,10 +4,10 @@
 RemoteFast package for the current operating system and CPU, so Windows, macOS,
 and Linux native binaries are no longer downloaded together.
 
-One-command LiveDesk application. The same launcher resolves this computer's
-Hub or Client role. A Client starts one managed Agent. A Hub starts the Hub
-server plus one headless Self Agent, so the Hub computer also appears on the
-wall and can be controlled like the other computers.
+One-command LiveDesk application. The same launcher resolves this computer's
+Hub or Client role. A Client starts one managed Agent. A Hub starts the Hub
+server plus one headless Self Agent, so the Hub computer also appears on the
+wall and can be controlled like the other computers.
 
 The `hub/`, `client/`, `runtime-core/`, and `web/` folders in this package are
 generated copies. Edit the source packages and run
@@ -45,11 +45,11 @@ npx -y --prefer-online livedesk@latest --force-role client
 npx -y --prefer-online livedesk@latest hub
 ```
 
-This starts the LiveDesk Hub, opens the local screen wall, accepts clients, and
-connects one local Self Agent through loopback TCP. The Self Agent reuses the
-Hub computer's stable device identity and does not open another login or status
-page. Hub shutdown, update, and role change drain that exact Agent tree before
-the launcher exits or hands off.
+This starts the LiveDesk Hub, opens the local screen wall, accepts clients, and
+connects one local Self Agent through loopback TCP. The Self Agent reuses the
+Hub computer's stable device identity and does not open another login or status
+page. Hub shutdown, update, and role change drain that exact Agent tree before
+the launcher exits or hands off.
 The Hub UI/API listens on `127.0.0.1` by default while the client endpoint
 continues to listen on the LAN.
 

package/bin/livedesk.js

@@ -46,11 +46,11 @@ import {
   readDeadWindowsOwnedProcessManifest,
   readWindowsOwnedProcessManifest
 } from '../client/src/runtime/windows-owned-process-manifest.js';
-import { inspectMacDiagnosticLease } from '../diagnostics/livedesk-mac-physical-isolation.mjs';
-import {
-  buildHubSelfAgentLaunchSpec,
-  createHubSelfAgentSupervisor
-} from '../bootstrap/hub-self-agent.js';
+import { inspectMacDiagnosticLease } from '../diagnostics/livedesk-mac-physical-isolation.mjs';
+import {
+  buildHubSelfAgentLaunchSpec,
+  createHubSelfAgentSupervisor
+} from '../bootstrap/hub-self-agent.js';
 
 const require = createRequire(import.meta.url);
 const __dirname = dirname(fileURLToPath(import.meta.url));
@@ -2540,47 +2540,47 @@ async function runManager(args, resolvedRole = null, runtimeLock = null, updateH
   let updateStopTimer = null;
   let updateHardStopTimer = null;
   let launcherShutdownSignal = '';
-  let launcherShutdownHardStopTimer = null;
-  let runtimeShutdownWatcher = null;
-  let selfAgentStopPromise = null;
-  const launcherSignalHandlers = new Map();
-
-  let hubSelfAgent = null;
-  try {
-    const clientEntry = resolve(packageRoot, 'client', 'bin', 'livedesk-client.js');
-    if (!existsSync(clientEntry)) {
-      throw new Error('the packaged Client runtime is missing');
-    }
-    hubSelfAgent = createHubSelfAgentSupervisor({
-      launch: buildHubSelfAgentLaunchSpec({
-        nodePath: process.execPath,
-        clientEntry,
-        remotePort,
-        pairToken,
-        deviceId: env.LIVEDESK_DEVICE_ID,
-        deviceName: env.LIVEDESK_DEVICE_NAME,
-        stateDir: MANAGER_STATE_DIR,
-        runtimeOwner,
-        baseEnv: env
-      }),
-      report: reportLauncherUpdate
-    });
-  } catch (error) {
-    reportLauncherUpdate(
-      `[LiveDesk Hub] Self Agent is unavailable: ${error?.message || error}. Remote Clients remain available.`,
-      true
-    );
-  }
-
-  const stopHubSelfAgent = reason => {
-    if (!hubSelfAgent) return Promise.resolve({ ok: true, skipped: true });
-    if (!selfAgentStopPromise) {
-      selfAgentStopPromise = hubSelfAgent.stop(reason).finally(() => {
-        selfAgentStopPromise = null;
-      });
-    }
-    return selfAgentStopPromise;
-  };
+  let launcherShutdownHardStopTimer = null;
+  let runtimeShutdownWatcher = null;
+  let selfAgentStopPromise = null;
+  const launcherSignalHandlers = new Map();
+
+  let hubSelfAgent = null;
+  try {
+    const clientEntry = resolve(packageRoot, 'client', 'bin', 'livedesk-client.js');
+    if (!existsSync(clientEntry)) {
+      throw new Error('the packaged Client runtime is missing');
+    }
+    hubSelfAgent = createHubSelfAgentSupervisor({
+      launch: buildHubSelfAgentLaunchSpec({
+        nodePath: process.execPath,
+        clientEntry,
+        remotePort,
+        pairToken,
+        deviceId: env.LIVEDESK_DEVICE_ID,
+        deviceName: env.LIVEDESK_DEVICE_NAME,
+        stateDir: MANAGER_STATE_DIR,
+        runtimeOwner,
+        baseEnv: env
+      }),
+      report: reportLauncherUpdate
+    });
+  } catch (error) {
+    reportLauncherUpdate(
+      `[LiveDesk Hub] Self Agent is unavailable: ${error?.message || error}. Remote Clients remain available.`,
+      true
+    );
+  }
+
+  const stopHubSelfAgent = reason => {
+    if (!hubSelfAgent) return Promise.resolve({ ok: true, skipped: true });
+    if (!selfAgentStopPromise) {
+      selfAgentStopPromise = hubSelfAgent.stop(reason).finally(() => {
+        selfAgentStopPromise = null;
+      });
+    }
+    return selfAgentStopPromise;
+  };
 
   const removeLauncherSignalHandlers = () => {
     for (const [signal, handler] of launcherSignalHandlers) {
@@ -2589,7 +2589,7 @@ async function runManager(args, resolvedRole = null, runtimeLock = null, updateH
     launcherSignalHandlers.clear();
   };
 
-  const requestLauncherShutdown = signal => {
+  const requestLauncherShutdown = signal => {
     if (launcherShutdownSignal) return;
     launcherShutdownSignal = signal;
     restartRequest = null;
@@ -2601,18 +2601,18 @@ async function runManager(args, resolvedRole = null, runtimeLock = null, updateH
       clearTimeout(updateStopTimer);
       updateStopTimer = null;
     }
-    if (updateHardStopTimer) {
+    if (updateHardStopTimer) {
       clearTimeout(updateHardStopTimer);
-      updateHardStopTimer = null;
-    }
-    void stopHubSelfAgent(`launcher-${signal}`);
-    const child = activeChild;
-    if (!child || child.exitCode !== null || child.signalCode) {
-      void stopHubSelfAgent(`launcher-${signal}`).finally(() => {
-        try { hubLogStream?.end(); } catch {}
-        process.exit(0);
-      });
-      return;
+      updateHardStopTimer = null;
+    }
+    void stopHubSelfAgent(`launcher-${signal}`);
+    const child = activeChild;
+    if (!child || child.exitCode !== null || child.signalCode) {
+      void stopHubSelfAgent(`launcher-${signal}`).finally(() => {
+        try { hubLogStream?.end(); } catch {}
+        process.exit(0);
+      });
+      return;
     }
     reportLauncherUpdate(
       `[LiveDesk Hub] Launcher received ${signal}; requesting graceful Hub shutdown for pid=${child.pid || 'unknown'}.`
@@ -2859,17 +2859,17 @@ async function runManager(args, resolvedRole = null, runtimeLock = null, updateH
           failPreflight(message);
           return;
         }
-        restartRequest = {
+        restartRequest = {
           ...request,
           latestVersion: requestedVersion,
           pid: requestPid,
           operationId,
           _neutralCwd: neutralCwd,
           _originalCwd: UPDATE_ORIGINAL_CWD
-        };
-        reportLauncherUpdate(`[LiveDesk Hub] Restart requested for update ${request.operationId || 'unknown'} target=${requestedVersion}.`);
-        void stopHubSelfAgent('hub-update');
-        const updateChild = activeChild;
+        };
+        reportLauncherUpdate(`[LiveDesk Hub] Restart requested for update ${request.operationId || 'unknown'} target=${requestedVersion}.`);
+        void stopHubSelfAgent('hub-update');
+        const updateChild = activeChild;
         let shutdownFallbackStarted = false;
         const forceStop = reason => {
           if (!updateChild || updateChild.exitCode !== null || updateChild.signalCode) return;
@@ -2910,7 +2910,7 @@ async function runManager(args, resolvedRole = null, runtimeLock = null, updateH
     }
   };
 
-  const startHubProcess = () => {
+  const startHubProcess = () => {
     const stderrChunks = [];
     let stderrLength = 0;
     const child = spawn(process.execPath, [hubEntry, ...options.forwarded], {
@@ -2918,22 +2918,22 @@ async function runManager(args, resolvedRole = null, runtimeLock = null, updateH
       stdio: ['inherit', 'pipe', 'pipe'],
       windowsHide: !debugConsole
     });
-    activeChild = child;
-
-    void waitForManager(hubProbeBaseUrl).then(ok => {
-      if (!ok
-        || activeChild !== child
-        || child.exitCode !== null
-        || child.signalCode
-        || launcherShutdownSignal
-        || restartRequest) return;
-      hubSelfAgent?.start();
-    }).catch(error => {
-      reportLauncherUpdate(
-        `[LiveDesk Hub] Self Agent startup wait failed: ${error?.message || error}.`,
-        true
-      );
-    });
+    activeChild = child;
+
+    void waitForManager(hubProbeBaseUrl).then(ok => {
+      if (!ok
+        || activeChild !== child
+        || child.exitCode !== null
+        || child.signalCode
+        || launcherShutdownSignal
+        || restartRequest) return;
+      hubSelfAgent?.start();
+    }).catch(error => {
+      reportLauncherUpdate(
+        `[LiveDesk Hub] Self Agent startup wait failed: ${error?.message || error}.`,
+        true
+      );
+    });
 
     child.stdout.on('data', chunk => {
       appendHubLog(chunk.toString());
@@ -2957,19 +2957,19 @@ async function runManager(args, resolvedRole = null, runtimeLock = null, updateH
     });
     child.once('exit', (code, signal) => {
       const startupOutput = stderrChunks.join('');
-      if (launcherShutdownSignal) {
+      if (launcherShutdownSignal) {
         if (launcherShutdownHardStopTimer) {
           clearTimeout(launcherShutdownHardStopTimer);
           launcherShutdownHardStopTimer = null;
         }
-        runtimeShutdownWatcher?.stop();
-        removeLauncherSignalHandlers();
-        void stopHubSelfAgent(`launcher-${launcherShutdownSignal}`).finally(() => {
-          try { hubLogStream?.end(); } catch {}
-          process.exit(0);
-        });
-        return;
-      }
+        runtimeShutdownWatcher?.stop();
+        removeLauncherSignalHandlers();
+        void stopHubSelfAgent(`launcher-${launcherShutdownSignal}`).finally(() => {
+          try { hubLogStream?.end(); } catch {}
+          process.exit(0);
+        });
+        return;
+      }
       if (restartRequest) {
         const request = restartRequest;
         restartRequest = null;
@@ -2985,7 +2985,7 @@ async function runManager(args, resolvedRole = null, runtimeLock = null, updateH
           clearInterval(updatePollId);
           updatePollId = null;
         }
-        void stopHubSelfAgent('hub-update').then(() => restartWithLatest(request)).catch(error => {
+        void stopHubSelfAgent('hub-update').then(() => restartWithLatest(request)).catch(error => {
           const message = `The Hub restart handoff failed after shutdown: ${error instanceof Error ? error.message : String(error)}`;
           reportLauncherUpdate(`[LiveDesk Hub] ${message}. Restarting the unchanged Hub.`, true);
           try {
@@ -3012,7 +3012,7 @@ async function runManager(args, resolvedRole = null, runtimeLock = null, updateH
           } catch {
             // The unchanged Hub still restarts even if diagnostics are read-only.
           }
-          startHubProcess();
+          startHubProcess();
           if (!updatePollId) {
             updatePollId = setInterval(pollUpdateRequest, HUB_UPDATE_POLL_MS);
             updatePollId.unref?.();
@@ -3020,44 +3020,44 @@ async function runManager(args, resolvedRole = null, runtimeLock = null, updateH
         });
         return;
       }
-      if (!signal && code === ROLE_TRANSITION_EXIT_CODE) {
-        if (updatePollId) {
-          clearInterval(updatePollId);
-          updatePollId = null;
-        }
-        void stopHubSelfAgent('role-transition').then(() => {
-          try {
-            runtimeLock?.updateRole?.('client');
-          } catch (error) {
-            console.error(
-              `[LiveDesk Hub] The shared runtime lock could not transition to Client: ${error?.message || error}. `
-              + 'The launcher will exit so a clean invocation can recover.'
-            );
-            runtimeShutdownWatcher?.stop();
-            removeLauncherSignalHandlers();
-            try { hubLogStream?.end(); } catch {}
-            process.exit(1);
-            return;
-          }
-          writeRoleCache({
-            role: 'client',
-            deviceId: resolvedRole?.deviceId || process.env.LIVEDESK_DEVICE_ID || '',
-            deviceName: resolvedRole?.deviceName || os.hostname(),
-            source: 'supabase',
-            isOfflineFallback: false
-          }, { stateDir: MANAGER_STATE_DIR });
-          console.log('[LiveDesk Hub] Role transition accepted. Starting the Client runtime.');
-          runtimeShutdownWatcher?.stop();
-          removeLauncherSignalHandlers();
-          void runClient([], { ...resolvedRole, role: 'client', source: 'supabase', roleTransition: true }, runtimeLock).catch(error => {
-            console.error(`Failed to start LiveDesk Client runtime: ${error?.message || error}`);
-            process.exitCode = 1;
-          });
-        }).catch(error => {
-          console.error(`[LiveDesk Hub] Self Agent did not stop for role transition: ${error?.message || error}`);
-          process.exit(1);
-        });
-        return;
+      if (!signal && code === ROLE_TRANSITION_EXIT_CODE) {
+        if (updatePollId) {
+          clearInterval(updatePollId);
+          updatePollId = null;
+        }
+        void stopHubSelfAgent('role-transition').then(() => {
+          try {
+            runtimeLock?.updateRole?.('client');
+          } catch (error) {
+            console.error(
+              `[LiveDesk Hub] The shared runtime lock could not transition to Client: ${error?.message || error}. `
+              + 'The launcher will exit so a clean invocation can recover.'
+            );
+            runtimeShutdownWatcher?.stop();
+            removeLauncherSignalHandlers();
+            try { hubLogStream?.end(); } catch {}
+            process.exit(1);
+            return;
+          }
+          writeRoleCache({
+            role: 'client',
+            deviceId: resolvedRole?.deviceId || process.env.LIVEDESK_DEVICE_ID || '',
+            deviceName: resolvedRole?.deviceName || os.hostname(),
+            source: 'supabase',
+            isOfflineFallback: false
+          }, { stateDir: MANAGER_STATE_DIR });
+          console.log('[LiveDesk Hub] Role transition accepted. Starting the Client runtime.');
+          runtimeShutdownWatcher?.stop();
+          removeLauncherSignalHandlers();
+          void runClient([], { ...resolvedRole, role: 'client', source: 'supabase', roleTransition: true }, runtimeLock).catch(error => {
+            console.error(`Failed to start LiveDesk Client runtime: ${error?.message || error}`);
+            process.exitCode = 1;
+          });
+        }).catch(error => {
+          console.error(`[LiveDesk Hub] Self Agent did not stop for role transition: ${error?.message || error}`);
+          process.exit(1);
+        });
+        return;
       }
       if (!signal
         && code !== 0
@@ -3079,11 +3079,11 @@ async function runManager(args, resolvedRole = null, runtimeLock = null, updateH
           });
         return;
       }
-      if (signal) {
-        void stopHubSelfAgent(`hub-signal-${signal}`).finally(() => process.kill(process.pid, signal));
-        return;
-      }
-      void stopHubSelfAgent('hub-exited').finally(() => process.exit(code ?? 0));
+      if (signal) {
+        void stopHubSelfAgent(`hub-signal-${signal}`).finally(() => process.kill(process.pid, signal));
+        return;
+      }
+      void stopHubSelfAgent('hub-exited').finally(() => process.exit(code ?? 0));
     });
   };
 
@@ -3389,12 +3389,12 @@ async function main() {
     await stopProcessesOnPorts([replacementCleanup.runtimePort, remotePort]);
   }
 
-  if (resolvedRole.role === 'client' || resolvedRole.role === 'hub') {
-    // A launcher and Agent can both die while an independently spawned capture
-    // helper survives. This applies to a normal Client and to the Hub-owned
-    // Self Agent. Consume only the exact manifest generation returned by the
-    // stale-lock compare-and-swap; no process-name scan participates here.
-    const reclaimedManifestDrain = await drainReclaimedWindowsClientManifest(lock.reclaimedOwner);
+  if (resolvedRole.role === 'client' || resolvedRole.role === 'hub') {
+    // A launcher and Agent can both die while an independently spawned capture
+    // helper survives. This applies to a normal Client and to the Hub-owned
+    // Self Agent. Consume only the exact manifest generation returned by the
+    // stale-lock compare-and-swap; no process-name scan participates here.
+    const reclaimedManifestDrain = await drainReclaimedWindowsClientManifest(lock.reclaimedOwner);
     const testHoldAfterDrainMs = Number(
       process.env.LIVEDESK_TEST_HOLD_AFTER_RECLAIMED_WINDOWS_DRAIN_MS || 0
     );
@@ -3402,12 +3402,12 @@ async function main() {
         && process.env.LIVEDESK_DEBUG === '1'
         && Number.isFinite(testHoldAfterDrainMs)
         && testHoldAfterDrainMs > 0) {
-      console.log('[LiveDesk test] Holding after reclaimed manifest drain before Agent startup.');
-      await waitMilliseconds(Math.min(60_000, Math.round(testHoldAfterDrainMs)));
-    }
-  }
-
-  if (resolvedRole.role === 'client') {
+      console.log('[LiveDesk test] Holding after reclaimed manifest drain before Agent startup.');
+      await waitMilliseconds(Math.min(60_000, Math.round(testHoldAfterDrainMs)));
+    }
+  }
+
+  if (resolvedRole.role === 'client') {
     const clientRuntimePort = normalizePort(
       process.env.LIVEDESK_CLIENT_RUNTIME_PORT || process.env.LIVEDESK_LOCAL_RUNTIME_PORT,
       DEFAULT_MANAGER_HTTP_PORT