livedesk 0.1.448 → 0.1.450

package/bootstrap/legacy-client-update.js

@@ -47,9 +47,6 @@ const PRESERVED_SINGLE_FLAGS = new Set([
   '--no-audio',
   '--tasks',
   '--no-tasks',
-  '--ai',
-  '--no-ai',
-  '--fake-ai',
   '--fake-thumbnail',
   '--trace-frames'
 ]);
@@ -57,7 +54,6 @@ const PRESERVED_VALUE_FLAGS = new Set([
   '--name',
   '--heartbeat',
   '--files-dir',
-  '--ai-model',
   '--transport'
 ]);
 const JOINED_VALUE_FLAGS = new Set(['--name', '--files-dir']);
@@ -71,9 +67,7 @@ const SETTING_GROUPS = new Map([
   ['--audio', 'audio'],
   ['--no-audio', 'audio'],
   ['--tasks', 'tasks'],
-  ['--no-tasks', 'tasks'],
-  ['--ai', 'ai'],
-  ['--no-ai', 'ai']
+  ['--no-tasks', 'tasks']
 ]);
 
 function cleanVersion(value) {

package/client/bin/livedesk-client-node.js

@@ -19,15 +19,13 @@ const AGENT_VERSION = (() => {
 const PRODUCT_VERSION = String(process.env.LIVEDESK_NPM_LAUNCHER_VERSION || AGENT_VERSION).trim() || AGENT_VERSION;
 const DEFAULT_MANAGER = '127.0.0.1:5197';
 const DEFAULT_HEARTBEAT_MS = 5000;
-const DEFAULT_RECONNECT_MS = 5000;
-const EXIT_INVALID_PAIR_TOKEN = 23;
-const EXIT_CLIENT_UPDATE = 42;
-const DEFAULT_AI_MODEL = 'gpt-5.4-mini';
-const DEFAULT_LIVE_FPS = 30;
-const MAX_LIVE_FPS = 30;
-const MAX_FRAME_BASE64_CHARS = 3 * 1024 * 1024;
-const MAX_AI_OUTPUT_CHARS = 6000;
-const MAX_FILE_TRANSFER_FILES = 24;
+const DEFAULT_RECONNECT_MS = 5000;
+const EXIT_INVALID_PAIR_TOKEN = 23;
+const EXIT_CLIENT_UPDATE = 42;
+const DEFAULT_LIVE_FPS = 30;
+const MAX_LIVE_FPS = 30;
+const MAX_FRAME_BASE64_CHARS = 3 * 1024 * 1024;
+const MAX_FILE_TRANSFER_FILES = 24;
 const MAX_FILE_TRANSFER_BYTES = 24 * 1024 * 1024;
 const MAX_AGENT_OUTPUT_CHARS = 32000;
 const launchedProcessRegistry = new Map();
@@ -281,14 +279,10 @@ Options:
   --no-thumbnail         Disable thumbnail capture capability.
   --live                 Enable focused live screen streaming. Default on.
   --no-live              Disable focused live screen streaming.
-  --tasks                Enable safe remote task inbox. Default on.
-  --no-tasks             Disable remote task dispatch capability.
-  --files-dir <path>     Default folder for received files. Default: ~/Desktop/LiveDeskFiles.
-  --ai                   Enable OpenAI-backed remote AI assist tasks.
-  --no-ai                Disable OpenAI-backed remote AI assist tasks.
-  --ai-model <model>     OpenAI model for AI assist. Default: ${DEFAULT_AI_MODEL}
-  --fake-ai              Use deterministic AI assist responses for smoke tests.
-  --fake-thumbnail       Use generated thumbnail frames for smoke tests.
+  --tasks                Enable safe remote task inbox. Default on.
+  --no-tasks             Disable remote task dispatch capability.
+  --files-dir <path>     Default folder for received files. Default: ~/Desktop/LiveDeskFiles.
+  --fake-thumbnail       Use generated thumbnail frames for smoke tests.
   --exit-on-disconnect   Exit after Hub disconnect. Useful for tests.
   --exit-on-invalid-pair Exit when the Hub rejects the pair token.
   --once                 Connect, send one status packet, and exit after welcome.
@@ -328,14 +322,10 @@ function parseArgs(argv) {
         heartbeatMs: DEFAULT_HEARTBEAT_MS,
         deviceId: '',
         thumbnailEnabled: defaultDesktopCaptureEnabled && !isFalsy(process.env.LIVEDESK_CLIENT_THUMBNAIL ?? process.env.MINDEXEC_REMOTE_THUMBNAIL),
-        liveEnabled: defaultDesktopCaptureEnabled && !isFalsy(process.env.LIVEDESK_CLIENT_LIVE ?? process.env.MINDEXEC_REMOTE_LIVE),
-        taskEnabled: !isFalsy(process.env.LIVEDESK_CLIENT_TASKS ?? process.env.MINDEXEC_REMOTE_TASKS),
-        filesDir: process.env.LIVEDESK_CLIENT_FILES_DIR || process.env.MINDEXEC_REMOTE_FILES_DIR || '',
-        aiEnabled: isTruthy(process.env.LIVEDESK_CLIENT_AI || process.env.MINDEXEC_REMOTE_AI),
-        aiModel: process.env.LIVEDESK_CLIENT_AI_MODEL || process.env.MINDEXEC_REMOTE_AI_MODEL || process.env.OPENAI_MODEL || DEFAULT_AI_MODEL,
-        openAiApiKey: process.env.OPENAI_API_KEY || '',
-        fakeAi: isTruthy(process.env.LIVEDESK_CLIENT_FAKE_AI || process.env.MINDEXEC_REMOTE_FAKE_AI),
-        fakeThumbnail: isTruthy(process.env.LIVEDESK_CLIENT_FAKE_THUMBNAIL || process.env.MINDEXEC_REMOTE_FAKE_THUMBNAIL),
+        liveEnabled: defaultDesktopCaptureEnabled && !isFalsy(process.env.LIVEDESK_CLIENT_LIVE ?? process.env.MINDEXEC_REMOTE_LIVE),
+        taskEnabled: !isFalsy(process.env.LIVEDESK_CLIENT_TASKS ?? process.env.MINDEXEC_REMOTE_TASKS),
+        filesDir: process.env.LIVEDESK_CLIENT_FILES_DIR || process.env.MINDEXEC_REMOTE_FILES_DIR || '',
+        fakeThumbnail: isTruthy(process.env.LIVEDESK_CLIENT_FAKE_THUMBNAIL || process.env.MINDEXEC_REMOTE_FAKE_THUMBNAIL),
         exitOnDisconnect: false,
         exitOnInvalidPair: false,
         once: false,
@@ -387,26 +377,11 @@ function parseArgs(argv) {
             case '--no-tasks':
                 result.taskEnabled = false;
                 break;
-            case '--files-dir':
-                result.filesDir = args[++index] || result.filesDir;
-                break;
-            case '--ai':
-                result.aiEnabled = true;
-                result.taskEnabled = true;
-                break;
-            case '--no-ai':
-                result.aiEnabled = false;
-                break;
-            case '--ai-model':
-                result.aiModel = args[++index] || result.aiModel;
-                break;
-            case '--fake-ai':
-                result.fakeAi = true;
-                result.aiEnabled = true;
-                result.taskEnabled = true;
-                break;
-            case '--fake-thumbnail':
-                result.fakeThumbnail = true;
+            case '--files-dir':
+                result.filesDir = args[++index] || result.filesDir;
+                break;
+            case '--fake-thumbnail':
+                result.fakeThumbnail = true;
                 result.thumbnailEnabled = true;
                 break;
             case '--exit-on-disconnect':
@@ -586,7 +561,7 @@ function getStatus(options = {}) {
         usedMemRatio,
         platform: os.platform(),
         release: os.release(),
-        role: options.aiEnabled ? 'Agent worker' : options.taskEnabled ? 'Task worker' : 'Local machine',
+        role: options.taskEnabled ? 'Command-ready Client' : 'Local machine',
         cpu: {
             cores: cpuCores,
             model: cpus[0]?.model || '',
@@ -609,9 +584,9 @@ function getStatus(options = {}) {
         gpu: acceleratorStatus.gpu,
         npu: acceleratorStatus.npu,
         network: getNetworkStatus(),
-        workload: {
-            role: options.aiEnabled ? 'Agent worker' : options.taskEnabled ? 'Task worker' : 'Local machine',
-            status: 'idle',
+        workload: {
+            role: options.taskEnabled ? 'Command-ready Client' : 'Local machine',
+            status: 'idle',
             title: 'idle'
         },
         timestamp: new Date().toISOString()
@@ -941,95 +916,17 @@ async function captureThumbnailFrame(options, payload, frameSeq) {
     return await captureScreenFrame(options, payload, frameSeq, 'thumbnail');
 }
 
-function normalizeApprovalLevel(value) {
-    const level = String(value || 'task-only').trim().toLowerCase();
-    return level === 'ai-assist' ? 'ai-assist' : 'task-only';
-}
-
-function buildAiPrompt(options, payload, instruction) {
-    const title = String(payload?.title || 'Remote AI task').trim();
-    return [
-        'You are the LiveDesk client AI assistant running on a controlled remote computer.',
-        'Complete the LiveDesk Hub task as a text-only assistant.',
-        'Do not claim you used shell commands, file writes, browser automation, keyboard input, or mouse input.',
-        'If the task requires external side effects, explain what would be needed and stop.',
-        '',
-        `Device: ${options.name} (${os.hostname()}, ${os.platform()} ${os.release()}, ${os.arch()})`,
-        `Task title: ${title}`,
-        '',
-        'Hub instruction:',
-        instruction
-    ].join('\n');
-}
-
-function extractResponseText(response) {
-    if (typeof response?.output_text === 'string' && response.output_text.trim()) {
-        return response.output_text.trim();
-    }
-
-    const parts = [];
-    if (Array.isArray(response?.output)) {
-        for (const item of response.output) {
-            if (!Array.isArray(item?.content)) {
-                continue;
-            }
-
-            for (const content of item.content) {
-                if (typeof content?.text === 'string') {
-                    parts.push(content.text);
-                }
-                if (typeof content?.output_text === 'string') {
-                    parts.push(content.output_text);
-                }
-            }
-        }
-    }
-
-    return parts.join('\n').trim();
-}
-
-async function runAiAssistTask(options, payload, instruction) {
-    if (!options.aiEnabled) {
-        throw new Error('AI assist capability is disabled. Start the agent with --ai to enable it.');
-    }
-
-    if (options.fakeAi) {
-        return {
-            text: [
-                `Fake AI assist completed on ${options.name}.`,
-                '',
-                `Instruction: ${instruction.slice(0, 500)}`,
-                '',
-                'No shell, file, input, browser, or persistent side effects were performed.'
-            ].join('\n'),
-            model: 'fake-ai',
-            responseId: `fake-ai-${String(payload?.taskId || crypto.randomUUID()).slice(0, 96)}`
-        };
-    }
-
-    if (!options.openAiApiKey) {
-        throw new Error('OPENAI_API_KEY is required for --ai remote tasks.');
-    }
-
-    const openaiModule = await import('openai');
-    const OpenAI = openaiModule.default || openaiModule.OpenAI;
-    const client = new OpenAI({ apiKey: options.openAiApiKey });
-    const model = String(payload?.model || options.aiModel || DEFAULT_AI_MODEL).trim() || DEFAULT_AI_MODEL;
-    const response = await client.responses.create({
-        model,
-        input: buildAiPrompt(options, payload, instruction)
-    });
-    const text = extractResponseText(response);
-    if (!text) {
-        throw new Error('AI assist returned no text output.');
-    }
-
-    return {
-        text: text.slice(0, MAX_AI_OUTPUT_CHARS),
-        model,
-        responseId: response?.id || ''
-    };
-}
+const RETIRED_CLIENT_AGENT_TASK_ERROR = 'agent-ai-assist-retired';
+
+function getRetiredClientAgentTaskError(payload = {}) {
+    const source = payload && typeof payload === 'object' ? payload : {};
+    const approvalLevel = String(source.approvalLevel || '').trim().toLowerCase();
+    const hasModelSelection = ['model', 'aiModel', 'aiProvider', 'provider']
+        .some(key => Object.prototype.hasOwnProperty.call(source, key));
+    return approvalLevel === 'ai-assist' || hasModelSelection
+        ? RETIRED_CLIENT_AGENT_TASK_ERROR
+        : '';
+}
 
 function clampInteger(value, min, max, fallback) {
     const number = Number(value);
@@ -1846,10 +1743,25 @@ async function handleRemoteCommand(socket, options, message, nextFrameSeq, activ
                 error: 'remote task capability is disabled'
             });
             return;
-        }
-
-        const payload = message.payload || {};
-        const instruction = String(payload.instruction || '').replace(/\0/g, '').trim().slice(0, 4000);
+        }
+
+        const payload = message.payload || {};
+        const retiredTaskError = getRetiredClientAgentTaskError(payload);
+        if (retiredTaskError) {
+            writeJsonLine(socket, {
+                type: 'command.result',
+                commandId: message.commandId,
+                error: retiredTaskError,
+                result: {
+                    ok: false,
+                    status: 'failed',
+                    error: retiredTaskError,
+                    completedAt: new Date().toISOString()
+                }
+            });
+            return;
+        }
+        const instruction = String(payload.instruction || '').replace(/\0/g, '').trim().slice(0, 4000);
         if (!instruction) {
             writeJsonLine(socket, {
                 type: 'command.result',
@@ -1859,43 +1771,13 @@ async function handleRemoteCommand(socket, options, message, nextFrameSeq, activ
             return;
         }
 
-        const approvalLevel = normalizeApprovalLevel(payload.approvalLevel);
-        const completedAt = new Date().toISOString();
-        const title = String(payload.title || instruction.split(/\r?\n/)[0] || 'Remote task')
-            .replace(/[\r\n\t]/g, ' ')
-            .trim()
-            .slice(0, 120);
-        if (approvalLevel === 'ai-assist') {
-            try {
-                const aiResult = await runAiAssistTask(options, payload, instruction);
-                writeJsonLine(socket, {
-                    type: 'command.result',
-                    commandId: message.commandId,
-                    result: {
-                        kind: 'agent.task',
-                        mode: 'ai-assist',
-                        taskId: String(payload.taskId || '').slice(0, 128),
-                        title,
-                        status: 'completed',
-                        summary: aiResult.text,
-                        sideEffects: 'none',
-                        model: aiResult.model,
-                        responseId: aiResult.responseId,
-                        instructionPreview: instruction.slice(0, 320),
-                        completedAt: new Date().toISOString()
-                    }
-                });
-            } catch (error) {
-                writeJsonLine(socket, {
-                    type: 'command.result',
-                    commandId: message.commandId,
-                    error: error?.message || String(error)
-                });
-            }
-            return;
-        }
-
-        writeJsonLine(socket, {
+        const completedAt = new Date().toISOString();
+        const title = String(payload.title || instruction.split(/\r?\n/)[0] || 'Remote task')
+            .replace(/[\r\n\t]/g, ' ')
+            .trim()
+            .slice(0, 120);
+
+        writeJsonLine(socket, {
             type: 'command.result',
             commandId: message.commandId,
             result: {
@@ -2140,14 +2022,11 @@ function connectOnce(options, deviceId) {
                     taskDispatch: options.taskEnabled,
                     clientUpdate: true,
                     productVersion: PRODUCT_VERSION,
-                    agentApproval: options.taskEnabled,
-                    agentAudit: options.taskEnabled,
-                    agentTools: [...NODE_AGENT_OPERATIONS],
-                    elevation: typeof process.getuid === 'function' ? process.getuid() === 0 : false,
-                    aiAssist: options.taskEnabled && options.aiEnabled && (options.fakeAi || !!options.openAiApiKey),
-                    aiModel: options.aiModel,
-                    aiProvider: options.fakeAi ? 'fake' : (options.openAiApiKey ? 'openai' : ''),
-                    externalEffects: options.taskEnabled
+                    agentApproval: options.taskEnabled,
+                    agentAudit: options.taskEnabled,
+                    agentTools: [...NODE_AGENT_OPERATIONS],
+                    elevation: typeof process.getuid === 'function' ? process.getuid() === 0 : false,
+                    externalEffects: options.taskEnabled
                 }
             });
         });