livedesk 0.1.209 → 0.1.210

package/hub/src/agents/agent-audit-store.js

@@ -1,9 +1,10 @@
-import { appendFile, mkdir, readFile } from 'node:fs/promises';
+import { appendFile, mkdir, readFile, rename, writeFile } from 'node:fs/promises';
 import crypto from 'node:crypto';
 import os from 'node:os';
 import path from 'node:path';
 
 const MAX_AUDIT_RECORDS = 2000;
+const MAX_AUDIT_FILE_RECORDS = 2250;
 const MAX_AUDIT_FIELD = 4000;
 
 function safeText(value, max = MAX_AUDIT_FIELD) {
@@ -23,13 +24,17 @@ function redact(value, depth = 0) {
 export function createAgentAuditStore({ dataDir = path.join(os.homedir(), '.livedesk') } = {}) {
   const filePath = path.join(dataDir, 'agent-audit.jsonl');
   let records = null;
+  let rewriteNeeded = false;
+  let fileRecordCount = 0;
   let writeQueue = Promise.resolve();
 
   async function load() {
     if (records) return records;
     try {
-      const lines = (await readFile(filePath, 'utf8')).split(/\r?\n/).filter(Boolean).slice(-MAX_AUDIT_RECORDS);
-      records = lines.map(line => JSON.parse(line)).filter(item => item && typeof item === 'object');
+      const allLines = (await readFile(filePath, 'utf8')).split(/\r?\n/).filter(Boolean);
+      fileRecordCount = allLines.length;
+      rewriteNeeded = allLines.length > MAX_AUDIT_FILE_RECORDS;
+      records = allLines.slice(-MAX_AUDIT_RECORDS).map(line => JSON.parse(line)).filter(item => item && typeof item === 'object');
     } catch {
       records = [];
     }
@@ -57,12 +62,24 @@ export function createAgentAuditStore({ dataDir = path.join(os.homedir(), '.live
   return {
     async record(event) {
       const record = normalize(event);
-      const current = await load();
-      current.push(record);
-      if (current.length > MAX_AUDIT_RECORDS) current.splice(0, current.length - MAX_AUDIT_RECORDS);
       writeQueue = writeQueue.then(async () => {
+        const current = await load();
+        current.push(record);
+        fileRecordCount += 1;
+        if (current.length > MAX_AUDIT_RECORDS) {
+          current.splice(0, current.length - MAX_AUDIT_RECORDS);
+        }
+        if (fileRecordCount > MAX_AUDIT_FILE_RECORDS) rewriteNeeded = true;
         await mkdir(path.dirname(filePath), { recursive: true });
-        await appendFile(filePath, `${JSON.stringify(record)}\n`, { encoding: 'utf8', mode: 0o600 });
+        if (rewriteNeeded) {
+          const tempPath = `${filePath}.${process.pid}.${crypto.randomUUID()}.tmp`;
+          await writeFile(tempPath, `${current.map(item => JSON.stringify(item)).join('\n')}\n`, { encoding: 'utf8', mode: 0o600 });
+          await rename(tempPath, filePath);
+          fileRecordCount = current.length;
+          rewriteNeeded = false;
+        } else {
+          await appendFile(filePath, `${JSON.stringify(record)}\n`, { encoding: 'utf8', mode: 0o600 });
+        }
       });
       await writeQueue;
       return record;

package/hub/src/agents/agent-manager.js

@@ -169,6 +169,7 @@ export function createAgentManager({
       return runtime.start(input);
     },
     getRun(runId) { return runtime?.get(runId) || null; },
-    cancelRun(runId) { return runtime?.cancel(runId) || null; }
+    cancelRun(runId) { return runtime?.cancel(runId) || null; },
+    cancelAllRuns() { return runtime?.cancelAll?.() || 0; }
   };
 }

package/hub/src/agents/agent-permissions.js

@@ -44,14 +44,14 @@ const PRESET_CATEGORIES = Object.freeze({
   },
   'safe-auto': {
     read: 'allow',
-    processControl: 'ask',
-    serviceControl: 'ask',
-    applicationControl: 'ask',
+    processControl: 'allow',
+    serviceControl: 'allow',
+    applicationControl: 'allow',
     fileRead: 'allow',
-    fileWrite: 'ask',
-    fileDelete: 'deny',
+    fileWrite: 'allow',
+    fileDelete: 'ask',
     shell: 'ask',
-    script: 'ask',
+    script: 'allow',
     softwareInstall: 'ask',
     network: 'allow',
     systemPower: 'ask',
@@ -151,6 +151,27 @@ function targetIdsFromArgs(args, fallback = []) {
   return normalizeIds(args?.deviceIds?.length ? args.deviceIds : fallback);
 }
 
+function isSafeAutoRelativePath(value) {
+  const text = String(value || '').trim();
+  if (!text || text.length > 600 || text.startsWith('/') || /^[A-Za-z]:[\\/]/.test(text) || text.startsWith('\\\\')) return false;
+  const segments = text.replaceAll('\\', '/').split('/').filter(Boolean);
+  return segments.length > 0 && !segments.includes('..');
+}
+
+function safeAutoConstraint(tool, args, mode) {
+  if (mode !== 'safe-auto') return '';
+  if (tool.category === 'fileWrite' && !isSafeAutoRelativePath(args?.path)) {
+    return 'Safe Auto file writes are limited to relative paths inside the LiveDesk files directory.';
+  }
+  if (tool.category === 'script') {
+    const scriptPath = String(args?.path || '').trim().toLowerCase();
+    if (!isSafeAutoRelativePath(scriptPath) || !scriptPath.replaceAll('\\', '/').startsWith('scripts/') || !/\.(ps1|psm1|sh|bash|py|js|mjs|cmd|bat)$/.test(scriptPath)) {
+      return 'Safe Auto scripts must be registered relative script files inside the LiveDesk files directory.';
+    }
+  }
+  return '';
+}
+
 export function evaluateAgentToolPermission({ policy, toolName, arguments: args = {}, deviceIds = [] } = {}) {
   const tool = getAgentToolDefinition(toolName);
   if (!tool) return { decision: 'deny', category: 'unknown', risk: 'critical', reason: 'Unknown or unregistered Agent tool.' };
@@ -163,6 +184,10 @@ export function evaluateAgentToolPermission({ policy, toolName, arguments: args
     return { decision: 'deny', category: tool.category, risk: 'high', reason: 'The Agent permission policy has expired.' };
   }
   const category = TOOL_CATEGORY_ALIASES[tool.name.replace(/^livedesk\./, '')] || tool.category;
+  const constraintError = safeAutoConstraint(tool, args, policy?.mode);
+  if (constraintError) {
+    return { decision: 'deny', category, risk: tool.risk, reason: constraintError };
+  }
   const decision = normalizeDecision(policy?.categories?.[category], 'deny');
   return {
     decision,

package/hub/src/agents/codex-agent-runtime.js

@@ -492,7 +492,7 @@ export function createCodexAgentRuntime({
             throw new AgentProviderError('codex-turn-limit-reached', 'Codex exceeded the LiveDesk turn limit.', { status: 409 });
           }
         }
-        if (run.toolCallCount > settings.codexMaxToolCalls) {
+        if (run.toolCallCount > run.permissionPolicy.maxToolCalls) {
           run.abortReason = 'tool-limit';
           run.abortController.abort();
           session.cancel();
@@ -589,5 +589,16 @@ export function createCodexAgentRuntime({
     return publicRun(run);
   }
 
-  return { getStatus, testConnection, start, get, cancel, workspace, codexHome, getSecurityStatus: securityStatus };
+  function cancelAll() {
+    let cancelled = 0;
+    for (const run of runs.values()) {
+      if (!isTerminalStatus(run.status)) {
+        cancel(run.runId);
+        cancelled += 1;
+      }
+    }
+    return cancelled;
+  }
+
+  return { getStatus, testConnection, start, get, cancel, cancelAll, workspace, codexHome, getSecurityStatus: securityStatus };
 }

package/hub/src/server.js

@@ -396,7 +396,7 @@ function createAgentMcpSession({ runId, signal, allowedDeviceIds: allowedDeviceI
     signal,
     allowedDeviceIds,
     toolCallCount: 0,
-    maxToolCalls: normalizeAgentMcpToolCallLimit(maxToolCalls),
+    maxToolCalls: normalizeAgentMcpToolCallLimit(effectivePermissionPolicy.maxToolCalls ?? maxToolCalls),
     toolLimitReached: false,
     permissionPolicy: effectivePermissionPolicy,
     permissionPolicyHash: hashAgentPermissionPolicy(effectivePermissionPolicy),
@@ -429,6 +429,14 @@ function delayAgentMcp(ms) {
   return new Promise(resolve => setTimeout(resolve, ms));
 }
 
+function normalizeAgentPlatform(value) {
+  const platform = String(value || '').trim().toLowerCase();
+  if (platform === 'win32' || platform === 'windows') return 'windows';
+  if (platform === 'darwin' || platform === 'macos' || platform === 'osx') return 'macos';
+  if (platform === 'linux') return 'linux';
+  return platform;
+}
+
 function validateAgentMcpArguments(name, args) {
   const value = args && typeof args === 'object' && !Array.isArray(args) ? args : null;
   if (!value) return 'agent-tool-arguments-invalid';
@@ -510,6 +518,24 @@ async function dispatchAgentMcpTool(session, name, args = {}) {
   const targetIds = resolution.deviceIds;
   if (targetIds.length === 0) return { ok: false, error: resolution.error };
   if (name !== 'livedesk.list_devices' && !operation) return { ok: false, error: 'codex-tool-not-allowed' };
+  if (!tool.supportsBatch && targetIds.length !== 1) {
+    return { ok: false, error: 'agent-tool-single-target-required', toolName: name, targetCount: targetIds.length };
+  }
+  const selectedDevices = remoteHub.listDevices({ includeDataUrl: false }).filter(device => targetIds.includes(device.deviceId));
+  const unsupportedPlatform = selectedDevices.find(device => {
+    const platform = normalizeAgentPlatform(device.platform);
+    return platform && Array.isArray(tool.supportedPlatforms) && tool.supportedPlatforms.length > 0 && !tool.supportedPlatforms.includes(platform);
+  });
+  if (unsupportedPlatform) {
+    return { ok: false, error: 'agent-tool-platform-unsupported', toolName: name, deviceId: unsupportedPlatform.deviceId, platform: normalizeAgentPlatform(unsupportedPlatform.platform) };
+  }
+  const unsupportedCapability = selectedDevices.find(device => {
+    const advertised = device.capabilities?.agentTools;
+    return Array.isArray(advertised) && advertised.length > 0 && operation && !advertised.includes(operation);
+  });
+  if (unsupportedCapability) {
+    return { ok: false, error: 'agent-tool-capability-unavailable', toolName: name, deviceId: unsupportedCapability.deviceId };
+  }
   const permission = evaluateAgentToolPermission({
     policy: session.permissionPolicy,
     toolName: name,
@@ -734,7 +760,7 @@ function sendAgentError(res, error) {
   const status = Number.isInteger(error?.status) && error.status >= 400 && error.status <= 599
     ? error.status
     : code === 'agent-api-key-missing' || code === 'agent-api-key-invalid' || code === 'codex-auth-required' ? 401
-    : code === 'agent-no-target-devices' || code === 'agent-target-outside-selection' || code === 'codex-tool-not-allowed' || code === 'agent-permission-denied' || code === 'agent-approval-required' || code === 'agent-approval-rejected' || code === 'agent-approval-expired' ? 400
+    : code === 'agent-no-target-devices' || code === 'agent-target-outside-selection' || code === 'codex-tool-not-allowed' || code === 'agent-permission-denied' || code === 'agent-approval-required' || code === 'agent-approval-rejected' || code === 'agent-approval-expired' || code === 'agent-tool-single-target-required' || code === 'agent-tool-platform-unsupported' || code === 'agent-tool-capability-unavailable' ? 400
         : code === 'agent-mcp-loopback-only' ? 403
           : code === 'codex-isolation-unavailable' || code === 'codex-environment-isolation-failed' || code === 'codex-unsupported-security-config' ? 503
             : code === 'codex-run-timeout' ? 504
@@ -1753,6 +1779,24 @@ app.post('/api/settings/agent/runs/:runId/cancel', async (req, res) => {
   res.json({ ok: true, ...agentRunResponse(req.params.runId) });
 });
 
+app.post('/api/settings/agent/runs/cancel-all', async (_req, res) => {
+  noStore(res);
+  let cancelledSessions = 0;
+  const cancelledBatchIds = new Set();
+  for (const session of agentMcpSessions.values()) {
+    if (!session.cancelled) cancelledSessions += 1;
+    for (const batchId of agentMcpRunBatches.get(session.runId) || []) cancelledBatchIds.add(batchId);
+    session.cancel();
+  }
+  for (const batchIds of agentMcpRunBatches.values()) {
+    for (const batchId of batchIds) cancelledBatchIds.add(batchId);
+  }
+  for (const batchId of cancelledBatchIds) remoteHub.cancelTaskBatch(batchId);
+  const cancelledRuns = agentManager.cancelAllRuns();
+  recordAgentAudit({ event: 'runs-cancelled-all', status: 'cancelled', details: { cancelledRuns, cancelledSessions, cancelledBatches: cancelledBatchIds.size } });
+  res.json({ ok: true, cancelledRuns, cancelledSessions, cancelledBatches: cancelledBatchIds.size });
+});
+
 app.post('/api/settings/agent/plan', async (req, res) => {
   noStore(res);
   try {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "livedesk",
-  "version": "0.1.209",
+  "version": "0.1.210",
   "description": "LiveDesk Hub and client launcher",
   "type": "module",
   "bin": {
@@ -31,7 +31,7 @@
   },
   "dependencies": {
     "@ffmpeg-installer/ffmpeg": "^1.1.0",
-    "@livedesk/client": "0.1.121",
+    "@livedesk/client": "0.1.122",
     "@openai/codex-sdk": "0.144.5",
     "cors": "^2.8.5",
     "express": "^4.21.2",