livedesk 0.1.122 → 0.1.124

package/hub/src/remote-hub.js

@@ -31,6 +31,8 @@ const REMOTE_FRAME_PROTOCOL = 'mindexec.remote.frame.v2';
 const REMOTE_FRAME_PROTOCOL_VERSION = 2;
 const REMOTE_FRAME_HANDSHAKE = 'smartview-request-open-frame';
 const DEFAULT_REMOTE_FRAME_MODE = 'mode1-jpeg';
+const TCP_BINARY_FRAME_MAGIC = Buffer.from('LDFB', 'ascii');
+const TCP_BINARY_FRAME_HEADER_BYTES = 12;
 const REMOTE_FRAME_MODE_PROFILES = Object.freeze({
     thumbnail: Object.freeze({
         mode: 'thumbnail',
@@ -1003,6 +1005,59 @@ function parseRemoteHubWebSocketBinaryFrame(buffer) {
     return { header, payload };
 }
 
+function hasTcpBinaryFrameMagicPrefix(buffer) {
+    if (!Buffer.isBuffer(buffer) || buffer.length <= 0 || buffer.length > TCP_BINARY_FRAME_MAGIC.length) {
+        return false;
+    }
+
+    for (let index = 0; index < buffer.length; index += 1) {
+        if (buffer[index] !== TCP_BINARY_FRAME_MAGIC[index]) {
+            return false;
+        }
+    }
+    return true;
+}
+
+function startsWithTcpBinaryFrameMagic(buffer) {
+    return Buffer.isBuffer(buffer)
+        && buffer.length >= TCP_BINARY_FRAME_MAGIC.length
+        && buffer.subarray(0, TCP_BINARY_FRAME_MAGIC.length).equals(TCP_BINARY_FRAME_MAGIC);
+}
+
+function parseTcpBinaryFramePacket(buffer) {
+    if (!Buffer.isBuffer(buffer) || buffer.length < TCP_BINARY_FRAME_HEADER_BYTES) {
+        return { incomplete: true };
+    }
+    if (!startsWithTcpBinaryFrameMagic(buffer)) {
+        return null;
+    }
+
+    const metaLength = buffer.readUInt32BE(4);
+    const payloadLength = buffer.readUInt32BE(8);
+    const maxPayloadBytes = Math.max(MAX_THUMBNAIL_BINARY_BYTES, MAX_STREAM_BINARY_BYTES, MAX_AUDIO_BINARY_BYTES);
+    if (!Number.isFinite(metaLength)
+        || !Number.isFinite(payloadLength)
+        || metaLength <= 0
+        || metaLength > 64 * 1024
+        || payloadLength <= 0
+        || payloadLength > maxPayloadBytes) {
+        return { invalid: true, reason: 'invalid-tcp-binary-frame-size' };
+    }
+
+    const packetLength = TCP_BINARY_FRAME_HEADER_BYTES + metaLength + payloadLength;
+    if (buffer.length < packetLength) {
+        return { incomplete: true };
+    }
+
+    try {
+        const header = JSON.parse(buffer.subarray(TCP_BINARY_FRAME_HEADER_BYTES, TCP_BINARY_FRAME_HEADER_BYTES + metaLength).toString('utf8'));
+        const payload = buffer.subarray(TCP_BINARY_FRAME_HEADER_BYTES + metaLength, packetLength);
+        return { header, payload, packetLength };
+    } catch (err) {
+        return { invalid: true, reason: err?.message || 'invalid-tcp-binary-frame-header' };
+    }
+}
+
 class RemoteHubWebSocketAgentSocket {
     constructor(socket) {
         this.__remoteHubWebSocket = true;
@@ -3563,6 +3618,29 @@ export function createRemoteHub(options = {}) {
                     continue;
                 }
 
+                if (state.authenticated && state.frameOnly && state.buffer.length > 0) {
+                    if (state.buffer.length < TCP_BINARY_FRAME_MAGIC.length && hasTcpBinaryFrameMagicPrefix(state.buffer)) {
+                        return;
+                    }
+
+                    if (startsWithTcpBinaryFrameMagic(state.buffer)) {
+                        const packet = parseTcpBinaryFramePacket(state.buffer);
+                        if (packet?.incomplete) {
+                            return;
+                        }
+                        if (!packet || packet.invalid) {
+                            writeJsonLine(socket, { type: 'error', error: 'invalid-tcp-binary-frame' });
+                            logWarn('remote', `invalid tcp binary frame from agent: ${packet?.reason || 'bad-magic'}`);
+                            socket.destroy();
+                            return;
+                        }
+
+                        state.buffer = state.buffer.subarray(packet.packetLength);
+                        enqueueAgentBinaryFrame(socket, state, packet.header, packet.payload);
+                        continue;
+                    }
+                }
+
                 const newlineIndex = state.buffer.indexOf(0x0a);
                 if (newlineIndex < 0) {
                     if (state.buffer.length > MAX_LINE_CHARS) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "livedesk",
-  "version": "0.1.122",
+  "version": "0.1.124",
   "description": "LiveDesk Hub and client launcher",
   "type": "module",
   "bin": {
@@ -30,7 +30,7 @@
     "node": ">=20"
   },
   "dependencies": {
-    "@livedesk/client": "0.1.85",
+    "@livedesk/client": "0.1.86",
     "cors": "^2.8.5",
     "express": "^4.21.2",
     "ws": "^8.18.3"