liteagents 2.9.0 → 2.11.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (117) hide show
  1. package/CHANGELOG.md +43 -0
  2. package/README.md +27 -33
  3. package/installer/cli.js +6 -2
  4. package/package.json +3 -3
  5. package/packages/ampcode/AGENT.md +11 -16
  6. package/packages/ampcode/agents/code-developer.md +11 -12
  7. package/packages/ampcode/agents/quality-assurance.md +1 -1
  8. package/packages/{droid/commands/systematic-debugging.md → ampcode/commands/debug-method.md} +9 -9
  9. package/packages/ampcode/commands/diff-review.md +78 -0
  10. package/packages/ampcode/commands/friction/friction.js +28 -6
  11. package/packages/ampcode/commands/optimize.md +45 -4
  12. package/packages/ampcode/commands/refactor.md +33 -1
  13. package/packages/ampcode/commands/release.md +88 -0
  14. package/packages/ampcode/commands/remember.md +34 -3
  15. package/packages/ampcode/commands/security.md +28 -1
  16. package/packages/ampcode/commands/stash.md +7 -0
  17. package/packages/{droid/commands/test-driven-development.md → ampcode/commands/tdd-flow.md} +2 -2
  18. package/packages/ampcode/commands/test-generate.md +64 -15
  19. package/packages/{opencode/command/testing-anti-patterns.md → ampcode/commands/test-traps.md} +77 -3
  20. package/packages/{droid/commands/root-cause-tracing.md → ampcode/commands/trace-back.md} +3 -3
  21. package/packages/ampcode/commands/{verification-before-completion.md → verify-done.md} +3 -3
  22. package/packages/claude/CLAUDE.md +10 -15
  23. package/packages/claude/agents/code-developer.md +11 -12
  24. package/packages/claude/agents/quality-assurance.md +1 -1
  25. package/packages/claude/commands/diff-review.md +78 -0
  26. package/packages/claude/commands/friction/friction.js +28 -6
  27. package/packages/claude/commands/optimize.md +45 -4
  28. package/packages/claude/commands/refactor.md +33 -1
  29. package/packages/claude/commands/release.md +88 -0
  30. package/packages/claude/commands/remember.md +34 -3
  31. package/packages/claude/commands/security.md +28 -1
  32. package/packages/claude/commands/stash.md +7 -0
  33. package/packages/claude/commands/test-generate.md +64 -15
  34. package/packages/claude/plugins/live-canvas-marketplace/plugins/live-canvas-channel/package-lock.json +3 -3
  35. package/packages/claude/skills/{systematic-debugging → debug-method}/CREATION-LOG.md +1 -1
  36. package/packages/claude/skills/{systematic-debugging → debug-method}/SKILL.md +9 -9
  37. package/packages/claude/skills/{systematic-debugging → debug-method}/test-academic.md +1 -1
  38. package/packages/claude/skills/{systematic-debugging → debug-method}/test-pressure-1.md +1 -1
  39. package/packages/claude/skills/{systematic-debugging → debug-method}/test-pressure-2.md +1 -1
  40. package/packages/claude/skills/{systematic-debugging → debug-method}/test-pressure-3.md +1 -1
  41. package/packages/claude/skills/{test-driven-development → tdd-flow}/SKILL.md +3 -3
  42. package/packages/claude/skills/{testing-anti-patterns → test-traps}/SKILL.md +77 -3
  43. package/packages/claude/skills/{root-cause-tracing → trace-back}/SKILL.md +3 -3
  44. package/packages/claude/skills/{verification-before-completion → verify-done}/SKILL.md +3 -3
  45. package/packages/droid/AGENTS.md +9 -14
  46. package/packages/{opencode/command/systematic-debugging.md → droid/commands/debug-method.md} +9 -9
  47. package/packages/droid/commands/diff-review.md +78 -0
  48. package/packages/droid/commands/friction/friction.js +28 -6
  49. package/packages/droid/commands/optimize.md +45 -4
  50. package/packages/droid/commands/refactor.md +33 -1
  51. package/packages/droid/commands/release.md +88 -0
  52. package/packages/droid/commands/remember.md +34 -3
  53. package/packages/droid/commands/security.md +28 -1
  54. package/packages/droid/commands/stash.md +7 -0
  55. package/packages/{opencode/command/test-driven-development.md → droid/commands/tdd-flow.md} +2 -2
  56. package/packages/droid/commands/test-generate.md +64 -15
  57. package/packages/droid/commands/{testing-anti-patterns.md → test-traps.md} +77 -3
  58. package/packages/{opencode/command/root-cause-tracing.md → droid/commands/trace-back.md} +3 -3
  59. package/packages/droid/commands/{verification-before-completion.md → verify-done.md} +3 -3
  60. package/packages/droid/droids/code-developer.md +11 -12
  61. package/packages/droid/droids/quality-assurance.md +1 -1
  62. package/packages/opencode/AGENTS.md +9 -14
  63. package/packages/opencode/agent/code-developer.md +11 -12
  64. package/packages/opencode/agent/quality-assurance.md +1 -1
  65. package/packages/{ampcode/commands/systematic-debugging.md → opencode/command/debug-method.md} +9 -9
  66. package/packages/opencode/command/diff-review.md +78 -0
  67. package/packages/opencode/command/friction/friction.js +28 -6
  68. package/packages/opencode/command/optimize.md +45 -4
  69. package/packages/opencode/command/refactor.md +33 -1
  70. package/packages/opencode/command/release.md +88 -0
  71. package/packages/opencode/command/remember.md +34 -3
  72. package/packages/opencode/command/security.md +28 -1
  73. package/packages/opencode/command/stash.md +7 -0
  74. package/packages/{ampcode/commands/test-driven-development.md → opencode/command/tdd-flow.md} +2 -2
  75. package/packages/opencode/command/test-generate.md +64 -15
  76. package/packages/{ampcode/commands/testing-anti-patterns.md → opencode/command/test-traps.md} +77 -3
  77. package/packages/{ampcode/commands/root-cause-tracing.md → opencode/command/trace-back.md} +3 -3
  78. package/packages/opencode/command/{verification-before-completion.md → verify-done.md} +3 -3
  79. package/packages/opencode/opencode.jsonc +16 -36
  80. package/packages/subagentic-manual.md +56 -51
  81. package/packages/ampcode/commands/code-review.md +0 -107
  82. package/packages/ampcode/commands/condition-based-waiting.md +0 -122
  83. package/packages/ampcode/commands/debug.md +0 -20
  84. package/packages/ampcode/commands/explain.md +0 -18
  85. package/packages/ampcode/commands/friction.md +0 -139
  86. package/packages/ampcode/commands/git-commit.md +0 -14
  87. package/packages/ampcode/commands/review.md +0 -18
  88. package/packages/claude/commands/debug.md +0 -20
  89. package/packages/claude/commands/explain.md +0 -18
  90. package/packages/claude/commands/friction.md +0 -139
  91. package/packages/claude/commands/git-commit.md +0 -14
  92. package/packages/claude/commands/review.md +0 -18
  93. package/packages/claude/skills/code-review/SKILL.md +0 -107
  94. package/packages/claude/skills/code-review/code-reviewer.md +0 -146
  95. package/packages/claude/skills/condition-based-waiting/SKILL.md +0 -122
  96. package/packages/droid/commands/code-review.md +0 -107
  97. package/packages/droid/commands/condition-based-waiting.md +0 -122
  98. package/packages/droid/commands/debug.md +0 -20
  99. package/packages/droid/commands/explain.md +0 -18
  100. package/packages/droid/commands/friction.md +0 -139
  101. package/packages/droid/commands/git-commit.md +0 -14
  102. package/packages/droid/commands/review.md +0 -18
  103. package/packages/opencode/command/code-review.md +0 -107
  104. package/packages/opencode/command/condition-based-waiting.md +0 -122
  105. package/packages/opencode/command/debug.md +0 -20
  106. package/packages/opencode/command/explain.md +0 -18
  107. package/packages/opencode/command/friction.md +0 -139
  108. package/packages/opencode/command/git-commit.md +0 -14
  109. package/packages/opencode/command/review.md +0 -18
  110. /package/packages/ampcode/commands/{condition-based-waiting → test-traps}/example.ts +0 -0
  111. /package/packages/ampcode/commands/{root-cause-tracing → trace-back}/find-polluter.sh +0 -0
  112. /package/packages/claude/skills/{condition-based-waiting → test-traps}/example.ts +0 -0
  113. /package/packages/claude/skills/{root-cause-tracing → trace-back}/find-polluter.sh +0 -0
  114. /package/packages/droid/commands/{condition-based-waiting → test-traps}/example.ts +0 -0
  115. /package/packages/droid/commands/{root-cause-tracing → trace-back}/find-polluter.sh +0 -0
  116. /package/packages/opencode/command/{condition-based-waiting → test-traps}/example.ts +0 -0
  117. /package/packages/opencode/command/{root-cause-tracing → trace-back}/find-polluter.sh +0 -0
@@ -3,6 +3,7 @@ name: refactor
3
3
  description: Refactor [code]
4
4
  usage: /refactor <code-section>
5
5
  argument-hint: [file-or-function]
6
+ allowed-tools: Read, Edit, Grep, Glob, Bash(npm test *), Bash(npx jest *), Bash(npx vitest *), Bash(pnpm test *), Bash(yarn test *), Bash(pytest *), Bash(python *), Bash(go test *), Bash(cargo test *), Bash(make test *), Bash(git diff *)
6
7
  ---
7
8
  Refactor $ARGUMENTS.
8
9
 
@@ -14,8 +15,39 @@ Refactor $ARGUMENTS.
14
15
  - Smaller functions (single responsibility)
15
16
 
16
17
  ## Constraints
17
- - NO behavior changes
18
+ - **NO behavior changes**
18
19
  - Keep public API intact
19
20
  - Existing tests must pass
20
21
 
21
22
  Explain each change.
23
+
24
+ ## After the refactor — verify it didn't break anything
25
+
26
+ "Existing tests must pass" is the load-bearing constraint, and the only
27
+ honest way to know is to run them.
28
+
29
+ 1. **Detect the project's test command** (look for `package.json`
30
+ scripts, `pytest.ini` / `pyproject.toml`, `go.mod`, `Cargo.toml`,
31
+ `Makefile`). If none is found, **stop and ask** before claiming the
32
+ refactor is done — silent green isn't acceptable.
33
+ 2. **Run the tests.** Scope to the affected area when possible (`-t`,
34
+ `--testPathPattern`, `pytest path/`, `go test ./pkg`); otherwise run
35
+ the suite.
36
+ 3. **Report** pass / fail counts and any failure's name + `file:line`.
37
+
38
+ **Stop and ask** when (HITL gates — not all the time, only here):
39
+ - a test **fails** after the refactor. Don't auto-revert (destroys
40
+ work-in-progress) and don't push forward (the no-behavior-change
41
+ constraint is broken). Present the failure and the options:
42
+ **revert**, **patch the refactor**, or **update the test** (with
43
+ reasoning).
44
+ - the refactor crossed a **public API boundary** that callers depend
45
+ on — even if tests pass, downstream consumers may break.
46
+ - the change is **bigger than the user asked for** (scope creep —
47
+ unrelated cleanups, formatting, comment edits). Confirm before
48
+ applying.
49
+
50
+ Final report:
51
+ - **refactor done, tests N pass / 0 fail** — ready, OR
52
+ - **refactor done, but K tests fail** — awaiting direction (revert /
53
+ patch / update test).
@@ -0,0 +1,88 @@
1
+ ---
2
+ name: release
3
+ description: Deliver a feature end-to-end — verify, docs, merge, tag (publish stays manual)
4
+ usage: /release [branch]
5
+ argument-hint: [branch — new or existing; else current]
6
+ allowed-tools: Read, Grep, Glob, Edit, Write, Bash(git *), Bash(gh *), Bash(npm *), Bash(pnpm *), Bash(yarn *), Bash(pytest *), Bash(python *), Bash(go *), Bash(cargo *), Bash(make *)
7
+ ---
8
+ End-to-end feature-delivery **orchestrator**. It does **not** re-implement
9
+ checks — it runs your existing gates (`/ship`, `/security`, `/diff-review`)
10
+ under `/verify-done` discipline, then performs the release actions. Two halves
11
+ split by a hard gate: everything **before** the gate is safe and read-only;
12
+ everything **after** rewrites history and is confirmed step by step.
13
+
14
+ **A feature branch is required — `main` is only the merge target.** `$ARGUMENTS`
15
+ names the branch to release. Omit it only if you are already on a feature
16
+ branch. If you are on `main` with nothing named, a branch is created for you —
17
+ but you should be releasing a deliberately-named feature branch.
18
+
19
+ ## Phase 0 — Preflight (resolve a feature branch — never `main`)
20
+ - **Resolve the release branch** — whatever gets merged into `main`:
21
+ - `$ARGUMENTS` given → `git switch` to it (create it if it does not exist).
22
+ - else not on `main` → release the **current** branch.
23
+ - else on `main` with no arg → **create** `feat/<slug>` (named for the
24
+ change) and carry your working changes onto it. **Never release `main`.**
25
+ - **Land the feature on the branch** — if the working tree still has
26
+ uncommitted feature changes, commit them now; the gates must review a real
27
+ diff, not a dirty tree.
28
+ - `git fetch origin`; the release diff is `origin/main...HEAD` (now guaranteed
29
+ to be the resolved branch). If it is empty, **stop** — nothing to release.
30
+ - Print a one-line plan: branch · commit count · files changed.
31
+
32
+ ## Phase 1 — VERIFY (delegate; no hand-waving)
33
+ **First, load the real checklists.** Locate and **read** the sibling command
34
+ definitions so you apply their exact checks, not an approximation — glob your
35
+ installed commands/skills for `ship.md`, `security.md`, `diff-review.md`, and
36
+ `verify-done` (a skill or command). If one cannot be found, run that check from
37
+ its name and **flag that its full checklist was unavailable** — never pretend
38
+ it passed.
39
+
40
+ Then run each gate and capture **fresh evidence** — the exact command, its exit
41
+ code, and the result. Per `/verify-done`: a check you did **not** actually run
42
+ is a **FAIL**, never an assumed pass.
43
+ - **`/ship`** — pre-deploy gate (tests, lint, build, secrets, authz, rate
44
+ limit, data scope, migrations, docs-sync).
45
+ - **`/security`** — on the changed files.
46
+ - **`/diff-review`** — on `origin/main...HEAD`.
47
+
48
+ Emit a coverage table, one row per gate: `ran? ✓/✗` · evidence · verdict. If
49
+ any row is ✗ (could not run), the run is **Blocked 🛑** — do not continue.
50
+
51
+ ## 🚦 Gate
52
+ - **Any Critical** (failing tests/build, a Critical security or diff-review
53
+ finding) → **stop**, report, ask how to proceed. Touch no history.
54
+ - **Warnings, or anything you cannot confidently decide** → **stop**,
55
+ summarize, ask.
56
+ - **All clean** → continue to Phase 2.
57
+
58
+ ## Phase 2 — DOCS (only what the feature changed)
59
+ Update as needed, matching each file's existing format; touch nothing
60
+ unrelated. If a doc needs no change, **say so** rather than editing for its
61
+ own sake.
62
+ - **CHANGELOG.md** — new entry.
63
+ - **PRD** — the feature's PRD entry / status.
64
+ - **context / guide** — the project's context or guide doc.
65
+ - **README.md** — only if user-facing usage changed.
66
+
67
+ ## Phase 3 — RELEASE (irreversible — confirm each step)
68
+ 1. **Version bump** — pick the semver level from the change (patch / minor /
69
+ major; ask if ambiguous) and update `package.json`.
70
+ 2. **Commit** — `release: vX.Y.Z — <summary>`, including the docs + bump.
71
+ 3. **Push** the branch.
72
+ 4. **Open PR** — `gh pr create` into `main` (main is PR-protected: 1 approving
73
+ review).
74
+ 5. **Merge** — `gh pr merge --delete-branch`. If the review requirement blocks
75
+ it, **stop** and ask the user to approve — never force or bypass protection.
76
+ 6. **Tag** — after the merge, `git tag vX.Y.Z` on `main` and push it. Keep
77
+ cut→tag tight — one frozen step.
78
+
79
+ ## Stop here — publish is your call
80
+ Do **not** publish. `publish.yml` is manual `workflow_dispatch` **by design**.
81
+ Print the handoff:
82
+ > Merged, branch deleted, tagged **vX.Y.Z**. To publish, run it yourself:
83
+ > `gh workflow run publish.yml`
84
+ > Then confirm the version is actually live (`npm view <pkg> versions`) and
85
+ > validate the **installed** artifact, not the working tree.
86
+
87
+ Final report: **Delivered ✅ (vX.Y.Z — publish pending)** or **Blocked 🛑**
88
+ with the specific reason.
@@ -4,7 +4,7 @@ description: Consolidate stashes + friction into project memory
4
4
  usage: /remember
5
5
  ---
6
6
 
7
- Consolidate session stashes and friction analysis into a single project-local MEMORY.md, then inject into AGENT.md.
7
+ Run friction analysis, then consolidate session stashes + friction antigens into a single project-local MEMORY.md, and inject into AGENT.md. Friction runs automatically (best-effort) — there is no separate `/friction` command.
8
8
 
9
9
  **Guardrails**
10
10
  - Favor straightforward, minimal implementations first and add complexity only when requested or clearly required.
@@ -17,12 +17,43 @@ Reads all raw material (`.amp/stash/*.md` + `.amp/friction/antigen_clusters.json
17
17
 
18
18
  **Steps**
19
19
 
20
+ 0. **Run friction first** (best-effort — friction analyzes ALL your usage, not just this repo)
21
+
22
+ Friction's signal is *global*: recurring corrections and frustrations across every
23
+ project are behavioral lessons worth keeping everywhere. So point it at the tool's
24
+ **global sessions root** (all projects), not a per-project directory.
25
+
26
+ - **Locate `friction.js`** — it is bundled next to this command at `friction/friction.js`
27
+ (the same directory as `remember.md`, whether installed or run from the package). If it
28
+ exists nowhere, skip to step 1 (stash-only) and tell the user friction.js is missing.
29
+ - **Resolve the global sessions root** — probe this list top-to-bottom, use the first that
30
+ exists and contains `.jsonl` files (recursively). **Never prompt the user.**
31
+ ```
32
+ # ── Add your own global sessions root at the TOP so it is checked first ──
33
+ ~/.claude/projects/ # Claude Code
34
+ ~/.factory/projects/ # Droid / Factory
35
+ ~/.config/amp/projects/ # Amp
36
+ ~/.config/opencode/projects/ # opencode
37
+ ~/.codex/sessions/ # Codex CLI (use $CODEX_HOME/sessions/ if set)
38
+ ~/.gemini/antigravity-cli/brain/ # Antigravity
39
+ ```
40
+ > Note: `friction.js` parses Claude Code's session schema. The Codex/Antigravity roots
41
+ > will resolve but yield no signals until friction learns their formats — open an issue
42
+ > to request one: https://github.com/hamr0/liteagents/issues
43
+ - **Run** `node <friction.js> "<resolved-root>"`. friction writes its output to
44
+ `.amp/friction/` in the current project.
45
+ - **On any miss — loud, never silent.** If no root resolves, or friction errors, or it
46
+ finds no usable sessions, print this and continue with stash-only consolidation:
47
+ > ⚠️ Friction didn't run — no sessions found. To enable it, open this command file
48
+ > (`remember.md`) and add your tool's **global** sessions root to the TOP of the probe
49
+ > list in step 0, then re-run `/remember`. Consolidating stashes only this time.
50
+
20
51
  1. **Gather sources**
21
52
  - Read all `.amp/stash/*.md` files in the current project
22
- - Check for friction output at `.amp/friction/antigen_clusters.json` (preferred) or `.amp/friction/antigen_review.md` (fallback)
53
+ - Read friction output written in step 0: `.amp/friction/antigen_clusters.json` (preferred) or `.amp/friction/antigen_review.md` (fallback)
23
54
  - Read existing `.amp/memory/MEMORY.md` if it exists — create dir if missing
24
55
  - Read processed manifest at `.amp/memory/.processed` — skip already-processed stashes
25
- - If no unprocessed stashes AND no friction output, report "nothing to consolidate" and stop
56
+ - If no unprocessed stashes AND friction produced no new antigens, report "nothing to consolidate" and stop
26
57
 
27
58
  2. **Extract from unprocessed stashes** (use Task tool with sonnet model for each)
28
59
  - For each unprocessed stash, call sonnet to extract:
@@ -3,7 +3,7 @@ name: security
3
3
  description: Scan security [target]
4
4
  usage: /security
5
5
  argument-hint: [file, directory, or leave empty for full scan]
6
- allowed-tools: Read, Grep, Glob, Bash(git log *), Bash(git grep *), Bash(rg *)
6
+ allowed-tools: Read, Edit, Grep, Glob, Bash(git log *), Bash(git grep *), Bash(rg *)
7
7
  ---
8
8
  Audit $ARGUMENTS for security vulnerabilities. Adapt scope to what the target
9
9
  actually is — a library, CLI, web app, and service won't all have every
@@ -57,3 +57,30 @@ Severity-ranked findings (Critical → High → Medium → Low), each with:
57
57
  End with: which of the six classes were checked and found **clean**, and any
58
58
  marked **N/A** for this target — so the scan's coverage is auditable, not just
59
59
  its hits.
60
+
61
+ ## After the scan — verify, then fix
62
+
63
+ Findings are claims, not facts. Validate before acting; validate again after.
64
+
65
+ **Verify each claim.** Re-read the cited `file:line` in context. Confirm the
66
+ risk actually holds here — not in the abstract. Mark each **confirmed**, **false
67
+ positive** (with reason), or **uncertain**.
68
+
69
+ **Fix what's confirmed and unambiguous** — minimal shape, one obvious way, no
70
+ change to a public API / response / caller contract. Apply directly. After
71
+ each edit, re-read the changed region and confirm it closes the gap without
72
+ breaking nearby logic. A fix isn't done until you've grounded it the same way
73
+ you grounded the claim.
74
+
75
+ **Stop and ask** when any of these hold (HITL gates — not all the time, only
76
+ here):
77
+ - the finding is **uncertain** after grounding (you'd need info you don't have),
78
+ - the fix has **multiple reasonable shapes** (e.g. reject-vs-sanitize,
79
+ index-vs-paginate) — present options with tradeoffs, not a chosen path,
80
+ - it **affects downstream** (function signatures, response shape, DB schema,
81
+ any caller contract), or
82
+ - it touches **auth / crypto / session / token** primitives — even an "obvious"
83
+ fix here warrants confirmation.
84
+
85
+ Final report: **confirmed-and-fixed** · **confirmed-but-asking** (why + options)
86
+ · **false-positive** (why) · **uncertain** (what's needed to decide).
@@ -17,6 +17,13 @@ Save session context for compaction recovery or handoffs.
17
17
  3. Stores important findings and insights
18
18
  4. Creates stash file in `.amp/stash/`
19
19
  5. Enables context restoration after compaction
20
+ 6. **Consolidation nudge** — after saving, count the unprocessed backlog:
21
+ `unprocessed = (files in .amp/stash/*.md) − (entries in .amp/memory/.processed)`
22
+ (a missing `.processed` manifest means 0 processed). If `unprocessed >= 5`, end with one line:
23
+ > 📝 N stashes since last consolidation — run `/remember` to fold them into memory.
24
+
25
+ No counter is stored — the count is derived each time, and running `/remember` updates
26
+ `.processed`, so the backlog drops on its own. Just emit the nudge; never run `/remember` automatically.
20
27
 
21
28
  **When to use**
22
29
  - Before long-running tasks that may trigger compaction
@@ -1,9 +1,9 @@
1
1
  ---
2
- name: test-driven-development
2
+ name: tdd-flow
3
3
  description: Use when implementing any feature or bugfix, before writing implementation code - write the test first, watch it fail, write minimal code to pass; ensures tests actually verify behavior by requiring failure first
4
4
  ---
5
5
 
6
- # Test-Driven Development (TDD)
6
+ # TDD Flow
7
7
 
8
8
  ## Auto-Trigger
9
9
 
@@ -1,18 +1,67 @@
1
1
  ---
2
2
  name: test-generate
3
- description: Generate tests [file]
4
- usage: /test-generate <code-section>
5
- argument-hint: [file-to-test]
3
+ description: Generate and run tests [file]
4
+ usage: /test-generate <file>
5
+ argument-hint: [file or symbol to test]
6
+ allowed-tools: Read, Edit, Write, Grep, Glob, Bash(npm test *), Bash(npx jest *), Bash(npx vitest *), Bash(pnpm test *), Bash(yarn test *), Bash(pytest *), Bash(python *), Bash(go test *), Bash(cargo test *), Bash(make test *)
6
7
  ---
7
- Generate tests for $ARGUMENTS.
8
-
9
- ## Include
10
- - Happy path (expected usage)
11
- - Edge cases (empty, null, boundaries)
12
- - Error scenarios (invalid input, failures)
13
- - Integration points (mocks for external deps)
14
-
15
- ## Requirements
16
- - Match existing test patterns in this project
17
- - Use the testing framework already in use
18
- - Clear test names: "should [expected] when [condition]"
8
+ Generate tests for $ARGUMENTS, then run them. This is a generate → run →
9
+ verify loop, not just file generation.
10
+
11
+ ## 1. Discover
12
+ - Detect the test framework already in use (look for `jest.config*`,
13
+ `vitest.config*`, `pytest.ini` / `pyproject.toml [tool.pytest]`, Go's
14
+ `_test.go` convention, `Cargo.toml [dev-dependencies]`, etc.). **Never
15
+ add a new framework or runner.**
16
+ - Skim 1–2 existing test files near the target to mirror style, fixtures,
17
+ setup/teardown, assertion style, and naming convention.
18
+
19
+ ## 2. Generate
20
+ Cover:
21
+ - **Happy path** (expected usage)
22
+ - **Edges** (empty / null / boundary / malformed)
23
+ - **Errors** (invalid input, IO / network / DB failures)
24
+
25
+ Match existing patterns:
26
+ - Same framework, same fixture style, same naming convention.
27
+ - Reuse existing setup/teardown helpers; do **not** add new mock libraries
28
+ or new test-runner config.
29
+ - Do **not** add test-only public methods or exports to production code to
30
+ make a test possible — if the test wants a hook the prod code doesn't
31
+ expose, stop and ask (`test-traps` territory).
32
+
33
+ ## 3. Run
34
+ Execute the project's real test command, scoped to just the new tests
35
+ (`-t <name>`, `--testPathPattern`, `pytest path/to/test.py`, `go test
36
+ ./pkg`, etc.). Report:
37
+ - Pass / fail counts.
38
+ - Any failure with the assertion message and `file:line`.
39
+
40
+ ## 4. Verify the tests BITE
41
+ A test that passes is not the same as a test that **exercises** the code.
42
+ For each new test, confirm:
43
+ - It would fail if the function under test returned the wrong value.
44
+ Mentally swap a broken impl — does the assertion actually catch it?
45
+ - It isn't `expect(true).toBe(true)`, `expect(fn).toBeDefined()`, or a
46
+ mock asserting itself.
47
+ - It isn't passing only because the setup masked the real call.
48
+
49
+ Mark each new test **biting** or **superficial** (with reason).
50
+ Superficial tests count as a failure to ship — either fix or delete.
51
+
52
+ ## 5. Report
53
+ - Files added / modified.
54
+ - Pass / fail.
55
+ - Biting vs superficial breakdown.
56
+ - What was deliberately **not** tested, and why (third-party shims,
57
+ trivial getters/setters, generated code). Documented gaps beat fake
58
+ coverage.
59
+
60
+ **Stop and ask** when:
61
+ - A meaningful test would require a non-obvious design change to
62
+ production code (don't pollute prod to make tests pass — present the
63
+ options instead).
64
+ - The existing test setup has multiple reasonable patterns and it's
65
+ unclear which to mirror.
66
+ - An existing dependency would need to be mocked in a way the project
67
+ doesn't currently do (introducing a new mock style is a design choice).
@@ -1,11 +1,11 @@
1
1
  ---
2
- name: testing-anti-patterns
2
+ name: test-traps
3
3
  description: Use when writing or changing tests, adding mocks, or tempted to add test-only methods to production code - prevents testing mock behavior, production pollution with test-only methods, and mocking without understanding dependencies
4
- usage: /testing-anti-patterns <testing-scenario>
4
+ usage: /test-traps <testing-scenario>
5
5
  auto_trigger: true
6
6
  ---
7
7
 
8
- # Testing Anti-Patterns
8
+ # Test Traps
9
9
 
10
10
  ## Overview
11
11
 
@@ -253,6 +253,79 @@ TDD cycle:
253
253
  4. THEN claim complete
254
254
  ```
255
255
 
256
+ ## Anti-Pattern 6: Timeout-Based Waiting
257
+
258
+ **The violation:**
259
+ ```typescript
260
+ // Wait an arbitrary amount of time, then check
261
+ await new Promise(r => setTimeout(r, 50));
262
+ const result = getResult();
263
+ expect(result).toBeDefined();
264
+ ```
265
+
266
+ ```python
267
+ time.sleep(0.5)
268
+ assert get_result() is not None
269
+ ```
270
+
271
+ **Why this is wrong:**
272
+ - Passes on fast machines, fails in CI under load (or vice versa).
273
+ - Either too short (flaky) or too long (slow suite) — every value is wrong somewhere.
274
+ - Hides the actual condition the test cares about.
275
+ - A real bug in the async machinery looks identical to a "too-short sleep."
276
+
277
+ **The fix — poll for the actual condition:**
278
+ ```typescript
279
+ await waitFor(() => getResult() !== undefined);
280
+ const result = getResult();
281
+ expect(result).toBeDefined();
282
+ ```
283
+
284
+ | Scenario | Pattern |
285
+ |----------|---------|
286
+ | Wait for event | `waitFor(() => events.find(e => e.type === 'DONE'))` |
287
+ | Wait for state | `waitFor(() => machine.state === 'ready')` |
288
+ | Wait for count | `waitFor(() => items.length >= 5)` |
289
+ | Wait for file | `waitFor(() => fs.existsSync(path))` |
290
+ | Complex condition | `waitFor(() => obj.ready && obj.value > 10)` |
291
+
292
+ Minimal generic poller:
293
+ ```typescript
294
+ async function waitFor<T>(
295
+ condition: () => T | undefined | null | false,
296
+ description = 'condition',
297
+ timeoutMs = 5000
298
+ ): Promise<T> {
299
+ const start = Date.now();
300
+ while (true) {
301
+ const result = condition();
302
+ if (result) return result;
303
+ if (Date.now() - start > timeoutMs) {
304
+ throw new Error(`Timeout waiting for ${description} after ${timeoutMs}ms`);
305
+ }
306
+ await new Promise(r => setTimeout(r, 10));
307
+ }
308
+ }
309
+ ```
310
+
311
+ See `example.ts` for domain-specific helpers (`waitForEvent`, `waitForEventCount`, `waitForEventMatch`) drawn from a real debugging session.
312
+
313
+ **Polling pitfalls:**
314
+ - **Polling too fast** (`setTimeout(check, 1)`) wastes CPU. **Fix:** poll every ~10ms.
315
+ - **No timeout** means a never-met condition hangs the suite forever. **Fix:** always include a timeout with a descriptive error.
316
+ - **Stale data** — if you read state once before the loop, you'll never see updates. **Fix:** call the getter *inside* the loop.
317
+
318
+ **When an arbitrary timeout IS correct:**
319
+ ```typescript
320
+ // Tool ticks every 100ms; observe 2 ticks of partial output.
321
+ await waitForEvent(manager, 'TOOL_STARTED'); // condition first
322
+ await new Promise(r => setTimeout(r, 200)); // then a documented, calculated wait
323
+ // 200ms = 2 ticks at the documented 100ms cadence
324
+ ```
325
+ Requirements: (1) wait for the triggering condition first, (2) the delay is based on a *known* interval (not a guess), (3) a comment explains why a sleep is correct here.
326
+
327
+ **Real-world impact** (debugging session, 2025-10-03): 15 flaky tests across 3 files, pass rate 60% → 100%, suite 40% faster, race conditions gone.
328
+
256
329
  ## When Mocks Become Too Complex
257
330
 
258
331
  **Warning signs:**
@@ -284,6 +357,7 @@ TDD cycle:
284
357
  | Mock without understanding | Understand dependencies first, mock minimally |
285
358
  | Incomplete mocks | Mirror real API completely |
286
359
  | Tests as afterthought | TDD - tests first |
360
+ | Timeout-based waiting | Poll for the actual condition with `waitFor()` |
287
361
  | Over-complex mocks | Consider integration tests |
288
362
 
289
363
  ## Red Flags
@@ -1,11 +1,11 @@
1
1
  ---
2
- name: root-cause-tracing
2
+ name: trace-back
3
3
  description: Use when errors occur deep in execution and you need to trace back to find the original trigger - systematically traces bugs backward through call stack, adding instrumentation when needed, to identify source of invalid data or incorrect behavior
4
- usage: /root-cause-tracing <issue-description>
4
+ usage: /trace-back <issue-description>
5
5
  auto_trigger: false
6
6
  ---
7
7
 
8
- # Root Cause Tracing
8
+ # Trace Back
9
9
 
10
10
  ## Overview
11
11
 
@@ -1,11 +1,11 @@
1
1
  ---
2
- name: verification-before-completion
2
+ name: verify-done
3
3
  description: Use when about to claim work is complete, fixed, or passing, before committing or creating PRs - requires running verification commands and confirming output before making any success claims; evidence before assertions always
4
- usage: /verification-before-completion <work-to-verify>
4
+ usage: /verify-done <work-to-verify>
5
5
  auto_trigger: true
6
6
  ---
7
7
 
8
- # Verification Before Completion
8
+ # Verify Done
9
9
 
10
10
  ## Auto-Trigger
11
11
 
@@ -22,38 +22,33 @@ These subagents are available when using Claude Code CLI. Droid can reference th
22
22
  | system-architect | Architect | Use for system design, architecture documents, technology selection, API design, and infrastructure planning |
23
23
  | ui-designer | UX Expert | Use for UI/UX design, wireframes, prototypes, front-end specifications, and user experience optimization |
24
24
 
25
- ### Skills (10 total)
25
+ ### Skills (9 total)
26
26
 
27
27
  | ID | Description | Usage | Auto |
28
28
  |---|---|---|---|
29
29
  | brainstorming | Refines rough ideas into fully-formed designs through collaborative questioning | /brainstorming <session-type> <topic> | false |
30
- | code-review | Reviews implementation against plan or requirements before proceeding | /code-review <review-scope> <focus-areas> | false |
31
- | condition-based-waiting | Replaces arbitrary timeouts with condition polling to wait for actual state changes | /condition-based-waiting <condition-type> <timeout-specs> | false |
32
30
  | docs-builder | Create comprehensive project documentation with structured /docs hierarchy | /docs-builder | false |
33
- | root-cause-tracing | Systematically traces bugs backward through call stack to identify source | /root-cause-tracing <issue-description> | false |
31
+ | trace-back | Systematically traces bugs backward through call stack to identify source | /trace-back <issue-description> | false |
34
32
  | live-canvas | Conduct design interviews, generate UI variations, collect live click-to-annotate feedback via a browser overlay that streams into the session | /live-canvas | false |
35
33
  | skill-creator | Guide for creating effective skills and extending Claude capabilities | /skill-creator <skill-type> <skill-description> | false |
36
- | systematic-debugging | Four-phase debugging framework - investigate root cause before any fixes | /systematic-debugging <bug-or-error-description> | false |
37
- | test-driven-development | Write test first, watch it fail, write minimal code to pass | /test-driven-development <feature-or-behavior-to-test> | true |
38
- | testing-anti-patterns | Prevents testing mock behavior and production pollution with test-only methods | /testing-anti-patterns <testing-scenario> | true |
39
- | verification-before-completion | Requires running verification commands before making any success claims | /verification-before-completion <work-to-verify> | true |
34
+ | debug-method | Four-phase debugging framework - investigate root cause before any fixes | /debug-method <bug-or-error-description> | false |
35
+ | tdd-flow | Write test first, watch it fail, write minimal code to pass | /tdd-flow <feature-or-behavior-to-test> | true |
36
+ | test-traps | Prevents testing mock behavior and production pollution with test-only methods | /test-traps <testing-scenario> | true |
37
+ | verify-done | Requires running verification commands before making any success claims | /verify-done <work-to-verify> | true |
40
38
 
41
- ### Commands (12 total)
39
+ ### Commands (9 total)
42
40
 
43
41
  | ID | Description | Usage |
44
42
  |---|---|---|
45
- | debug | Debug an issue systematically using structured investigation techniques | /debug <issue-description> |
46
- | explain | Explain code for someone new to the codebase | /explain <code-section> |
47
- | friction | Analyze session logs for failure patterns and behavioral signals | /friction <sessions-path> |
48
- | git-commit | Analyze changes and create intelligent git commits | /git-commit |
49
43
  | optimize | Analyze and optimize performance issues | /optimize <target-area> |
50
44
  | refactor | Refactor code while maintaining behavior and tests | /refactor <code-section> |
51
45
  | remember | Consolidate stashes + friction into project memory | /remember |
52
- | review | Comprehensive code review including quality, tests, and architecture | /review |
46
+ | diff-review | Comprehensive code review including quality, tests, and architecture | /diff-review |
53
47
  | security | Security vulnerability scan and analysis | /security |
54
48
  | ship | Pre-deployment verification checklist | /ship |
49
+ | release | Deliver a feature end-to-end: verify, docs, merge, tag (publish stays manual) | /release [branch] |
55
50
  | stash | Save session context for compaction recovery or handoffs | /stash ["optional-name"] |
56
- | test-generate | Generate comprehensive test suites for existing code | /test-generate <code-section> |
51
+ | test-generate | Generate tests, run them, verify each one actually exercises the code | /test-generate <file> |
57
52
 
58
53
  All resources are auto-discovered from frontmatter in their respective directories:
59
54
  - **Agents**: `./agents/*.md`
@@ -41,7 +41,7 @@ digraph CodeDeveloper {
41
41
  context_discovery [label="Context Discovery\n(search related code,\ndeps, usages)", fillcolor=lightyellow];
42
42
 
43
43
  // Debug path
44
- use_debug [label="Use /systematic-debugging\nor /root-cause-tracing"];
44
+ use_debug [label="Use /debug-method\nor /trace-back"];
45
45
 
46
46
  // Refactor path
47
47
  use_refactor [label="Use /refactor"];
@@ -54,12 +54,12 @@ digraph CodeDeveloper {
54
54
 
55
55
  // Conditional testing
56
56
  tdd_needed [label="TDD specified\nor tests needed?", shape=diamond];
57
- use_tdd [label="Use /test-driven-development\nor /test-generate"];
57
+ use_tdd [label="Use /tdd-flow\nor /test-generate"];
58
58
 
59
59
  // Validation
60
60
  run_validations [label="Run validations\n(lint, build, tests)"];
61
61
  validations_pass [label="Pass?", shape=diamond];
62
- fix_issues [label="Fix issues\n(use /debug if needed)"];
62
+ fix_issues [label="Fix issues\n(use /debug-method if needed)"];
63
63
  failure_count [label="3+ failures?", shape=diamond];
64
64
 
65
65
  // Security check
@@ -75,8 +75,8 @@ digraph CodeDeveloper {
75
75
  regression_fixable [label="Fixable?", shape=diamond];
76
76
 
77
77
  // Review and complete
78
- code_review [label="Run /code-review"];
79
- verification [label="Run /verification-before-completion", fillcolor=orange];
78
+ code_review [label="Run /diff-review"];
79
+ verification [label="Run /verify-done", fillcolor=orange];
80
80
 
81
81
  // Story-specific
82
82
  update_story [label="Update story\n(checkbox, changelog)"];
@@ -184,15 +184,14 @@ All require `*` prefix. Invocation commands in table above. Additional:
184
184
 
185
185
  | Situation | Delegate To |
186
186
  |-----------|-------------|
187
- | Bug encountered | `/systematic-debugging` first, then `/debug` |
188
- | Error deep in stack | `/root-cause-tracing` |
187
+ | Bug encountered | `/debug-method` (use `/trace-back` when the error is deep in the stack) |
188
+ | Error deep in stack | `/trace-back` |
189
189
  | Refactoring code | `/refactor` |
190
- | Need tests (when required) | `/test-generate` or `/test-driven-development` |
191
- | Writing any test | `/testing-anti-patterns` (avoid mocks, production pollution) |
192
- | Before completion | `/verification-before-completion` |
190
+ | Need tests (when required) | `/test-generate` or `/tdd-flow` |
191
+ | Writing any test | `/test-traps` (avoid mocks, production pollution) |
192
+ | Before completion | `/verify-done` |
193
193
  | After code changes | `/security` |
194
- | Task complete (vs plan) | `/code-review` (checks against requirements/plan) |
195
- | General code review | `/review` (comprehensive quality check) |
194
+ | Task complete / general review | `/diff-review` (diffs branch or staged changes, verifies, fixes confirmed issues, asks on ambiguous ones) |
196
195
  | Performance issues | `/optimize` |
197
196
 
198
197
  You are an autonomous implementation specialist. Execute with precision, delegate appropriately, and communicate clearly when you need guidance or encounter blockers.
@@ -65,7 +65,7 @@ Before any analysis, read (if exists):
65
65
 
66
66
  ## Slash Commands Available
67
67
 
68
- Use these during analysis: `/code-review`, `/security`, `/debug`, `/review`, `/verification-before-completion`
68
+ Use these during analysis: `/diff-review`, `/security`, `/verify-done`
69
69
 
70
70
  ## Analysis Areas
71
71