linter-bundle 7.1.0 → 7.1.2

package/CHANGELOG.md

@@ -6,7 +6,28 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ## [Unreleased]
 
-[Show all code changes](https://github.com/jens-duttke/linter-bundle/compare/v7.1.0...HEAD)
+[Show all code changes](https://github.com/jens-duttke/linter-bundle/compare/v7.1.2...HEAD)
+
+## [7.1.2] - 2025-03-15
+
+### Fixed
+
+- [eslint] Add line-break before variable declarations groups
+
+### Changed
+
+- [eslint] Optimize parens position of `enforce-logical-expression-parens` and `enforce-ternary-parens`
+- [eslint] Improve `eslint.config.mjs` code example in [README.md](./README.md)
+
+[Show all code changes](https://github.com/jens-duttke/linter-bundle/compare/v7.1.1...v7.1.2)
+
+## [7.1.1] - 2025-03-15
+
+### Fixed
+
+- [eslint/react] Fixed `Key "plugins": Cannot redefine plugin "linter-bundle".` issue
+
+[Show all code changes](https://github.com/jens-duttke/linter-bundle/compare/v7.1.0...v7.1.1)
 
 ## [7.1.0] - 2025-03-15
 
@@ -21,7 +42,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - [eslint] Added custom linter rule [`linter-bundle/enforce-ternary-parens`](./eslint/rules/enforce-ternary-parens.md) which ensures ternary expressions are wrapped in parentheses
 - [eslint] Added custom linter rule [`linter-bundle/no-extra-spaces-in-generics`](./eslint/rules/no-extra-spaces-in-generics.md) to disallows spaces after the `<` and before the `>` in TypeScript generics
 - [eslint] Added custom linter rule [`linter-bundle/no-ternary-return`](./eslint/rules/no-ternary-return.md) which disallows ternary expressions as return values for better readability
-- [eslint] Configure [`padding-line-between-statements`](https://eslint.org/docs/latest/rules/padding-line-between-statements) to enforce line-breaks before `return`, `throw`, `break`, `continue`, around multi-line block statements and around `const`, `let`, `var` groups
+- [eslint] Configured [`padding-line-between-statements`](https://eslint.org/docs/latest/rules/padding-line-between-statements) to enforce line-breaks before `return`, `throw`, `break`, `continue`, around multi-line block statements and around `const`, `let`, `var` groups
 - [eslint/react] Added custom linter rule [`linter-bundle/ensure-lucide-import-consistency`](./eslint/rules/ensure-lucide-import-consistency.md) to enforces using [Lucide](https://lucide.dev/guide/packages/lucide-react) prefix for lucide-react imports and their usage
 - [eslint] Updated `eslint-import-resolver-typescript` from `3.8.4` to `3.9.0`
 - [stylelint] Updated `stylelint` from `16.15.0` to `16.16.0`

package/README.md

@@ -93,17 +93,28 @@ npm install linter-bundle --save-dev
 #### eslint.config.mjs
 
 ```js
+import gatsbyConfig from './eslint/gatsby.mjs';
+import javascriptConfig from './eslint/javascript.mjs';
+// import javascriptLazyConfig from './eslint/javascript-lazy.mjs';
+import jestConfig from './eslint/jest.mjs';
+import jsdocConfig from './eslint/jsdoc.mjs';
+import reactConfig from './eslint/react.mjs';
+import storybookConfig from './eslint/storybook.mjs';
+import typeDeclarationsConfig from './eslint/type-declarations.mjs';
+import workerConfig from './eslint/worker.mjs';
+import eslintConfig from './eslint.mjs';
+
 export default [
-  ...(await import('linter-bundle/eslint.mjs')).default,
-  // ...(await import('linter-bundle/eslint/gatsby.mjs')).default,
-  // ...(await import('linter-bundle/eslint/javascript.mjs')).default,
-  ...(await import('linter-bundle/eslint/javascript-lazy.mjs')).default,
-  // ...(await import('linter-bundle/eslint/jest.mjs')).default,
-  ...(await import('linter-bundle/eslint/jsdoc.mjs')).default,
-  // ...(await import('linter-bundle/eslint/react.mjs')).default,
-  // ...(await import('linter-bundle/eslint/storybook.mjs')).default,
-  // ...(await import('linter-bundle/eslint/type-declarations.mjs')).default,
-  // ...(await import('linter-bundle/eslint/worker.mjs')).default
+  ...eslintConfig,
+  ...gatsbyConfig,
+  ...javascriptConfig,
+  // ...javascriptLazyConfig,
+  ...jsdocConfig,
+  ...reactConfig,
+  ...storybookConfig,
+  ...typeDeclarationsConfig,
+  ...workerConfig
+  ...jestConfig,
 ]
 ```
 

package/eslint/index.mjs

@@ -24,6 +24,7 @@ import { linterBundleConfig } from '../helper/linter-bundle-config.js';
 
 import enforceLogicalExpressionParens from './rules/enforce-logical-expression-parens.mjs';
 import enforceTernaryParensRule from './rules/enforce-ternary-parens.mjs';
+import ensureLucideImportConsistencyRule from './rules/ensure-lucide-import-consistency.mjs';
 import noExtraSpacesInGenericsRule from './rules/no-extra-spaces-in-generics.mjs';
 import noTernaryReturnRule from './rules/no-ternary-return.mjs';
 import noUnnecessaryTypeofRule from './rules/no-unnecessary-typeof.mjs';
@@ -53,6 +54,7 @@ export default [
 				rules: {
 					'enforce-logical-expression-parens': enforceLogicalExpressionParens,
 					'enforce-ternary-parens': enforceTernaryParensRule,
+					'ensure-lucide-import-consistency': ensureLucideImportConsistencyRule,
 					'no-extra-spaces-in-generics': noExtraSpacesInGenericsRule,
 					'no-ternary-return': noTernaryReturnRule,
 					'no-unnecessary-typeof': noUnnecessaryTypeofRule,
@@ -390,6 +392,7 @@ export default [
 				'error',
 				{ blankLine: 'always', prev: '*', next: ['return', 'throw', 'break', 'continue'] },
 				{ blankLine: 'always', prev: ['const', 'let', 'var'], next: '*' },
+				{ blankLine: 'always', prev: '*', next: ['const', 'let', 'var'] },
 				{ blankLine: 'any', prev: ['const', 'let', 'var'], next: ['const', 'let', 'var'] },
 				{ blankLine: 'always', prev: '*', next: 'multiline-block-like' },
 				{ blankLine: 'always', prev: 'multiline-block-like', next: '*' }

package/eslint/react.mjs

@@ -9,19 +9,12 @@ import * as reactHooksPlugin from 'eslint-plugin-react-hooks';
 import * as ensureType from '../helper/ensure-type.mjs';
 import { linterBundleConfig } from '../helper/linter-bundle-config.js';
 
-import ensureLucideImportConsistencyRule from './rules/ensure-lucide-import-consistency.mjs';
-
 export default [
 	{
 		plugins: {
 			'react-hooks': reactHooksPlugin,
 			'react': reactPlugin,
-			'@stylistic/jsx': stylisticJSXPlugin,
-			'linter-bundle': {
-				rules: {
-					'ensure-lucide-import-consistency': ensureLucideImportConsistencyRule
-				}
-			}
+			'@stylistic/jsx': stylisticJSXPlugin
 		}
 	},
 	{

package/eslint/rules/enforce-logical-expression-parens.mjs

@@ -25,12 +25,21 @@ export default {
 					return; // Do not add parentheses if they are already present
 				}
 
-				// If no parentheses are present, add parentheses around the logical operation
 				context.report({
 					node,
 					message: 'Add parentheses around the logical operation.',
 					fix (fixer) {
-						return fixer.replaceText(node, `(${context.getSourceCode().getText(node)})`);
+						const nodeBefore = context.sourceCode.getTokenBefore(node, { includeComments: true });
+						const nodeAfter = context.sourceCode.getTokenAfter(node, { includeComments: true });
+
+						if (!nodeBefore || !nodeAfter) {
+							return fixer.replaceText(node, `(${context.sourceCode.getText(node)})`);
+						}
+
+						return [
+							fixer.insertTextAfter(nodeBefore, '('),
+							fixer.insertTextBefore(nodeAfter, ')')
+						];
 					}
 				});
 			}

package/eslint/rules/enforce-ternary-parens.mjs

@@ -29,8 +29,17 @@ export default {
 					node,
 					message: 'Ternary expressions must be wrapped in parentheses.',
 					fix (fixer) {
-						// Wrap the entire ternary expression in parentheses.
-						return fixer.replaceText(node, `(${context.sourceCode.getText(node)})`);
+						const nodeBefore = context.sourceCode.getTokenBefore(node, { includeComments: true });
+						const nodeAfter = context.sourceCode.getTokenAfter(node, { includeComments: true });
+
+						if (!nodeBefore || !nodeAfter) {
+							return fixer.replaceText(node, `(${context.sourceCode.getText(node)})`);
+						}
+
+						return [
+							fixer.insertTextAfter(nodeBefore, '('),
+							fixer.insertTextBefore(nodeAfter, ')')
+						];
 					}
 				});
 			}

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "linter-bundle",
-	"version": "7.1.0",
+	"version": "7.1.2",
 	"type": "module",
 	"description": "Ready-to use bundle of linting tools, containing configurations for ESLint, stylelint and markdownlint.",
 	"keywords": [