linter-bundle 2.3.0 → 2.3.1

package/CHANGELOG.md

@@ -6,9 +6,22 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ## [Unreleased]
 
-[Show all code changes](https://github.com/jens-duttke/linter-bundle/compare/v2.2.0...HEAD)
+[Show all code changes](https://github.com/jens-duttke/linter-bundle/compare/v2.3.1...HEAD)
 
-## [2.2.0] - 2022.01.27
+## [2.3.1] - 2022.01.28
+
+### Fixed
+
+- [eslint/overrides-javascript(-lazy)] Move `import/no-import-module-exports` rule to`overrides-javascript`
+- [eslint/overrides-gatsby] Ignore '@reach/router' in `import/no-unresolved` rule
+- [eslint] Disabled `react/require-default-props`, because of false-positive for React.forwardRef wrapped functional components
+- [eslint] Disabled `unicorn/prefer-top-level-await`, because of false-positive on environments with Node.js below v14.8
+- [eslint] Activated `allowThrowingUnknown` option of the [`@typescript-eslint/no-throw-literal`](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-throw-literal.md) rule
+- [stylelint] Activate `camelCaseSvgKeywords` option of the [`value-keyword-case`](https://github.com/stylelint/stylelint/tree/main/lib/rules/value-keyword-case) rule
+
+[Show all code changes](https://github.com/jens-duttke/linter-bundle/compare/v2.3.0...v2.3.1)
+
+## [2.3.0] - 2022.01.27
 
 ### Changed
 
@@ -47,7 +60,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - [stylelint] Added new [`scss/at-use-no-unnamespaced`](https://github.com/stylelint-scss/stylelint-scss/tree/master/src/rules/at-use-no-unnamespaced) rule
 - [stylelint] Added but disabled [`rule-selector-property-disallowed-list`](https://github.com/stylelint/stylelint/tree/main/lib/rules/rule-selector-property-disallowed-list) rule
 
-[Show all code changes](https://github.com/jens-duttke/linter-bundle/compare/v2.1.0...v2.2.0)
+[Show all code changes](https://github.com/jens-duttke/linter-bundle/compare/v2.1.0...v2.3.0)
 
 ## [2.1.0] - 2021.11.07
 

package/eslint/index.js

@@ -644,7 +644,7 @@ module.exports = {
 		'@typescript-eslint/no-this-alias': 'error',
 		'@typescript-eslint/no-throw-literal': ['error', {
 			allowThrowingAny: false,
-			allowThrowingUnknown: false
+			allowThrowingUnknown: true
 		}],
 		'@typescript-eslint/no-type-alias': ['off', { // @todo There should be an option like 'sub-in-unions-and-intersections', which allows `type A = (string | number)[];`
 			allowAliases: 'always',
@@ -770,7 +770,7 @@ module.exports = {
 				'workbox-window/utils/WorkboxEvent'
 			]
 		}],
-		'import/no-import-module-exports': 'error',
+		'import/no-import-module-exports': 'off', // Activated only for JavaScript files
 		'import/no-mutable-exports': 'error',
 		'import/no-named-as-default-member': 'error',
 		'import/no-named-as-default': 'error',
@@ -987,7 +987,7 @@ module.exports = {
 		'unicorn/prefer-string-trim-start-end': 'error',
 		'unicorn/prefer-switch': 'error',
 		'unicorn/prefer-ternary': 'off', // We prefer readability over saving a few chars
-		'unicorn/prefer-top-level-await': 'error',
+		'unicorn/prefer-top-level-await': 'off', // @todo There should be a detection that this option is only activated on Node.js v14.8 environments and above (Check for "engine" property in package.json, and "node -v")
 		'unicorn/prefer-regexp-test': 'error',
 		'unicorn/prefer-type-error': 'error',
 		'unicorn/prevent-abbreviations': ['error', { ignore: ['args', 'i', 'j', 'i18n', 'ref', 'Ref', 'params', 'props', 'Props'] }],

package/eslint/overrides-gatsby.js

@@ -33,6 +33,13 @@ module.exports = {
 				 */
 				'@typescript-eslint/no-confusing-void-expression': 'off', // @todo Conflicts with graphql-template strings
 
+				/**
+				 * eslint-plugin-import
+				 *
+				 * @see https://github.com/import-js/eslint-plugin-import
+				 */
+				'import/no-unresolved': ['error', { caseSensitiveStrict: true, ignore: ['@reach/router'] }],
+
 				/**
 				 * eslint-plugin-unicorn
 				 *

package/eslint/overrides-javascript.js

@@ -42,6 +42,7 @@ module.exports = {
 				 * @see https://github.com/import-js/eslint-plugin-import
 				 */
 				'import/no-commonjs': 'off',
+				'import/no-import-module-exports': 'error',
 				'import/no-internal-modules': 'off',
 				'import/no-nodejs-modules': 'off',
 

package/eslint/overrides-react.js

@@ -88,7 +88,7 @@ module.exports = {
 				'react/prefer-stateless-function': 'error',
 				'react/prop-types': 'off',
 				'react/react-in-jsx-scope': 'error',
-				'react/require-default-props': ['error', { forbidDefaultForRequired: true, ignoreFunctionalComponents: true }], // @see https://medium.com/@matanbobi/react-defaultprops-is-dying-whos-the-contender-443c19d9e7f1
+				'react/require-default-props': ['off', { forbidDefaultForRequired: true, ignoreFunctionalComponents: true }], // @see https://medium.com/@matanbobi/react-defaultprops-is-dying-whos-the-contender-443c19d9e7f1 @todo Also disabled becaues of false-positive with React.forwardRef(), create bug report?
 				'react/require-optimization': 'error',
 				'react/require-render-return': 'error',
 				'react/self-closing-comp': 'error',

package/lint.js

@@ -121,7 +121,6 @@ const jobs = getTasksToRun(process.argv.splice(2)).map(({ taskName, config }) =>
 	throw new Error(`"${taskName}" is not a valid task.`);
 });
 
-// eslint-disable-next-line unicorn/prefer-top-level-await -- The minimum required Node.js version is v14.8, but we are also support down till v14.0
 void (async () => {
 	for (const { jobTitle, taskSetup, job } of jobs) {
 		process.stdout.write(jobTitle);

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "linter-bundle",
-	"version": "2.3.0",
+	"version": "2.3.1",
 	"description": "Ready-to use bundle of linting tools, containing configurations for ESLint, stylelint and markdownlint.",
 	"keywords": [
 		"eslint",
@@ -70,7 +70,7 @@
 	},
 	"devDependencies": {
 		"@types/eslint": "8.4.1",
-		"@types/node": "17.0.12",
+		"@types/node": "17.0.13",
 		"stylelint-find-new-rules": "^3.0.4",
 		"typescript": "4.5.5"
 	}

package/stylelint/index.js

@@ -309,7 +309,12 @@ module.exports = {
 		'unit-case': 'lower',
 		'unit-disallowed-list': null,
 		'unit-no-unknown': true,
-		'value-keyword-case': 'lower',
+		'value-keyword-case': [
+			'lower',
+			{
+				camelCaseSvgKeywords: true
+			}
+		],
 		'value-list-comma-newline-after': 'always-multi-line',
 		'value-list-comma-newline-before': 'never-multi-line',
 		'value-list-comma-space-after': 'always-single-line',