linter-bundle 2.16.0 → 2.19.0

package/CHANGELOG.md

@@ -6,10 +6,66 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ## [Unreleased]
 
-[Show all code changes](https://github.com/jens-duttke/linter-bundle/compare/v2.15.0...HEAD)
+[Show all code changes](https://github.com/jens-duttke/linter-bundle/compare/v2.18.0...HEAD)
+
+## [2.19.0] - 2022.08.28
+
+### Changed
+
+- [eslint] Updated `@typescript-eslint` from `5.33.1` to `5.35.1`
+- [eslint] Updated `eslint` from `8.22.0` to `8.23.0`
+- [eslint] Updated `eslint-import-resolver-typescript` from `3.4.2` to `3.5.0`
+- [eslint] Updated `eslint-plugin-jest` from `26.8.3` to `26.9.0`
+- [eslint] Updated `eslint-plugin-promise` from `6.0.0` to `6.0.1`
+- [eslint] Updated `eslint-plugin-react` from `7.30.1` to `7.31.1`
+- [markdownlint] Updated `markdownlint-cli` from `0.32.1` to `0.32.2`
+- [stylelint] Updated `stylelint` from `14.10.0` to `14.11.0`
+- [eslint] Activate [`allowEmptyCase`](https://github.com/eslint/eslint/blob/main/docs/src/rules/no-fallthrough.md#allowemptycase) option of `no-fallthrough` rule
+- [stylelint] Activate [`ignoreAfterCombinators: ['>', '+']`](https://stylelint.io/user-guide/rules/list/selector-max-universal/#ignoreaftercombinators-array-of-combinators) of `selector-max-universal` rule, see [this issue](https://github.com/stylelint/stylelint/issues/5792) for details
+
+### Added
+
+- [eslint/overrides-jest] Make use of [jest/prefer-each](https://github.com/jest-community/eslint-plugin-jest/blob/main/docs/rules/prefer-each.md) rule
+
+## [2.18.0] - 2022.08.19
+
+### Changed
+
+- [eslint] Updated `@typescript-eslint/eslint-plugin` from `5.33.0` to `5.33.1`
+- [eslint] Updated `eslint` from `8.21.0` to `8.22.0`
+- [eslint] Updated `eslint-import-resolver-typescript` from `3.4.0` to `3.4.2`
+- [eslint] Updated `eslint-plugin-jest` from `26.8.2` to `26.8.3`
+- [stylelint] Updated `stylelint` from `14.9.1` to `14.10.0`
+- [eslint/overrides-react] Activate [`allowExpressions`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-no-useless-fragment.md#allowexpressions) for
+  [`react/jsx-no-useless-fragment`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-no-useless-fragment.md) rule, to fill the React type definitions
+  requirement that when a component returns only children (a ReactNode), the return value is a ReactElement by wrapping children in a React.Fragment
+
+### Added
+
+- [stylelint] Make use of [`annotation-no-unknown`](https://github.com/stylelint/stylelint/tree/main/lib/rules/annotation-no-unknown) rule
+- [stylelint] Make use of [`keyframe-selector-notation`](https://github.com/stylelint/stylelint/tree/main/lib/rules/keyframe-selector-notation) rule, with option `percentage`
+
+[Show all code changes](https://github.com/jens-duttke/linter-bundle/compare/v2.17.0...v2.18.0)
+
+## [2.17.0] - 2022.08.10
+
+### Changed
+
+- [eslint] Updated `@typescript-eslint/eslint-plugin` from `5.32.0` to `5.33.0`
+- [eslint] Updated `eslint-plugin-jest` from `26.7.0` to `26.8.2`
+- [eslint] Updated `eslint-plugin-jsdoc` from `39.3.4` to `39.3.6`
+
+### Fixed
+
+- [eslint/overrides-react] Disable [`react/jsx-no-leaked-render`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-no-leaked-render.md) rule, as this should be covered by types in TypeScript to prevent unnecessary type castings from boolean to boolean
+- [stylelint] Add `except` for `"margin"` and `"padding"` in `stylelint-use-logical-spec` rule, to prevent [unnecessary warnings](https://github.com/Jordan-Hall/stylelint-use-logical-spec/issues/33) for usages like `margin: 10px 20px;`
+
+[Show all code changes](https://github.com/jens-duttke/linter-bundle/compare/v2.16.0...v2.17.0)
 
 ## [2.16.0] - 2022.08.05
 
+### Changed
+
 - [eslint] Updated `eslint` from `8.14.0` to `8.21.0`
 - [eslint] Updated `eslint-import-resolver-typescript` from `2.7.1` to `3.4.0`
 - [eslint] Updated `eslint-plugin-functional` from `4.2.1` to `4.2.2`
@@ -20,7 +76,14 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - [eslint] Updated `eslint-plugin-react-hooks` from `4.5.0` to `4.6.0`
 - [eslint] Updated `eslint-plugin-unicorn` from `42.0.0` to `43.0.2`
 - [eslint] Updated `@typescript-eslint` from `5.22.0` to `5.32.0`
-- [eslint] Remove deprecated `@typescript-eslint/no-duplicate-imports` rule
+- [markdownlint] Updated `markdownlint-cli` from `0.31.1` to `0.32.1`
+- [stylelint] Updated `stylelint` from `14.8.2` to `14.9.1`
+- [stylelint] Updated `stylelint-scss` from `4.2.0` to `4.3.0`
+- [stylelint] Updated `stylelint-selector-no-empty` from `1.0.8` to `1.0.9`
+- [stylelint] Updated `stylelint-use-logical-spec` from `3.2.2` to `4.1.0`
+
+### Added
+
 - [eslint] Make use of [`@typescript-eslint/no-restricted-imports`](https://typescript-eslint.io/rules/no-restricted-imports/) rule
 - [eslint] Make use of [`@typescript-eslint/space-infix-ops`](https://typescript-eslint.io/rules/space-infix-ops/) rule
 - [eslint] Make use of [`@typescript-eslint/consistent-generic-constructors`](https://typescript-eslint.io/rules/consistent-generic-constructors/) rule
@@ -30,17 +93,20 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - [eslint/overrides-react] Make use of [`react/jsx-no-leaked-render`](https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/jsx-no-leaked-render.md) rule
 - [eslint] Added but disable [`unicorn/prefer-event-target`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-event-target.md) rule
 - [eslint] Make use of [`unicorn/prefer-logical-operator-over-ternary`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-logical-operator-over-ternary.md) rule
-- [eslint] Remove deprecated `unicorn/import-index` rule
-- [markdownlint] Updated `markdownlint-cli` from `0.31.1` to `0.32.1`
-- [stylelint] Updated `stylelint` from `14.8.2` to `14.9.1`
-- [stylelint] Updated `stylelint-scss` from `4.2.0` to `4.3.0`
-- [stylelint] Updated `stylelint-selector-no-empty` from `1.0.8` to `1.0.9`
-- [stylelint] Updated `stylelint-use-logical-spec` from `3.2.2` to `4.1.0`
 - [stylelint] Added but disable [`import-notation`](https://github.com/stylelint/stylelint/tree/main/lib/rules/import-notation) rule
 
+### Removed
+
+- [eslint] Remove deprecated `@typescript-eslint/no-duplicate-imports` rule
+- [eslint] Remove deprecated `unicorn/import-index` rule
+
+[Show all code changes](https://github.com/jens-duttke/linter-bundle/compare/v2.15.0...v2.16.0)
+
+[Show all code changes](https://github.com/jens-duttke/linter-bundle/compare/v2.15.0...v2.16.0)
+
 ## [2.15.0] - 2022.05.05
 
-### Changed
+### Fixed
 
 - [stylelint] Disabled `declaration-property-max-values` rule because of false-positives.
 - [stylelint] Disabled `selector-not-notation` for now, because it depends on the project if modern Selectors Level 4 CSS can be used.
@@ -59,14 +125,20 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ### Changed
 
-- [general] Remove files from npm package which are only necessary for development
 - [eslint] Updated `@typescript-eslint` from `5.21.0` to `5.22.0`
 - [eslint] Updated `eslint-plugin-jsdoc` from `39.2.8` to `39.2.9`
 - [eslint] Updated `eslint-plugin-react-hooks` from `4.4.0` to `4.5.0`
 - [stylelint] Updated `stylelint` from `14.7.1` to `14.8.2`
+
+### Added
+
 - [eslint] Make use of new [`@typescript-eslint/no-duplicate-enum-values`](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/no-duplicate-enum-values.md) rule
 - [stylelint] Make use of new [`keyframe-block-no-duplicate-selectors`](https://github.com/stylelint/stylelint/blob/main/lib/rules/keyframe-block-no-duplicate-selectors/README.md) rule
 - [stylelint] In the deployment process, ensure that the used Stylelint options are valid
+
+### Fixed
+
+- [general] Remove files from npm package which are only necessary for development
 - [stylelint] Fix invalid configuration of [`declaration-property-max-values`](https://github.com/stylelint/stylelint/blob/main/lib/rules/declaration-property-max-values/README.md) rule
 
 [Show all code changes](https://github.com/jens-duttke/linter-bundle/compare/v2.13.0...v2.14.0)
@@ -75,7 +147,6 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 
 ### Changed
 
-- [eslint] Activate `allowExpressions` option of [`@typescript-eslint/explicit-function-return-type`](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/explicit-function-return-type.md) rule
 - [eslint] Updated `@typescript-eslint` from `5.17.0` to `5.21.0`
 - [eslint] Updated `eslint` from `8.12.0` to `8.14.0`
 - [eslint] Updated `eslint-import-resolver-typescript` from `2.7.0` to `2.7.1`
@@ -86,14 +157,17 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - [eslint] Updated `eslint-plugin-unicorn` from `41.0.1` to `42.0.0`
 - [stylelint] Updated `postcss-scss` from `4.0.3` to `4.0.4`
 - [stylelint] Updated `stylelint` from `14.6.1` to `14.7.1`
-- [eslint] Activate `allowExpressions` option of [`@typescript-eslint/explicit-function-return-type`](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/explicit-function-return-type.md) rule
 - [eslint/overrides-jsdoc] Set [`minLineCount` option to 2](https://github.com/gajus/eslint-plugin-jsdoc/issues/870) for `require-jsdoc` rule
+- [stylelint] Set [`selector-not-notation`](https://github.com/stylelint/stylelint/blob/main/lib/rules/selector-not-notation/README.md) rule to `"complex"`
+
+### Added
+
+- [eslint] Activate `allowExpressions` option of [`@typescript-eslint/explicit-function-return-type`](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/docs/rules/explicit-function-return-type.md) rule
 - [eslint] Reactivated the [`import/no-relative-packages`](https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/no-relative-packages.md) rule
 - [eslint] Make use of new [`unicorn/no-useless-switch-case`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-useless-switch-case.md) rule
 - [eslint] Make use of new [`unicorn/prefer-modern-math-apis`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-modern-math-apis.md) rule
 - [eslint] Make use of new [`unicorn/no-unreadable-iife`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/no-unreadable-iife.md) rule
 - [eslint] Add but disable [`unicorn/prefer-native-coercion-functions`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-native-coercion-functions.md) rule, because this would produce inconsistency in the code and is harder to read
-- [stylelint] Set [`selector-not-notation`](https://github.com/stylelint/stylelint/blob/main/lib/rules/selector-not-notation/README.md) rule to `"complex"`
 
 [Show all code changes](https://github.com/jens-duttke/linter-bundle/compare/v2.12.0...v2.13.0)
 
@@ -112,9 +186,12 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 - [stylelint] Updated `stylelint` from `14.5.3` to `14.6.1`
 - [stylelint] Updated `stylelint-scss` from `4.1.0` to `4.2.0`
 - [general] Updated `micromatch` from `4.0.4` to `4.0.5`
+- [stylelint] Replace `function-no-unknown` by `scss/function-no-unknown`
+
+### Added
+
 - [eslint] Make use of [`destructuredArrayIgnorePattern`](https://eslint.org/docs/rules/no-unused-vars#destructuredarrayignorepattern) of `@typescript-eslint/no-unused-vars` rule, to ignore variables with leading underscore.
 - [stylelint] Make use of [`declaration-property-max-values`](https://stylelint.io/user-guide/rules/list/declaration-property-max-values/) rule, and set `unprefixed-property-name` to `4`
-- [stylelint] Replace `function-no-unknown` by `scss/function-no-unknown`
 
 [Show all code changes](https://github.com/jens-duttke/linter-bundle/compare/v2.11.1...v2.12.0)
 

package/eslint/index.js

@@ -173,7 +173,7 @@ module.exports = {
 		'no-extend-native': 'error',
 		'no-extra-bind': 'error',
 		'no-extra-label': 'error',
-		'no-fallthrough': 'error',
+		'no-fallthrough': ['error', { allowEmptyCase: true }],
 		'no-floating-decimal': 'error',
 		'no-global-assign': 'error',
 		'no-implicit-coercion': ['error', { disallowTemplateShorthand: true }],

package/eslint/overrides-jest.js

@@ -97,6 +97,7 @@ module.exports = {
 				'jest/prefer-hooks-in-order': 'error',
 				'jest/prefer-hooks-on-top': 'error',
 				'jest/prefer-comparison-matcher': 'error',
+				'jest/prefer-each': 'error',
 				'jest/prefer-equality-matcher': 'error',
 				'jest/prefer-mock-promise-shorthand': 'error',
 				'jest/prefer-snapshot-hint': 'error',

package/eslint/overrides-react.js

@@ -150,12 +150,12 @@ module.exports = {
 				'react/jsx-no-comment-textnodes': 'error',
 				'react/jsx-no-constructed-context-values': 'error',
 				'react/jsx-no-duplicate-props': 'error',
-				'react/jsx-no-leaked-render': 'error',
+				'react/jsx-no-leaked-render': 'off', // Should be covered by boolean-types in TypeScript, otherwise unnecessary type-castings from boolean to boolean would be required
 				'react/jsx-no-literals': 'off',
 				'react/jsx-no-script-url': 'error',
 				'react/jsx-no-target-blank': ['error', { allowReferrer: true, forms: true }],
 				'react/jsx-no-undef': 'error',
-				'react/jsx-no-useless-fragment': 'error',
+				'react/jsx-no-useless-fragment': ['error', { allowExpressions: true }],
 				'react/jsx-one-expression-per-line': ['off', { allow: 'single-child' }], // @todo Doesn't work with something like "Text <a href="...">Link</a> More Text", which should be valid
 				'react/jsx-curly-brace-presence': ['error', { propElementValues: 'always' }],
 				'react/jsx-fragments': ['error', 'element'],

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "linter-bundle",
-	"version": "2.16.0",
+	"version": "2.19.0",
 	"description": "Ready-to use bundle of linting tools, containing configurations for ESLint, stylelint and markdownlint.",
 	"keywords": [
 		"eslint",
@@ -40,26 +40,26 @@
 		"check-outdated": "npx --yes -- check-outdated --ignore-pre-releases"
 	},
 	"dependencies": {
-		"@typescript-eslint/eslint-plugin": "5.32.0",
-		"@typescript-eslint/parser": "5.32.0",
-		"eslint": "8.21.0",
-		"eslint-import-resolver-typescript": "3.4.0",
+		"@typescript-eslint/eslint-plugin": "5.35.1",
+		"@typescript-eslint/parser": "5.35.1",
+		"eslint": "8.23.0",
+		"eslint-import-resolver-typescript": "3.5.0",
 		"eslint-import-resolver-webpack": "0.13.2",
 		"eslint-plugin-eslint-comments": "3.2.0",
 		"eslint-plugin-functional": "4.2.2",
 		"eslint-plugin-import": "2.26.0",
-		"eslint-plugin-jest": "26.7.0",
-		"eslint-plugin-jsdoc": "39.3.4",
+		"eslint-plugin-jest": "26.9.0",
+		"eslint-plugin-jsdoc": "39.3.6",
 		"eslint-plugin-jsx-a11y": "6.6.1",
 		"eslint-plugin-node": "11.1.0",
-		"eslint-plugin-promise": "6.0.0",
-		"eslint-plugin-react": "7.30.1",
+		"eslint-plugin-promise": "6.0.1",
+		"eslint-plugin-react": "7.31.1",
 		"eslint-plugin-react-hooks": "4.6.0",
 		"eslint-plugin-unicorn": "43.0.2",
-		"markdownlint-cli": "0.32.1",
+		"markdownlint-cli": "0.32.2",
 		"micromatch": "4.0.5",
 		"postcss-scss": "4.0.4",
-		"stylelint": "14.9.1",
+		"stylelint": "14.11.0",
 		"stylelint-declaration-block-no-ignored-properties": "2.5.0",
 		"stylelint-order": "5.0.0",
 		"stylelint-scss": "4.3.0",
@@ -71,10 +71,10 @@
 		"typescript": "^4.0.0"
 	},
 	"devDependencies": {
-		"@types/eslint": "8.4.5",
+		"@types/eslint": "8.4.6",
 		"@types/micromatch": "4.0.2",
-		"@types/node": "18.6.4",
+		"@types/node": "18.7.13",
 		"stylelint-find-new-rules": "4.0.0",
-		"typescript": "4.7.4"
+		"typescript": "4.8.2"
 	}
 }

package/stylelint/index.js

@@ -68,6 +68,7 @@ module.exports = {
 		 * @see https://github.com/stylelint/stylelint/tree/master/lib/rules
 		 */
 		'alpha-value-notation': 'number', // @todo change that to 'percentage'?
+		'annotation-no-unknown': true,
 		'at-rule-allowed-list': null,
 		'at-rule-disallowed-list': null,
 		'at-rule-empty-line-before': [
@@ -197,6 +198,7 @@ module.exports = {
 		'indentation': 'tab',
 		'keyframe-block-no-duplicate-selectors': true,
 		'keyframe-declaration-no-important': true,
+		'keyframe-selector-notation': 'percentage',
 		'keyframes-name-pattern': '^[a-z]+(-[a-z]+)*\\d*$',
 		'length-zero-no-unit': true,
 		'linebreaks': 'unix',
@@ -288,7 +290,7 @@ module.exports = {
 			}
 		],
 		'selector-max-type': 6,
-		'selector-max-universal': 1,
+		'selector-max-universal': [1, { ignoreAfterCombinators: ['>', '+'] }],
 		'selector-nested-pattern': null,
 		'selector-no-qualifying-type': [true, { ignore: ['attribute', 'class'] }],
 		'selector-no-vendor-prefix': true,
@@ -952,9 +954,11 @@ module.exports = {
 			'border-right', // "border-inline-end" is new and should not be used before 2022. @see https://caniuse.com/mdn-css_properties_border-inline-end
 			'border-right-color', // "border-inline-end-color" is new and should not be used before 2022. @see https://caniuse.com/mdn-css_properties_border-inline-end-color
 
+			'margin',
 			'margin-top',
 			'margin-bottom',
 
+			'padding',
 			'padding-top',
 			'padding-bottom',
 

package/stylelint/plugins/stylelint-high-performance-animation.js

@@ -122,12 +122,12 @@ const propsThatCausePaint = [
 ];
 
 /**
- * Get blacklisted properties.
+ * Get disallowed properties.
  *
  * @param {string} ignore - Property name.
- * @returns {string[]} - Array of blacklisted properties.
+ * @returns {string[]} - Array of disallowed properties.
  */
-const getBlacklist = (ignore) => {
+const getDisallowedList = (ignore) => {
 	if (ignore === 'paint-properties') {
 		return propertiesThatCauseLayout;
 	}
@@ -146,128 +146,131 @@ const getBlacklist = (ignore) => {
  */
 const unprefixed = (property) => property.replace(/^-\w+-/u, '');
 
-module.exports = stylelint.createPlugin(
-	ruleName,
-	(actual, options) => (cssRoot, result) => {
-		const validOptions = stylelint.utils.validateOptions(
-			result,
-			ruleName,
-			{ actual },
-			{
-				actual: options,
-				possible: {
-					ignore: ['paint-properties'],
-					ignoreProperties: [isString]
-				},
-				optional: true
-			}
-		);
+/**
+ * Rule function.
+ *
+ * @param {Record<string, any>} actual - Primary options
+ * @param {Record<string, any>} options - Secondary options
+ * @returns {(root: import('postcss').Root, result: import('stylelint').PostcssResult) => Promise<void> | void} PostCSS plugin
+ */
+const ruleFunction = (actual, options) => (cssRoot, result) => {
+	const validOptions = stylelint.utils.validateOptions(
+		result,
+		ruleName,
+		{ actual },
+		{
+			actual: options,
+			possible: {
+				ignore: ['paint-properties'],
+				ignoreProperties: [isString]
+			},
+			optional: true
+		}
+	);
 
-		if (!validOptions) { return; }
+	if (!validOptions) { return; }
 
-		// @ts-expect-error -- Property 'ignore' comes from an index signature, so it must be accessed with ['ignore'].
-		const blacklist = getBlacklist(options.ignore);
-		// @ts-expect-error -- Property 'ignoreProperties' comes from an index signature, so it must be accessed with ['ignoreProperties'].
-		const ignored = options.ignoreProperties ?? [];
+	const disallowedList = getDisallowedList(options['ignore']);
+	const ignored = options['ignoreProperties'] ?? [];
 
-		cssRoot.walkDecls('transition-property', (decl) => {
-			valueParser(decl.value).walk((node) => {
-				const value = unprefixed(node.value);
+	cssRoot.walkDecls('transition-property', (decl) => {
+		valueParser(decl.value).walk((node) => {
+			const value = unprefixed(node.value);
 
-				if (
-					node.type === 'word' &&
-					!ignored.includes(value) &&
-					(blacklist.includes(value) || value === 'all')
-				) {
-					const index = declarationValueIndex(decl) + node.sourceIndex;
+			if (
+				node.type === 'word' &&
+				!ignored.includes(value) &&
+				(disallowedList.includes(value) || value === 'all')
+			) {
+				const index = declarationValueIndex(decl) + node.sourceIndex;
 
-					stylelint.utils.report({
-						ruleName,
-						result,
-						node: decl,
-						message: messages.rejected('transition', node.value),
-						index
-					});
-				}
-			});
+				stylelint.utils.report({
+					ruleName,
+					result,
+					node: decl,
+					message: messages.rejected('transition', node.value),
+					index
+				});
+			}
 		});
+	});
 
-		cssRoot.walkDecls('transition', (decl) => {
-			/** @type {{ index: number; value: string; }[]} */
-			const nodes = [];
+	cssRoot.walkDecls('transition', (decl) => {
+		/** @type {{ index: number; value: string; }[]} */
+		const nodes = [];
 
-			valueParser(decl.value).walk((node) => {
-				if (node.type === 'word' || node.type === 'function') {
-					nodes.push({
-						index: node.sourceIndex,
-						value: node.value
-					});
-				}
+		valueParser(decl.value).walk((node) => {
+			if (node.type === 'word' || node.type === 'function') {
+				nodes.push({
+					index: node.sourceIndex,
+					value: node.value
+				});
+			}
 
-				return false;
-			});
+			return false;
+		});
+
+		if (!ignored.includes('all')) {
+			const transitionProp = nodes.filter((node) => {
+				const isUnit = valueParser.unit(node.value);
+				const isTimingFunction = cssTimingFunctionsRE.test(node.value);
 
-			if (!ignored.includes('all')) {
-				const transitionProp = nodes.filter((node) => {
-					const isUnit = valueParser.unit(node.value);
-					const isTimingFunction = cssTimingFunctionsRE.test(node.value);
+				if (isUnit || isTimingFunction) {
+					return false;
+				}
 
-					if (isUnit || isTimingFunction) {
-						return false;
-					}
+				return node;
+			});
 
-					return node;
+			if (nodes.length > 0 && transitionProp.length === 0) {
+				stylelint.utils.report({
+					ruleName,
+					result,
+					node: decl,
+					message: messages.rejected('transition', 'all'),
+					index: declarationValueIndex(decl) + nodes[0].index
 				});
 
-				if (nodes.length > 0 && transitionProp.length === 0) {
-					stylelint.utils.report({
-						ruleName,
-						result,
-						node: decl,
-						message: messages.rejected('transition', 'all'),
-						index: declarationValueIndex(decl) + nodes[0].index
-					});
-
-					return;
-				}
+				return;
 			}
+		}
 
-			for (const property of nodes) {
-				const index = declarationValueIndex(decl) + property.index;
-				const value = unprefixed(property.value);
+		for (const property of nodes) {
+			const index = declarationValueIndex(decl) + property.index;
+			const value = unprefixed(property.value);
 
-				if (
-					!ignored.includes(value) &&
-					(blacklist.includes(value) || value === 'all')
-				) {
-					stylelint.utils.report({
-						ruleName,
-						result,
-						node: decl,
-						message: messages.rejected('transition', property.value),
-						index
-					});
-				}
+			if (
+				!ignored.includes(value) &&
+				(disallowedList.includes(value) || value === 'all')
+			) {
+				stylelint.utils.report({
+					ruleName,
+					result,
+					node: decl,
+					message: messages.rejected('transition', property.value),
+					index
+				});
 			}
-		});
+		}
+	});
 
-		cssRoot.walkAtRules(/^keyframes$/iu, (atRuleKeyframes) => {
-			atRuleKeyframes.walkDecls((decl) => {
-				const value = unprefixed(decl.prop);
+	cssRoot.walkAtRules(/^keyframes$/iu, (atRuleKeyframes) => {
+		atRuleKeyframes.walkDecls((decl) => {
+			const value = unprefixed(decl.prop);
 
-				if (!ignored.includes(value) && blacklist.includes(value)) {
-					stylelint.utils.report({
-						ruleName,
-						result,
-						node: decl,
-						message: messages.rejected('animation', decl.prop)
-					});
-				}
-			});
+			if (!ignored.includes(value) && disallowedList.includes(value)) {
+				stylelint.utils.report({
+					ruleName,
+					result,
+					node: decl,
+					message: messages.rejected('animation', decl.prop)
+				});
+			}
 		});
-	}
-);
+	});
+};
+
+ruleFunction.ruleName = ruleName;
+ruleFunction.messages = messages;
 
-// @ts-expect-error -- Cannot assign to 'ruleName' because it is a read-only property.
-module.exports.ruleName = ruleName;
-module.exports.messages = messages;
+module.exports = stylelint.createPlugin(ruleName, ruleFunction);