linted 15.0.0-rc.1 → 15.0.0-rc.10

package/src/defaults.ts

@@ -1,14 +1,22 @@
-import type { Scopes } from "@eslinted/core";
+import type { Scope } from "@eslinted/core";
 
 export default {
-  js: ["*.config.js"],
+  js: ["**/*.config.js"],
   ts: [
+    "**/*.config.ts",
     "src/**/*.ts",
-    "*.config.ts",
+    "types/**/*.d.ts",
   ],
   svelte: ["src/**/*.svelte"],
   html: ["src/**/*.html"],
   json: ["**/*.json"],
-  jsonc: ["tsconfig.json"],
-  yml: [".github/workflows/*.yml"],
-} satisfies Record<Scopes, string[]>;
+  jsonc: [
+    "**/*.jsonc",
+    "**/tsconfig.json",
+  ],
+  yml: [
+    "**/*.yml",
+    "**/*.yaml",
+    ".github/workflows/*.yml",
+  ],
+} as const satisfies Record<Scope, string[]>;

package/src/index.ts

@@ -3,12 +3,12 @@ import defaults from "./defaults.js";
 import parsers from "./parsers.js";
 import plugins from "./plugins.js";
 import rulesets from "./rulesets.js";
-import type { Scopes } from "@eslinted/core";
+import type { Scope } from "@eslinted/core";
 import type { Rule } from "@eslinted/core";
 
 export default function (
   includes: Partial<typeof defaults> = {},
-  overrides: Partial<Record<Scopes, Rule["rules"]>> = {},
+  overrides: Partial<Record<Scope, Rule["rules"]>> = {},
 ) {
   try {
     return core(

package/src/parsers.ts

@@ -1,4 +1,4 @@
-import type { Scopes } from "@eslinted/core";
+import type { Scope } from "@eslinted/core";
 import ts from "@typescript-eslint/parser";
 import svelte from "svelte-eslint-parser";
 import html from "@html-eslint/parser";
@@ -12,4 +12,4 @@ export default {
   json: jsonc,
   jsonc,
   yml,
-} satisfies Partial<Record<Scopes, unknown>>;
+} as const satisfies Partial<Record<Scope, unknown>>;

package/src/plugins.ts

@@ -1,4 +1,4 @@
-import type { Scopes } from "@eslinted/core";
+import type { Scope } from "@eslinted/core";
 import stylistic from "@stylistic/eslint-plugin";
 import ts from "@typescript-eslint/eslint-plugin";
 import svelte from "eslint-plugin-svelte";
@@ -6,7 +6,7 @@ import html from "@html-eslint/eslint-plugin";
 import jsonc from "eslint-plugin-jsonc";
 import yml from "eslint-plugin-yml";
 
-const Plugins = {
+export default {
   js: { "@stylistic": stylistic },
   ts: {
     "@stylistic": stylistic,
@@ -21,12 +21,4 @@ const Plugins = {
   json: { jsonc },
   jsonc: { jsonc },
   yml: { yml },
-} satisfies Record<
-  Scopes,
-  Record<
-    string,
-    { configs: unknown }
-  >
->;
-
-export default Plugins;
+} as const satisfies Record<Scope, Record<string, { configs: unknown }>>;

package/src/rulesets/rules/js/JsEnable.ts

@@ -5,8 +5,8 @@ import {
   NEVER,
   ALWAYS,
   AS_NEEDED,
+  CONSECUTIVE,
   ALL,
-  MULTI,
   BOTH,
 } from "../state.js";
 import { Enable } from "../id.js";
@@ -15,7 +15,7 @@ const JsEnable = new Rule(
   Enable,
   {
 
-    /* #region Problems */
+    // #region Problems
     // [ https://eslint.org/docs/latest/rules/#possible-problems ]
     "array-callback-return": [
       ERROR,
@@ -25,12 +25,12 @@ const JsEnable = new Rule(
         allowVoid: true,
       },
     ],
-    "constructor-super": ERROR, // tsc
+    "constructor-super": ERROR, /* tsc */
     "for-direction": ERROR,
     "getter-return": [
       ERROR,
       { allowImplicit: false },
-    ], // tsc
+    ], /* tsc */
     "no-async-promise-executor": ERROR,
     "no-await-in-loop": ERROR,
     "no-class-assign": ERROR,
@@ -39,34 +39,30 @@ const JsEnable = new Rule(
       ERROR,
       ALWAYS,
     ],
-
-    /* #endregion */
-
-    /* #region Gunner */
-    "no-const-assign": ERROR, // tsc
+    "no-const-assign": ERROR, /* tsc */
     "no-constant-binary-expression": ERROR,
     "no-constant-condition": [
       ERROR,
-      { checkLoops: true },
+      { checkLoops: ALL },
     ],
     "no-constructor-return": ERROR,
     "no-control-regex": ERROR,
     "no-debugger": ERROR,
-    "no-dupe-args": ERROR, // tsc
-    "no-dupe-class-members": ERROR, // tsc -- TSLint:off: tsc
+    "no-dupe-args": ERROR, /* tsc */
+    "no-dupe-class-members": ERROR, /* tsc -- TSLint:off: tsc */
     "no-dupe-else-if": ERROR,
-    "no-dupe-keys": ERROR, // tsc
+    "no-dupe-keys": ERROR, /* tsc */
     "no-duplicate-case": ERROR,
-    "no-duplicate-imports": OFF, // BUG: breaks separation of TS type-only imports from value imports
+    "no-duplicate-imports": OFF, /* BUG: breaks separation of TS type-only imports from value imports */
     "no-empty-character-class": ERROR,
     "no-empty-pattern": [
       ERROR,
-      { allowObjectPatternsAsParameters: true },
+      { allowObjectPatternsAsParameters: false },
     ],
     "no-ex-assign": ERROR,
-    "no-fallthrough": OFF, // BUG:
-    "no-func-assign": ERROR, // tsc
-    "no-import-assign": ERROR, // tsc (except Object.assign())
+    "no-fallthrough": OFF, /* BUG: */
+    "no-func-assign": ERROR, /* tsc */
+    "no-import-assign": ERROR, /* tsc (except Object.assign()) */
     "no-inner-declarations": [
       ERROR,
       BOTH,
@@ -85,10 +81,10 @@ const JsEnable = new Rule(
         skipJSXText: true,
       },
     ],
-    "no-loss-of-precision": ERROR, // TSLint
+    "no-loss-of-precision": ERROR, /* TSLint */
     "no-misleading-character-class": ERROR,
     "no-new-native-nonconstructor": ERROR,
-    "no-obj-calls": ERROR, // tsc
+    "no-obj-calls": ERROR, /* tsc */
     "no-promise-executor-return": [
       ERROR,
       { allowVoid: true },
@@ -99,23 +95,23 @@ const JsEnable = new Rule(
       { props: true },
     ],
     "no-self-compare": ERROR,
-    "no-setter-return": ERROR, // tsc
+    "no-setter-return": ERROR, /* tsc */
     "no-sparse-arrays": ERROR,
     "no-template-curly-in-string": ERROR,
-    "no-this-before-super": ERROR, // tsc
-    "no-undef": ERROR, // tsc
+    "no-this-before-super": ERROR, /* tsc */
+    "no-undef": ERROR, /* tsc */
     "no-unexpected-multiline": ERROR,
     "no-unmodified-loop-condition": ERROR,
-    "no-unreachable": ERROR, // tsc
+    "no-unreachable": ERROR, /* tsc */
     "no-unreachable-loop": [
       ERROR,
-      { ignore: [] }, // WhileStatement, DoWhileStatement, ForStatement, ForInStatement, ForOfStatement
+      { ignore: [] }, /* WhileStatement, DoWhileStatement, ForStatement, ForInStatement, ForOfStatement */
     ],
     "no-unsafe-finally": ERROR,
     "no-unsafe-negation": [
       ERROR,
       { enforceForOrderingRelations: true },
-    ], // tsc
+    ], /* tsc */
     "no-unsafe-optional-chaining": [
       ERROR,
       { disallowArithmeticOperators: true },
@@ -129,7 +125,7 @@ const JsEnable = new Rule(
         caughtErrors: ALL,
         ignoreRestSiblings: false,
       },
-    ], // TSLint
+    ], /* TSLint */
     "no-use-before-define": [
       ERROR,
       {
@@ -138,7 +134,7 @@ const JsEnable = new Rule(
         variables: true,
         allowNamedExports: false,
       },
-    ], // TSLint
+    ], /* TSLint */
     "no-useless-backreference": ERROR,
     "require-atomic-updates": [
       ERROR,
@@ -156,7 +152,9 @@ const JsEnable = new Rule(
       { requireStringLiterals: true },
     ],
 
-    // Suggestions
+    // #endregion
+
+    // # region Suggestions
     // [ https://eslint.org/docs/latest/rules/#suggestions ]
     "accessor-pairs": [
       ERROR,
@@ -172,58 +170,58 @@ const JsEnable = new Rule(
       { requireReturnForObjectLiteral: true },
     ],
     "block-scoped-var": ERROR,
-    camelcase: OFF, // preference
-    "capitalized-comments": OFF, // preference
-    "class-methods-use-this": OFF, // preference -- TSLint
-    complexity: OFF, // preference
+    camelcase: OFF, /* preference */
+    "capitalized-comments": OFF, /* preference */
+    "class-methods-use-this": OFF, /* preference -- TSLint */
+    complexity: OFF, /* preference */
     "consistent-return": [
       ERROR,
       { treatUndefinedAsUnspecified: false },
-    ], // tsc -- TSLint:off: tsconfig: noImplicitReturns
-    "consistent-this": [ERROR],
+    ], /* tsc -- TSLint:off: tsconfig: noImplicitReturns */
+    "consistent-this": ERROR,
     curly: [
       ERROR,
-      MULTI,
+      "multi-or-nest",
     ],
-    "default-case": OFF, // preference: don't care
+    "default-case": OFF, /* preference: don't care */
     "default-case-last": ERROR,
-    "default-param-last": ERROR, // TSLint
+    "default-param-last": ERROR, /* TSLint */
     "dot-notation": [
       ERROR,
       { allowKeywords: true },
-    ], // TSLint
+    ], /* TSLint */
     eqeqeq: [
       ERROR,
       ALWAYS,
     ],
-    "func-name-matching": OFF, // preference
-    "func-names": OFF, // preference
-    "func-style": OFF, // preference
-    "grouped-accessor-pairs": OFF, // preference -- BUG: requires adjacency, not as described in documentation
-    "guard-for-in": ERROR,
-    "id-denylist": OFF, // preference
-    "id-length": OFF, // preference
-    "id-match": OFF, // preference
+    "func-name-matching": OFF, /* preference */
+    "func-names": OFF, /* preference */
+    "func-style": OFF, /* preference */
+    "grouped-accessor-pairs": OFF, /* preference -- BUG: requires adjacency, not as described in documentation */
+    "guard-for-in": OFF, /* preference - not helpful because using for-in on non-literal objects is bad practice and this rule doesn't guard against that anyway, while adding a pointless check to known object literals */
+    "id-denylist": OFF, /* preference */
+    "id-length": OFF, /* preference */
+    "id-match": OFF, /* preference */
     "init-declarations": [
       ERROR,
       ALWAYS,
-    ], // TSLint
+    ], /* TSLint */
     "logical-assignment-operators": [
       ERROR,
       ALWAYS,
       { enforceForIfStatements: true },
     ],
-    "max-classes-per-file": OFF, // preference
-    "max-depth": OFF, // preference
-    "max-lines": OFF, // preference
-    "max-lines-per-function": OFF, // preference
-    "max-nested-callbacks": OFF, // preference
-    "max-params": OFF, // preference -- TSLint:off: preference
-    "max-statements": OFF, // preference
-    "multiline-comment-style": OFF, // preference
-    "new-cap": OFF, // preference -- breaks Scriptable
+    "max-classes-per-file": OFF, /* preference */
+    "max-depth": OFF, /* preference */
+    "max-lines": OFF, /* preference */
+    "max-lines-per-function": OFF, /* preference */
+    "max-nested-callbacks": OFF, /* preference */
+    "max-params": OFF, /* preference -- TSLint:off: preference */
+    "max-statements": OFF, /* preference */
+    "multiline-comment-style": OFF, /* preference */
+    "new-cap": OFF, /* preference -- breaks Scriptable */
     "no-alert": ERROR,
-    "no-array-constructor": ERROR, // TSLint
+    "no-array-constructor": ERROR, /* TSLint */
     "no-bitwise": [
       ERROR,
       {
@@ -233,11 +231,11 @@ const JsEnable = new Rule(
     ],
     "no-caller": ERROR,
     "no-case-declarations": ERROR,
-    "no-console": OFF, // preference -- breaks Node.js
+    "no-console": OFF, /* preference -- breaks Node.js console applications and Scriptable, and otherwise unnecessarily hampers browser test code */
     "no-continue": ERROR,
     "no-delete-var": ERROR,
     "no-div-regex": ERROR,
-    "no-else-return": OFF, // preference
+    "no-else-return": OFF, /* preference */
     "no-empty": [
       ERROR,
       { allowEmptyCatch: false },
@@ -245,7 +243,7 @@ const JsEnable = new Rule(
     "no-empty-function": [
       ERROR,
       { allow: ["constructors"] }, /**  functions, arrowFunctions, generatorFunctions, methods, generatorMethods, getters, setters, constructors, asyncFunctions, asyncMethods; TS-ONLY: private-constructors, protected-constructors, decoratedFunctions, overrideMethods  */
-    ], // TSLint
+    ], /* TSLint */
     "no-empty-static-block": ERROR,
     "no-eq-null": ERROR,
     "no-eval": [
@@ -276,36 +274,26 @@ const JsEnable = new Rule(
         allow: [], /**  "~" | "!!" | "+" | "- -" | "-" | "*"  */
       },
     ],
-    "no-implicit-globals": OFF, // investigate (breaks Scriptable? breaks Sveltekit?)
-    "no-implied-eval": ERROR, // TSLint
-    "no-inline-comments": OFF, // preference
+    "no-implicit-globals": OFF, /* investigate (breaks Scriptable? breaks Sveltekit?) */
+    "no-implied-eval": ERROR, /* TSLint */
+    "no-inline-comments": OFF, /* preference */
     "no-invalid-this": [
       ERROR,
       { capIsConstructor: false },
-    ], // TSLint:off: tsconfig: { strict, noImplicitThis }
+    ], /* TSLint:off: tsconfig: { strict, noImplicitThis } */
     "no-iterator": ERROR,
     "no-label-var": ERROR,
     "no-lone-blocks": ERROR,
-    "no-lonely-if": OFF, // preference
-    "no-loop-func": ERROR, // TSLint
-    "no-magic-numbers": [
-      OFF,
-      {
-        ignore: [],
-        ignoreArrayIndexes: true,
-        ignoreDefaultValues: true,
-        ignoreClassFieldInitialValues: true,
-        enforceConst: true,
-        detectObjects: false,
-      },
-    ], // TSLint
+    "no-lonely-if": OFF, /* preference */
+    "no-loop-func": ERROR, /* TSLint */
+    "no-magic-numbers": OFF, /* preference - breaks TypeScript number literals, even with most liberal exceptions */
     "no-multi-assign": [
       ERROR,
       { ignoreNonDeclaration: false },
     ],
     "no-multi-str": ERROR,
-    "no-negated-condition": OFF, // preference
-    "no-nested-ternary": OFF, // preference
+    "no-negated-condition": OFF, /* preference */
+    "no-nested-ternary": OFF, /* preference */
     "no-new": ERROR,
     "no-new-func": ERROR,
     "no-new-wrappers": ERROR,
@@ -329,29 +317,29 @@ const JsEnable = new Rule(
     "no-redeclare": [
       ERROR,
       { builtinGlobals: true },
-    ], // tsc -- TSLint:off: tsc (let, const, -var)
-    "no-regex-spaces": OFF, // preference
-    "no-restricted-exports": OFF, // preference
-    "no-restricted-globals": OFF, // preference
-    "no-restricted-imports": OFF, // preference -- TSLint:off: preference
-    "no-restricted-properties": OFF, // preference
-    "no-restricted-syntax": OFF, // preference
+    ], /* tsc -- TSLint:off: tsc (let, const, -var) */
+    "no-regex-spaces": OFF, /* preference */
+    "no-restricted-exports": OFF, /* preference */
+    "no-restricted-globals": OFF, /* preference */
+    "no-restricted-imports": OFF, /* preference -- TSLint:off */
+    "no-restricted-properties": OFF, /* preference */
+    "no-restricted-syntax": OFF, /* preference */
     "no-return-assign": [
       ERROR,
-      ALWAYS, // ALWAYS | "except-parens" (disallow assignments unless enclosed in parens)
+      ALWAYS, /* ALWAYS | "except-parens" (disallow assignments unless enclosed in parens) */
     ],
     "no-script-url": ERROR,
     "no-sequences": [
       ERROR,
       { allowInParentheses: true },
     ],
-    "no-shadow": OFF, // investigate -- TSLint:off: investigate
+    "no-shadow": OFF, /* investigate -- TSLint:off: investigate */
     "no-shadow-restricted-names": ERROR,
-    "no-ternary": OFF, // preference
-    "no-throw-literal": ERROR, // TSLint
+    "no-ternary": OFF, /* preference */
+    "no-throw-literal": ERROR, /* TSLint */
     "no-undef-init": ERROR,
-    "no-undefined": OFF, // investigate (breaks Scriptable? breaks Sveltekit?)
-    "no-underscore-dangle": OFF, // preference
+    "no-undefined": OFF, /* investigate (breaks Scriptable? breaks Sveltekit?) */
+    "no-underscore-dangle": OFF, /* preference */
     "no-unneeded-ternary": [
       ERROR,
       { defaultAssignment: false },
@@ -364,7 +352,7 @@ const JsEnable = new Rule(
         allowTaggedTemplates: true,
         enforceForJSX: false,
       },
-    ], // TSLint
+    ], /* TSLint */
     "no-unused-labels": ERROR,
     "no-useless-call": ERROR,
     "no-useless-catch": ERROR,
@@ -373,7 +361,7 @@ const JsEnable = new Rule(
       { enforceForClassMembers: true },
     ],
     "no-useless-concat": ERROR,
-    "no-useless-constructor": ERROR, // TSLint
+    "no-useless-constructor": ERROR, /* TSLint */
     "no-useless-escape": ERROR,
     "no-useless-rename": [
       ERROR,
@@ -389,7 +377,7 @@ const JsEnable = new Rule(
       ERROR,
       { allowAsStatement: true },
     ],
-    "no-warning-comments": OFF, // preference
+    "no-warning-comments": OFF, /* preference */
     "no-with": ERROR,
     "object-shorthand": [
       ERROR,
@@ -403,9 +391,9 @@ const JsEnable = new Rule(
     "one-var": [
       ERROR,
       {
-        "var": NEVER,
-        let: NEVER,
-        "const": NEVER,
+        "var": CONSECUTIVE,
+        let: CONSECUTIVE,
+        "const": CONSECUTIVE,
         separateRequires: true,
       },
     ],
@@ -440,7 +428,7 @@ const JsEnable = new Rule(
         },
       },
       { enforceForRenamedProperties: true },
-    ], // TSLint
+    ], /* TSLint */
     "prefer-exponentiation-operator": ERROR,
     "prefer-named-capture-group": OFF,
     "prefer-numeric-literals": ERROR,
@@ -453,7 +441,7 @@ const JsEnable = new Rule(
     "prefer-regex-literals": [
       ERROR,
       { disallowRedundantWrapping: true },
-    ], // TSLint
+    ], /* TSLint */
     "prefer-rest-params": ERROR,
     "prefer-spread": ERROR,
     "prefer-template": ERROR,
@@ -461,14 +449,14 @@ const JsEnable = new Rule(
       ERROR,
       AS_NEEDED,
     ],
-    "require-await": ERROR, // TSLint
+    "require-await": ERROR, /* TSLint */
     "require-unicode-regexp": ERROR,
     "require-yield": ERROR,
-    "sort-imports": OFF, // preference
-    "sort-keys": OFF, // preference
-    "sort-vars": OFF, // preference
-    strict: OFF, // preference
-    "symbol-description": OFF, // preference
+    "sort-imports": OFF, /* preference */
+    "sort-keys": OFF, /* preference */
+    "sort-vars": OFF, /* preference */
+    strict: OFF, /* preference */
+    "symbol-description": OFF, /* preference */
     "vars-on-top": ERROR,
     yoda: [
       ERROR,
@@ -479,10 +467,13 @@ const JsEnable = new Rule(
       },
     ],
 
+    // #endregion
+
     // Layout & Formatting
     // [ https://eslint.org/docs/latest/rules/#layout--formatting ]
-    "line-comment-position": OFF, // preference
-    "unicode-bom": OFF, // preference: don't care
+    "unicode-bom": OFF, /* preference: don't care */
+
+    // #endregion
   },
 );
 

package/src/rulesets/rules/js/StylisticEnable.ts

@@ -360,23 +360,23 @@ const StylisticEnable = new Rule(
       {
         ObjectExpression: {
           multiline: true,
-          minProperties: 2,
-          consistent: false,
+          minProperties: 3,
+          consistent: true,
         },
         ObjectPattern: {
           multiline: true,
-          minProperties: 2,
-          consistent: false,
+          minProperties: 3,
+          consistent: true,
         },
         ImportDeclaration: {
           multiline: true,
-          minProperties: 2,
-          consistent: false,
+          minProperties: 3,
+          consistent: true,
         },
         ExportDeclaration: {
           multiline: true,
-          minProperties: 2,
-          consistent: false,
+          minProperties: 3,
+          consistent: true,
         },
       },
     ],
@@ -390,7 +390,7 @@ const StylisticEnable = new Rule(
     ],
     "@stylistic/object-property-newline": [
       ERROR,
-      { allowAllPropertiesOnSameLine: false },
+      { allowAllPropertiesOnSameLine: true },
     ],
     "@stylistic/one-var-declaration-per-line": [
       ERROR,
@@ -399,13 +399,7 @@ const StylisticEnable = new Rule(
     "@stylistic/operator-linebreak": [
       ERROR,
       BEFORE,
-      {
-        overrides: {
-          "=": AFTER,
-          "?": BEFORE,
-          ":": BEFORE,
-        },
-      },
+      { overrides: { "=": AFTER } },
     ],
     "@stylistic/padded-blocks": [
       ERROR,
@@ -686,8 +680,8 @@ const StylisticEnable = new Rule(
     "@stylistic/yield-star-spacing": [
       ERROR,
       {
-        before: true,
-        after: false,
+        before: false,
+        after: true,
       },
     ],
   },

package/src/rulesets/rules/state.ts

@@ -6,6 +6,7 @@ const ALWAYS = "always";
 const ALWAYS_MULTILINE = "always-multiline";
 const MULTILINE = "multiline";
 const CONSISTENT = "consistent";
+const CONSECUTIVE = "consecutive";
 const AS_NEEDED = "as-needed";
 const STRICT = "strict";
 const ANY = "any";
@@ -34,6 +35,7 @@ export {
   ALWAYS_MULTILINE,
   MULTILINE,
   CONSISTENT,
+  CONSECUTIVE,
   AS_NEEDED,
   STRICT,
   ANY,

package/src/rulesets.ts

@@ -1,3 +1,5 @@
+import type { Scope } from "@eslinted/core";
+import type { Ruleset } from "@eslinted/core";
 import JsRuleset from "./rulesets/JsRuleset.js";
 import TsRuleset from "./rulesets/TsRuleset.js";
 import SvelteRuleset from "./rulesets/SvelteRuleset.js";
@@ -6,7 +8,7 @@ import JsonRuleset from "./rulesets/JsonRuleset.js";
 import JsoncRuleset from "./rulesets/JsoncRuleset.js";
 import YmlRuleset from "./rulesets/YmlRuleset.js";
 
-const rulesets = {
+export default {
   js: JsRuleset,
   ts: TsRuleset,
   svelte: SvelteRuleset,
@@ -14,6 +16,4 @@ const rulesets = {
   json: JsonRuleset,
   jsonc: JsoncRuleset,
   yml: YmlRuleset,
-} as const;
-
-export default rulesets;
+} as const satisfies { [S in Scope]: Ruleset<S> };