lint-suite 1.3.2 → 1.3.8

package/LICENSE

@@ -1,21 +1,21 @@
-MIT License
-
-Copyright (c) 2025 Art 
-
-Permission is hereby granted, free of charge, to any person obtaining a copy
-of this software and associated documentation files (the "Software"), to deal
-in the Software without restriction, including without limitation the rights
-to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
-copies of the Software, and to permit persons to whom the Software is
-furnished to do so, subject to the following conditions:
-
-The above copyright notice and this permission notice shall be included in all
-copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
-IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
-FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
-AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
-LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
-OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
-SOFTWARE.
+MIT License
+
+Copyright (c) 2025 Art 
+
+Permission is hereby granted, free of charge, to any person obtaining a copy
+of this software and associated documentation files (the "Software"), to deal
+in the Software without restriction, including without limitation the rights
+to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
+copies of the Software, and to permit persons to whom the Software is
+furnished to do so, subject to the following conditions:
+
+The above copyright notice and this permission notice shall be included in all
+copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.

package/README.md

@@ -1,167 +1,167 @@
-# Lint Suite
-
-A comprehensive collection of ESLint Flat configurations for modern web applications.
-
-## Features
-
-- **TypeScript Linting**: Strict typing rules, v8 type-safety replacements, consistent imports, and code organization
-- **Angular Support**: Component best practices (including Signals), Angular 21+ template rules, and modern control flow
-- **RxJS Guidelines**: Observable patterns, Finnish notation, subject encapsulation, and operator safety
-- **Code Style**: Formatting rules, line limits, and structural consistency
-- **Accessibility**: ARIA validation, keyboard events, and semantic HTML
-- **Testing**: Jest, Vitest, and Playwright configurations with best-practice rules
-- **Prettier**: Automatic disabling of formatting rules that conflict with Prettier
-- **Architecture**: Module boundary enforcement with `eslint-plugin-boundaries`
-- **Additional Support**: JSON (with comment support for tsconfig), Storybook CSF enforcement
-
-## Installation
-
-```bash
-pnpm add -D lint-suite
-```
-
-## Dependencies
-
-```bash
-pnpm add -D eslint typescript-eslint eslint-config-prettier
-```
-
-## Usage
-
-Create an `eslint.config.mjs` file in your project root:
-
-```js
-import { recommended } from 'lint-suite';
-
-export default [...recommended];
-```
-
-Or selectively include configurations:
-
-```js
-import { base, javascript, typescript, prettier } from 'lint-suite';
-
-export default [
-  ...base,
-  ...javascript,
-  ...typescript,
-  ...prettier // Must be last to disable conflicting formatting rules
-];
-```
-
-## Available Configurations
-
-| Configuration       | Description                                              |
-| ------------------- | -------------------------------------------------------- |
-| `base`              | Core JavaScript rules, formatting, and complexity limits |
-| `javascript`        | JavaScript-specific rules via `@nx/eslint-plugin`        |
-| `typescript`        | TypeScript strict typing, imports, and naming conventions |
-| `angular`           | Angular component best practices with Signal support     |
-| `angularTemplate`   | HTML template rules with accessibility and performance   |
-| `rxjs`              | Observable patterns, operator safety, and subscriptions  |
-| `jest`              | Jest testing best practices and matchers                 |
-| `vitest`            | Vitest testing rules and matcher improvements            |
-| `playwright`        | Playwright e2e locator and matcher best practices        |
-| `json`              | JSON linting with comment support for tsconfig/vscode    |
-| `storybook`         | Storybook CSF enforcement                                |
-| `boundaries`        | Module boundary rules (feature, data-access, ui, etc.)   |
-| `prettier`          | Disables rules that conflict with Prettier (use last)    |
-| **`recommended`**   | **All of the above combined in the correct order**       |
-
-## Customization
-
-You can override any rules by adding a `rules` section to your ESLint config:
-
-```js
-import { typescript, prettier } from 'lint-suite';
-
-export default [
-  ...typescript,
-  {
-    rules: {
-      '@typescript-eslint/explicit-function-return-type': 'off'
-    }
-  },
-  ...prettier
-];
-```
-
-## Available Rules (you can add more as you prefer)
-
-### nx/eslint-plugin
-
-- `@nx/enforce-module-boundaries`: Enforces module boundary restrictions
-- `@nx/dependency-checks`: Validates dependencies in workspace projects
-- ...
-
-### eslint-plugin-jest
-
-- `jest/consistent-test-it`: Enforces consistent test function usage (`it`)
-- `jest/prefer-comparison-matcher`: Enforces comparison matchers
-- `jest/prefer-hooks-on-top`: Ensures hooks are at the top of describe blocks
-- `jest/no-conditional-in-test`: Warns against conditionals in tests
-- ...
-
-### @vitest/eslint-plugin
-
-- `vitest/max-nested-describe`: Limits describe nesting depth
-- `vitest/prefer-to-be`: Enforces `toBe` matcher usage
-- `vitest/no-conditional-in-test`: Disallows conditionals in tests
-- ...
-
-### eslint-plugin-playwright
-
-- `playwright/prefer-locator`: Enforces modern locator API
-- `playwright/prefer-native-locators`: Prefers native locator methods
-- `playwright/prefer-to-be`: Enforces `toBe` matcher usage
-- ...
-
-### eslint-plugin-json
-
-- `json/json`: Validates JSON syntax
-- `json/sort-package-json`: Enforces consistent ordering in package.json
-- ...
-
-### @smarttools/eslint-plugin-rxjs
-
-- `@rxjs/finnish`: Enforces Finnish notation for observables
-- `@rxjs/no-exposed-subjects`: Enforces subject encapsulation
-- `@rxjs/no-cyclic-action`: Prevents infinite loops in NgRx effects
-- `@rxjs/no-unsafe-takeuntil`: Ensures proper usage of takeUntil operator
-- ...
-
-### eslint-plugin-storybook
-
-- `storybook/csf-component`: Enforces component property in stories
-- `storybook/no-stories-of`: Prevents deprecated `storiesOf` API
-- ...
-
-### eslint-plugin-import-x
-
-- `import-x/no-cycle`: Detects circular dependencies
-- `import-x/no-self-import`: Prevents modules importing themselves
-- `import-x/order`: Enforces a consistent order of import statements
-- `import-x/consistent-type-specifier-style`: Consistent type import style
-- ...
-
-### @stylistic/eslint-plugin
-
-- `@stylistic/max-len`: Enforces maximum line length
-- `@stylistic/indent`: Enforces consistent indentation
-- `@stylistic/quotes`: Enforces consistent quote style
-- ...
-
-### eslint-config-prettier
-
-- Automatically disables all ESLint rules that conflict with Prettier
-- Must be the last configuration in the array
-
-## Contributing
-
-See [CONTRIBUTING.md](./CONTRIBUTING.md) for contribution guidelines.
-See [CHANGELOG.md](./CHANGELOG.md) for version history.
-See [RELEASE_NOTES.md](./RELEASE_NOTES.md) for detailed release notes.
-
-## License
-
-MIT
+# Lint Suite
+
+A comprehensive collection of ESLint Flat configurations for modern web applications.
+
+## Features
+
+- **TypeScript Linting**: Strict typing rules, v8 type-safety replacements, consistent imports, and code organization
+- **Angular Support**: Component best practices (including Signals), Angular 21+ template rules, and modern control flow
+- **RxJS Guidelines**: Observable patterns, Finnish notation, subject encapsulation, and operator safety
+- **Code Style**: Formatting rules, line limits, and structural consistency
+- **Accessibility**: ARIA validation, keyboard events, and semantic HTML
+- **Testing**: Jest, Vitest, and Playwright configurations with best-practice rules
+- **Prettier**: Automatic disabling of formatting rules that conflict with Prettier
+- **Architecture**: Module boundary enforcement with `eslint-plugin-boundaries`
+- **Additional Support**: JSON (with comment support for tsconfig), Storybook CSF enforcement
+
+## Installation
+
+```bash
+pnpm add -D lint-suite
+```
+
+## Dependencies
+
+```bash
+pnpm add -D eslint typescript-eslint eslint-config-prettier
+```
+
+## Usage
+
+Create an `eslint.config.mjs` file in your project root:
+
+```js
+import { recommended } from 'lint-suite';
+
+export default [...recommended];
+```
+
+Or selectively include configurations:
+
+```js
+import { base, javascript, typescript, prettier } from 'lint-suite';
+
+export default [
+  ...base,
+  ...javascript,
+  ...typescript,
+  ...prettier // Must be last to disable conflicting formatting rules
+];
+```
+
+## Available Configurations
+
+| Configuration       | Description                                              |
+| ------------------- | -------------------------------------------------------- |
+| `base`              | Core JavaScript rules, formatting, and complexity limits |
+| `javascript`        | JavaScript-specific rules via `@nx/eslint-plugin`        |
+| `typescript`        | TypeScript strict typing, imports, and naming conventions |
+| `angular`           | Angular component best practices with Signal support     |
+| `angularTemplate`   | HTML template rules with accessibility and performance   |
+| `rxjs`              | Observable patterns, operator safety, and subscriptions  |
+| `jest`              | Jest testing best practices and matchers                 |
+| `vitest`            | Vitest testing rules and matcher improvements            |
+| `playwright`        | Playwright e2e locator and matcher best practices        |
+| `json`              | JSON linting with comment support for tsconfig/vscode    |
+| `storybook`         | Storybook CSF enforcement                                |
+| `boundaries`        | Module boundary rules (feature, data-access, ui, etc.)   |
+| `prettier`          | Disables rules that conflict with Prettier (use last)    |
+| **`recommended`**   | **All of the above combined in the correct order**       |
+
+## Customization
+
+You can override any rules by adding a `rules` section to your ESLint config:
+
+```js
+import { typescript, prettier } from 'lint-suite';
+
+export default [
+  ...typescript,
+  {
+    rules: {
+      '@typescript-eslint/explicit-function-return-type': 'off'
+    }
+  },
+  ...prettier
+];
+```
+
+## Available Rules (you can add more as you prefer)
+
+### nx/eslint-plugin
+
+- `@nx/enforce-module-boundaries`: Enforces module boundary restrictions
+- `@nx/dependency-checks`: Validates dependencies in workspace projects
+- ...
+
+### eslint-plugin-jest
+
+- `jest/consistent-test-it`: Enforces consistent test function usage (`it`)
+- `jest/prefer-comparison-matcher`: Enforces comparison matchers
+- `jest/prefer-hooks-on-top`: Ensures hooks are at the top of describe blocks
+- `jest/no-conditional-in-test`: Warns against conditionals in tests
+- ...
+
+### @vitest/eslint-plugin
+
+- `vitest/max-nested-describe`: Limits describe nesting depth
+- `vitest/prefer-to-be`: Enforces `toBe` matcher usage
+- `vitest/no-conditional-in-test`: Disallows conditionals in tests
+- ...
+
+### eslint-plugin-playwright
+
+- `playwright/prefer-locator`: Enforces modern locator API
+- `playwright/prefer-native-locators`: Prefers native locator methods
+- `playwright/prefer-to-be`: Enforces `toBe` matcher usage
+- ...
+
+### eslint-plugin-json
+
+- `json/json`: Validates JSON syntax
+- `json/sort-package-json`: Enforces consistent ordering in package.json
+- ...
+
+### @smarttools/eslint-plugin-rxjs
+
+- `@rxjs/finnish`: Enforces Finnish notation for observables
+- `@rxjs/no-exposed-subjects`: Enforces subject encapsulation
+- `@rxjs/no-cyclic-action`: Prevents infinite loops in NgRx effects
+- `@rxjs/no-unsafe-takeuntil`: Ensures proper usage of takeUntil operator
+- ...
+
+### eslint-plugin-storybook
+
+- `storybook/csf-component`: Enforces component property in stories
+- `storybook/no-stories-of`: Prevents deprecated `storiesOf` API
+- ...
+
+### eslint-plugin-import-x
+
+- `import-x/no-cycle`: Detects circular dependencies
+- `import-x/no-self-import`: Prevents modules importing themselves
+- `import-x/order`: Enforces a consistent order of import statements
+- `import-x/consistent-type-specifier-style`: Consistent type import style
+- ...
+
+### @stylistic/eslint-plugin
+
+- `@stylistic/max-len`: Enforces maximum line length
+- `@stylistic/indent`: Enforces consistent indentation
+- `@stylistic/quotes`: Enforces consistent quote style
+- ...
+
+### eslint-config-prettier
+
+- Automatically disables all ESLint rules that conflict with Prettier
+- Must be the last configuration in the array
+
+## Contributing
+
+See [CONTRIBUTING.md](./CONTRIBUTING.md) for contribution guidelines.
+See [CHANGELOG.md](./CHANGELOG.md) for version history.
+See [RELEASE_NOTES.md](./RELEASE_NOTES.md) for detailed release notes.
+
+## License
+
+MIT

package/index.cjs

@@ -91,6 +91,10 @@ var angularTemplate = (0, import_config.defineConfig)([
       // v21.2.0: Prefer [class] over ngClass
       "@angular-eslint/template/prefer-static-string-properties": "error",
       // Reduce change detection
+      "@angular-eslint/template/no-non-null-assertion": "error",
+      // Forbid `!` assertions in templates
+      "@angular-eslint/template/no-inline-styles": "error",
+      // Forbid inline style="..." attributes
       "@angular-eslint/template/conditional-complexity": [
         "warn",
         { maxComplexity: 5 }
@@ -151,8 +155,26 @@ var angular = (0, import_config2.defineConfig)([
       // Prevent accidental reassignment
       "@angular-eslint/prefer-output-emitter-ref": "warn",
       // Modern output() function over @Output()
-      "@angular-eslint/sort-lifecycle-methods": "warn"
+      "@angular-eslint/sort-lifecycle-methods": "warn",
       // Consistent lifecycle method ordering
+      "@angular-eslint/computed-must-return": "error",
+      // Catch silent computed() bugs missing a return
+      "@angular-eslint/no-conflicting-lifecycle": "error",
+      // Block incompatible hook combinations (OnChanges + DoCheck)
+      "@angular-eslint/no-duplicates-in-metadata-arrays": "error",
+      // Catch duplicate imports/providers in @Component/@NgModule
+      "@angular-eslint/no-lifecycle-call": "error",
+      // Forbid manual this.ngOnInit() calls
+      "@angular-eslint/require-lifecycle-on-prototype": "error",
+      // Lifecycle hooks must be methods, not arrow-fn fields
+      "@angular-eslint/relative-url-prefix": "error",
+      // Require ./ in templateUrl/styleUrl for portability
+      "@angular-eslint/use-component-selector": "error",
+      // All components must declare a selector
+      "@angular-eslint/no-developer-preview": "error",
+      // Block APIs marked @developerPreview (no breaking-change policy)
+      "@angular-eslint/no-experimental": "error"
+      // Block APIs marked @experimental
     }
   }
 ]);
@@ -631,12 +653,12 @@ var explicit_accessibility_default = createRule({
         }
       }
       context.report({
-        node: reportNode,
+        node: reportNode ?? node,
         messageId: "missingAccessibility",
         data: { name },
         fix(fixer) {
-          let tokenToInsertBefore = null;
           let insertText = `${defaultAccessibility} `;
+          let tokenToInsertBefore;
           if (node.decorators.length > 0) {
             const lastDecorator = node.decorators[node.decorators.length - 1];
             tokenToInsertBefore = sourceCode.getTokenAfter(lastDecorator);
@@ -775,7 +797,10 @@ var typescript = (0, import_config10.defineConfig)([
       // Prevent confusing void usage
       "@typescript-eslint/no-dynamic-delete": "error",
       // Use Map instead of delete obj[key]
-      "@typescript-eslint/no-extraneous-class": ["error", { allowWithDecorator: true }],
+      "@typescript-eslint/no-extraneous-class": [
+        "error",
+        { allowWithDecorator: true }
+      ],
       // Allow Angular classes
       "@typescript-eslint/no-invalid-void-type": "error",
       // Restrict void to return types
@@ -911,8 +936,7 @@ var typescript = (0, import_config10.defineConfig)([
     settings: {
       "import-x/resolver-next": [
         (0, import_eslint_import_resolver_typescript.createTypeScriptImportResolver)({
-          alwaysTryTypes: true,
-          project: "tsconfig.base.json"
+          alwaysTryTypes: true
         })
       ]
     }