lint-suite 1.2.3 → 1.3.1

package/index.js

@@ -30,6 +30,23 @@ var angularTemplate = defineConfig([
       "@angular-eslint/template/no-nested-tags": "error",
       "@angular-eslint/template/use-track-by-function": "error",
       "@angular-eslint/template/label-has-associated-control": "error",
+      "@angular-eslint/template/prefer-at-else": "error",
+      // v21: @if/@else syntax
+      "@angular-eslint/template/prefer-at-empty": "error",
+      // v21: @for/@empty syntax
+      "@angular-eslint/template/prefer-contextual-for-variables": "error",
+      // v21: Use $index, $first, etc.
+      "@angular-eslint/template/no-empty-control-flow": "error",
+      // v21: Catch incomplete refactoring
+      "@angular-eslint/template/prefer-class-binding": "error",
+      // v21.2.0: Prefer [class] over ngClass
+      "@angular-eslint/template/prefer-static-string-properties": "error",
+      // Reduce change detection
+      "@angular-eslint/template/conditional-complexity": [
+        "warn",
+        { maxComplexity: 5 }
+      ],
+      // Template readability
       "@angular-eslint/template/attributes-order": [
         "error",
         {
@@ -76,7 +93,17 @@ var angular = defineConfig2([
       "@angular-eslint/use-injectable-provided-in": "error",
       "@angular-eslint/prefer-signal-model": "error",
       "@angular-eslint/no-uncalled-signals": "error",
-      "@angular-eslint/prefer-host-metadata-property": "error"
+      "@angular-eslint/prefer-host-metadata-property": "error",
+      "@angular-eslint/no-implicit-take-until-destroyed": "error",
+      // v21.2.0: Enforce explicit DestroyRef
+      "@angular-eslint/no-async-lifecycle-method": "error",
+      // Prevent async lifecycle hooks
+      "@angular-eslint/prefer-output-readonly": "warn",
+      // Prevent accidental reassignment
+      "@angular-eslint/prefer-output-emitter-ref": "warn",
+      // Modern output() function over @Output()
+      "@angular-eslint/sort-lifecycle-methods": "warn"
+      // Consistent lifecycle method ordering
     }
   }
 ]);
@@ -139,7 +166,10 @@ var base = defineConfig3([
       "no-useless-concat": "error",
       "prefer-template": "error",
       "no-nested-ternary": "error",
-      "no-return-await": "error",
+      "no-useless-assignment": "error",
+      // NEW: Catch unused assignments (ESLint v9)
+      "no-object-constructor": "error",
+      // Disallow new Object() without arguments
       "no-else-return": ["error", { allowElseIf: false }],
       // Prefer early returns
       "no-multi-assign": "error",
@@ -321,9 +351,29 @@ import { defineConfig as defineConfig5 } from "eslint/config";
 var jest = defineConfig5([
   {
     files: ["**/*.spec.ts", "**/*.spec.js"],
-    extends: [jestEslint.configs["flat/all"]],
+    extends: [jestEslint.configs["flat/recommended"]],
     rules: {
-      "jest/no-done-callback": "off"
+      "jest/no-done-callback": "off",
+      // Elevated from recommended defaults
+      "jest/no-focused-tests": "error",
+      "jest/no-identical-title": "error",
+      "jest/valid-expect": "error",
+      // Style rules (selective additions from flat/style)
+      "jest/prefer-to-be": "warn",
+      "jest/prefer-to-contain": "warn",
+      "jest/prefer-to-have-length": "warn",
+      // Best practice additions
+      "jest/consistent-test-it": ["error", { fn: "it" }],
+      "jest/prefer-comparison-matcher": "error",
+      "jest/prefer-equality-matcher": "error",
+      "jest/prefer-hooks-on-top": "error",
+      "jest/prefer-spy-on": "error",
+      "jest/prefer-strict-equal": "warn",
+      "jest/prefer-mock-promise-shorthand": "error",
+      "jest/no-conditional-in-test": "warn",
+      "jest/no-duplicate-hooks": "error",
+      "jest/no-test-return-statement": "error",
+      "jest/require-to-throw-message": "warn"
     }
   }
 ]);
@@ -335,13 +385,22 @@ var json = defineConfig6([
   {
     files: ["**/*.json"],
     extends: [jsonEslint.configs.recommended]
+  },
+  {
+    files: ["**/tsconfig*.json", "**/.vscode/*.json"],
+    extends: [jsonEslint.configs["recommended-with-comments"]]
   }
 ]);
 
+// packages/lint-suite/src/lib/prettier.ts
+import eslintConfigPrettier from "eslint-config-prettier";
+import { defineConfig as defineConfig7 } from "eslint/config";
+var prettier = defineConfig7([eslintConfigPrettier]);
+
 // packages/lint-suite/src/lib/rxjs.ts
 import rxjsEslint from "@smarttools/eslint-plugin-rxjs";
-import { defineConfig as defineConfig7 } from "eslint/config";
-var rxjs = defineConfig7([
+import { defineConfig as defineConfig8 } from "eslint/config";
+var rxjs = defineConfig8([
   {
     files: [
       "**/*.js",
@@ -397,25 +456,38 @@ var rxjs = defineConfig7([
       "rxjs/no-unsafe-first": "error",
       "rxjs/no-topromise": "error",
       "rxjs/throw-error": "error",
-      "rxjs/no-async-subscribe": "off"
+      "rxjs/no-async-subscribe": "off",
+      "rxjs/no-exposed-subjects": "error",
+      // Enforce subject encapsulation
+      "rxjs/no-cyclic-action": "error",
+      // Prevent infinite loops in NgRx effects
+      "rxjs/no-subscribe-handlers": "warn"
+      // Prefer observer objects (complements prefer-observer)
     }
   },
   {
     files: ["**/*.spec.ts", "**/*.test.ts", "**/*.spec.js", "**/*.test.js"],
     rules: {
-      "rxjs/no-ignored-subscription": "off"
+      "rxjs/no-ignored-subscription": "off",
+      "rxjs/no-subscribe-handlers": "off"
     }
   }
 ]);
 
 // packages/lint-suite/src/lib/storybook.ts
 import storybookEslint from "eslint-plugin-storybook";
-import { defineConfig as defineConfig8 } from "eslint/config";
-var storybook = defineConfig8([
+import { defineConfig as defineConfig9 } from "eslint/config";
+var storybook = defineConfig9([
   {
     ignores: ["!.storybook"],
     files: ["**/*.stories.ts"],
-    extends: [storybookEslint.configs["flat/recommended"]]
+    extends: [storybookEslint.configs["flat/recommended"]],
+    rules: {
+      "storybook/csf-component": "warn",
+      // Ensure component property is set
+      "storybook/no-stories-of": "error"
+      // Prevent deprecated storiesOf API
+    }
   }
 ]);
 
@@ -423,7 +495,7 @@ var storybook = defineConfig8([
 import { configs as configs5 } from "@nx/eslint-plugin";
 import { createTypeScriptImportResolver } from "eslint-import-resolver-typescript";
 import importPluginX2 from "eslint-plugin-import-x";
-import { defineConfig as defineConfig9 } from "eslint/config";
+import { defineConfig as defineConfig10 } from "eslint/config";
 
 // packages/lint-suite/src/lib/rules/explicit-accessibility.ts
 import { ESLintUtils, TSESTree } from "@typescript-eslint/utils";
@@ -564,7 +636,7 @@ var localTypescriptRules = {
     "explicit-accessibility": explicit_accessibility_default
   }
 };
-var typescript = defineConfig9([
+var typescript = defineConfig10([
   // NOTE: Checks for 'prettier' and 'eslint-plugin-prettier'
   {
     files: ["**/*.ts", "**/*.tsx", "**/*.cts", "**/*.mts"],
@@ -590,6 +662,13 @@ var typescript = defineConfig9([
       "@typescript-eslint/no-unsafe-member-access": "error",
       "@typescript-eslint/no-unsafe-return": "error",
       "@typescript-eslint/no-unsafe-argument": "error",
+      // New v8 type-safety rules (replacements for deprecated ban-types)
+      "@typescript-eslint/no-empty-object-type": "error",
+      // Bans confusing {} type
+      "@typescript-eslint/no-unsafe-function-type": "error",
+      // Bans Function type
+      "@typescript-eslint/no-wrapper-object-types": "error",
+      // Bans Number, String, Boolean wrappers
       // B. Explicit Annotations (partially covered, explicit module boundaries is key)
       "@typescript-eslint/explicit-module-boundary-types": "error",
       // Consider enabling if maximum explicitness is desired, even if verbose:
@@ -610,8 +689,14 @@ var typescript = defineConfig9([
       // E. Best Practices & Potential Errors (Some covered by presets, fine-tuning here)
       "@typescript-eslint/no-inferrable-types": "warn",
       // Keep as warn or disable if inference is preferred
-      "@typescript-eslint/no-var-requires": "error",
-      // Use ES modules
+      "@typescript-eslint/no-require-imports": "error",
+      // Use ES modules (replaces deprecated no-var-requires)
+      "@typescript-eslint/only-throw-error": "error",
+      // Replaces deprecated no-throw-literal
+      "@typescript-eslint/no-array-delete": "error",
+      // Prevents delete arr[0]
+      "@typescript-eslint/return-await": ["error", "in-try-catch"],
+      // Better stack traces in try/catch
       "@typescript-eslint/require-await": "error",
       "@typescript-eslint/restrict-template-expressions": [
         "error",
@@ -631,6 +716,32 @@ var typescript = defineConfig9([
       "@typescript-eslint/no-useless-constructor": "error",
       "@typescript-eslint/dot-notation": ["error", { allowKeywords: true }],
       // Prefer dot notation where possible
+      // Strict type-checked rules
+      "@typescript-eslint/no-unnecessary-condition": "error",
+      // Catches always-true/false conditions
+      "@typescript-eslint/no-confusing-void-expression": "error",
+      // Prevent confusing void usage
+      "@typescript-eslint/no-dynamic-delete": "error",
+      // Use Map instead of delete obj[key]
+      "@typescript-eslint/no-extraneous-class": ["error", { allowWithDecorator: true }],
+      // Allow Angular classes
+      "@typescript-eslint/no-invalid-void-type": "error",
+      // Restrict void to return types
+      "@typescript-eslint/unified-signatures": "error",
+      // Merge overloads where possible
+      "@typescript-eslint/no-non-null-asserted-nullish-coalescing": "error",
+      // Forbids foo! ?? bar
+      // Stylistic type-checked rules
+      "@typescript-eslint/prefer-find": "error",
+      // Use find() instead of filter()[0]
+      "@typescript-eslint/prefer-for-of": "error",
+      // Modern iteration
+      "@typescript-eslint/prefer-includes": "error",
+      // indexOf() → includes()
+      "@typescript-eslint/prefer-string-starts-ends-with": "error",
+      // Modern string methods
+      "@typescript-eslint/prefer-regexp-exec": "error",
+      // Better regex performance
       // F. Consistency & Style (Some covered by stylistic-type-checked)
       "@typescript-eslint/consistent-type-assertions": [
         "error",
@@ -732,10 +843,18 @@ var typescript = defineConfig9([
       "import-x/no-unresolved": "error",
       "import-x/no-duplicates": "error",
       "import-x/prefer-default-export": "off",
-      "import-x/no-useless-path-segments": "error",
+      "import-x/no-useless-path-segments": ["error", { noUselessIndex: true }],
       "import-x/newline-after-import": "error",
       "import-x/first": "error",
-      "import-x/no-mutable-exports": "error"
+      "import-x/no-mutable-exports": "error",
+      "import-x/no-self-import": "error",
+      // Prevents modules importing themselves
+      "import-x/no-cycle": ["error", { maxDepth: 2, ignoreExternal: true }],
+      // Prevents circular dependencies
+      "import-x/consistent-type-specifier-style": ["error", "prefer-top-level"],
+      // Consistent type imports
+      "import-x/no-anonymous-default-export": "error"
+      // Improve code searchability
     },
     settings: {
       "import-x/resolver-next": [
@@ -760,7 +879,8 @@ var typescript = defineConfig9([
   {
     files: ["**/*.action.ts"],
     rules: {
-      "@typescript-eslint/no-namespace": "off"
+      "@typescript-eslint/no-namespace": "off",
+      "@typescript-eslint/no-extraneous-class": "off"
     }
   },
   {
@@ -789,38 +909,62 @@ var typescript = defineConfig9([
 
 // packages/lint-suite/src/lib/vitest.ts
 import vitestEslint from "@vitest/eslint-plugin";
-import { defineConfig as defineConfig10 } from "eslint/config";
+import { defineConfig as defineConfig11 } from "eslint/config";
 var vitestPlugin = {
   vitest: vitestEslint
 };
-var vitest = defineConfig10([
+var vitest = defineConfig11([
   {
     files: ["**/*.spec.ts", "**/*.spec.js", "**/*.test.ts", "**/*.test.js"],
     plugins: vitestPlugin,
     rules: {
       ...vitestEslint.configs.recommended.rules,
-      "vitest/max-nested-describe": ["error", { max: 3 }]
+      "vitest/max-nested-describe": ["error", { max: 3 }],
+      // Matcher improvements
+      "vitest/prefer-to-be": "error",
+      "vitest/prefer-to-contain": "error",
+      "vitest/prefer-to-have-length": "error",
+      "vitest/prefer-comparison-matcher": "error",
+      "vitest/prefer-strict-equal": "warn",
+      // Test quality
+      "vitest/prefer-spy-on": "error",
+      "vitest/prefer-hooks-on-top": "error",
+      "vitest/prefer-each": "warn",
+      "vitest/no-test-return-statement": "error",
+      "vitest/prefer-mock-promise-shorthand": "error"
     }
   }
 ]);
 
 // packages/lint-suite/src/lib/playwright.ts
 import playwrightEslint from "eslint-plugin-playwright";
-import { defineConfig as defineConfig11 } from "eslint/config";
-var playwright = defineConfig11([
+import { defineConfig as defineConfig12 } from "eslint/config";
+var playwright = defineConfig12([
   {
     ...playwrightEslint.configs["flat/recommended"],
     files: ["**/*.e2e.ts", "**/*.e2e.js"],
     rules: {
-      ...playwrightEslint.configs["flat/recommended"].rules
+      ...playwrightEslint.configs["flat/recommended"].rules,
+      // Locator best practices
+      "playwright/prefer-locator": "error",
+      "playwright/prefer-native-locators": "error",
+      "playwright/no-nth-methods": "warn",
+      // Matcher improvements
+      "playwright/prefer-to-be": "error",
+      "playwright/prefer-to-have-count": "error",
+      "playwright/prefer-to-have-length": "error",
+      "playwright/prefer-comparison-matcher": "error",
+      // Test structure
+      "playwright/prefer-hooks-on-top": "error",
+      "playwright/require-top-level-describe": "warn"
     }
   }
 ]);
 
 // packages/lint-suite/src/lib/boundaries.ts
 import boundariesPlugin from "eslint-plugin-boundaries";
-import { defineConfig as defineConfig12 } from "eslint/config";
-var boundaries = defineConfig12([
+import { defineConfig as defineConfig13 } from "eslint/config";
+var boundaries = defineConfig13([
   {
     files: [
       "**/*.js",
@@ -924,7 +1068,9 @@ var recommended = [
   ...boundaries,
   ...storybook,
   ...vitest,
-  ...playwright
+  ...playwright,
+  ...prettier
+  // Must be last to disable formatting rules that conflict with Prettier
 ];
 export {
   angular,
@@ -935,6 +1081,7 @@ export {
   jest,
   json,
   playwright,
+  prettier,
   recommended,
   rxjs,
   storybook,