lint-suite 1.0.5 → 1.0.7

package/README.md

@@ -1,121 +1,135 @@
-# Lint Suite
-
-A comprehensive collection of ESLint Flat configurations for modern web applications.
-
-## Features
-
-- **TypeScript Linting**: Strict typing rules, consistent imports, and code organization
-- **Angular Support**: Component best practices and template accessibility rules
-- **RxJS Guidelines**: Observable patterns, Finnish notation, and operator safety
-- **Code Style**: Formatting rules, line limits, and structural consistency
-- **Accessibility**: ARIA validation, keyboard events, and semantic HTML
-- **Testing**: Jest configurations with appropriate relaxations for test files
-- **Additional Support**: JSON, Storybook, and more
-
-## Installation
-
-```bash
-npm install --save-dev lint-suite
-```
-
-## Usage
-
-Create a `.eslintrc.config.mjs` file in your project root:
-
-```js
-import { base, javascript, typescript } from 'lint-suite';
-
-export default [
-  ...base,
-  ...javascript,
-  ...typescript,
-  // Rest of the required configurations
-];
-```
-
-You can selectively include configurations you need.
-
-## Available Configurations
-
-- `base`: Core JavaScript rules and formatting
-- `typescript`: TypeScript-specific rules
-- `angular`: Angular component best practices
-- `angularTemplate`: HTML template rules with accessibility focus
-- `rxjs`: Observable patterns and operator safety
-- `jest`: Testing configurations
-- `json`: JSON file linting
-- `storybook`: Storybook support
-
-## Customization
-
-You can override any rules by adding a `rules` section to your ESLint config:
-
-```js
-import { typescript } from 'lint-suite';
-
-export default [
-  ...typescript,
-  {
-    rules: {
-      '@typescript-eslint/explicit-function-return-type': 'off',
-    },
-  },
-];
-```
-
-## Available Rules (you can add more as you prefer)
-
-### nx/eslint-plugin
-
-- `@nx/enforce-module-boundaries`: Enforces module boundary restrictions
-- `@nx/dependency-checks`: Validates dependencies in workspace projects
-- ...
-
-### eslint-plugin-jest
-
-- `jest/no-disabled-tests`: Disallows disabled tests
-- `jest/expect-expect`: Ensures test cases contain at least one expect statement
-- `jest/valid-expect`: Validates expect() usage
-- ...
-
-### eslint-plugin-json
-
-- `json/json`: Validates JSON syntax
-- `json/sort-package-json`: Enforces consistent ordering in package.json
-- ...
-
-### @smarttools/eslint-plugin-rxjs
-
-- `@rxjs/finnish`: Enforces Finnish notation for observables
-- `@rxjs/no-ignored-subscription`: Prevents ignoring returned subscriptions
-- `@rxjs/no-unsafe-takeuntil`: Ensures proper usage of takeUntil operator
-- ...
-
-### eslint-plugin-storybook
-
-- `storybook/no-redundant-story-name`: Prevents redundant story names
-- `storybook/csf-component`: Enforces Component Story Format standards
-- `storybook/hierarchy-separator`: Enforces story hierarchy separators
-- ...
-
-### eslint-plugin-import
-
-- `import/no-unresolved`: Ensures imports point to valid modules
-- `import/order`: Enforces a consistent order of import statements
-- `import/no-duplicates`: Prevents duplicate imports
-- ...
-
-### @stylistic/eslint-plugin
-
-- `@stylistic/max-len`: Enforces maximum line length
-- `@stylistic/indent`: Enforces consistent indentation
-- `@stylistic/quotes`: Enforces consistent quote style
-- ...
-
-## Contributing
-
-See [CONTRIBUTING.md](./CONTRIBUTING.md) for contribution guidelines.
-
-## License
-
-MIT
+# Lint Suite
+
+A comprehensive collection of ESLint Flat configurations for modern web applications.
+
+## Features
+
+- **TypeScript Linting**: Strict typing rules, consistent imports, and code organization
+- **Angular Support**: Component best practices and template accessibility rules
+- **RxJS Guidelines**: Observable patterns, Finnish notation, and operator safety
+- **Code Style**: Formatting rules, line limits, and structural consistency
+- **Accessibility**: ARIA validation, keyboard events, and semantic HTML
+- **Testing**: Jest configurations with appropriate relaxations for test files
+- **Additional Support**: JSON, Storybook, and more
+
+## Installation
+
+```bash
+npm install --save-dev lint-suite
+```
+
+## Dependencies
+
+```bash
+npm install --save-dev eslint typescript-eslint eslint-config-prettier
+```
+
+## Usage
+
+Create a `.eslintrc.config.mjs` file in your project root:
+
+```js
+import { base, javascript, typescript } from 'lint-suite';
+
+export default [
+  ...base,
+  ...javascript,
+  ...typescript
+  // Rest of the required configurations
+];
+```
+
+You can selectively include configurations you need.
+
+## Available Configurations
+
+- `base`: Core JavaScript rules and formatting
+- `typescript`: TypeScript-specific rules
+- `angular`: Angular component best practices
+- `angularTemplate`: HTML template rules with accessibility focus
+- `rxjs`: Observable patterns and operator safety
+- `jest`: Testing configurations
+- `json`: JSON file linting
+- `storybook`: Storybook support
+
+## Customization
+
+You can override any rules by adding a `rules` section to your ESLint config:
+
+```js
+import { typescript } from 'lint-suite';
+
+export default [
+  ...typescript,
+  {
+    rules: {
+      '@typescript-eslint/explicit-function-return-type': 'off'
+    }
+  }
+];
+```
+
+## Available Rules (you can add more as you prefer)
+
+### nx/eslint-plugin
+
+- `@nx/enforce-module-boundaries`: Enforces module boundary restrictions
+- `@nx/dependency-checks`: Validates dependencies in workspace projects
+- ...
+
+### eslint-plugin-jest
+
+- `jest/no-disabled-tests`: Disallows disabled tests
+- `jest/expect-expect`: Ensures test cases contain at least one expect statement
+- `jest/valid-expect`: Validates expect() usage
+- ...
+
+### eslint-plugin-json
+
+- `json/json`: Validates JSON syntax
+- `json/sort-package-json`: Enforces consistent ordering in package.json
+- ...
+
+### @smarttools/eslint-plugin-rxjs
+
+- `@rxjs/finnish`: Enforces Finnish notation for observables
+- `@rxjs/no-ignored-subscription`: Prevents ignoring returned subscriptions
+- `@rxjs/no-unsafe-takeuntil`: Ensures proper usage of takeUntil operator
+- ...
+
+### eslint-plugin-storybook
+
+- `storybook/no-redundant-story-name`: Prevents redundant story names
+- `storybook/csf-component`: Enforces Component Story Format standards
+- `storybook/hierarchy-separator`: Enforces story hierarchy separators
+- ...
+
+### eslint-plugin-import
+
+- `import/no-unresolved`: Ensures imports point to valid modules
+- `import/order`: Enforces a consistent order of import statements
+- `import/no-duplicates`: Prevents duplicate imports
+- ...
+
+### @stylistic/eslint-plugin
+
+- `@stylistic/max-len`: Enforces maximum line length
+- `@stylistic/indent`: Enforces consistent indentation
+- `@stylistic/quotes`: Enforces consistent quote style
+- ...
+
+## Contributing
+
+See [CONTRIBUTING.md](./CONTRIBUTING.md) for contribution guidelines.
+
+## License
+
+MIT
+
+```
+
+```
+
+```
+
+```

package/index.cjs

@@ -32,6 +32,7 @@ var src_exports = {};
 __export(src_exports, {
   angular: () => angular,
   angularTemplate: () => angularTemplate,
+  base: () => base,
   javascript: () => javascript,
   jest: () => jest,
   json: () => json,
@@ -43,12 +44,14 @@ __export(src_exports, {
 module.exports = __toCommonJS(src_exports);
 
 // packages/lint-suite/src/lib/angular-template.ts
-var import_eslint_plugin = __toESM(require("@nx/eslint-plugin"), 1);
-var angularTemplate = [
-  ...import_eslint_plugin.default.configs["flat/angular-template"],
+var import_angular_eslint = require("angular-eslint");
+var import_typescript_eslint = require("typescript-eslint");
+var angularTemplate = (0, import_typescript_eslint.config)([
   {
     files: ["**/*.html"],
+    extends: [...import_angular_eslint.configs.templateAccessibility, ...import_angular_eslint.configs.templateRecommended],
     rules: {
+      "@angular-eslint/template/prefer-template-literal": "error",
       "@angular-eslint/template/no-any": "error",
       "@angular-eslint/template/no-duplicate-attributes": "error",
       "@angular-eslint/template/button-has-type": "error",
@@ -86,26 +89,40 @@ var angularTemplate = [
       ]
     }
   }
-];
+]);
 
 // packages/lint-suite/src/lib/angular.ts
-var import_eslint_plugin2 = __toESM(require("@nx/eslint-plugin"), 1);
-var angular = [
-  ...import_eslint_plugin2.default.configs["flat/angular"],
+var import_globals = __toESM(require("globals"), 1);
+var import_angular_eslint2 = require("angular-eslint");
+var import_typescript_eslint2 = require("typescript-eslint");
+var angular = (0, import_typescript_eslint2.config)([
   {
     files: ["**/*.ts"],
+    extends: [...import_angular_eslint2.configs.tsRecommended],
+    languageOptions: {
+      globals: {
+        ...import_globals.default.browser,
+        ...import_globals.default.es2025,
+        ...import_globals.default.node
+      }
+    },
+    processor: import_angular_eslint2.processInlineTemplates,
+    plugins: { "@angular-eslint": import_angular_eslint2.tsPlugin },
     rules: {
-      "@angular-eslint/prefer-on-push-component-change-detection": "error"
+      "@angular-eslint/prefer-on-push-component-change-detection": "error",
+      "@angular-eslint/prefer-signals": "error",
+      "@angular-eslint/use-injectable-provided-in": "error"
     }
   }
-];
+]);
 
 // packages/lint-suite/src/lib/base.ts
-var import_eslint_plugin3 = __toESM(require("@nx/eslint-plugin"), 1);
-var import_eslint_plugin4 = __toESM(require("@stylistic/eslint-plugin"), 1);
+var import_eslint_plugin = require("@nx/eslint-plugin");
+var import_eslint_plugin2 = __toESM(require("@stylistic/eslint-plugin"), 1);
 var import_eslint_plugin_import_x = __toESM(require("eslint-plugin-import-x"), 1);
-var base = [
-  ...import_eslint_plugin3.default.configs["flat/base"],
+var import_typescript_eslint3 = require("typescript-eslint");
+var base = (0, import_typescript_eslint3.config)([
+  { extends: [...import_eslint_plugin.configs["flat/base"]] },
   {
     files: [
       "**/*.js",
@@ -117,7 +134,7 @@ var base = [
       "**/*.cts",
       "**/*.mts"
     ],
-    ...import_eslint_plugin_import_x.default.flatConfigs.recommended
+    extends: [import_eslint_plugin_import_x.default.flatConfigs.recommended]
   },
   {
     files: [
@@ -130,7 +147,7 @@ var base = [
       "**/*.cts",
       "**/*.mts"
     ],
-    ...import_eslint_plugin4.default.configs.recommended
+    extends: [import_eslint_plugin2.default.configs.recommended]
   },
   {
     files: [
@@ -149,7 +166,7 @@ var base = [
       "no-console": ["warn", { allow: ["warn", "error"] }],
       "no-debugger": "error",
       eqeqeq: ["error", "always", { null: "ignore" }],
-      curly: ["error", "all"],
+      curly: ["error", "multi"],
       "prefer-const": ["error", { destructuring: "all" }],
       "no-var": "error",
       "object-shorthand": "error",
@@ -179,7 +196,6 @@ var base = [
       "grouped-accessor-pairs": ["error", "getBeforeSet"],
       // Enforce consistency for getters/setters
       "class-methods-use-this": "error",
-      "no-void": "error",
       "no-underscore-dangle": "error",
       "max-len": [
         "error",
@@ -197,6 +213,38 @@ var base = [
           }
         }
       ],
+      "@stylistic/padding-line-between-statements": [
+        "error",
+        {
+          blankLine: "always",
+          prev: "export",
+          next: ["export", "const"]
+        },
+        {
+          blankLine: "always",
+          prev: ["const", "let", "var"],
+          next: "*"
+        },
+        {
+          blankLine: "any",
+          prev: ["const", "let", "var"],
+          next: ["const", "let", "var"]
+        },
+        {
+          blankLine: "always",
+          prev: "*",
+          next: [
+            "for",
+            "if",
+            "return",
+            "throw",
+            "switch",
+            "try",
+            "class",
+            "function"
+          ]
+        }
+      ],
       "@stylistic/comma-dangle": [
         "error",
         {
@@ -258,7 +306,7 @@ var base = [
   {
     files: ["**/*.spec.ts", "**/*.test.ts", "**/*.spec.js", "**/*.test.js"],
     rules: {
-      "max-line-per-function": "off",
+      "max-lines-per-function": "off",
       complexity: ["warn", { max: 1 }],
       "max-lines": [
         "error",
@@ -282,37 +330,45 @@ var base = [
       "class-methods-use-this": "off"
     }
   }
-];
+]);
 
 // packages/lint-suite/src/lib/javascript.ts
-var import_eslint_plugin5 = __toESM(require("@nx/eslint-plugin"), 1);
-var javascript = import_eslint_plugin5.default.configs["flat/javascript"];
+var import_eslint_plugin3 = require("@nx/eslint-plugin");
+var import_typescript_eslint4 = require("typescript-eslint");
+var javascript = (0, import_typescript_eslint4.config)({
+  files: ["**/*.js", "**/*.jsx", "**/*.cjs", "**/*.mjs"],
+  extends: [...import_eslint_plugin3.configs["flat/javascript"]],
+  rules: {}
+});
 
 // packages/lint-suite/src/lib/jest.ts
 var import_eslint_plugin_jest = __toESM(require("eslint-plugin-jest"), 1);
-var jest = [
+var import_typescript_eslint5 = require("typescript-eslint");
+var jest = (0, import_typescript_eslint5.config)([
   {
     files: ["**/*.spec.ts", "**/*.test.ts", "**/*.spec.js", "**/*.test.js"],
-    ...import_eslint_plugin_jest.default.configs["flat/all"],
+    extends: [import_eslint_plugin_jest.default.configs["flat/all"]],
     rules: {
-      "jest/no-done-callback": "off",
-      "jest/no-unbound-method": "error"
+      "jest/no-done-callback": "off"
     }
   }
-];
+]);
 
 // packages/lint-suite/src/lib/json.ts
 var import_eslint_plugin_json = __toESM(require("eslint-plugin-json"), 1);
-var json = [
+var import_typescript_eslint6 = require("typescript-eslint");
+var json = (0, import_typescript_eslint6.config)([
   {
     files: ["**/*.json"],
-    ...import_eslint_plugin_json.default.configs.recommended
+    extends: [import_eslint_plugin_json.default.configs.recommended],
+    rules: {}
   }
-];
+]);
 
 // packages/lint-suite/src/lib/rxjs.ts
 var import_eslint_plugin_rxjs = __toESM(require("@smarttools/eslint-plugin-rxjs"), 1);
-var rxjs = [
+var import_typescript_eslint7 = require("typescript-eslint");
+var rxjs = (0, import_typescript_eslint7.config)([
   {
     files: [
       "**/*.js",
@@ -329,7 +385,7 @@ var rxjs = [
         projectService: true
       }
     },
-    ...import_eslint_plugin_rxjs.default.configs.recommended
+    extends: [import_eslint_plugin_rxjs.default.configs.recommended]
   },
   {
     files: [
@@ -360,6 +416,7 @@ var rxjs = [
     rules: {
       "rxjs/prefer-observer": "error",
       "rxjs/finnish": "warn",
+      "rxjs/no-ignored-subscription": "warn",
       "rxjs/no-ignored-error": "warn",
       "rxjs/no-unsafe-switchmap": "error",
       "rxjs/no-unsafe-takeuntil": "error",
@@ -376,20 +433,22 @@ var rxjs = [
       "rxjs/no-ignored-subscription": "off"
     }
   }
-];
+]);
 
 // packages/lint-suite/src/lib/storybook.ts
 var import_eslint_plugin_storybook = __toESM(require("eslint-plugin-storybook"), 1);
-var storybook = [
-  ...import_eslint_plugin_storybook.default.configs["flat/recommended"],
+var import_typescript_eslint8 = require("typescript-eslint");
+var storybook = (0, import_typescript_eslint8.config)([
   {
     ignores: ["!.storybook"],
-    files: ["**/*.stories.ts"]
+    files: ["**/*.stories.ts"],
+    extends: [import_eslint_plugin_storybook.default.configs["flat/recommended"]],
+    rules: {}
   }
-];
+]);
 
 // packages/lint-suite/src/lib/typescript.ts
-var import_eslint_plugin6 = __toESM(require("@nx/eslint-plugin"), 1);
+var import_eslint_plugin4 = require("@nx/eslint-plugin");
 var import_eslint_import_resolver_typescript = require("eslint-import-resolver-typescript");
 var import_eslint_plugin_import_x2 = __toESM(require("eslint-plugin-import-x"), 1);
 
@@ -531,15 +590,21 @@ var explicit_accessibility_default = createRule({
 });
 
 // packages/lint-suite/src/lib/typescript.ts
+var import_typescript_eslint9 = require("typescript-eslint");
 var localTypescriptRules = {
   rules: {
     "explicit-accessibility": explicit_accessibility_default
   }
 };
-var typescript = [
+var typescript = (0, import_typescript_eslint9.config)([
   // NOTE: Checks for 'prettier' and 'eslint-plugin-prettier'
-  import_eslint_plugin_import_x2.default.flatConfigs.typescript,
-  ...import_eslint_plugin6.default.configs["flat/typescript"],
+  {
+    files: ["**/*.ts", "**/*.tsx", "**/*.cts", "**/*.mts"],
+    extends: [
+      import_eslint_plugin_import_x2.default.flatConfigs.typescript,
+      ...import_eslint_plugin4.configs["flat/typescript"]
+    ]
+  },
   {
     files: ["**/*.ts", "**/*.tsx", "**/*.cts", "**/*.mts"],
     plugins: { local: localTypescriptRules },
@@ -562,12 +627,14 @@ var typescript = [
       // Consider enabling if maximum explicitness is desired, even if verbose:
       // C. Null/Undefined Safety (Requires strictNullChecks)
       "@typescript-eslint/no-non-null-assertion": "error",
+      "@typescript-eslint/prefer-nullish-coalescing": "error",
+      "@typescript-eslint/prefer-optional-chain": "error",
       // D. Promise Handling (Supplementing plugin:promise/recommended)
       "@typescript-eslint/no-floating-promises": [
         "error",
         { ignoreVoid: true }
       ],
-      "@typescript-eslint/no-misused-promises": "error",
+      "@typescript-eslint/no-misused-promises": "warn",
       // Already in recommended-type-checked
       "@typescript-eslint/promise-function-async": "error",
       "@typescript-eslint/await-thenable": "error",
@@ -648,7 +715,16 @@ var typescript = [
             "unknown"
           ],
           pathGroups: [
-            { group: "external", pattern: "@angular/**", position: "before" },
+            {
+              pattern: "@angular/**",
+              group: "builtin",
+              position: "before"
+            },
+            {
+              pattern: "@nestjs/**",
+              group: "builtin",
+              position: "before"
+            },
             {
               pattern: "@*/shared/**",
               group: "internal",
@@ -665,7 +741,7 @@ var typescript = [
               position: "after"
             }
           ],
-          pathGroupsExcludedImportTypes: ["@angular/**"],
+          pathGroupsExcludedImportTypes: ["@angular/**", "@nestjs/**"],
           "newlines-between": "always",
           alphabetize: { order: "asc", caseInsensitive: true }
         }
@@ -708,10 +784,18 @@ var typescript = [
     files: ["**/*.spec.ts", "**/*.test.ts", "**/*.spec.js", "**/*.test.js"],
     rules: {
       "@typescript-eslint/no-empty-function": "off",
-      "@typescript-eslint/no-unbound-method": "off"
+      "@typescript-eslint/no-unbound-method": "off",
+      "@typescript-eslint/consistent-type-assertions": "off"
+    }
+  },
+  {
+    files: ["**/*.stories.ts"],
+    rules: {
+      "@typescript-eslint/consistent-type-assertions": "off",
+      "@typescript-eslint/naming-convention": "off"
     }
   }
-];
+]);
 
 // packages/lint-suite/src/index.ts
 var recommended = [
@@ -729,6 +813,7 @@ var recommended = [
 0 && (module.exports = {
   angular,
   angularTemplate,
+  base,
   javascript,
   jest,
   json,