lint-rules-alvin 1.1.0 → 1.1.2

package/eslint/configs/custom.js

@@ -5,6 +5,7 @@ import { jsxNoSingleObjectCurlyNewlineRule } from '../custom_rules/jsx-no-single
 import { maxChainPerLineRule } from '../custom_rules/max-chain-per-line.js';
 import { multilineParenNewlineRule } from '../custom_rules/multiline-paren-newline.js';
 import { multilineArrayAccessorNewlineRule } from '../custom_rules/multiline-array-accessor-newline.js';
+import { destructureNewlineRule } from '../custom_rules/destructure-newline.js';
 
 /**
  * Provides a config that creates a plugin and configures custom rules.
@@ -21,7 +22,8 @@ export const custom = {
 				'jsx-no-single-object-curly-newline': jsxNoSingleObjectCurlyNewlineRule,
 				'max-chain-per-line': maxChainPerLineRule,
 				'multiline-paren-newline': multilineParenNewlineRule,
-				'multiline-array-accessor-newline': multilineArrayAccessorNewlineRule
+				'multiline-array-accessor-newline': multilineArrayAccessorNewlineRule,
+				'destructure-newline': destructureNewlineRule
 			}
 		}
 	},
@@ -37,13 +39,18 @@ export const custom = {
 			'error',
 			{
 				maxChain: 2,
-				enforceSingleLine: true
+				enforceSingleLine: true,
+				checkSingleLink: true
 			}
 		],
 		'custom/multiline-paren-newline': [
 			'error',
 			{ singleArgument: true }
 		],
-		'custom/multiline-array-accessor-newline': 'error'
+		'custom/multiline-array-accessor-newline': 'error',
+		'custom/destructure-newline': [
+			'error',
+			{ minItems: 2 }
+		]
 	}
 };

package/eslint/configs/typescript.js

@@ -470,7 +470,7 @@ export const typescript = {
 		'@typescript-eslint/strict-boolean-expressions': [
 			'error',
 			{
-				allowAny: false,
+				allowAny: true,
 				allowNullableBoolean: false,
 				allowNullableEnum: false,
 				allowNullableNumber: true,

package/eslint/custom_rules/destructure-newline.js

@@ -0,0 +1,88 @@
+/**
+ * @type {import('eslint').Rule.RuleModule}
+ */
+export const destructureNewlineRule = {
+	meta: {
+		type: 'layout',
+		docs: {
+			description: 'Enforce newlines between properties in destructuring assignments',
+			category: 'Stylistic Issues',
+			recommended: false
+		},
+		fixable: 'whitespace',
+		schema: [
+			{
+				type: 'object',
+				properties: {
+					minItems: {
+						type: 'integer',
+						minimum: 2
+					}
+				},
+				additionalProperties: false
+			}
+		],
+		messages: { error: 'There should be a newline between destructuring properties.' }
+	},
+
+	create(context) {
+
+		const sourceCode = context.sourceCode;
+		const { minItems = 2 } = context.options[0] || {};
+
+		return {
+			VariableDeclarator(node) {
+
+				if (node.id.type !== 'ObjectPattern') {
+
+					return;
+
+				}
+				const properties = node.id.properties;
+
+				if (properties.length < minItems) {
+
+					return;
+
+				}
+
+				for (let i = 0; i < properties.length - 1; i++) {
+
+					const currentProperty = properties[i];
+					const nextProperty = properties[i + 1];
+
+					const lastTokenOfCurrent = sourceCode.getLastToken(currentProperty);
+					const firstTokenOfNext = sourceCode.getFirstToken(nextProperty);
+
+					if (
+						lastTokenOfCurrent
+							.loc
+							.end
+							.line === firstTokenOfNext
+							.loc
+							.start
+							.line
+					) {
+
+						context.report({
+							node: nextProperty,
+							messageId: 'error',
+							fix(fixer) {
+
+								return fixer.insertTextBefore(
+									nextProperty,
+									'\n'
+								);
+
+							}
+						});
+
+					}
+
+				}
+
+			}
+		};
+
+	}
+};

package/eslint/custom_rules/jsx-multiline-prop-newline.js

@@ -86,13 +86,12 @@ export const jsxMultilinePropNewlineRule = {
 						fix(fixer) {
 
 							// Get indentation of the line with the opening tag.
-							const line = sourceCode
-								.getLines()[
-									node
-										.loc
-										.start
-										.line - 1
-								];
+							const line = sourceCode.getLines()[
+								node
+									.loc
+									.start
+									.line - 1
+							];
 							const baseIndentMatch = line.match(/^\s*/);
 							const baseIndent = baseIndentMatch
 								? baseIndentMatch[0]

package/eslint/custom_rules/max-chain-per-line.js

@@ -21,6 +21,10 @@ export const maxChainPerLineRule = {
 					enforceSingleLine: {
 						type: 'boolean',
 						default: false
+					},
+					checkSingleLink: {
+						type: 'boolean',
+						default: false
 					}
 				},
 				additionalProperties: false
@@ -34,9 +38,11 @@ export const maxChainPerLineRule = {
 	create(context) {
 
 		const {
-			maxChain = 2, enforceSingleLine = false
+			maxChain = 2,
+			enforceSingleLine = false,
+			checkSingleLink = false
 		} = context.options[0] || {};
-		const sourceCode = context.getSourceCode();
+		const sourceCode = context.sourceCode;
 		const processedChains = new Set();
 
 		/**
@@ -123,7 +129,10 @@ export const maxChainPerLineRule = {
 			const links = getChainLinks(outermostNode);
 			const chainCount = links.length;
 
-			if (chainCount <= 1) {
+			const minChain = checkSingleLink
+				? 1
+				: 2;
+			if (chainCount < minChain) {
 
 				return;
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "lint-rules-alvin",
-  "version": "1.1.0",
+  "version": "1.1.2",
   "description": "My own personal linting ruleset for a bunch of different plugins. Includes a few custom rules. Used in a few of my repos.",
   "keywords": [
     "eslint"