linny-r 2.0.5 → 2.0.7

package/static/scripts/linny-r-ctrl.js

@@ -875,9 +875,9 @@ class ChartManager {
 // CLASS SensitivityAnalysis provides the sensitivity analysis functionality
 class SensitivityAnalysis {
   constructor() {
-    // Initialize main dialog properties
+    // Initialize main dialog properties.
     this.reset();
-    // Sensitivity analysis creates & disposes an experiment and a chart
+    // Sensitivity analysis creates & disposes an experiment and a chart.
     this.experiment_title = '___SENSITIVITY_ANALYSIS___';
     this.chart_title = '___SENSITIVITY_ANALYSIS_CHART___';
   }
@@ -912,7 +912,7 @@ class SensitivityAnalysis {
     // a dummy chart is created that includes all these outcomes as *chart*
     // variables.
     if(!this.experiment) {
-      // Clear results from previous analysis
+      // Clear results from previous analysis.
       this.clearResults();
       this.parameters = [];
       for(let i = 0; i < MODEL.sensitivity_parameters.length; i++) {
@@ -924,7 +924,7 @@ class SensitivityAnalysis {
         if(oax) {
           this.parameters.push(oax);
         } else if(vn.length === 1 && obj instanceof Dataset) {
-          // Dataset without selector => push the dataset vector
+          // Dataset without selector => push the dataset vector.
           this.parameters.push(obj.vector);
         } else {
           UI.alert(`Parameter ${p} is not a dataset or expression`);
@@ -938,23 +938,24 @@ class SensitivityAnalysis {
       this.experiment = new Experiment(this.experiment_title);
       this.experiment.charts = [this.chart];
       this.experiment.inferVariables();
-      // This experiment always uses the same combination: the base selectors
+      // This experiment always uses the same combination: the base selectors.
       const bs = MODEL.base_case_selectors.split(' ');
       this.experiment.combinations = [];
-      // Add this combination N+1 times for N parameters
+      // Add this combination N+1 times for N parameters.
       for(let i = 0; i <= this.parameters.length; i++) {
         this.experiment.combinations.push(bs);
       }
-      // NOTE: model settings will not be changed, but nevertheless restored
+      // NOTE: Model settings will not be changed, but will be restored after
+      // each run => store the original settings.
       this.experiment.original_model_settings = MODEL.settingsString;
       this.experiment.original_round_sequence = MODEL.round_sequence;
     }
-    // Change the button (GUI only -- console will return FALSE)
+    // Change the button (GUI only -- console will return FALSE).
     const paused = this.resumeButtons();
     if(!paused) {
       this.experiment.time_started = new Date().getTime();
       this.experiment.active_combination_index = 0;
-      // NOTE: start with base case run, hence no active parameter yet
+      // NOTE: Start with base case run, hence no active parameter yet.
       MODEL.running_experiment = this.experiment;
     }
     // Let the experiment manager do the work!!
@@ -962,31 +963,31 @@ class SensitivityAnalysis {
   }
   
   processRestOfRun() {   
-    // This method is called by the experiment manager after an SA run
+    // This method is called by the experiment manager after a SA run.
     const x = MODEL.running_experiment;
     if(!x) return;
-    // Double-check that indeed the SA experiment is running 
+    // Double-check that indeed the SA experiment is running.
     if(x !== this.experiment) {
       UI.alert('ERROR: Expected SA experiment run, but got ' + x.title);
       return;
     } 
     const aci = x.active_combination_index;
-    // Always add solver messages
+    // Always add solver messages.
     x.runs[aci].addMessages();
-    // NOTE: use a "dummy experiment object" to ensure proper XML saving and
-    // loading , as the actual experiment is not stored
+    // NOTE: Use a "dummy experiment object" to ensure proper XML saving and
+    // loading , as the actual experiment is not stored.
     x.runs.experiment = {title: SENSITIVITY_ANALYSIS.experiment_title};
-    // Add run to the sensitivity analysis
+    // Add run to the sensitivity analysis.
     MODEL.sensitivity_runs.push(x.runs[aci]);
     this.showProgress('Run #' + aci);
-    // See if more runs should be done
+    // See if more runs should be done.
     const n = x.combinations.length;
     if(!VM.halted && aci < n - 1) {
       if(this.must_pause) {
         this.pausedButtons(aci);
         UI.setMessage('');
       } else {
-        // NOTE: use aci because run #0 is the base case w/o active parameter
+        // NOTE: Use aci because run #0 is the base case w/o active parameter.
         MODEL.active_sensitivity_parameter = this.parameters[aci];
         x.active_combination_index++;
         setTimeout(() => EXPERIMENT_MANAGER.runModel(), 5);
@@ -1001,31 +1002,31 @@ class SensitivityAnalysis {
       } else {
         this.showCheckmark(msecToTime(x.time_stopped - x.time_started));
       }
-      // No more runs => perform wrap-up
-      // Restore original model settings
+      // No more runs => perform wrap-up.
+      // (1) Restore original model settings.
       MODEL.running_experiment = null;
       MODEL.active_sensitivity_parameter = null;
       MODEL.parseSettings(x.original_model_settings);
       MODEL.round_sequence = x.original_round_sequence;
-      // Reset the Virtual Machine so t=0 at the status line,
-      // and ALL expressions are reset as well
+      // (2) Reset the Virtual Machine so t=0 at the status line, and ALL
+      // expressions are reset as well.
       VM.reset();
-      // Free the SA experiment and SA chart
+      // Free the SA experiment and SA chart.
       this.experiment = null;
       this.chart = null;
-      // Reset buttons (GUI only)
+      // Reset buttons (GUI only).
       this.readyButtons();
     }
     this.updateDialog();
-    // Reset the model, as results of last run will be showing still
+    // Reset the model, as results of last run will be showing still.
     UI.resetModel();
     CHART_MANAGER.resetChartVectors();
-    // NOTE: clear chart only when done (charts do not update during experiment)
+    // NOTE: Clear chart only when done (charts do not update during experiment).
     if(!MODEL.running_experiment) CHART_MANAGER.updateDialog();
   }
 
   stop() {
-    // Interrupt solver but retain data on server (and no resume)
+    // Interrupt solver but retain data on server (and no resume).
     VM.halt();
     this.readyButtons();
     this.showProgress('');
@@ -1033,13 +1034,13 @@ class SensitivityAnalysis {
   }
   
   clearResults() {
-    // Clear results and reset control buttons
+    // Clear results, and reset control buttons.
     MODEL.sensitivity_runs.length = 0;
     this.selected_run = -1;
   }
   
   computeData(sas) {
-    // Compute data value or status for statistic `sas`
+    // Compute data value or status for statistic `sas`.
     this.perc = {};
     this.shade = {};
     this.data = {};
@@ -1047,12 +1048,12 @@ class SensitivityAnalysis {
         ol = MODEL.sensitivity_outcomes.length,
         rl = MODEL.sensitivity_runs.length;
     if(ol === 0) return;
-    // Always find highest relative change
+    // Always find highest relative change.
     let max_dif = 0;
     for(let i = 0; i < ol; i++) {
       this.data[i] = [];
       for(let j = 0; j < rl; j++) {
-        // Get the selected statistic for each run to get an array of numbers
+        // Get the selected statistic for each run to get an array of numbers.
         const rr = MODEL.sensitivity_runs[j].results[i];
         if(!rr) {
           this.data[i].push(VM.UNDEFINED);
@@ -1076,7 +1077,7 @@ class SensitivityAnalysis {
           this.data[i].push(rr.last);
         }
       }
-      // Compute relative change
+      // Compute the relative change.
       let bsv = this.data[i][0];
       if(Math.abs(bsv) < VM.NEAR_ZERO) bsv = 0;
       this.perc[i] = [];
@@ -1097,26 +1098,26 @@ class SensitivityAnalysis {
         for(let j = 1; j < this.data[i].length; j++) this.perc[i].push('-');
       }
     }
-    // Now use max_dif to compute shades
+    // Now use max_dif to compute shades.
     for(let i = 0; i < ol; i++) {      
       this.shade[i] = [];
-      // Color scale range is -max ... +max (0 in center => white)
+      // Color scale range is -max ... +max (0 in center => white).
       for(let j = 0; j < this.perc[i].length; j++) {
         const p = this.perc[i][j];
         this.shade[i].push(p === VM.UNDEFINED || max_dif < VM.NEAR_ZERO ?
             0.5 : (p / max_dif + 1) / 2);
       }
-      // Convert to sig4Dig
+      // Convert to sig4Dig.
       for(let j = 0; j < this.data[i].length; j++) {
         this.data[i][j] = VM.sig4Dig(this.data[i][j]);
       }
-      // Format data such that they all have same number of decimals
+      // Format data such that they all have same number of decimals.
       if(this.relative_scale && this.perc[i][0] !== '-') {
         for(let j = 0; j < this.perc[i].length; j++) {
           this.perc[i][j] = VM.sig4Dig(this.perc[i][j]);
         }
         uniformDecimals(this.perc[i]);
-        // NOTE: only consider data of base scenario
+        // NOTE: Only consider data of base scenario.
         this.data[i][0] = VM.sig4Dig(this.data[i][0]);
       } else {
         uniformDecimals(this.data[i]);
@@ -1125,11 +1126,11 @@ class SensitivityAnalysis {
   }
   
   resumeButtons() {
-    // Console experiments cannot be paused, and hence not resumed
+    // Console experiments cannot be paused, and hence not resumed.
     return false;
   }
 
-  // Dummy methods: actions that are meaningful only for the graphical UI
+  // Dummy methods: actions that are meaningful only for the graphical UI.
   updateDialog() {}
   showCheckmark() {}
   showProgress() {}
@@ -1143,7 +1144,7 @@ class SensitivityAnalysis {
 // Class ExperimentManager controls the collection of experiments of the model
 class ExperimentManager {
   constructor() {
-    // NOTE: the properties below are relevant only for the GUI
+    // NOTE: The properties below are relevant only for the GUI.
     this.experiment_table = null;
     this.focal_table = null;
   }

package/static/scripts/linny-r-gui-constraint-editor.js

@@ -283,7 +283,8 @@ class ConstraintEditor {
           i = this.selected_point,
           pts = this.selected.points,
           li = pts.length - 1,
-          p = pts[this.selected_point],
+          // NOTE: Use a copy of the selected point, or it will not be updated.
+          p = pts[this.selected_point].slice(),
           minx = (i === 0 ? 0 : (i === li ? 100 : pts[i - 1][0])),
           maxx = (i === 0 ? 0 : (i === li ? 100 : pts[i + 1][0]));
       let cx = false,
@@ -317,6 +318,9 @@ class ConstraintEditor {
           p[1] = Math.round(3 * p[1]) / 3;
         }
       }
+      this.dragged_point = this.selected_point;
+      this.movePoint(p[0], p[1]);
+      this.dragged_point = -1;
       this.draw();
       this.updateEquation();
     }
@@ -670,7 +674,7 @@ class ConstraintEditor {
   }
 
   deleteSelector() {
-    // Delete modifier from selected dataset
+    // Delete modifier from selected dataset.
     if(!this.selected) return;
     const
         bl = this.selected,
@@ -1156,7 +1160,7 @@ class ConstraintEditor {
   }
 
   updateConstraint() {
-    // Updates the edited constraint, or adds a new constraint to the model
+    // Update the edited constraint, or add a new constraint to the model.
     // TO DO: prepare for undo
     if(this.edited_constraint === null) {
       this.edited_constraint = MODEL.addConstraint(this.from_node, this.to_node);

package/static/scripts/linny-r-gui-controller.js

@@ -13,7 +13,7 @@ handler functions.
 */
 
 /*
-Copyright (c) 2017-2024 Delft University of Technology
+Copyright (c) 2017-2025 Delft University of Technology
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
@@ -3608,6 +3608,7 @@ console.log('HERE name conflicts', name_conflicts, mapping);
     this.setBox('settings-diagnose', model.always_diagnose);
     this.setBox('settings-power', model.with_power_flow);
     this.setBox('settings-cost-prices', model.infer_cost_prices);
+    this.setBox('settings-negative-flows', model.ignore_negative_flows);
     this.setBox('settings-report-results', model.report_results);
     this.setBox('settings-encrypt', model.encrypt);
     const pg_btn = md.element('power-btn');
@@ -3672,7 +3673,7 @@ console.log('HERE name conflicts', name_conflicts, mapping);
       UI.notify('To diagnose unbounded problems, values beyond 1e+10 ' +
           'are considered as infinite (\u221E)');
     }
-    // Some changes may necessitate redrawing the diagram
+    // Some changes may necessitate redrawing the diagram.
     let cb = UI.boxChecked('settings-align-to-grid'),
         redraw = !model.align_to_grid && cb;
     model.align_to_grid = cb;
@@ -3683,10 +3684,11 @@ console.log('HERE name conflicts', name_conflicts, mapping);
     cb = UI.boxChecked('settings-cost-prices');
     redraw = redraw || cb !== model.infer_cost_prices;
     model.infer_cost_prices = cb;
+    model.ignore_negative_flows = UI.boxChecked('settings-negative-flows');
     cb = UI.boxChecked('settings-block-arrows');
     redraw = redraw || cb !== model.show_block_arrows;
     model.show_block_arrows = cb;
-    // Changes affecting run length (hence vector lengths) require a model reset
+    // Changes affecting run length (hence vector lengths) require a model reset.
     let reset = false;
     reset = reset || (ts != model.time_scale);
     model.time_scale = ts;
@@ -4281,7 +4283,7 @@ console.log('HERE name conflicts', name_conflicts, mapping);
     const
         md = this.modals.link,
         l = this.edited_object;
-    // Check whether all input fields are valid
+    // Check whether all input fields are valid.
     if(!this.updateExpressionInput('link-R', 'rate', l.relative_rate)) {
       return false;
     }
@@ -4316,8 +4318,10 @@ console.log('HERE name conflicts', name_conflicts, mapping);
                 `</strong> will cause issues for ${VM.LM_SYMBOLS[m]} link`);
       }
     }
-    // NOTE: share of cost is input as a percentage, but stored as a floating
-    // point value between 0 and 1
+    // NOTE: Share of cost is input as a percentage, but stored as a floating
+    // point value between 0 and 1.
+    // If SoC is changed, *all* output links must be redrawn.
+    const soc_change = (l.share_of_cost !== soc / 100);
     l.share_of_cost = soc / 100;
     if(md.group.length > 1) {
       // NOTE: Special care must be taken to not set special multipliers
@@ -4328,10 +4332,15 @@ console.log('HERE name conflicts', name_conflicts, mapping);
       MODEL.focal_cluster.clearAllProcesses();
       UI.drawDiagram(MODEL);
     } else {
-      // Redraw the arrow shape that represents the edited link
-      this.paper.drawArrow(this.on_arrow);
-      // Redraw the FROM node if link has become (or no longer is) "first commit"
-      if(redraw) this.drawObject(this.on_arrow.from_node);
+      if(soc_change) {
+        // Redraw process with its links so that all SoC labels are updated.
+        this.on_arrow.from_node.drawWithLinks();
+      } else {
+        // Only redraw the arrow shape that represents the edited link.
+        this.paper.drawArrow(this.on_arrow);
+        // Redraw the FROM node if link has become (or no longer is) "first commit".
+        if(redraw) this.drawObject(this.on_arrow.from_node);
+      }
     }
     md.hide();
   }

package/static/scripts/linny-r-gui-finder.js

@@ -458,6 +458,19 @@ class Finder {
           xol.push(l.identifier);
         }
       }
+      // Check all constraint boundline index expressions.
+      for(let k in MODEL.constraints) if(MODEL.constraints.hasOwnProperty(k)) {
+        const c = MODEL.constraints[k];
+        for(let i = 0; i < c.bound_lines.length; i++) {
+          const bl = c.bound_lines[i];
+          for(let j = 0; j < bl.selectors.length; j++) {
+            if(re.test(bl.selectors[j].expression.text)) {
+              xal.push('I' + (i + 1));
+              xol.push(c.identifier);
+            }
+          }
+        }
+      }
       // Check all dataset modifier expressions.
       for(let k in MODEL.datasets) if(MODEL.datasets.hasOwnProperty(k)) {
         const ds = MODEL.datasets[k];

package/static/scripts/linny-r-gui-model-autosaver.js

@@ -12,7 +12,7 @@ dialogs, the main drawing canvas, and event handler functions.
 */
 
 /*
-Copyright (c) 2017-2024 Delft University of Technology
+Copyright (c) 2017-2025 Delft University of Technology
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
@@ -165,7 +165,7 @@ class ModelAutoSaver {
       html += ['<tr class="dataset" style="color: gray" ',
           'onclick="FILE_MANAGER.loadAutoSavedModel(\'',
           m.name,'\');"><td class="restore-name">', m.name, '</td><td>',
-          m.date.substring(1, 16).replace('T', ' '),
+          m.date.substring(0, 16).replace('T', ' '),
           '</td><td style="text-align: right">',
           bytes[0], '</td><td>', bytes[1], '</td><td style="width:15px">',
           '<img class="del-asm-btn" src="images/delete.png" ',

package/static/scripts/linny-r-gui-monitor.js

@@ -11,7 +11,7 @@ for the Linny-R Monitor dialog.
 */
 
 /*
-Copyright (c) 2017-2024 Delft University of Technology
+Copyright (c) 2017-2025 Delft University of Technology
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

package/static/scripts/linny-r-gui-paper.js

@@ -11,7 +11,7 @@ functionality for the Linny-R model editor.
 */
 
 /*
-Copyright (c) 2017-2024 Delft University of Technology
+Copyright (c) 2017-2025 Delft University of Technology
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal
@@ -909,16 +909,17 @@ class Paper {
   }
   
   //
-  // Diagram-drawing method draws the diagram for the focal cluster
+  // Diagram-drawing method draws the diagram for the focal cluster.
   //
   
   drawModel(mdl) {
-    // Draw the diagram for the focal cluster
+    // Draw the diagram for the focal cluster.
     this.clear();
-    // Prepare to draw all elements in the focal cluster
+    // Prepare to draw all elements in the focal cluster.
     const fc = mdl.focal_cluster;
     fc.categorizeEntities();
-    // NOTE: product positions must be updated before links are drawn
+    // NOTE: Product positions must be updated before links are drawn, so
+    // that links arrows will be drawn over their shapes.
     fc.positionProducts();
     for(let i = 0; i < fc.processes.length; i++) {
       fc.processes[i].clearHiddenIO();
@@ -926,10 +927,10 @@ class Paper {
     for(let i = 0; i < fc.sub_clusters.length; i++) {
       fc.sub_clusters[i].clearHiddenIO();
     }
-    // NOTE: also ensure that notes will update their fields
+    // NOTE: Also ensure that notes will update their fields.
     fc.resetNoteFields();
     // Draw link arrows and constraints first, as all other entities are
-    // slightly transparent so they cannot completely hide these lines
+    // slightly transparent so they cannot completely hide these lines.
     for(let i = 0; i < fc.arrows.length; i++) {
       this.drawArrow(fc.arrows[i]);
     }
@@ -945,25 +946,25 @@ class Paper {
     for(let i = 0; i < fc.sub_clusters.length; i++) {
       this.drawCluster(fc.sub_clusters[i]);
     }
-    // Draw notes last, as they are semi-transparent (and can be quite small)
+    // Draw notes last, as they are semi-transparent (and can be quite small).
     for(let i = 0; i < fc.notes.length; i++) {
       this.drawNote(fc.notes[i]);
     }
-    // Resize paper if necessary
+    // Resize paper if necessary.
     this.extend();
-    // Display model name in browser
+    // Display model name in browser.
     document.title = mdl.name || 'Linny-R';
   }
   
   drawSelection(mdl, dx=0, dy=0) {
     // NOTE: Clear this global, as Bezier curves move from under the cursor
-    // without a mouseout event 
+    // without a mouseout event.
     this.constraint_under_cursor = null;
-    // Draw the selected entities and associated links, and also constraints
+    // Draw the selected entities and associated links, and also constraints.
     for(let i = 0; i < mdl.selection.length; i++) {
       const obj = mdl.selection[i];
       // Links and constraints are drawn separately, so do not draw those
-      // contained in the selection 
+      // contained in the selection.
       if(!(obj instanceof Link || obj instanceof Constraint)) {
         if(obj instanceof Note) obj.parsed = false;
         UI.drawObject(obj, dx, dy);
@@ -972,12 +973,12 @@ class Paper {
     if(mdl.selection_related_arrows.length === 0) {
       mdl.selection_related_arrows = mdl.focal_cluster.selectedArrows();
     }
-    // Only draw the arrows that relate to the selection
+    // Only draw the arrows that relate to the selection.
     for(let i = 0; i < mdl.selection_related_arrows.length; i++) {
       this.drawArrow(mdl.selection_related_arrows[i]);
     }
     // As they typically are few, simply redraw all constraints that relate to
-    // the focal cluster
+    // the focal cluster.
     for(let i = 0; i < mdl.focal_cluster.related_constraints.length; i++) {
       this.drawConstraint(mdl.focal_cluster.related_constraints[i]);
     }
@@ -990,23 +991,23 @@ class Paper {
   //
 
   drawArrow(arrw, dx=0, dy=0) {
-    // Draws an arrow from FROM nodebox to TO nodebox
-    // NOTE: first erase previously drawn arrow
+    // Draw an arrow from FROM nodebox to TO nodebox.
+    // NOTE: First erase previously drawn arrow.
     arrw.shape.clear();
     arrw.hidden_nodes.length = 0;
-    // Use local variables so as not to change any "real" attribute values
+    // Use local variables so as not to change any "real" attribute values.
     let cnb, proc, prod, fnx, fny, fnw, fnh, tnx, tny, tnw, tnh,
         cp, rr, aa, bb, dd, nn, af, l, s, w, tw, th, bpx, bpy, epx, epy,
         sda, stroke_color, stroke_width, arrow_start, arrow_end,
         font_color, font_weight, luc = null, grid = null;
-    // Get the main arrow attributes
+    // Get the main arrow attributes.
     const
         from_nb = arrw.from_node,
         to_nb = arrw.to_node;
-    // Use "let" because `ignored` may also be set later on (for single link)
+    // Use "let" because `ignored` may also be set later on (for single link).
     let ignored = (from_nb && MODEL.ignored_entities[from_nb.identifier]) ||
         (to_nb && MODEL.ignored_entities[to_nb.identifier]);
-    // First check if this is a block arrow (ONE node being null)
+    // First check if this is a block arrow (ONE node being null).
     if(!from_nb) {
       cnb = to_nb;
     } else if(!to_nb) {
@@ -1014,22 +1015,22 @@ class Paper {
     } else {
       cnb = null;
     }
-    // If not NULL `cnb` is the cluster or node box (product or process) having
+    // If not NULL, `cnb` is the cluster or node box (product or process) having
     // links to entities outside the focal cluster. Such links are summarized
     // by "block arrows": on the left edge of the box to indicate inflows,
     // on the right edge to indicate outflows, and two-headed on the top edge
     // to indicate two-way flows. When the cursor is moved over a block arrow,
     // the Documentation dialog will display the list of associated nodes
-    // (with their actual flows if non-zero)
+    // (with their actual flows if non-zero).
     if(cnb) {
-      // Distinguish between input, output and io products
+      // Distinguish between input, output and io products.
       let ip = [], op = [], iop = [];
       if(cnb instanceof Cluster) {
         for(let i = 0; i < arrw.links.length; i++) {
           const lnk = arrw.links[i];
-          // determine which product is involved
+          // Determine which product is involved.
           prod = (lnk.from_node instanceof Product ? lnk.from_node : lnk.to_node);
-          // NOTE: clusters "know" their input/output products
+          // NOTE: Clusters "know" their input/output products.
           if(cnb.io_products.indexOf(prod) >= 0) {
             addDistinct(prod, iop);
           } else if(cnb.consumed_products.indexOf(prod) >= 0) {
@@ -1039,7 +1040,7 @@ class Paper {
           }
         }
       } else {
-        // cnb is process or product => knows its inputs and outputs
+        // `cnb` is process or product => knows its inputs and outputs.
         for(let i = 0; i < arrw.links.length; i++) {
           const lnk = arrw.links[i];
           if(lnk.from_node === cnb) {
@@ -1047,7 +1048,7 @@ class Paper {
           } else {
             addDistinct(lnk.from_node, ip);
           }
-          // NOTE: for processes, products cannot be BOTH input and output
+          // NOTE: For processes, products cannot be BOTH input and output.
         }
       }
       cnb.hidden_inputs = ip;