linked-rolls 0.49.0 → 0.51.0

package/lib/constraints.d.ts

@@ -2,7 +2,7 @@ import { EditionView } from "./EditionView.js";
 export type ConstraintProblem = {
     version: string;
     symbol: string;
-    problem: 'alignment-reference-missing' | 'before-reference-missing' | 'after-reference-missing' | 'placed-relative-to-itself' | 'placed-several-ways' | 'partner-missing' | 'paired-with-itself' | 'in-several-pairs' | 'pair-placed-on-both-sides' | 'type-not-on-the-bar' | 'carrier-on-another-track' | 'copies-disagree-on-the-paper';
+    problem: 'alignment-reference-missing' | 'before-reference-missing' | 'after-reference-missing' | 'placed-relative-to-itself' | 'placed-several-ways' | 'partner-missing' | 'paired-with-itself' | 'in-several-pairs' | 'pair-placed-on-both-sides' | 'type-not-on-the-bar' | 'carrier-on-another-track' | 'copies-disagree-on-the-paper' | 'strike-bites-nothing';
 };
 /**
  * Where the edition cannot hold as stated, version by version: a
@@ -10,7 +10,8 @@ export type ConstraintProblem = {
  * placed relative to itself or in several ways at once, one claimed by
  * several pairs, a pair whose members are both placed and so cannot
  * keep their distance and follow their references at once, an
- * expression the version's own bar cannot read, and a carrier sitting
- * on a track that does not say what its symbol says.
+ * expression the version's own bar cannot read, a carrier sitting on a
+ * track that does not say what its symbol says, and a strike that takes
+ * nothing out.
  */
 export declare const constraintProblems: (view: EditionView) => ConstraintProblem[];

package/lib/constraints.js

@@ -3,6 +3,7 @@ import { isCommand, pairsAmong, placementsOf } from "./Symbol.js";
 import { keyOf } from "./TrackerBar.js";
 import { trackerBarOf } from "./systems/index.js";
 import { barOf } from "./RollCopy.js";
+import { deletedBy, insertedBy } from "./Version.js";
 const missingReference = {
     alignedWith: 'alignment-reference-missing',
     before: 'before-reference-missing',
@@ -100,14 +101,37 @@ const carriersOffTheirMeaning = (view, version, commands) => {
 const paperDisagreed = (view, version) => view.speedScalesIn(version).length > 1
     ? [{ version: version.id, symbol: version.id, problem: 'copies-disagree-on-the-paper' }]
     : [];
+/**
+ * A version's strikes that take nothing out of its text: each deleted
+ * symbol has to be one the parent hands down, or one the version put
+ * there itself, or the strike says nothing.
+ *
+ * It is the check for what happens when a symbol two versions shared is
+ * parted in two. The strike still names a symbol that exists, so
+ * nothing dangles and nothing looks wrong, but the reading it meant to
+ * reject has passed to the symbol standing in its place and comes back
+ * into the text unstruck. Nothing else in the edition shows it: the
+ * counts move, and only by a handful.
+ */
+const strikesBitingNothing = (view, version) => {
+    const parent = view.predecessorOf(version.id);
+    const reachable = new Set([
+        ...(parent ? view.snapshot(parent.id).map(symbol => symbol.id) : []),
+        ...insertedBy(version).map(symbol => symbol.id)
+    ]);
+    return deletedBy(version)
+        .filter(id => !reachable.has(id))
+        .map(id => ({ version: version.id, symbol: id, problem: 'strike-bites-nothing' }));
+};
 /**
  * Where the edition cannot hold as stated, version by version: a
  * placement or pairing reference absent from the version, a command
  * placed relative to itself or in several ways at once, one claimed by
  * several pairs, a pair whose members are both placed and so cannot
  * keep their distance and follow their references at once, an
- * expression the version's own bar cannot read, and a carrier sitting
- * on a track that does not say what its symbol says.
+ * expression the version's own bar cannot read, a carrier sitting on a
+ * track that does not say what its symbol says, and a strike that takes
+ * nothing out.
  */
 export const constraintProblems = (view) => view.edition.versions.flatMap(version => {
     const snapshot = view.snapshot(version.id);
@@ -116,6 +140,7 @@ export const constraintProblems = (view) => view.edition.versions.flatMap(versio
         ...problemsIn(version.id, commands),
         ...typesNotOnTheBar(version, snapshot),
         ...carriersOffTheirMeaning(view, version.id, commands),
-        ...paperDisagreed(view, version)
+        ...paperDisagreed(view, version),
+        ...strikesBitingNothing(view, version)
     ];
 });

package/lib/validate.js

@@ -1,5 +1,8 @@
 import Ajv from "ajv";
-import * as schema from "./schema.json" with { type: 'json' };
+// A default import, not a namespace one: Node's ESM gives a JSON module
+// only a default export, so `import * as` hands ajv the namespace object
+// and it compiles a schema that constrains nothing.
+import schema from "./schema.json" with { type: 'json' };
 const compileEditionSchema = () => new Ajv({ strict: false, formats: { "date": true } }).compile(schema);
 /**
  * Compiling costs enough that a consumer which never validates should not

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "linked-rolls",
-  "version": "0.49.0",
+  "version": "0.51.0",
   "description": "Digital editions of piano rolls: import, collation, editorial assumptions, JSON-LD export, and emulation through a reproducing system",
   "license": "MIT",
   "repository": {
@@ -38,10 +38,11 @@
   ],
   "scripts": {
     "build": "npm run build:schema && rm -rf lib && tsc",
-    "prepublishOnly": "npm run build && vitest run",
+    "prepublishOnly": "npm run build && vitest run && npm run smoke",
     "test": "vitest",
     "build:schema": "npx ts-json-schema-generator --additional-properties --validation-keywords see --path 'src/**/*.ts' --type 'Edition' > schema_.json && node schema/postprocess.js && rm schema_.json && mv schema.json src/schema.json",
-    "build:docs": "node schema/docs/generate.ts src/schema.json docs/index.html"
+    "build:docs": "node schema/docs/generate.ts src/schema.json docs/index.html",
+    "smoke": "node scripts/smoke.mjs"
   },
   "devDependencies": {
     "@types/jsonld": "^1.5.15",