lightning 9.8.0 → 9.8.2

package/CHANGELOG.md

@@ -1,6 +1,10 @@
 # Versions
 
-## 9.8.0
+## 9.8.2
+
+- `subscribeToForwards`: Cancel subscription when there are no event listeners
+
+## 9.8.1
 
 - `getPendingChannels`: Add `blocks_until_expiry` for opening funding expiry
 

package/lnd_methods/info/constants.json

@@ -31,6 +31,7 @@
     "5c36d96c9cbe8b27c29f9682dcbdab7928ae870f": "0.15.0-beta",
     "6042004edaaa5b3cad0a0808ff23dba4716f7178": "0.14.1-beta",
     "61c34683058f2cc8dc10f49392a0057440d831c4": "0.13.4-beta",
+    "6bd30047c1b1188029e8af6ee8a135cf86e7dc4b": "0.16.4-beta",
     "725ff104808f49f0a5247bfdb4b6b5da7f488d38": "0.13.0-beta",
     "7f34774529fa0964d47fc418d4d2965435cbfdc0": "0.11.1-beta",
     "86d3dec7b939b21bb10f2cd1ff56970c392a1c69": "0.13.2-beta",

package/lnd_methods/offchain/subscribe_to_forwards.js

@@ -4,9 +4,11 @@ const asyncDoUntil = require('async/doUntil');
 const {chanFormat} = require('bolt07');
 
 const {forwardFromHtlcEvent} = require('./../../lnd_responses');
+const {handleRemoveListener} = require('./../../grpc');
 const {isLnd} = require('./../../lnd_requests');
 
 const event = 'forward';
+const events = ['error', 'forward'];
 const method = 'subscribeHtlcEvents';
 const restartForwardListenerDelayMs = 1e3;
 const type = 'router';
@@ -70,6 +72,9 @@ module.exports = ({lnd}) => {
 
   const sub = lnd[type][method]({});
 
+  // Terminate subscription when all listeners are removed
+  handleRemoveListener({events, emitter, subscription: sub});
+
   sub.on('data', data => {
     // Exit early on subscribed events
     if (!!data && !!data.subscribed_event) {

package/package.json

@@ -7,10 +7,10 @@
     "url": "https://github.com/alexbosworth/lightning/issues"
   },
   "dependencies": {
-    "@grpc/grpc-js": "1.8.17",
-    "@grpc/proto-loader": "0.7.7",
+    "@grpc/grpc-js": "1.8.18",
+    "@grpc/proto-loader": "0.7.8",
     "@types/express": "4.17.17",
-    "@types/node": "20.3.2",
+    "@types/node": "20.4.2",
     "@types/request": "2.48.8",
     "@types/ws": "8.5.5",
     "async": "3.2.4",
@@ -26,7 +26,7 @@
     "invoices": "3.0.0",
     "psbt": "3.0.0",
     "tiny-secp256k1": "2.2.3",
-    "type-fest": "3.12.0"
+    "type-fest": "4.0.0"
   },
   "description": "Lightning Network client library",
   "devDependencies": {
@@ -51,12 +51,12 @@
     "url": "https://github.com/alexbosworth/lightning.git"
   },
   "scripts": {
-    "test": "npx nyc@15.1 node --experimental-test-coverage --test && npm run test:types",
+    "test": "npx nyc@15.1.0 node --experimental-test-coverage --test && npm run test:types",
     "test:types": "tsd"
   },
   "tsd": {
     "directory": "test/typescript"
   },
   "types": "index.d.ts",
-  "version": "9.8.0"
+  "version": "9.8.2"
 }

package/test/arrays/test_sort_by.js

@@ -1,4 +1,4 @@
-const {deepStrictEqual} = require('node:assert').strict;
+const {deepEqual} = require('node:assert').strict;
 const test = require('node:test');
 const {throws} = require('node:assert').strict;
 
@@ -39,7 +39,7 @@ tests.forEach(({args, description, error, expected}) => {
     } else {
       const {sorted} = sortBy(args);
 
-      deepStrictEqual(sorted, expected.sorted, 'Array is sorted as expected');
+      deepEqual(sorted, expected.sorted, 'Array is sorted as expected');
     }
 
     return end();

package/test/bolt00/test_mtokens_amount.js

@@ -1,4 +1,4 @@
-const {deepStrictEqual} = require('node:assert').strict;
+const {deepEqual} = require('node:assert').strict;
 const test = require('node:test');
 const {throws} = require('node:assert').strict;
 
@@ -49,7 +49,7 @@ tests.forEach(({args, description, error, expected}) => {
     } else {
       const {mtokens} = mtokensAmount(args);
 
-      deepStrictEqual(mtokens, expected.mtokens, 'Got expected output');
+      deepEqual(mtokens, expected.mtokens, 'Got expected output');
     }
 
     return end();

package/test/bolt00/test_safe_tokens.js

@@ -1,4 +1,4 @@
-const {deepStrictEqual} = require('node:assert').strict;
+const {deepEqual} = require('node:assert').strict;
 const test = require('node:test');
 
 const {safeTokens} = require('./../../bolt00');
@@ -30,8 +30,8 @@ tests.forEach(({args, description, expected}) => {
   return test(description, (t, end) => {
     const {safe, tokens} = safeTokens(args);
 
-    deepStrictEqual(safe, expected.safe, 'Got expected safe tokens');
-    deepStrictEqual(tokens, expected.tokens, 'Got expected tokens');
+    deepEqual(safe, expected.safe, 'Got expected safe tokens');
+    deepEqual(tokens, expected.tokens, 'Got expected tokens');
 
     return end();
   });

package/test/lnd_methods/offchain/test_subscribe_to_forwards.js

@@ -7,6 +7,8 @@ const {subscribeToForwards} = require('./../../../');
 
 const emitter = new EventEmitter();
 
+emitter.cancel = () => {};
+
 const makeForwardResponse = () => {
   return {
     event_type: 'UNKNOWN',