lightning 5.9.1 → 5.11.0

package/CHANGELOG.md

@@ -1,5 +1,18 @@
 # Versions
 
+## 5.11.0
+
+- `updateAlias`: Add method to update the node graph announcement alias
+- `updateColor`: Add method to update the node graph announcement color
+
+## 5.10.1
+
+- Always use TLV when paying along routes
+
+## 5.10.0
+
+- `signTransaction`: Add `spending` attribute for specifying external inputs
+
 ## 5.9.1
 
 - `createChainAddress`: Add support for creating P2TR addresses

package/README.md

@@ -9,28 +9,28 @@ Methods for working with the Lightning Network
 - [bitpay.com crypto-rpc](https://bitpay.com/) -
     https://github.com/bitpay/crypto-rpc
 - [coinos.io](https://coinos.io/) - https://github.com/coinos/coinos-server
+- [Galoy](https://galoy.io/) - https://github.com/GaloyMoney/galoy
+- [Lightning Poker](https://lightning-poker.com/) -
+    https://github.com/igreshev/lightning-poker
+- [Lightning Roulette](https://lightning-roulette.com/) -
+    https://github.com/igreshev/lightning-roulette
 - [Lightning Shell](https://lightningshell.app/) -
     https://github.com/ibz/lightning-shell
 - [LNMarkets](https://twitter.com/lnmarkets) -
     https://github.com/lnmarkets/umbrel
-- [Galoy](https://galoy.io/) - https://github.com/GaloyMoney/galoy
-- [Tarnhelm](https://www.tarnhelm.app/) - https://github.com/bkiac/tarnhelm
-- [tbtcswaps](https://tbtcswaps.com/) -
-    https://github.com/keep-community/tbtcswaps
-- [stackernews](https://stacker.news/) -
-    https://github.com/stackernews/stacker.news
-- [Thunderhub](https://www.thunderhub.io/) -
-    https://github.com/apotdevin/thunderhub
-- [Lightning Roulette](https://lightning-roulette.com/) -
-    https://github.com/igreshev/lightning-roulette
-- [Lightning Poker](https://lightning-poker.com/) -
-    https://github.com/igreshev/lightning-poker
 - [p2plnbot](https://telegram.me/lnp2pbot) - https://github.com/grunch/p2plnbot
 - [rekr](https://rekr.app/) - https://github.com/ryan-lingle/rekr
+- [stackernews](https://stacker.news/) -
+    https://github.com/stackernews/stacker.news
 - [Suredbits API](https://suredbits.com/) -
     https://github.com/Suredbits/sb-api-lnd
 - [Synonym demo server](https://synonym.to) -
     https://github.com/synonymdev/slash-pay-demo-server
+- [Tarnhelm](https://www.tarnhelm.app/) - https://github.com/bkiac/tarnhelm
+- [tbtcswaps](https://tbtcswaps.com/) -
+    https://github.com/keep-community/tbtcswaps
+- [Thunderhub](https://www.thunderhub.io/) -
+    https://github.com/apotdevin/thunderhub
 
 ## LND Authentication
 

package/grpc/grpc_services.json

@@ -7,6 +7,7 @@
     "ChainNotifier": "chainrpc",
     "Invoices": "invoicesrpc",
     "Lightning": "lnrpc",
+    "Peers": "peersrpc",
     "Router": "routerrpc",
     "Signer": "signrpc",
     "State": "lnrpc",
@@ -21,6 +22,7 @@
     "ChainNotifier": "chainnotifier.proto",
     "Invoices": "invoices.proto",
     "Lightning": "lightning.proto",
+    "Peers": "peers.proto",
     "Router": "router.proto",
     "Signer": "signer.proto",
     "State": "stateservice.proto",
@@ -36,6 +38,7 @@
     "chain": "ChainNotifier",
     "default": "Lightning",
     "invoices": "Invoices",
+    "peers": "Peers",
     "router": "Router",
     "signer": "Signer",
     "tower_client": "WatchtowerClient",

package/grpc/protos/peers.proto

@@ -0,0 +1,94 @@
+syntax = "proto3";
+
+import "lightning.proto";
+
+package peersrpc;
+
+option go_package = "github.com/lightningnetwork/lnd/lnrpc/peersrpc";
+
+// Peers is a service that can be used to get information and interact
+// with the other nodes of the newtwork.
+service Peers {
+    /* lncli: peers updatenodeannouncement
+    UpdateNodeAnnouncement allows the caller to update the node parameters
+    and broadcasts a new version of the node announcement to its peers.
+    */
+    rpc UpdateNodeAnnouncement (NodeAnnouncementUpdateRequest)
+        returns (NodeAnnouncementUpdateResponse);
+}
+
+// UpdateAction is used to determine the kind of action we are referring to.
+enum UpdateAction {
+    // ADD indicates this is an "insertion" kind of action.
+    ADD = 0;
+
+    // REMOVE indicates this is a "deletion" kind of action.
+    REMOVE = 1;
+}
+
+enum FeatureSet {
+    /*
+    SET_INIT identifies features that should be sent in an Init message to
+    a remote peer.
+    */
+    SET_INIT = 0;
+
+    /*
+    SET_LEGACY_GLOBAL identifies features that should be set in the legacy
+    GlobalFeatures field of an Init message, which maintains backwards
+    compatibility with nodes that haven't implemented flat features.
+    */
+    SET_LEGACY_GLOBAL = 1;
+
+    /*
+    SET_NODE_ANN identifies features that should be advertised on node
+    announcements.
+    */
+    SET_NODE_ANN = 2;
+
+    /*
+    SET_INVOICE identifies features that should be advertised on invoices
+    generated by the daemon.
+    */
+    SET_INVOICE = 3;
+
+    /*
+    SET_INVOICE_AMP identifies the features that should be advertised on
+    AMP invoices generated by the daemon.
+    */
+    SET_INVOICE_AMP = 4;
+}
+
+message UpdateAddressAction {
+    // Determines the kind of action.
+    UpdateAction action = 1;
+
+    // The address used to apply the update action.
+    string address = 2;
+}
+
+message UpdateFeatureAction {
+    // Determines the kind of action.
+    UpdateAction action = 1;
+
+    // The feature bit used to apply the update action.
+    lnrpc.FeatureBit feature_bit = 2;
+}
+
+message NodeAnnouncementUpdateRequest {
+    // Set of changes for the features that the node supports.
+    repeated UpdateFeatureAction feature_updates = 1;
+
+    // Color is the node's color in hex code format.
+    string color = 2;
+
+    // Alias or nick name of the node.
+    string alias = 3;
+
+    // Set of changes for the node's known addresses.
+    repeated UpdateAddressAction address_updates = 4;
+}
+
+message NodeAnnouncementUpdateResponse {
+    repeated lnrpc.Op ops = 1;
+}

package/index.js

@@ -127,7 +127,9 @@ const {subscribeToWalletStatus} = require('./lnd_methods');
 const {unauthenticatedLndGrpc} = require('./lnd_grpc');
 const {unlockUtxo} = require('./lnd_methods');
 const {unlockWallet} = require('./lnd_methods');
+const {updateAlias} = require('./lnd_methods');
 const {updateChainTransaction} = require('./lnd_methods');
+const {updateColor} = require('./lnd_methods');
 const {updateConnectedWatchtower} = require('./lnd_methods');
 const {updatePathfindingSettings} = require('./lnd_methods');
 const {updateRoutingFees} = require('./lnd_methods');
@@ -267,6 +269,8 @@ module.exports = {
   unauthenticatedLndGrpc,
   unlockUtxo,
   unlockWallet,
+  updateAlias,
+  updateColor,
   updateChainTransaction,
   updateConnectedWatchtower,
   updatePathfindingSettings,

package/lnd_grpc/authenticated_lnd_grpc.js

@@ -37,6 +37,7 @@ const pathForProto = proto => join(__dirname, protosDir, proto);
       chain: <ChainNotifier API Methods Object>
       default: <Default API Methods Object>
       invoices: <Invoices API Methods Object>
+      peers: <Peers API Methods Object>
       router: <Router API Methods Object>
       signer: <Signer Methods API Object>
       tower_client: <Watchtower Client Methods Object>

package/lnd_methods/index.js

@@ -123,7 +123,9 @@ const {subscribeToTransactions} = require('./onchain');
 const {subscribeToWalletStatus} = require('./unauthenticated');
 const {unlockUtxo} = require('./onchain');
 const {unlockWallet} = require('./unauthenticated');
+const {updateAlias} = require('./peers');
 const {updateChainTransaction} = require('./onchain');
+const {updateColor} = require('./peers');
 const {updateConnectedWatchtower} = require('./offchain');
 const {updatePathfindingSettings} = require('./offchain');
 const {updateRoutingFees} = require('./offchain');
@@ -259,7 +261,9 @@ module.exports = {
   subscribeToWalletStatus,
   unlockUtxo,
   unlockWallet,
+  updateAlias,
   updateChainTransaction,
+  updateColor,
   updateConnectedWatchtower,
   updatePathfindingSettings,
   updateRoutingFees,

package/lnd_methods/info/get_wallet_info.js

@@ -12,6 +12,8 @@ const noConnectionMessage = 'No connection established';
 
 /** Get overall wallet info.
 
+  Requires `info:read` permission
+
   {
     lnd: <Authenticated LND API Object>
   }

package/lnd_methods/macaroon/methods.json

@@ -490,14 +490,22 @@
     "method": "releaseOutput",
     "type": "wallet"
   },
-  "updateConnectedWatchtower": {
-    "methods": ["AddTower", "RemoveTower"],
-    "type": "tower_client"
+  "updateAlias": {
+    "method": "updateNodeAnnouncement",
+    "type": "peers"
   },
   "updateChainTransaction": {
     "method": "LabelTransaction",
     "type": "wallet"
   },
+  "updateColor": {
+    "method": "updateNodeAnnouncement",
+    "type": "peers"
+  },
+  "updateConnectedWatchtower": {
+    "methods": ["AddTower", "RemoveTower"],
+    "type": "tower_client"
+  },
   "updatePathfindingSettings": {
     "method": "SetMissionControlConfig",
     "type": "router"

package/lnd_methods/onchain/partially_sign_psbt.d.ts

@@ -20,7 +20,7 @@ export type PartiallySignPsbtResult = {
  *
  * Requires LND built with `walletrpc` tag
  *
- * This method is not supported in LND 0.14.3 and below
+ * This method is not supported in LND 0.14.1 and below
  */
 export const partiallySignPsbt: AuthenticatedLightningMethod<
   PartiallySignPsbtArgs,

package/lnd_methods/onchain/partially_sign_psbt.js

@@ -16,7 +16,7 @@ const type = 'wallet';
 
   Requires LND built with `walletrpc` tag
 
-  This method is not supported in LND 0.14.3 and below
+  This method is not supported in LND 0.14.1 and below
 
   {
     lnd: <Authenticated LND API Object>

package/lnd_methods/onchain/subscribe_to_chain_address.js

@@ -25,7 +25,7 @@ const type = 'chain';
 
   {
     [bech32_address]: <Address String>
-    lnd: <Chain RPC LND API Object>
+    lnd: <Authenticated LND API Object>
     [min_confirmations]: <Minimum Confirmations Number>
     min_height: <Minimum Transaction Inclusion Blockchain Height Number>
     [output_script]: <Output Script Hex String>

package/lnd_methods/peers/index.js

@@ -2,5 +2,14 @@ const addPeer = require('./add_peer');
 const getPeers = require('./get_peers');
 const removePeer = require('./remove_peer');
 const subscribeToPeers = require('./subscribe_to_peers');
+const updateAlias = require('./update_alias');
+const updateColor = require('./update_color');
 
-module.exports = {addPeer, getPeers, removePeer, subscribeToPeers};
+module.exports = {
+  addPeer,
+  getPeers,
+  removePeer,
+  subscribeToPeers,
+  updateAlias,
+  updateColor,
+};

package/lnd_methods/peers/update_alias.js

@@ -0,0 +1,58 @@
+const asyncAuto = require('async/auto');
+const {returnResult} = require('asyncjs-util');
+
+const {isLnd} = require('./../../lnd_requests');
+
+const errorUnimplemented = 'unknown service peersrpc.Peers';
+const method = 'updateNodeAnnouncement';
+const type = 'peers';
+
+/** Update the node alias as advertised in the graph
+
+  Note: this method is not supported in LND versions 0.14.3 and below
+
+  Requires LND built with `peersrpc` build tag
+
+  Requires `peers:write` permissions
+
+  {
+    color: <Node Color #000000 String>
+    lnd: <Authenticated LND API Object>
+  }
+
+  @returns via cbk or Promise
+*/
+module.exports = ({alias, lnd}, cbk) => {
+  return new Promise((resolve, reject) => {
+    return asyncAuto({
+      // Check arguments
+      validate: cbk => {
+        if (alias === undefined) {
+          return cbk([400, 'ExpectedAliasToUpdateNodeAnnouncementAlias']);
+        }
+
+        if (!isLnd({lnd, method, type})) {
+          return cbk([400, 'ExpectedLndToUpdateNodeAnnouncementAlias']);
+        }
+
+        return cbk();
+      },
+
+      // Update the node alias with the updated alias
+      updateAlias: ['validate', ({}, cbk) => {
+        return lnd[type][method]({alias}, (err, res) => {
+          if (!!err && err.details === errorUnimplemented) {
+            return cbk([400, 'ExpectedPeersRpcLndBuildTagToUpdateAlias']);
+          }
+
+          if (!!err) {
+            return cbk([503, 'UnexpectedErrorUpdatingNodeAlias', {err}]);
+          }
+
+          return cbk();
+        });
+      }],
+    },
+    returnResult({reject, resolve}, cbk));
+  });
+};

package/lnd_methods/peers/update_color.js

@@ -0,0 +1,58 @@
+const asyncAuto = require('async/auto');
+const {returnResult} = require('asyncjs-util');
+
+const {isLnd} = require('./../../lnd_requests');
+
+const errorUnimplemented = 'unknown service peersrpc.Peers';
+const method = 'updateNodeAnnouncement';
+const type = 'peers';
+
+/** Update the node color as advertised in the graph
+
+  Note: this method is not supported in LND versions 0.14.3 and below
+
+  Requires LND built with `signrpc` build tag
+
+  Requires `peers:write` permissions
+
+  {
+    color: <Node Color String>
+    lnd: <Authenticated LND API Object>
+  }
+
+  @returns via cbk or Promise
+*/
+module.exports = ({color, lnd}, cbk) => {
+  return new Promise((resolve, reject) => {
+    return asyncAuto({
+      // Check arguments
+      validate: cbk => {
+        if (!color) {
+          return cbk([400, 'ExpectedColorToUpdateNodeAnnouncementColor']);
+        }
+
+        if (!isLnd({lnd, method, type})) {
+          return cbk([400, 'ExpectedLndToUpdateNodeAnnouncementColor']);
+        }
+
+        return cbk();
+      },
+
+      // Update the node alias with the updated alias
+      updateAlias: ['validate', ({}, cbk) => {
+        return lnd[type][method]({color}, (err, res) => {
+          if (!!err && err.details === errorUnimplemented) {
+            return cbk([400, 'ExpectedPeersRpcLndBuildTagToUpdateColor']);
+          }
+
+          if (!!err) {
+            return cbk([503, 'UnexpectedErrorUpdatingNodeColor', {err}]);
+          }
+
+          return cbk();
+        });
+      }],
+    },
+    returnResult({reject, resolve}, cbk));
+  });
+};

package/lnd_methods/signer/sign_transaction.d.ts

@@ -20,6 +20,12 @@ export type SignTransactionArgs = AuthenticatedLightningArgs<{
     /** Witness Script Hex String */
     witness_script: string;
   }[];
+  spending?: {
+    /** Non-Internal Spend Output Script Hex String */
+    output_script: string;
+    /** Non-Internal Spend Output Tokens Number */
+    output_tokens: number;
+  }[];
   /** Unsigned Transaction Hex String */
   transaction: string;
 }>;
@@ -35,6 +41,8 @@ export type SignTransactionResult = {
  * Requires LND built with `signrpc` build tag
  *
  * Requires `signer:generate` permission
+ *
+ * `spending` is not supported in LND 0.14.3 and below
  */
 export const signTransaction: AuthenticatedLightningMethod<
   SignTransactionArgs,

package/lnd_methods/signer/sign_transaction.js

@@ -3,16 +3,24 @@ const {returnResult} = require('asyncjs-util');
 
 const {isLnd} = require('./../../lnd_requests');
 
+const bufferAsHex = buffer => buffer.toString('hex');
+const hexAsBuffer = hex => Buffer.from(hex, 'hex');
 const {isArray} = Array;
+const method = 'signOutputRaw';
 const notFound = -1;
+const type = 'signer';
 const unimplementedError = '12 UNIMPLEMENTED: unknown service signrpc.Signer';
 
 /** Sign transaction
 
+  `spending` is required for non-internal inputs for a Taproot signature
+
   Requires LND built with `signrpc` build tag
 
   Requires `signer:generate` permission
 
+  `spending` is not supported in LND 0.14.3 and below
+
   {
     inputs: [{
       key_family: <Key Family Number>
@@ -24,6 +32,10 @@ const unimplementedError = '12 UNIMPLEMENTED: unknown service signrpc.Signer';
       witness_script: <Witness Script Hex String>
     }]
     lnd: <Authenticated LND API Object>
+    [spending]: [{
+      output_script: <Non-Internal Spend Output Script Hex String>
+      output_tokens: <Non-Internal Spend Output Tokens Number>
+    }]
     transaction: <Unsigned Transaction Hex String>
   }
 
@@ -32,7 +44,7 @@ const unimplementedError = '12 UNIMPLEMENTED: unknown service signrpc.Signer';
     signatures: [<Signature Hex String>]
   }
 */
-module.exports = ({inputs, lnd, transaction}, cbk) => {
+module.exports = ({inputs, lnd, spending, transaction}, cbk) => {
   return new Promise((resolve, reject) => {
     return asyncAuto({
       // Check arguments
@@ -41,7 +53,7 @@ module.exports = ({inputs, lnd, transaction}, cbk) => {
           return cbk([400, 'ExpectedInputsToSignTransaction']);
         }
 
-        if (!isLnd({lnd, method: 'signOutputRaw', type: 'signer'})) {
+        if (!isLnd({lnd, method, type})) {
           return cbk([400, 'ExpectedAuthenticatedLndToSignTransaction']);
         }
 
@@ -54,8 +66,12 @@ module.exports = ({inputs, lnd, transaction}, cbk) => {
 
       // Get signatures
       signTransaction: ['validate', ({}, cbk) => {
-        return lnd.signer.signOutputRaw({
-          raw_tx_bytes: Buffer.from(transaction, 'hex'),
+        return lnd[type][method]({
+          prev_outputs: [].concat(inputs).concat(spending || []).map(utxo => ({
+            pk_script: hexAsBuffer(utxo.output_script),
+            value: utxo.output_tokens,
+          })),
+          raw_tx_bytes: hexAsBuffer(transaction),
           sign_descs: inputs.map(input => ({
             input_index: input.vin,
             key_desc: {
@@ -65,11 +81,11 @@ module.exports = ({inputs, lnd, transaction}, cbk) => {
               },
             },
             output: {
-              pk_script: Buffer.from(input.output_script, 'hex'),
+              pk_script: hexAsBuffer(input.output_script),
               value: input.output_tokens,
             },
             sighash: input.sighash,
-            witness_script: Buffer.from(input.witness_script, 'hex'),
+            witness_script: hexAsBuffer(input.witness_script),
           })),
         },
         (err, res) => {
@@ -93,9 +109,7 @@ module.exports = ({inputs, lnd, transaction}, cbk) => {
             return cbk([503, 'ExpectedSignatureBuffersInSignResponse']);
           }
 
-          return cbk(null, {
-            signatures: res.raw_sigs.map(n => n.toString('hex'))
-          });
+          return cbk(null, {signatures: res.raw_sigs.map(bufferAsHex)});
         });
       }],
     },

package/lnd_requests/rpc_hop_from_hop.js

@@ -60,6 +60,7 @@ module.exports = args => {
     fee: millitokensAsTokens(args.fee_mtokens).toString(),
     fee_msat: args.fee_mtokens,
     pub_key: args.public_key,
+    tlv_payload: true,
   };
 
   // Exit early when there are no messages to encode in this hop
@@ -67,9 +68,6 @@ module.exports = args => {
     return hop;
   }
 
-  // Set custom TLV payload records for this hop
-  hop.tlv_payload = true;
-
   hop.custom_records = args.messages.reduce((tlv, n) => {
     tlv[n.type] = hexAsBuffer(n.value);
 

package/package.json

@@ -7,10 +7,10 @@
     "url": "https://github.com/alexbosworth/lightning/issues"
   },
   "dependencies": {
-    "@grpc/grpc-js": "1.6.1",
+    "@grpc/grpc-js": "1.6.6",
     "@grpc/proto-loader": "0.6.9",
     "@types/express": "4.17.13",
-    "@types/node": "17.0.23",
+    "@types/node": "17.0.25",
     "@types/request": "2.48.8",
     "@types/ws": "8.5.3",
     "async": "3.2.3",
@@ -23,7 +23,7 @@
     "cbor": "8.1.0",
     "ecpair": "2.0.1",
     "express": "4.17.3",
-    "invoices": "2.0.5",
+    "invoices": "2.0.6",
     "psbt": "2.0.1",
     "tiny-secp256k1": "2.2.1",
     "type-fest": "2.12.2"
@@ -59,5 +59,5 @@
     "directory": "test/typescript"
   },
   "types": "index.d.ts",
-  "version": "5.9.1"
+  "version": "5.11.0"
 }

package/test/lnd_grpc/test_authenticated_lnd_grpc.js

@@ -7,6 +7,7 @@ const expectedServices = [
   'chain',
   'default',
   'invoices',
+  'peers',
   'router',
   'signer',
   'tower_client',

package/test/lnd_methods/peers/test_update_alias.js

@@ -0,0 +1,56 @@
+const {test} = require('@alexbosworth/tap');
+
+const {updateAlias} = require('./../../../');
+
+const makeLnd = ({err}) => {
+  return {peers: {updateNodeAnnouncement: (args, cbk) => cbk(err)}};
+};
+
+const makeArgs = overrides => {
+  const args = {alias: 'alias', lnd: makeLnd({})};
+
+  Object.keys(overrides).forEach(key => args[key] = overrides[key]);
+
+  return args;
+};
+
+const tests = [
+  {
+    args: makeArgs({alias: undefined}),
+    description: 'An alias is required to update alias to',
+    error: [400, 'ExpectedAliasToUpdateNodeAnnouncementAlias'],
+  },
+  {
+    args: makeArgs({lnd: undefined}),
+    description: 'LND is required to update alias',
+    error: [400, 'ExpectedLndToUpdateNodeAnnouncementAlias'],
+  },
+  {
+    args: makeArgs({
+      lnd: makeLnd({err: {details: 'unknown service peersrpc.Peers'}}),
+    }),
+    description: 'LND with peersrpc is required to update alias',
+    error: [400, 'ExpectedPeersRpcLndBuildTagToUpdateAlias'],
+  },
+  {
+    args: makeArgs({lnd: makeLnd({err: 'err'})}),
+    description: 'LND error is returned',
+    error: [503, 'UnexpectedErrorUpdatingNodeAlias', {err: 'err'}],
+  },
+  {
+    args: makeArgs({}),
+    description: 'Alias updated successfully',
+  },
+];
+
+tests.forEach(({args, description, error, expected}) => {
+  return test(description, async ({deepEqual, end, equal, rejects}) => {
+    if (!!error) {
+      await rejects(() => updateAlias(args), error, 'Got error');
+    } else {
+      await updateAlias(args);
+    }
+
+    return end();
+  });
+});

package/test/lnd_methods/peers/test_update_color.js

@@ -0,0 +1,56 @@
+const {test} = require('@alexbosworth/tap');
+
+const {updateColor} = require('./../../../');
+
+const makeLnd = ({err}) => {
+  return {peers: {updateNodeAnnouncement: (args, cbk) => cbk(err)}};
+};
+
+const makeArgs = overrides => {
+  const args = {color: '#012345', lnd: makeLnd({})};
+
+  Object.keys(overrides).forEach(key => args[key] = overrides[key]);
+
+  return args;
+};
+
+const tests = [
+  {
+    args: makeArgs({color: undefined}),
+    description: 'A color is required to update color to',
+    error: [400, 'ExpectedColorToUpdateNodeAnnouncementColor'],
+  },
+  {
+    args: makeArgs({lnd: undefined}),
+    description: 'LND is required to update color',
+    error: [400, 'ExpectedLndToUpdateNodeAnnouncementColor'],
+  },
+  {
+    args: makeArgs({
+      lnd: makeLnd({err: {details: 'unknown service peersrpc.Peers'}}),
+    }),
+    description: 'LND with peersrpc is required to update color',
+    error: [400, 'ExpectedPeersRpcLndBuildTagToUpdateColor'],
+  },
+  {
+    args: makeArgs({lnd: makeLnd({err: 'err'})}),
+    description: 'LND error is returned',
+    error: [503, 'UnexpectedErrorUpdatingNodeColor', {err: 'err'}],
+  },
+  {
+    args: makeArgs({}),
+    description: 'Color updated successfully',
+  },
+];
+
+tests.forEach(({args, description, error, expected}) => {
+  return test(description, async ({deepEqual, end, equal, rejects}) => {
+    if (!!error) {
+      await rejects(() => updateColor(args), error, 'Got error');
+    } else {
+      await updateColor(args);
+    }
+
+    return end();
+  });
+});

package/test/lnd_requests/test_rpc_hop_from_hop.js

@@ -39,6 +39,7 @@ const tests = [
       fee: '1',
       fee_msat: '1000',
       pub_key: 'public_key',
+      tlv_payload: true,
     },
   },
   {

package/test/typescript/sign_transaction.test-d.ts

@@ -14,6 +14,12 @@ const inputs = [
     witness_script: '00',
   },
 ];
+const spending = [
+  {
+    output_script: 'script',
+    output_tokens: 0,
+  },
+];
 const transaction = '00';
 
 expectError(signTransaction());
@@ -32,9 +38,22 @@ expectType<SignTransactionResult>(
     transaction,
   })
 );
+expectType<SignTransactionResult>(
+  await signTransaction({
+    lnd,
+    inputs,
+    transaction,
+    spending,
+  })
+);
 
 expectType<void>(
   signTransaction({lnd, inputs, transaction}, (error, result) => {
     expectType<SignTransactionResult>(result);
   })
 );
+expectType<void>(
+  signTransaction({lnd, inputs, transaction, spending}, (error, result) => {
+    expectType<SignTransactionResult>(result);
+  })
+);