lightning 5.8.3 → 5.8.4

package/CHANGELOG.md

@@ -1,5 +1,9 @@
 # Versions
 
+## 5.8.4
+
+- `getWalletInfo`, `payViaPaymentDetails`: Correct typescript fields
+
 ## 5.8.3
 
 - `getInvoice`: Add typescript timeout field on individual payment HTLCs

package/lnd_methods/info/get_wallet_info.d.ts

@@ -34,6 +34,8 @@ export type GetWalletInfoResult = {
   pending_channels_count: number;
   /** Public Key */
   public_key: string;
+  /** Version String */
+  version: string;
 };
 
 /**

package/lnd_methods/offchain/pay_via_payment_details.d.ts

@@ -42,7 +42,7 @@ export type PayViaPaymentDetailsArgs = AuthenticatedLightningArgs<{
   pathfinding_timeout?: number;
   /** Payment Identifier Hex String */
   payment?: string;
-  routes: {
+  routes?: {
     /** Base Routing Fee In Millitokens */
     base_fee_mtokens?: string;
     /** Standard Format Channel Id */

package/lnd_methods/offchain/pay_via_payment_details.js

@@ -42,7 +42,7 @@ const type = 'router';
     [outgoing_channels]: [<Pay Out of Outgoing Channel Ids String>]
     [pathfinding_timeout]: <Time to Spend Finding a Route Milliseconds Number>
     [payment]: <Payment Identifier Hex String>
-    routes: [[{
+    [routes]: [[{
       [base_fee_mtokens]: <Base Routing Fee In Millitokens String>
       [channel]: <Standard Format Channel Id String>
       [cltv_delta]: <CLTV Blocks Delta Number>

package/lnd_methods/onchain/subscribe_to_chain_address.js

@@ -113,7 +113,7 @@ module.exports = args => {
       return;
     }
 
-    eventEmitter.emit('error', new Error('UnexpectedErrInTxSubscription'));
+    eventEmitter.emit('error', err);
 
     return;
   });

package/package.json

@@ -7,12 +7,12 @@
     "url": "https://github.com/alexbosworth/lightning/issues"
   },
   "dependencies": {
-    "@grpc/grpc-js": "1.5.7",
+    "@grpc/grpc-js": "1.5.9",
     "@grpc/proto-loader": "0.6.9",
     "@types/express": "4.17.13",
-    "@types/node": "17.0.21",
+    "@types/node": "17.0.22",
     "@types/request": "2.48.8",
-    "@types/ws": "8.5.2",
+    "@types/ws": "8.5.3",
     "async": "3.2.3",
     "asyncjs-util": "1.2.8",
     "bitcoinjs-lib": "6.0.1",
@@ -26,7 +26,7 @@
     "invoices": "2.0.4",
     "psbt": "2.0.0",
     "tiny-secp256k1": "2.2.1",
-    "type-fest": "2.12.0"
+    "type-fest": "2.12.1"
   },
   "description": "Lightning Network client library",
   "devDependencies": {
@@ -59,5 +59,5 @@
     "directory": "test/typescript"
   },
   "types": "index.d.ts",
-  "version": "5.8.3"
+  "version": "5.8.4"
 }

package/test/lnd_methods/onchain/test_fund_pending_channels.js

@@ -3,6 +3,7 @@ const {test} = require('@alexbosworth/tap');
 const {fundPendingChannels} = require('./../../../lnd_methods');
 
 const id = Buffer.alloc(32).toString('hex');
+const id2 = Buffer.alloc(32, 1).toString('hex');
 
 const makeLnd = ({finalizeErr, verifyErr}) => {
   return {
@@ -75,6 +76,35 @@ const tests = [
     args: makeArgs({}),
     description: 'Channel funding is executed',
   },
+  {
+    args: makeArgs({
+      channels: [id, id2],
+      lnd: {
+        default: {
+          fundingStateStep: (args, cbk) => {
+            const finalize = args.psbt_finalize;
+
+            if (!finalize) {
+              return cbk();
+            }
+
+            const pendingId = finalize.pending_chan_id.toString('hex');
+
+            if (pendingId === id && finalize.no_publish !== true) {
+              return cbk('ExpectedFirstChannelIsNoPublish');
+            }
+
+            if (pendingId === id2 && finalize.no_publish !== false) {
+              return cbk('ExpectedLastChannelIsNotNoPublish');
+            }
+
+            return cbk();
+          },
+        },
+      },
+    }),
+    description: 'Channel funding across multiple channels is executed',
+  },
 ];
 
 tests.forEach(({args, description, error, expected}) => {

package/test/lnd_methods/onchain/test_open_channels.js

@@ -5,6 +5,8 @@ const {test} = require('@alexbosworth/tap');
 const {openChannels} = require('./../../../lnd_methods');
 
 const emitter = new EventEmitter();
+const nodeKey1 = Buffer.alloc(33).toString('hex');
+const nodeKey2 = Buffer.alloc(33, 2).toString('hex');
 
 const makeChannels = ({}) => {
   return [{
@@ -128,6 +130,57 @@ const tests = [
     description: 'Channels are pending',
     expected: {pending: {address: 'funding_address', tokens: 1}},
   },
+  {
+    args: {
+      channels: [
+        {capacity: 1, partner_public_key: nodeKey1},
+        {capacity: 2, partner_public_key: nodeKey2},
+      ],
+      lnd: {
+        default: {
+          fundingStateStep: ({}, cbk) => cbk(),
+          openChannel: args => {
+            const eventEmitter = new EventEmitter();
+
+            const key = args.node_pubkey.toString('hex');
+
+            if (key === nodeKey1 && !args.funding_shim.psbt_shim.no_publish) {
+              throw new Error('ExpectedFirstKeyIsNoPublish');
+            }
+
+            if (key === nodeKey2 && !!args.funding_shim.psbt_shim.no_publish) {
+              throw new Error('TheSecondChannelShouldPublish');
+            }
+
+            process.nextTick(() => {
+              eventEmitter.emit('data', {});
+
+              eventEmitter.emit('data', {
+                psbt_fund: {
+                  funding_address: 'funding_address',
+                  funding_amount: '1',
+                },
+                update: 'psbt_fund',
+              });
+
+              // Emit twice to make sure that cbk isn't called twice
+              eventEmitter.emit('data', {
+                psbt_fund: {
+                  funding_address: 'funding_address',
+                  funding_amount: '1',
+                },
+                update: 'psbt_fund',
+              });
+            });
+
+            return eventEmitter;
+          },
+        },
+      },
+    },
+    description: 'Multiple channels are pending',
+    expected: {pending: {address: 'funding_address', tokens: 1}},
+  },
 ];
 
 tests.forEach(({args, description, error, expected}) => {

package/test/typescript/pay_via_payment_details.test-d.ts

@@ -44,7 +44,6 @@ expectError(payViaPaymentDetails({destination}));
 expectError(payViaPaymentDetails({destination, routes}));
 expectError(payViaPaymentDetails({routes}));
 expectError(payViaPaymentDetails({lnd}));
-expectError(payViaPaymentDetails({lnd, destination}));
 expectError(payViaPaymentDetails({lnd, routes}));
 
 expectType<PayViaPaymentDetailsResult>(