lightning 5.20.1 → 5.21.1

package/CHANGELOG.md

@@ -2,6 +2,14 @@
 
 ## 5.21.1
 
+- `getChainFeeEstimate`: Add support for specifying min `utxo_confirmations`
+
+## 5.20.2
+
+- `getWalletInfo`: Add support for detecting lnd versions 0.15.0 and 0.15.1
+
+## 5.20.1
+
 - Update typescript definitions
 
 ## 5.20.0

package/README.md

@@ -18,6 +18,7 @@ Methods for working with the Lightning Network
     https://github.com/ibz/lightning-shell
 - [LNMarkets](https://twitter.com/lnmarkets) -
     https://github.com/lnmarkets/umbrel
+- [LNPingBot](https://github.com/swissrouting/lnpingbot) - https://github.com/swissrouting/lnpingbot
 - [mempool.space](https://mempool.space/) - https://github.com/mempool/mempool
 - [p2plnbot](https://telegram.me/lnp2pbot) - https://github.com/grunch/p2plnbot
 - [rekr](https://rekr.app/) - https://github.com/ryan-lingle/rekr

package/lnd_methods/info/constants.json

@@ -25,6 +25,7 @@
     "4f567577db9d85b6f392f960b3aabddcad3cd02c": "0.13.3-beta",
     "52bb3f33707b81972c67937c7a89addcdf00991c": "0.10.1-beta",
     "596fd90ef310cd7abbf2251edaae9ba4d5f8a689": "0.13.1-beta",
+    "5c36d96c9cbe8b27c29f9682dcbdab7928ae870f": "0.15.0-beta",
     "6042004edaaa5b3cad0a0808ff23dba4716f7178": "0.14.1-beta",
     "61c34683058f2cc8dc10f49392a0057440d831c4": "0.13.4-beta",
     "725ff104808f49f0a5247bfdb4b6b5da7f488d38": "0.13.0-beta",
@@ -35,7 +36,8 @@
     "d176d2d65fc06e6631c4dc9478592be8545a21de": "0.12.0-beta",
     "d233f61383f2f950aa06f5b09da5b0e78e784fae": "0.12.1-beta",
     "d62c575f8499a314eb27f12462d20500b6bda2c7": "0.10.3-beta",
-    "df0b82f0165f19bde8832bacd1e35544b0a2990d": "0.14.0-beta"
+    "df0b82f0165f19bde8832bacd1e35544b0a2990d": "0.14.0-beta",
+    "fd1a95bf322cdd1c743a1554f8e470fbf9a5e564": "0.15.1-beta"
   },
   "weightedType": "weightedcomb",
   "wrongLnd": "12 UNIMPLEMENTED: unknown service autopilotrpc.Autopilot"

package/lnd_methods/onchain/get_chain_fee_estimate.d.ts

@@ -12,6 +12,8 @@ export type GetChainFeeEstimateArgs = AuthenticatedLightningArgs<{
   }[];
   /** Target Confirmations */
   target_confirmations?: number;
+  /** Minimum Confirmations for UTXO Selection */
+  utxo_confirmations?: number;
 }>;
 
 export type GetChainFeeEstimateResult = {

package/lnd_methods/onchain/get_chain_fee_estimate.js

@@ -8,11 +8,14 @@ const {isArray} = Array;
 const method = 'estimateFee';
 const notFound = -1;
 const type = 'default';
+const unconfirmedConfCount = 0;
 
 /** Get a chain fee estimate for a prospective chain send
 
   Requires `onchain:read` permission
 
+  Specifying 0 for `utxo_confirmations` is not supported in LND 0.13.0 or below
+
   {
     lnd: <Authenticated LND API Object>
     send_to: [{
@@ -20,6 +23,7 @@ const type = 'default';
       tokens: <Tokens Number>
     }]
     [target_confirmations]: <Target Confirmations Number>
+    [utxo_confirmations]: <Minimum Confirmations for UTXO Selection Number>
   }
 
   @returns via cbk or Promise
@@ -65,6 +69,8 @@ module.exports = (args, cbk) => {
         return args.lnd[type][method]({
           AddrToAmount,
           target_conf: args.target_confirmations || undefined,
+          min_confs: args.utxo_confirmations || undefined,
+          spend_unconfirmed: args.utxo_confirmations === unconfirmedConfCount,
         },
         (err, res) => {
           if (!!err) {

package/lnd_methods/onchain/send_to_chain_address.js

@@ -5,6 +5,7 @@ const {isLnd} = require('./../../lnd_requests');
 
 const initialConfirmationCount = 0;
 const {isArray} = Array;
+const {isInteger} = Number;
 const lowBalanceErr = 'insufficient funds available to construct transaction';
 const method = 'sendCoins';
 const OPEN = 1;
@@ -53,6 +54,10 @@ module.exports = (args, cbk) => {
           return cbk([400, 'ExpectedLndForChainSendRequest']);
         }
 
+        if (!!args.tokens && !isInteger(args.tokens)) {
+          return cbk([400, 'ExpectedWholeNumberAmountToSendFundsOnChain']);
+        }
+
         if (!args.tokens && !args.is_send_all) {
           return cbk([400, 'MissingTokensToSendOnChain']);
         }

package/package.json

@@ -7,10 +7,10 @@
     "url": "https://github.com/alexbosworth/lightning/issues"
   },
   "dependencies": {
-    "@grpc/grpc-js": "1.6.10",
+    "@grpc/grpc-js": "1.7.0",
     "@grpc/proto-loader": "0.7.2",
     "@types/express": "4.17.13",
-    "@types/node": "18.7.13",
+    "@types/node": "18.7.16",
     "@types/request": "2.48.8",
     "@types/ws": "8.5.3",
     "async": "3.2.4",
@@ -23,7 +23,7 @@
     "cbor": "8.1.0",
     "ecpair": "2.0.1",
     "express": "4.18.1",
-    "invoices": "2.1.0",
+    "invoices": "2.2.0",
     "psbt": "2.7.1",
     "tiny-secp256k1": "2.2.1",
     "type-fest": "2.19.0"
@@ -32,8 +32,8 @@
   "devDependencies": {
     "@alexbosworth/node-fetch": "2.6.2",
     "@alexbosworth/tap": "15.0.11",
-    "tsd": "0.22.0",
-    "typescript": "4.8.2",
+    "tsd": "0.23.0",
+    "typescript": "4.8.3",
     "ws": "8.8.1"
   },
   "engines": {
@@ -59,5 +59,5 @@
     "directory": "test/typescript"
   },
   "types": "index.d.ts",
-  "version": "5.20.1"
+  "version": "5.21.1"
 }

package/test/lnd_methods/onchain/test_get_chain_fee_estimate.js

@@ -78,6 +78,22 @@ const tests = [
     description: 'Fee rate and fee are given in chain response',
     expected: {fee: 1, tokens_per_vbyte: 1},
   },
+  {
+    args: {
+      lnd: {
+        default: {
+          estimateFee: ({}, cbk) => cbk(null, {
+            fee_sat: '1',
+            feerate_sat_per_byte: '1',
+          }),
+        },
+      },
+      send_to: [{address: 'address', tokens: 1}],
+      utxo_confirmations: 0,
+    },
+    description: 'Passing 0 UTXO confirmations is supported',
+    expected: {fee: 1, tokens_per_vbyte: 1},
+  },
 ];
 
 tests.forEach(({args, description, error, expected}) => {

package/test/lnd_methods/onchain/test_send_to_chain_address.js

@@ -36,6 +36,11 @@ const tests = [
     description: 'Expected tokens to send to chain address',
     error: [400, 'MissingTokensToSendOnChain'],
   },
+  {
+    args: makeArgs({tokens: 0.1}),
+    description: 'Expected non-fractional tokens to send to chain address',
+    error: [400, 'ExpectedWholeNumberAmountToSendFundsOnChain'],
+  },
   {
     args: makeArgs({is_send_all: true, tokens: 1}),
     description: 'Expected either send all or tokens to send to chain address',