lightning 4.14.3 → 4.14.4

package/CHANGELOG.md

@@ -1,6 +1,6 @@
 # Versions
 
-## 4.14.3
+## 4.14.4
 
 - `getPayment`, `subscribeToPastPayment`: Add `pending` for pending payment details
 

package/index.js

@@ -75,10 +75,10 @@ const {lndGateway} = require('./lnd_gateway');
 const {lockUtxo} = require('./lnd_methods');
 const {openChannel} = require('./lnd_methods');
 const {openChannels} = require('./lnd_methods');
+const {pay} = require('./lnd_methods');
 const {payViaPaymentDetails} = require('./lnd_methods');
 const {payViaPaymentRequest} = require('./lnd_methods');
 const {payViaRoutes} = require('./lnd_methods');
-const {pay} = require('./lnd_methods');
 const {prepareForChannelProposal} = require('./lnd_methods');
 const {probeForRoute} = require('./lnd_methods');
 const {proposeChannel} = require('./lnd_methods');
@@ -123,8 +123,8 @@ const {subscribeToWalletStatus} = require('./lnd_methods');
 const {unauthenticatedLndGrpc} = require('./lnd_grpc');
 const {unlockUtxo} = require('./lnd_methods');
 const {unlockWallet} = require('./lnd_methods');
-const {updateConnectedWatchtower} = require('./lnd_methods');
 const {updateChainTransaction} = require('./lnd_methods');
+const {updateConnectedWatchtower} = require('./lnd_methods');
 const {updatePathfindingSettings} = require('./lnd_methods');
 const {updateRoutingFees} = require('./lnd_methods');
 const {verifyAccess} = require('./lnd_methods');
@@ -211,10 +211,10 @@ module.exports = {
   lockUtxo,
   openChannel,
   openChannels,
+  pay,
   payViaPaymentDetails,
   payViaPaymentRequest,
   payViaRoutes,
-  pay,
   prepareForChannelProposal,
   probeForRoute,
   proposeChannel,
@@ -259,8 +259,8 @@ module.exports = {
   unauthenticatedLndGrpc,
   unlockUtxo,
   unlockWallet,
-  updateConnectedWatchtower,
   updateChainTransaction,
+  updateConnectedWatchtower,
   updatePathfindingSettings,
   updateRoutingFees,
   verifyAccess,

package/lnd_methods/offchain/disconnect_watchtower.d.ts

@@ -6,8 +6,6 @@ import {
 export type DisconnectWatchtowerArgs = AuthenticatedLightningArgs<{
   /** Watchtower Public Key Hex String */
   public_key: string;
-  /** Retry Delay Milliseconds Number */
-  retry_delay?: number;
 }>;
 
 /**

package/lnd_methods/offchain/disconnect_watchtower.js

@@ -17,7 +17,6 @@ const unimplementedError = '12 UNIMPLEMENTED: unknown service wtclientrpc.Watcht
   {
     lnd: <Authenticated LND API Object>
     public_key: <Watchtower Public Key Hex String>
-    [retry_delay]: <Retry Delay Milliseconds Number>
   }
 
   @returns via cbk or Promise

package/lnd_methods/offchain/subscribe_to_past_payment.js

@@ -8,10 +8,12 @@ const {confirmedFromPayment} = require('./../../lnd_responses');
 const {confirmedFromPaymentStatus} = require('./../../lnd_responses');
 const emitPayment = require('./emit_payment');
 const {failureFromPayment} = require('./../../lnd_responses');
+const {handleRemoveListener} = require('./../../grpc');
 const {isLnd} = require('./../../lnd_requests');
 const {safeTokens} = require('./../../bolt00');
 const {states} = require('./payment_states');
 
+const events = ['confirmed', 'failed', 'paying'];
 const hexToBuffer = hex => Buffer.from(hex, 'hex');
 const {isArray} = Array;
 const isHash = n => /^[0-9A-F]{64}$/i.test(n);
@@ -141,6 +143,9 @@ module.exports = args => {
 
   const sub = args.lnd[type][method]({payment_hash: hash});
 
+  // Terminate subscription when all listeners are removed
+  handleRemoveListener({emitter, events, subscription: sub});
+
   sub.on('data', data => emitPayment({data, emitter}));
   sub.on('end', () => emitter.emit('end'));
   sub.on('error', err => emitError(err));

package/package.json

@@ -22,7 +22,7 @@
     "bolt09": "0.2.0",
     "cbor": "8.1.0",
     "express": "4.17.1",
-    "invoices": "2.0.1",
+    "invoices": "2.0.2",
     "psbt": "1.1.10"
   },
   "description": "Lightning Network client library",
@@ -56,5 +56,5 @@
     "directory": "test/typescript"
   },
   "types": "index.d.ts",
-  "version": "4.14.3"
+  "version": "4.14.4"
 }

package/test/lnd_methods/offchain/test_get_payment.js

@@ -52,6 +52,8 @@ const makeLnd = args => {
         };
         const emitter = new EventEmitter();
 
+        emitter.cancel = () => {};
+
         if (!!args.is_end) {
           process.nextTick(() => emitter.emit('end'));
         } else if (!!args.err) {

package/test/typescript/disconnect_watchtower.test-d.ts

@@ -10,13 +10,7 @@ expectError(disconnectWatchtower());
 expectError(disconnectWatchtower({}));
 expectError(disconnectWatchtower({lnd}));
 expectError(disconnectWatchtower({public_key}));
-expectError(disconnectWatchtower({retry_delay}));
-expectError(disconnectWatchtower({lnd, retry_delay}));
 
 expectType<void>(await disconnectWatchtower({lnd, public_key}));
-expectType<void>(await disconnectWatchtower({lnd, public_key, retry_delay}));
 
 expectType<void>(disconnectWatchtower({lnd, public_key}, () => {}));
-expectType<void>(
-  disconnectWatchtower({lnd, public_key, retry_delay}, () => {})
-);