lightning 10.10.1 → 10.10.3

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # Versions
 
+## 10.10.3
+
+- `getPeers`: Set minimum possible peer ping time to positive zero
+
+## 10.10.2
+
+- `getChainFeeEstimate`: Add default chain fee conf target when none is passed
+
 ## 10.10.1
 
 - `closeChannel`, `openChannel`, `sendToChainAddress`, `sendToChainAddresses`:

package/lnd_methods/onchain/get_chain_fee_estimate.js

@@ -3,6 +3,7 @@ const {returnResult} = require('asyncjs-util');
 
 const {isLnd} = require('./../../lnd_requests');
 
+const defaultConfTarget = 6;
 const hasNumber = n => !!n && n !== '0';
 const {isArray} = Array;
 const method = 'estimateFee';
@@ -75,7 +76,7 @@ module.exports = (args, cbk) => {
         return args.lnd[type][method]({
           AddrToAmount,
           coin_selection_strategy: strategy(args.utxo_selection),
-          target_conf: args.target_confirmations || undefined,
+          target_conf: args.target_confirmations || defaultConfTarget,
           min_confs: args.utxo_confirmations || undefined,
           spend_unconfirmed: args.utxo_confirmations === unconfirmedConfCount,
         },

package/lnd_responses/rpc_peer_as_peer.js

@@ -11,6 +11,7 @@ const isString = n => typeof n === 'string';
 const isZero = n => n === '0';
 const {keys} = Object;
 const microPerMilli = 1e3;
+const minTime = n => n < 1 ? 0 : n;
 
 /** Translate an RPC peer into a peer
 
@@ -124,7 +125,7 @@ module.exports = peer => {
     is_inbound: peer.inbound,
     is_sync_peer: isKnownSyncType ? isActiveSync(peer.sync_type) : undefined,
     last_reconnection: !!lastReconnected ? date(lastReconnected) : undefined,
-    ping_time: ceil(Number(peer.ping_time) / microPerMilli),
+    ping_time: minTime(ceil(Number(peer.ping_time) / microPerMilli)),
     public_key: peer.pub_key,
     reconnection_rate: !!peer.flap_count ? peer.flap_count : undefined,
     socket: peer.address,

package/package.json

@@ -53,5 +53,5 @@
     "directory": "test/typescript"
   },
   "types": "index.d.ts",
-  "version": "10.10.1"
+  "version": "10.10.3"
 }

package/test/lnd_responses/test_rpc_peer_as_peer.js

@@ -122,6 +122,11 @@ const tests = [
     description: 'RPC peer is mapped to peer details',
     expected: makeExpected({}),
   },
+  {
+    args: makePeer({ping_time: '-1'}),
+    description: 'Ping time is set to zero when negative',
+    expected: makeExpected({ping_time: 0}),
+  },
   {
     args: makePeer({sync_type: 'PASSIVE_SYNC'}),
     description: 'RPC passive sync peer is mapped to peer details',