lightning-base-components 1.21.2-alpha → 1.21.3-alpha

package/src/lightning/datatable/columnResizer.js

@@ -98,7 +98,7 @@ export function setMinColumnWidth(columns, widthsData, value) {
         'non-negative',
         getResizerDefaultState().minColumnWidth
     );
-
+    // Tracked state change.
     updateColumnWidthsMetadata(columns, widthsData);
 }
 
@@ -108,13 +108,14 @@ export function getMaxColumnWidth(widthsData) {
     return widthsData.maxColumnWidth;
 }
 export function setMaxColumnWidth(columns, widthsData, value) {
+    // Untracked state change.
     widthsData.maxColumnWidth = normalizeNumberAttribute(
         'maxColumnWidth',
         value,
         'non-negative',
         getResizerDefaultState().maxColumnWidth
     );
-
+    // Tracked state change.
     updateColumnWidthsMetadata(columns, widthsData);
 }
 
@@ -163,11 +164,10 @@ export function adjustColumnsSizeFromState(state) {
  * @param {number} width - the new width is gonna be applied
  */
 export function resizeColumn(columns, widthsData, colIndex, width) {
-    const columnToResize = columns[colIndex];
-    const columnsWidths = getColumnsWidths(widthsData);
-    const currentWidth = columnsWidths[colIndex];
-    const { minWidth, maxWidth } = columnToResize;
-
+    const col = columns[colIndex];
+    const columnWidths = getColumnsWidths(widthsData);
+    const currentWidth = columnWidths[colIndex];
+    const { minWidth, maxWidth } = col;
     const newWidth = clamp(width, minWidth, maxWidth);
     if (currentWidth !== newWidth) {
         const newDelta = newWidth - currentWidth;
@@ -175,25 +175,21 @@ export function resizeColumn(columns, widthsData, colIndex, width) {
         updateColumnWidth(columns, widthsData, colIndex, newWidth);
         // Workaround for header positioning issues in RTL
         updateColumnOffsets(columns, colIndex + 1, newDelta);
-        columnToResize.isResized = true;
+        // Tracked state change.
+        col.isResized = true;
     }
 }
 
 /**
  * Resize a column width with an additional delta
- * @param {object} columns - all columns of the table
- * @param {object} widthsData - data regarding column and table widths
- * @param {number} colIndex - the index of the column based on state.columns
- * @param {number} widthDelta - the delta that creates the new width
+ * @param {object} columns - The column definitions
+ * @param {object} widthsData - The widths data
+ * @param {number} colIndex - The index of the column based on state.columns
+ * @param {number} delta - The delta that creates the new width
  */
-export function resizeColumnWithDelta(
-    columns,
-    widthsData,
-    colIndex,
-    widthDelta
-) {
+export function resizeColumnWithDelta(columns, widthsData, colIndex, delta) {
     const currentWidth = getColumnsWidths(widthsData)[colIndex];
-    resizeColumn(columns, widthsData, colIndex, currentWidth + widthDelta);
+    resizeColumn(columns, widthsData, colIndex, currentWidth + delta);
 }
 
 function updateColumnWidth(columns, widthsData, colIndex, newWidth) {
@@ -206,19 +202,17 @@ function updateColumnWidth(columns, widthsData, colIndex, newWidth) {
 }
 
 export function updateColumnWidthsMetadata(columns, widthsData) {
-    for (let i = 0, { length } = columns; i < length; i += 1) {
-        const col = columns[i];
+    for (let colIndex = 0; colIndex < columns.length; colIndex += 1) {
+        const col = columns[colIndex];
         if (!col.internal) {
             col.minWidth = getMinColumnWidth(widthsData);
             col.maxWidth = getMaxColumnWidth(widthsData);
         }
 
-        if (col.initialWidth) {
-            col.initialWidth = clamp(
-                col.initialWidth,
-                col.minWidth,
-                col.maxWidth
-            );
+        const { initialWidth } = col;
+        if (initialWidth) {
+            const { minWidth: min, maxWidth: max } = col;
+            col.initialWidth = clamp(initialWidth, min, max);
         }
     }
 }
@@ -234,6 +228,7 @@ export function updateColumnWidthsMetadata(columns, widthsData) {
 function updateColumnOffsets(columns, colIndex, newDelta) {
     if (isRTL()) {
         for (let i = colIndex, { length } = columns; i < length; i += 1) {
+            // Tracked state change.
             columns[i].offset += newDelta;
         }
     }
@@ -241,17 +236,17 @@ function updateColumnOffsets(columns, colIndex, newDelta) {
 
 /**
  * Returns the current widths for customer columns
- * @param {object} columns - all columns of the table
- * @param {object} widthsData - data regarding column and table widths
- * @returns {Array} - the widths collection, every element
+ * @param {object} columns - The columns of the table
+ * @param {object} widthsData - The data regarding column and table widths
+ * @returns {Array} - The widths collection, every element
  * belong to a column with the same index in column prop
  */
 export function getCustomerColumnWidths(columns, widthsData) {
     const widths = [];
     const { columnWidths } = widthsData;
-    for (let i = 0, { length } = columns; i < length; i += 1) {
-        if (isCustomerColumn(columns[i])) {
-            widths.push(columnWidths[i]);
+    for (let colIndex = 0; colIndex < columns.length; colIndex += 1) {
+        if (isCustomerColumn(columns[colIndex])) {
+            widths.push(columnWidths[colIndex]);
         }
     }
     return widths;
@@ -264,9 +259,14 @@ export function getCustomerColumnWidths(columns, widthsData) {
  */
 export function isTableRenderedVisible(root) {
     const CONTAINER_SEL = '.slds-scrollable_y';
-    const elem = root.querySelector(CONTAINER_SEL);
+    const scrollerY = root.querySelector(CONTAINER_SEL);
     return (
-        elem && !!(elem.offsetParent || elem.offsetHeight || elem.offsetWidth)
+        scrollerY &&
+        !!(
+            scrollerY.offsetParent ||
+            scrollerY.offsetHeight ||
+            scrollerY.offsetWidth
+        )
     );
 }