lightning-base-components 1.21.1-alpha → 1.21.3-alpha

package/src/lightning/datepicker/datepicker.js

@@ -7,7 +7,8 @@ import labelMinAndMaxRangeMessage from '@salesforce/label/LightningDateTimePicke
 import labelRequired from '@salesforce/label/LightningControl.required';
 import labelSelectDateFor from '@salesforce/label/LightningDateTimePicker.selectDateFor';
 import labelHelpTextAlternativeText from '@salesforce/label/LightningInput.helptextAlternativeText';
-import { LightningElement, api, track } from 'lwc';
+import { api, track } from 'lwc';
+import LightningShadowBaseClass from 'lightning/shadowBaseClassPrivate';
 import {
     normalizeISODate,
     parseFormattedDate,
@@ -28,6 +29,7 @@ import {
     isIE11,
     computeAriaInvalid,
     reflectAttribute,
+    isCSR,
 } from 'lightning/utilsPrivate';
 import {
     generateUniqueId,
@@ -63,9 +65,7 @@ const DATE_STYLE = {
     LONG: 'long',
 };
 
-export default class LightningDatePicker extends LightningElement {
-    static delegatesFocus = true;
-
+export default class LightningDatePicker extends LightningShadowBaseClass {
     @track _disabled = false;
     @track _readonly = false;
     @track _required = false;
@@ -78,6 +78,8 @@ export default class LightningDatePicker extends LightningElement {
 
     _min;
     _max;
+    _userMaxValue;
+    _userMinValue;
     _displayMin;
     _displayMax;
     _dateStyle = DATE_STYLE.MEDIUM;
@@ -110,6 +112,17 @@ export default class LightningDatePicker extends LightningElement {
         }
     }
 
+    setNormalisedIsoDateMin() {
+        const normalizedDate = normalizeISODate(
+            this._userMinValue,
+            this._dateStyle
+        );
+        if (normalizedDate.isoValue) {
+            this._min = normalizedDate.isoValue;
+            this._displayMin = normalizedDate.displayValue;
+        }
+    }
+
     @api
     get min() {
         return this._min;
@@ -119,11 +132,19 @@ export default class LightningDatePicker extends LightningElement {
         // normalization of the given value is possible.
         this._min = value;
         this._displayMin = value;
+        this._userMinValue = value;
+
+        this.setNormalisedIsoDateMin();
+    }
 
-        const normalizedDate = normalizeISODate(value, this.dateStyle);
+    setNormalisedIsoDateMax() {
+        const normalizedDate = normalizeISODate(
+            this._userMaxValue,
+            this._dateStyle
+        );
         if (normalizedDate.isoValue) {
-            this._min = normalizedDate.isoValue;
-            this._displayMin = normalizedDate.displayValue;
+            this._max = normalizedDate.isoValue;
+            this._displayMax = normalizedDate.displayValue;
         }
     }
 
@@ -136,12 +157,9 @@ export default class LightningDatePicker extends LightningElement {
         // normalization of the given value is possible.
         this._max = value;
         this._displayMax = value;
+        this._userMaxValue = value;
 
-        const normalizedDate = normalizeISODate(value, this.dateStyle);
-        if (normalizedDate.isoValue) {
-            this._max = normalizedDate.isoValue;
-            this._displayMax = normalizedDate.displayValue;
-        }
+        this.setNormalisedIsoDateMax();
     }
 
     @api
@@ -252,6 +270,9 @@ export default class LightningDatePicker extends LightningElement {
     }
 
     synchronizeA11y() {
+        if (!this._rendered) {
+            return;
+        }
         const input = this.template.querySelector('input');
         if (!input) {
             return;
@@ -277,6 +298,7 @@ export default class LightningDatePicker extends LightningElement {
     }
 
     renderedCallback() {
+        this._rendered = true;
         this.synchronizeA11y();
     }
 
@@ -377,8 +399,13 @@ export default class LightningDatePicker extends LightningElement {
             validValues: [DATE_STYLE.SHORT, DATE_STYLE.MEDIUM, DATE_STYLE.LONG],
         });
 
-        const normalizedDate = normalizeISODate(this._value, this.dateStyle);
+        const normalizedDate = normalizeISODate(this._value, this._dateStyle);
         this._displayValue = normalizedDate.displayValue;
+
+        // W-14161407 min and max setters are being called before dateStyle is being set
+        // hence updating the min max values
+        this.setNormalisedIsoDateMax();
+        this.setNormalisedIsoDateMin();
     }
 
     constructor() {
@@ -388,6 +415,7 @@ export default class LightningDatePicker extends LightningElement {
     }
 
     connectedCallback() {
+        super.connectedCallback();
         this.connected = true;
         if (!this.ariaObserver) {
             this.ariaObserver = new AriaObserver(this);
@@ -398,6 +426,7 @@ export default class LightningDatePicker extends LightningElement {
 
     disconnectedCallback() {
         this.connected = false;
+        this._rendered = false;
         if (this.ariaObserver) {
             this.ariaObserver.disconnect();
             this.ariaObserver = undefined;
@@ -485,7 +514,7 @@ export default class LightningDatePicker extends LightningElement {
     }
 
     connectAriaDescribedBy() {
-        if (this.ariaObserver) {
+        if (this.ariaObserver && this._rendered) {
             this.ariaObserver.connect({
                 attribute: ARIA_DESCRIBEDBY,
                 targetSelector: 'input',
@@ -759,9 +788,10 @@ export default class LightningDatePicker extends LightningElement {
     }
 
     get computedAriaInvalid() {
-        const isAriaInvalid =
-            this.template.host.getAttribute('data-aria-invalid') ||
-            this._errorMessage;
+        const dataAriaInvalid = isCSR
+            ? this.template.host.getAttribute('data-aria-invalid')
+            : null;
+        const isAriaInvalid = dataAriaInvalid || this._errorMessage;
         return computeAriaInvalid(isAriaInvalid, this.hasBadInput() || '');
     }
 

package/src/lightning/datepicker/datepicker.js-meta.xml

@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<LightningComponentBundle xmlns="http://soap.sforce.com/2006/04/metadata">
+    <capabilities>
+        <capability>lightning__ServerRenderableWithHydration</capability>
+    </capabilities>
+</LightningComponentBundle>

package/src/lightning/datepicker/datepicker.lbc.native.css

@@ -0,0 +1,3 @@
+@import 'lightning/sldsCommon';
+@import './input-text.slds.css';
+@import './form-element.slds.css';

package/src/lightning/datepicker/form-element.slds.css

@@ -1,201 +1,230 @@
 
 /* Copyright (c) 2015-present, salesforce.com, inc. All rights reserved
   Licensed under BSD 3-Clause - see LICENSE.txt or git.io/sfdc-license */
-  @supports (--styling-hooks: '') {
-    /* TODO: Swap with utility classes */
-    :host([data-render-mode="shadow"]) fieldset {
+
+/**
+ * sldsFormElementUtils.css and form-element.css have many similarities
+ * however, they are used for very different use cases, and this is why
+ * they both exist, separate of each other. the 2 files are not 1:1.
+ *
+ * form-element.css is used for inclusion by LBC engineers (internal)
+ * in many of our lightning-input components, and is written with
+ * part attributes in mind. Some unneeded form element blueprint sections
+ * are not included in form-element.css, but could be added as needed later
+ *
+ * sldsFormElementUtils.css is used by customers (external) to get the
+ * specific layout styles that are provided by the form element blueprint
+ * https://www.lightningdesignsystem.com/components/form-element/
+ * there are no part attribute rules in this file
+ * the main use case of this utility is LightningModal for styling
+ * form layout for Form Element variants: Stacked, Horizontal, Compound
+ * sldsFormElementUtils.css is imported by customers via LWC CSS files:
+ * @import 'lightning/sldsFormElementUtils';
+ *
+ * **NOTE:** If you are updating this file, also check sldsFormElementUtils.css
+ * for any needed updates to keep these files in sync
+ */
+
+/* TODO: Swap with utility classes */
+
+:host([data-render-mode="shadow"]) fieldset {
       border: 0;
       margin: 0;
       padding: 0;
     }
 
-    /* FORM ELEMENT: BASE */
-    :host([data-render-mode="shadow"]) .slds-form-element {
+/* FORM ELEMENT: BASE */
+
+:host([data-render-mode="shadow"]) .slds-form-element {
         position: relative;
         min-width: 0;
     }
 
-    :host([data-render-mode="shadow"]) .slds-form-element__label {
+:host([data-render-mode="shadow"]) .slds-form-element__label {
         overflow-wrap: break-word;
         word-wrap: break-word;
         hyphens: auto;
         display: inline-block;
-        color: var(--sds-g-color-neutral-base-30, #444444);
-        font-size: var(--sds-g-font-scale-neg-3, 0.75rem);
-        padding-inline-end: var(--sds-g-spacing-2, 0.5rem);
-        padding-block-start: var(--sds-g-spacing-1, 0.25rem);
-        margin-block-end: calc(var(--sds-g-spacing-1, 0.25rem) / 2);
+        color: var(--slds-g-color-on-surface-2);
+        font-size: var(--slds-g-font-scale-neg-3);
+        padding-inline-end: var(--slds-g-spacing-2);
+        padding-block-start: var(--slds-g-spacing-1);
+        margin-block-end: calc(var(--slds-g-spacing-1) / 2);
     }
 
-    :host([data-render-mode="shadow"]) .slds-form-element__label:empty {
+:host([data-render-mode="shadow"]) .slds-form-element__label:empty {
         margin: 0;
     }
 
-    :host([data-render-mode="shadow"]) .slds-form-element__control {
+:host([data-render-mode="shadow"]) .slds-form-element__control {
         clear: left; /* NOTE: Ideally we want left to be inline-start but browser support is not ready for that value. We need to figure out better RTL support */
         position: relative;
     }
 
-    :host([data-render-mode="shadow"]) .slds-form-element__icon {
+:host([data-render-mode="shadow"]) .slds-form-element__control .slds-radio {
+      display: block;
+    }
+
+:host([data-render-mode="shadow"]) .slds-form-element__icon {
         display: inline-block;
         position: relative;
-        padding-block-start: var(--sds-g-spacing-1, 0.25rem);
+        padding-block-start: var(--slds-g-spacing-1);
         vertical-align: top;
-        line-height: var(--sds-g-font-lineheight-1, 1);
+        line-height: var(--slds-g-font-lineheight-1);
         z-index: 1;
     }
 
-    :host([data-render-mode="shadow"]) .slds-form-element__icon .slds-button_icon {
+:host([data-render-mode="shadow"]) .slds-form-element__icon .slds-button_icon {
         position: relative;
     }
 
-    :host([data-render-mode="shadow"]) .slds-form-element__help,:host([data-render-mode="shadow"]) 
+:host([data-render-mode="shadow"]) .slds-form-element__help,:host([data-render-mode="shadow"]) 
     .slds-form-element__helper {
-        font-size: var(--sds-g-font-scale-neg-3, 0.75rem);
-        margin-block-start: calc(var(--sds-g-spacing-1, 0.25rem) / 2);
+        font-size: var(--slds-g-font-scale-neg-3);
+        margin-block-start: calc(var(--slds-g-spacing-1) / 2);
         display: block;
     }
 
-    :host([data-render-mode="shadow"]) .slds-form-element_edit .slds-form-element__static {
-        width: calc(100% - var(--sds-g-sizing-7, 1.5rem));
+:host([data-render-mode="shadow"]) .slds-form-element_edit .slds-form-element__static {
+        width: calc(100% - var(--slds-g-sizing-7));
     }
 
-    :host([data-render-mode="shadow"]) .slds-form-element_readonly {
+:host([data-render-mode="shadow"]) .slds-form-element_readonly {
         flex-basis: 0%;
-        border-bottom: var(--sds-g-sizing-border-1, 1px) solid var(--sds-g-color-neutral-base-90, #e5e5e5);
+        border-bottom: var(--slds-g-sizing-border-1) solid var(--slds-g-color-border-1);
         margin-block-end: 0;
     }
 
-    :host([data-render-mode="shadow"]) .slds-form-element_readonly .slds-form-element__control {
-        padding-block-start: calc(var(--sds-g-spacing-1, 0.25rem) / 2);
-        padding-block-end: calc(var(--sds-g-spacing-1, 0.25rem) / 2);
+:host([data-render-mode="shadow"]) .slds-form-element_readonly .slds-form-element__control {
+        padding-block-start: calc(var(--slds-g-spacing-1) / 2);
+        padding-block-end: calc(var(--slds-g-spacing-1) / 2);
     }
 
-    :host([data-render-mode="shadow"]) .slds-form-element_readonly .slds-form-element__label {
+:host([data-render-mode="shadow"]) .slds-form-element_readonly .slds-form-element__label {
         margin-block-end: 0;
     }
 
-    :host([data-render-mode="shadow"]) .slds-form-element__legend {
-        font-weight: var(--sds-g-font-weight-7, 700);
+:host([data-render-mode="shadow"]) .slds-form-element__legend {
+        font-weight: var(--slds-g-font-weight-7);
         float: left;
     }
 
-    :host([data-render-mode="shadow"]) .slds-form-element__addon {
+:host([data-render-mode="shadow"]) .slds-form-element__addon {
         display: inline-block;
         margin-block-start: 0;
         margin-block-end: 0;
-        margin-inline-start: var(--sds-g-spacing-2, 0.5rem);
-        margin-inline-end: var(--sds-g-spacing-2, 0.5rem);
+        margin-inline-start: var(--slds-g-spacing-2);
+        margin-inline-end: var(--slds-g-spacing-2);
         align-self: center;
     }
 
-    :host([data-render-mode="shadow"]) .slds-form-element__static {
+:host([data-render-mode="shadow"]) .slds-form-element__static {
         overflow-wrap: break-word;
         word-wrap: break-word;
         word-break: break-word;
         display: inline-block;
-        font-size: var(--sds-g-font-scale-neg-1, 0.875rem);
-        font-weight: var(--sds-g-font-weight-4, 400);
-        color: var(--sds-g-color-neutral-base-10, #181818);
+        font-size: var(--slds-g-font-scale-neg-1);
+        font-weight: var(--slds-g-font-weight-4);
+        color: var(--slds-g-color-neutral-base-10);
         width: 100%;
     }
 
-    :host([data-render-mode="shadow"]) .slds-form-element__static.slds-text-longform *:last-child {
+:host([data-render-mode="shadow"]) .slds-form-element__static.slds-text-longform *:last-child {
         margin-block-end: 0;
     }
 
-    :host([data-render-mode="shadow"]) .slds-form-element__static:empty {
-        min-height: calc(var(--sds-g-sizing-6, 1.25rem) + 1px);
+:host([data-render-mode="shadow"]) .slds-form-element__static:empty {
+        min-height: calc(var(--slds-g-sizing-6) + 1px);
         vertical-align: bottom;
     }
 
-    :host([data-render-mode="shadow"]) .slds-form-element__static--edit {
-        width: calc(100% - var(--sds-g-sizing-7, 1.5rem));
+:host([data-render-mode="shadow"]) .slds-form-element__static--edit {
+        width: calc(100% - var(--slds-g-sizing-7));
     }
 
-    :host([data-render-mode="shadow"]) .slds-required {
-        color: var(--sds-g-color-error-base-50, #ea001e);
+:host([data-render-mode="shadow"]) .slds-required {
+        color: var(--slds-g-color-error-base-50);
         margin-block-start: 0;
         margin-block-end: 0;
-        margin-inline-start: calc(var(--sds-g-spacing-1, 0.25rem) / 2);
-        margin-inline-end: calc(var(--sds-g-spacing-1, 0.25rem) / 2);
+        margin-inline-start: calc(var(--slds-g-spacing-1) / 2);
+        margin-inline-end: calc(var(--slds-g-spacing-1) / 2);
     }
 
-    :host([data-render-mode="shadow"]) .slds-has-error .slds-form-element__help {
-        color: var(--sds-g-color-error-base-50, #ea001e);
+:host([data-render-mode="shadow"]) .slds-has-error .slds-form-element__help {
+        color: var(--slds-g-color-error-1);
     }
 
-    :host([data-render-mode="shadow"][invalid]) .slds-form-element__help {
-        color: var(--sds-g-color-error-base-50, #ea001e);
+:host([data-render-mode="shadow"][invalid]) .slds-form-element__help {
+        color: var(--slds-g-color-error-1);
     }
 
-    /* --------------------------------------- */
+/* --------------------------------------- */
 
-    /* FORM ELEMENT: STACKED */
+/* FORM ELEMENT: STACKED */
 
-    :host([data-render-mode="shadow"][variant='label-stacked']) {
+:host([data-render-mode="shadow"][variant='label-stacked']) {
         display: block;
     }
 
-    /* TODO: Using `:not` is currently not working, and it could break the build because of issues with the dist script */
+/* TODO: Using `:not` is currently not working, and it could break the build because of issues with the dist script */
 
-    /* :host([variant='label-stacked']):not(.slds-form-element_readonly) {
-        margin-block-end: var(--sds-g-spacing-2);
+/* :host([variant='label-stacked']):not(.slds-form-element_readonly) {
+        margin-block-end: var(--slds-g-spacing-2);
     }
 
     :host([variant='label-stacked']):not(.slds-is-editing) {
-        padding: 0 var(--sds-g-spacing-1);
+        padding: 0 var(--slds-g-spacing-1);
     } */
 
-    /* :host([variant='label-stacked']):not([class*="slds-size"]) {
+/* :host([variant='label-stacked']):not([class*="slds-size"]) {
           width: 100%;
           flex-basis: 100%;
     } */
 
-    :host([data-render-mode="shadow"][variant='label-stacked']) .slds-form-element {
+:host([data-render-mode="shadow"][variant='label-stacked']) .slds-form-element {
         padding: 0;
         margin-block-end: 0;
     }
 
-    :host([data-render-mode="shadow"][variant='label-stacked']) .slds-form-element__label,:host([data-render-mode="shadow"][variant='label-stacked']) .slds-form-element__control {
+:host([data-render-mode="shadow"][variant='label-stacked']) .slds-form-element__label,:host([data-render-mode="shadow"][variant='label-stacked']) .slds-form-element__control {
         border-bottom: 0; /* Remove border when using legacy version of slds-form-element */
         padding-inline-start: 0;
     }
 
-    :host([data-render-mode="shadow"][variant='label-stacked']) .slds-form-element__control {
+:host([data-render-mode="shadow"][variant='label-stacked']) .slds-form-element__control {
         width: 100%;
         flex-basis: 100%;
         clear: left;
     }
 
-    :host([data-render-mode="shadow"][variant='label-stacked']) .slds-form-element__icon {
+:host([data-render-mode="shadow"][variant='label-stacked']) .slds-form-element__icon {
         float: none;
-        padding-block-start: var(--sds-g-spacing-1, 0.25rem);
+        padding-block-start: var(--slds-g-spacing-1);
     }
 
-    /* --------------------------------------- */
+/* --------------------------------------- */
 
-    /* FORM ELEMENT: INLINE */
+/* FORM ELEMENT: INLINE */
 
-    :host([data-render-mode="shadow"][variant='label-inline']) {
+:host([data-render-mode="shadow"][variant='label-inline']) {
         display: block;
     }
 
-    /*
+/*
     we have to combine with slds class here to avoid duplication
     of this rule in child elements who import this stylesheet
     in lighting-input this slds class is synonymous with the variant
     */
 
-    :host([data-render-mode="shadow"][variant='label-inline'].slds-form-element_horizontal) {
-        padding: var(--sds-g-spacing-1, 0.25rem);
-        margin-block-end: var(--sds-g-spacing-2, 0.5rem);
+:host([data-render-mode="shadow"][variant='label-inline'].slds-form-element_horizontal) {
+        padding: var(--slds-g-spacing-1);
+        margin-block-end: var(--slds-g-spacing-2);
     }
 
-    /* TODO: Using `:not` is currently not working, and it could break the build because of issues with the dist script */
+/* TODO: Using `:not` is currently not working, and it could break the build because of issues with the dist script */
 
-    /* :host([variant='label-inline']):not(.slds-form-element_readonly) {
-        margin-block-end: var(--sds-g-spacing-2);
+/* :host([variant='label-inline']):not(.slds-form-element_readonly) {
+        margin-block-end: var(--slds-g-spacing-2);
     }
 
     :host([variant='label-inline']):not([class*="slds-size"]) {
@@ -204,18 +233,17 @@
     }
 
     :host([variant='label-inline']:not(.slds-is-editing)) {
-        padding: var(--sds-g-spacing-1);
+        padding: var(--slds-g-spacing-1);
     } */
 
-    :host([data-render-mode="shadow"][variant='label-inline']).slds-is-edited {
-        padding-block-start: var(--sds-g-sizing-6, 1.25rem)
+:host([data-render-mode="shadow"][variant='label-inline']).slds-is-edited {
+        padding-block-start: var(--slds-g-sizing-6)
     }
 
-    @media (width >= 48em) {
+@media (width >= 48em) {
         :host([data-render-mode="shadow"][variant='label-inline']) .slds-form-element__label {
-          float: left;
-          max-width: calc(33% - var(--sds-g-sizing-6, 1.25rem)); /* Removing icon width for when the help-text icon is present */
-          flex-basis: calc(33% - var(--sds-g-sizing-6, 1.25rem)); /* Some form element controls are set to display:flex */
+          max-width: calc(33% - var(--slds-g-sizing-6)); /* Removing icon width for when the help-text icon is present */
+          flex-basis: calc(33% - var(--slds-g-sizing-6)); /* Some form element controls are set to display:flex */
           flex-grow: 1; /* For IE and Safari which didn't auto expand to the available space */
           margin-block-end: 0;
           position: relative;
@@ -254,35 +282,34 @@
         }
     }
 
-    /* --------------------------------------- */
+/* --------------------------------------- */
 
-    /* FORM ELEMENT: COMPOUND */
+/* FORM ELEMENT: COMPOUND */
 
-    :host([data-render-mode="shadow"]) .slds-form-element_compound .slds-form-element__row {
+:host([data-render-mode="shadow"]) .slds-form-element_compound .slds-form-element__row {
       display: flex;
-      margin-bottom: var(--sds-g-spacing-1, 0.25rem);
-      margin-left: calc(var(--sds-g-spacing-1, 0.25rem) * -1);
-      margin-right: calc(var(--sds-g-spacing-1, 0.25rem) * -1);
+      margin-bottom: var(--slds-g-spacing-1);
+      margin-left: calc(var(--slds-g-spacing-1) * -1);
+      margin-right: calc(var(--slds-g-spacing-1) * -1);
     }
 
-    :host([data-render-mode="shadow"]) .slds-form-element_compound .slds-form-element__row .slds-form-element__label {
+:host([data-render-mode="shadow"]) .slds-form-element_compound .slds-form-element__row .slds-form-element__label {
       padding-top: 0;
     }
 
-    :host([data-render-mode="shadow"]) .slds-form-element_compound .slds-form-element {
-      padding-left: var(--sds-g-spacing-1, 0.25rem);
-      padding-right: var(--sds-g-spacing-1, 0.25rem);
+:host([data-render-mode="shadow"]) .slds-form-element_compound .slds-form-element {
+      padding-left: var(--slds-g-spacing-1);
+      padding-right: var(--slds-g-spacing-1);
     }
 
-    :host([data-render-mode="shadow"]) .slds-form-element_address .slds-form-element__row {
+:host([data-render-mode="shadow"]) .slds-form-element_address .slds-form-element__row {
       align-items: flex-end;
     }
 
-    /* --------------------------------------- */
+/* --------------------------------------- */
 
-    /* FORM ELEMENT: HIDDEN */
+/* FORM ELEMENT: HIDDEN */
 
-    :host([data-render-mode="shadow"][variant='label-hidden']) .slds-form-element__label {
+:host([data-render-mode="shadow"][variant='label-hidden']) .slds-form-element__label {
       display: none
   }
-}