lightning-base-components 1.19.7-alpha → 1.19.8-alpha

package/src/lightning/datatable/types.js

@@ -1,106 +1,143 @@
 import { assert } from 'lightning/utilsPrivate';
 
-const STANDARD_TYPES = {
-    text: ['linkify'],
-    boolean: true,
-    number: [
-        'minimumIntegerDigits',
-        'minimumFractionDigits',
-        'maximumFractionDigits',
-        'minimumSignificantDigits',
-        'maximumSignificantDigits',
+const STANDARD_TYPE_NAME_ENTRIES = [
+    ['text', ['linkify']],
+    ['boolean', []],
+    [
+        'number',
+        [
+            'minimumIntegerDigits',
+            'minimumFractionDigits',
+            'maximumFractionDigits',
+            'minimumSignificantDigits',
+            'maximumSignificantDigits',
+        ],
     ],
-    currency: [
-        'currencyCode',
-        'currencyDisplayAs',
-        'minimumIntegerDigits',
-        'minimumFractionDigits',
-        'maximumFractionDigits',
-        'minimumSignificantDigits',
-        'maximumSignificantDigits',
+    [
+        'currency',
+        [
+            'currencyCode',
+            'currencyDisplayAs',
+            'minimumIntegerDigits',
+            'minimumFractionDigits',
+            'maximumFractionDigits',
+            'minimumSignificantDigits',
+            'maximumSignificantDigits',
+        ],
     ],
-    percent: [
-        'minimumIntegerDigits',
-        'minimumFractionDigits',
-        'maximumFractionDigits',
-        'minimumSignificantDigits',
-        'maximumSignificantDigits',
+    [
+        'percent',
+        [
+            'minimumIntegerDigits',
+            'minimumFractionDigits',
+            'maximumFractionDigits',
+            'minimumSignificantDigits',
+            'maximumSignificantDigits',
+        ],
     ],
-    email: true,
-    date: [
-        'day',
-        'era',
-        'hour',
-        'hour12',
-        'minute',
-        'month',
-        'second',
-        'timeZone',
-        'timeZoneName',
-        'weekday',
-        'year',
+    ['email', []],
+    [
+        'date',
+        [
+            'day',
+            'era',
+            'hour',
+            'hour12',
+            'minute',
+            'month',
+            'second',
+            'timeZone',
+            'timeZoneName',
+            'weekday',
+            'year',
+        ],
     ],
-    'date-local': ['day', 'month', 'year'],
-    phone: true,
-    url: ['label', 'target', 'tooltip'],
-    location: true,
-    reference: ['displayValue'],
-    rowNumber: ['error'],
-    action: ['menuAlignment', 'rowActions'],
-    button: [
-        'variant',
-        'label',
-        'iconName',
-        'iconPosition',
-        'disabled',
-        'name',
-        'class',
-        'title',
+    ['date-local', ['day', 'month', 'year']],
+    ['phone', []],
+    ['url', ['label', 'target', 'tooltip']],
+    ['location', []],
+    ['reference', ['displayValue']],
+    ['rowNumber', ['error']],
+    ['action', ['menuAlignment', 'rowActions']],
+    [
+        'button',
+        [
+            'variant',
+            'label',
+            'iconName',
+            'iconPosition',
+            'disabled',
+            'name',
+            'class',
+            'title',
+        ],
     ],
-    'button-icon': [
-        'variant',
-        'alternativeText',
-        'iconName',
-        'iconClass',
-        'disabled',
-        'name',
-        'class',
-        'title',
+    [
+        'button-icon',
+        [
+            'variant',
+            'alternativeText',
+            'iconName',
+            'iconClass',
+            'disabled',
+            'name',
+            'class',
+            'title',
+        ],
     ],
-    tree: [
-        'hasChildren',
-        'isExpanded',
-        'level',
-        'setSize',
-        'posInSet',
-        'subType',
+    [
+        'tree',
+        [
+            'hasChildren',
+            'isExpanded',
+            'level',
+            'setSize',
+            'posInSet',
+            'subType',
+        ],
     ],
-};
+];
 
-const TREE_SUPPORTED_TYPES = {
-    text: true,
-    url: true,
-    date: true,
-    number: true,
-    currency: true,
-    percent: true,
-    button: true,
-    'button-icon': true,
-    reference: true,
-};
+const STANDARD_TYPE_VALUE_ENTRIES = Array(STANDARD_TYPE_NAME_ENTRIES.length);
+for (let i = 0, { length } = STANDARD_TYPE_NAME_ENTRIES; i < length; i += 1) {
+    const { 0: typeName, 1: typeAttributes } = STANDARD_TYPE_NAME_ENTRIES[i];
+    STANDARD_TYPE_VALUE_ENTRIES[i] = [
+        typeName,
+        {
+            typeAttributes,
+            type: 'standard',
+        },
+    ];
+}
+
+const STANDARD_TYPE_NAMES = new Map(STANDARD_TYPE_NAME_ENTRIES);
+
+const STANDARD_TYPE_VALUES = new Map(STANDARD_TYPE_VALUE_ENTRIES);
 
-const EDITABLE_STANDARD_TYPES = {
-    text: true,
-    percent: true,
-    phone: true,
-    email: true,
-    url: true,
-    currency: true,
-    number: true,
-    boolean: true,
-    'date-local': true,
-    date: true,
-};
+const TREE_SUPPORTED_TYPES = new Set([
+    'text',
+    'url',
+    'date',
+    'number',
+    'currency',
+    'percent',
+    'button',
+    'button-icon',
+    'reference',
+]);
+
+const EDITABLE_STANDARD_TYPES = new Set([
+    'text',
+    'percent',
+    'phone',
+    'email',
+    'url',
+    'currency',
+    'number',
+    'boolean',
+    'date-local',
+    'date',
+]);
 
 /**
  * Determines if a supplied type is a valid datatable type.
@@ -109,7 +146,7 @@ const EDITABLE_STANDARD_TYPES = {
  * @returns {Boolean} Whether the supplied type is valid
  */
 export function isValidType(typeName) {
-    return !!STANDARD_TYPES[typeName];
+    return STANDARD_TYPE_NAMES.has(typeName);
 }
 
 /**
@@ -129,7 +166,7 @@ export function isTreeType(typeName) {
  * @returns {Boolean} Whether the supplied type is valid for a tree
  */
 export function isValidTypeForTree(typeName) {
-    return !!TREE_SUPPORTED_TYPES[typeName];
+    return TREE_SUPPORTED_TYPES.has(typeName);
 }
 
 /**
@@ -154,36 +191,36 @@ export function getAttributesNames(typeName) {
  * @returns {Array} An array of attributes for the supplied type
  */
 function getStandardTypeAttributesNames(typeName) {
-    return Array.isArray(STANDARD_TYPES[typeName])
-        ? STANDARD_TYPES[typeName]
-        : [];
+    return STANDARD_TYPE_NAMES.get(typeName) || [];
 }
 
 /**
  * A class for handling valid datatable types.
  */
 export default class DatatableTypes {
-    privateCustomTypes = {};
+    privateCustomTypes = new Map();
     isValidTypeForTree = isValidTypeForTree;
 
     constructor(types) {
         if (typeof types === 'object' && types !== null) {
-            Object.keys(types).reduce((seed, key) => {
+            const { privateCustomTypes } = this;
+            const keys = Object.keys(types);
+            for (let i = 0, { length } = keys; i < length; i += 1) {
+                const key = keys[i];
                 const {
                     template,
                     editTemplate,
                     typeAttributes = [],
                     standardCellLayout = false,
                 } = types[key];
-                seed[key] = {
+                privateCustomTypes.set(key, {
                     template,
                     editTemplate,
                     typeAttributes,
                     standardCellLayout: standardCellLayout === true,
                     type: 'custom',
-                };
-                return seed;
-            }, this.privateCustomTypes);
+                });
+            }
         }
     }
 
@@ -195,16 +232,10 @@ export default class DatatableTypes {
      * @returns {Object | Undefined} The type metadata
      */
     getType(typeName) {
-        if (this.privateCustomTypes[typeName]) {
-            return this.privateCustomTypes[typeName];
-        }
-        if (STANDARD_TYPES[typeName]) {
-            return {
-                typeAttributes: getStandardTypeAttributesNames(typeName),
-                type: 'standard',
-            };
-        }
-        return undefined;
+        return (
+            this.privateCustomTypes.get(typeName) ||
+            STANDARD_TYPE_VALUES.get(typeName)
+        );
     }
 
     /**
@@ -214,10 +245,8 @@ export default class DatatableTypes {
      * @returns {Object | Undefined} The custom type's edit template
      */
     getCustomTypeEditTemplate(typeName) {
-        if (this.privateCustomTypes[typeName]) {
-            return this.privateCustomTypes[typeName].editTemplate;
-        }
-        return undefined;
+        const privateType = this.privateCustomTypes.get(typeName);
+        return privateType ? privateType.editTemplate : undefined;
     }
 
     /**
@@ -227,7 +256,10 @@ export default class DatatableTypes {
      * @returns {Boolean} Whether the type is valid
      */
     isValidType(typeName) {
-        return !!this.getType(typeName);
+        return (
+            this.privateCustomTypes.has(typeName) ||
+            STANDARD_TYPE_NAMES.has(typeName)
+        );
     }
 
     /**
@@ -237,10 +269,11 @@ export default class DatatableTypes {
      * @returns {Boolean} Whether the type is editable
      */
     isEditableType(typeName) {
-        return (
-            !!EDITABLE_STANDARD_TYPES[typeName] ||
-            this.isStandardCellLayoutForCustomType(typeName)
-        );
+        if (EDITABLE_STANDARD_TYPES.has(typeName)) {
+            return true;
+        }
+        const privateType = this.privateCustomTypes.get(typeName);
+        return privateType ? privateType.standardCellLayout : false;
     }
 
     /**
@@ -250,9 +283,7 @@ export default class DatatableTypes {
      * @returns {Boolean} Whether the type is a non-standard type
      */
     isCustomType(typeName) {
-        return (
-            this.getType(typeName) && this.getType(typeName).type === 'custom'
-        );
+        return this.privateCustomTypes.has(typeName);
     }
 
     /**
@@ -262,9 +293,7 @@ export default class DatatableTypes {
      * @returns {Boolean} Whether the custom type is using a standard cell layout
      */
     isStandardCellLayoutForCustomType(typeName) {
-        return (
-            this.isCustomType(typeName) &&
-            this.getType(typeName).standardCellLayout
-        );
+        const privateType = this.privateCustomTypes.get(typeName);
+        return privateType ? privateType.standardCellLayout : false;
     }
 }

package/src/lightning/datatable/utils.js

@@ -1,3 +1,5 @@
+import { classSetToString } from 'lightning/utilsPrivate';
+
 const CLASSSET_PROTOTYPE = {
     add(className) {
         if (typeof className === 'string') {
@@ -8,15 +10,15 @@ const CLASSSET_PROTOTYPE = {
         return this;
     },
     invert() {
-        Object.keys(this).forEach((key) => {
+        const keys = Object.keys(this);
+        for (let i = 0, { length } = keys; i < length; i += 1) {
+            const key = keys[i];
             this[key] = !this[key];
-        });
+        }
         return this;
     },
     toString() {
-        return Object.keys(this)
-            .filter((key) => this[key])
-            .join(' ');
+        return classSetToString(this);
     },
 };
 
@@ -48,14 +50,11 @@ export const isObjectLike = function (value) {
  * @param {String | Object} config The initial class configuration
  * @returns An interface, as defined in the `proto` method.
  */
-export const classSet = function (config) {
-    if (typeof config === 'string') {
-        const key = config;
-        config = {};
-        config[key] = true;
-    }
-    return Object.assign(Object.create(CLASSSET_PROTOTYPE), config);
-};
+export function classSet(config) {
+    return typeof config === 'string'
+        ? { __proto__: CLASSSET_PROTOTYPE, [config]: true }
+        : Object.assign({ __proto__: CLASSSET_PROTOTYPE }, config);
+}
 
 /**
  * Clamps a value between a minimum and maximum value
@@ -65,9 +64,9 @@ export const classSet = function (config) {
  * @param {Number} max The maximum value the number can be
  * @returns The clamped number
  */
-export const clamp = function (num, min, max) {
+export function clamp(num, min, max) {
     return num <= min ? min : num >= max ? max : num;
-};
+}
 
 /**
  * Tests if the value passed in is a value greater than 0.
@@ -75,9 +74,9 @@ export const clamp = function (num, min, max) {
  * @param {Integer} value Value to test
  * @returns {Boolean} Whether the value is greater than 0
  */
-export const isPositiveInteger = function (value) {
+export function isPositiveInteger(value) {
     return /^[0-9]*[1-9][0-9]*$/.test(value);
-};
+}
 
 /**
  * Tests if the value passed in is 0 or a number greater than 0.
@@ -85,9 +84,9 @@ export const isPositiveInteger = function (value) {
  * @param {Integer} value Value to test
  * @returns {Boolean} Whether the value is greater than or equal to 0
  */
-export const isNonNegativeInteger = function (value) {
+export function isNonNegativeInteger(value) {
     return /^\d+$/.test(value);
-};
+}
 
 /**
  * Accepts a value which may be an Integer or String and tests that value
@@ -152,10 +151,13 @@ export function getScrollOffsetFromTableEnd(el) {
  * @returns {String} Representing array/object as a string
  */
 export function styleToString(style) {
-    if (!Array.isArray(style)) {
-        return Object.entries(style)
-            .map(([key, value]) => `${key}:${value}`)
-            .join(';');
+    if (Array.isArray(style)) {
+        return style.join(';');
+    }
+    const entries = Object.keys(style);
+    for (let i = 0, { length } = entries; i < length; i += 1) {
+        const key = entries[i];
+        entries[i] = `${key}:${style[key]}`;
     }
-    return style.join(';');
+    return entries.join(';');
 }

package/src/lightning/datatable/wrapText.js

@@ -80,13 +80,15 @@ export function setWrapTextMaxLines(state, value) {
  * @param {String} colKeyValue The column key value to look up wrap text configuration
  */
 function updateWrapTextAndMaxLinesValuesInCells(state, colIndex, colKeyValue) {
-    state.rows.forEach((row) => {
+    const { rows } = state;
+    for (let i = 0, { length } = rows; i < length; i += 1) {
+        const row = rows[i];
         const cell = row.cells[colIndex];
         cell.wrapText = state.wrapText[colKeyValue];
         cell.wrapTextMaxLines = cell.wrapText
             ? state.wrapTextMaxLines
             : undefined;
-    });
+    }
 }
 
 /************************** HEADER ACTIONS **************************/
@@ -159,18 +161,23 @@ export function handleTriggeredAction(state, action, colKeyValue) {
  * @param {String} colKeyValue The column key.
  */
 function updateSelectedOptionInHeaderActions(state, colKeyValue) {
-    const columns = getColumns(state);
     const colIndex = getStateColumnIndex(state, colKeyValue);
+    if (colIndex === -1) {
+        return;
+    }
+    const columns = getColumns(state);
     const colData = columns[colIndex];
+    const { internalActions } = colData.actions;
 
-    colData.actions.internalActions.forEach((action) => {
-        if (action.name === 'wrapText') {
+    for (let i = 0, { length } = internalActions; i < length; i += 1) {
+        const action = internalActions[i];
+        const { name } = action;
+        if (name === 'wrapText') {
             action.checked = state.wrapText[colKeyValue];
-        }
-        if (action.name === 'clipText') {
+        } else if (name === 'clipText') {
             action.checked = !state.wrapText[colKeyValue];
         }
-    });
+    }
 
     updateWrapTextAndMaxLinesValuesInCells(state, colIndex, colKeyValue);
 

package/src/lightning/input/input.html

@@ -5,8 +5,13 @@
             accesskey={accesskey}
             aria-errormessage="help-message"
             aria-haspopup={ariaHasPopup}
+            aria-keyshortcuts={ariaKeyShortcuts}
+            aria-disabled={ariaDisabled}
+            aria-roledescription={ariaRoleDescription}
             aria-invalid={computedAriaInvalid}
             aria-label={computedAriaLabel}
+            aria-expanded={ariaExpanded}
+            aria-autocomplete={ariaAutoComplete}
             autocomplete={autocomplete}
             computed-label-class={computedLabelClass}
             disabled={disabled}
@@ -25,12 +30,13 @@
             name={name}
             onblur={handleBlur}
             onfocus={handleFocus}
-            onchange={handlePrimitiveInputSimpleChange}
+            onchange={handlePrimitiveInputChange}
             oncommit={handleCommit}
             pattern={pattern}
             placeholder={placeholder}
             readonly={readOnly}
             required={required}
+            role={role}
             step={step}
             type={type}
             timezone={timezone}
@@ -44,6 +50,9 @@
         <lightning-primitive-input-toggle
             accesskey={accesskey}
             aria-label={computedAriaLabel}
+            aria-keyshortcuts={ariaKeyShortcuts}
+            aria-disabled={ariaDisabled}
+            aria-roledescription={ariaRoleDescription}
             aria-invalid={computedAriaInvalid}
             checked={checked}
             disabled={disabled}
@@ -66,6 +75,9 @@
         <lightning-primitive-input-checkbox
             accesskey={accesskey}
             aria-label={computedAriaLabel}
+            aria-keyshortcuts={ariaKeyShortcuts}
+            aria-disabled={ariaDisabled}
+            aria-roledescription={ariaRoleDescription}
             aria-invalid={computedAriaInvalid}
             checked={checked}
             disabled={disabled}
@@ -88,6 +100,9 @@
         <lightning-primitive-input-checkbox-button
             label={label}
             aria-label={ariaLabel}
+            aria-keyshortcuts={ariaKeyShortcuts}
+            aria-disabled={ariaDisabled}
+            aria-roledescription={ariaRoleDescription}
             aria-invalid={computedAriaInvalid}
             required={required}
             accesskey={accesskey}
@@ -106,6 +121,9 @@
         <lightning-primitive-input-radio
             accesskey={accesskey}
             aria-invalid={computedAriaInvalid}
+            aria-keyshortcuts={ariaKeyShortcuts}
+            aria-disabled={ariaDisabled}
+            aria-roledescription={ariaRoleDescription}
             aria-label={ariaLabel}
             disabled={disabled}
             help-message={_helpMessage}
@@ -125,6 +143,9 @@
             accept={accept}
             accesskey={accesskey}
             aria-invalid={computedAriaInvalid}
+            aria-keyshortcuts={ariaKeyShortcuts}
+            aria-disabled={ariaDisabled}
+            aria-roledescription={ariaRoleDescription}
             aria-label={computedAriaLabel}
             disabled={disabled}
             help-message={_helpMessage}
@@ -150,7 +171,7 @@
             onblur={handleBlur}
             oncommit={handleCommit}
             onfocus={handleFocus}
-            onchange={handleChange}
+            onchange={handlePrimitiveInputChange}
             has-external-label={hasExternalLabel}
             required={required}
             accesskey={accesskey}