lightning-base-components 1.17.2-alpha → 1.17.5-alpha

package/src/lightning/treeGrid/treeGrid.js

@@ -272,39 +272,34 @@ export default class LightningTreeGrid extends LightningElement {
 
     handleRowSelection(event) {
         event.stopPropagation();
-        let selectedRowKeys;
         // pass the event through
-        switch (event.detail.config.action) {
-            case ROWS_ACTION.ROW_SELECT:
-                selectedRowKeys = this._selectedRowKeys.slice();
-                this._selectedRowKeys.push(event.detail.config.value);
-                break;
-            case ROWS_ACTION.ROW_DESELECT: {
-                const index = this._selectedRowKeys.indexOf(
-                    event.detail.config.value
-                );
-                selectedRowKeys = this._selectedRowKeys.slice();
-                this._selectedRowKeys.splice(index, 1);
-                break;
+        if (event.detail.config) {
+            switch (event.detail.config.action) {
+                case ROWS_ACTION.ROW_SELECT:
+                    this._selectedRowKeys.push(event.detail.config.value);
+                    break;
+                case ROWS_ACTION.ROW_DESELECT: {
+                    const index = this._selectedRowKeys.indexOf(
+                        event.detail.config.value
+                    );
+                    this._selectedRowKeys.splice(index, 1);
+                    break;
+                }
+                case ROWS_ACTION.SELECT_ALL_ROWS:
+                    this._selectedRowKeys = this.getSelectedRowKeys(
+                        event.detail.selectedRows
+                    );
+                    break;
+                case ROWS_ACTION.DESELECT_ALL_ROWS:
+                    this._selectedRowKeys = this.getSelectedRowKeys(
+                        event.detail.selectedRows
+                    );
+                    break;
+                default:
+                    break;
             }
-            case ROWS_ACTION.SELECT_ALL_ROWS:
-                selectedRowKeys = this._selectedRowKeys.slice();
-                this._selectedRowKeys = this.getSelectedRowKeys(
-                    event.detail.selectedRows
-                );
-                break;
-            case ROWS_ACTION.DESELECT_ALL_ROWS:
-                selectedRowKeys = this._selectedRowKeys.slice();
-                this._selectedRowKeys = this.getSelectedRowKeys(
-                    event.detail.selectedRows
-                );
-                break;
-            default:
-                this._selectedRowKeys.push(event.detail.config.value);
-                selectedRowKeys = this._selectedRowKeys.slice();
-                break;
+            event.detail.config.selectedRowKeys = this._selectedRowKeys.slice();
         }
-        event.detail.config.selectedRowKeys = selectedRowKeys;
         this.fireSelectedRowsChange(event.detail);
     }
 

package/src/lightning/utilsPrivate/normalize.js

@@ -25,6 +25,23 @@ export function normalizeBoolean(value) {
     return typeof value === 'string' || !!value;
 }
 
+const isNotNumber = (value) => {
+    // Need to make sure it is a number than check isNaN
+    // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isNaN#difference_between_number.isnan_and_global_isnan
+    if (
+        Number.isNaN(value) ||
+        value === null ||
+        value === undefined ||
+        value === '' ||
+        Array.isArray(value)
+    ) {
+        return true;
+    }
+    // to eliminate non numeric string or other non numeric-typed objects
+    const convertedNumber = Number(value);
+    return Number.isNaN(convertedNumber);
+};
+
 /**
  * A number normalization utility for attributes.
  * @param {number} value - The value to normalize.
@@ -39,18 +56,17 @@ export function normalizeNumber(value, config = {}) {
     const returnValueIfInvalid =
         (typeof fallbackValue === 'number' && fallbackValue) || undefined;
 
-    // Need to make sure it is a number than check isNaN
-    // https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Number/isNaN#difference_between_number.isnan_and_global_isnan
-    if (typeof value !== 'number' || Number.isNaN(value)) {
+    if (isNotNumber(value)) {
         return returnValueIfInvalid;
     }
-    if (typeof minValue === 'number' && value < minValue) {
+    if (!isNotNumber(value) && value < minValue) {
         return returnValueIfInvalid;
     }
-    if (typeof maxValue === 'number' && value > maxValue) {
+    if (!isNotNumber(value) && value > maxValue) {
         return returnValueIfInvalid;
     }
-    return value;
+    // multiplying 1 is to make sure to convert from a numeric string to a number
+    return value * 1;
 }
 
 export function normalizeArray(value) {

package/src/lightning/utilsPrivate/url.js

@@ -9,7 +9,8 @@ export function makeAbsoluteUrl(url) {
     return isAbsoluteUrl(url) ? url : `${protocol}//${url}`;
 }
 
-export const FALLBACK_URL = 'about:blank';
+// eslint-disable-next-line no-script-url
+export const FALLBACK_URL = 'javascript:void(0)';
 const IS_SCRIPT_OR_DATA = /^(?:\w+script|data):/i;
 const IS_HTML_ENTITY = /&#(\w+)(^\w|;)?/g;
 const htmlCtrlEntityRegex = /&(newline|tab);/gi;

package/src/lightning/verticalNavigation/vertical-navigation.slds.css

@@ -0,0 +1,4 @@
+
+:host([data-render-mode="shadow"]) [part~='vertical-navigation'] {
+  position: relative;
+}

package/src/lightning/verticalNavigation/verticalNavigation.css

@@ -0,0 +1 @@
+/* @import './vertical-navigation.slds.css'; */

package/src/lightning/verticalNavigation/verticalNavigation.html

@@ -1,5 +1,5 @@
 <template>
-    <nav class={computedClass} onprivateitemselect={handleItemSelect} onprivateitemregister={handleItemRegister} aria-label={ariaLabel}>
+    <nav class={computedClass} onprivateitemselect={handleItemSelect} onprivateitemregister={handleItemRegister} aria-label={ariaLabel} part="vertical-navigation">
         <slot></slot>
     </nav>
 </template>

package/src/lightning/verticalNavigationSection/vertical-navigation-section.slds.css

@@ -0,0 +1,19 @@
+
+@supports (--styling-hooks: '') {
+    :host([data-render-mode="shadow"]) .slds-nav-vertical__title {
+        padding-block-start: var(--sds-g-spacing-2, 0.5rem);
+        padding-block-end: var(--sds-g-spacing-2, 0.5rem);
+        padding-inline-start: var(--sds-g-spacing-5, 1.5rem);
+        padding-inline-end: var(--sds-g-spacing-4, 1rem);
+        font-size: var(--sds-g-font-size-base, 1rem);
+        font-weight: var(--sds-g-font-weight-7, 700);
+    }
+
+    :host([data-render-mode="shadow"]) .slds-nav-vertical__section:not(:first-of-type) {
+        margin-block-start: var(--sds-g-spacing-2, 0.5rem);
+    }
+
+    :host([data-render-mode="shadow"]) .slds-nav-vertical__title:not(:first-of-type) {
+        margin-block-start: var(--sds-g-spacing-2, 0.5rem);
+    }
+}

package/src/lightning/verticalNavigationSection/verticalNavigationSection.css

@@ -1,3 +1,5 @@
+/* @import './vertical-navigation-section.slds.css'; */
+
 div[role="list"] {
     list-style: none;
 }

package/src/lightning/verticalNavigationSection/verticalNavigationSection.html

@@ -1,5 +1,5 @@
 <template>
-    <div class="slds-nav-vertical__section" onprivateoverflowregister={handleOverflowRegister}>
+    <div class="slds-nav-vertical__section" onprivateoverflowregister={handleOverflowRegister} part="vertical-navigation-section">
         <h2 id="vertical-navigation-section-heading" class="slds-nav-vertical__title" aria-level={_privateHeadingAriaLevel}>{label}</h2>
         <div role="list" aria-describedby="vertical-navigation-section-heading">
             <slot></slot>