lightning-base-components 1.16.7-alpha → 1.16.8-alpha

package/src/lightning/overlayContainer/overlayContainer.js

@@ -100,41 +100,54 @@ export default class LightningOverlayContainer extends LightningElement {
      */
     @api pop(element, result, promise) {
         const stackLength = this.stack.length;
-        let stackElement,
+        let stackElementToRemove,
             stackIndexToRemove = -1;
         if (stackLength > 0) {
             // find element to remove, by looping through array in reverse order
-            // typically, the last item in the array will be removed
-            for (let index = stackLength; index--; index >= 0) {
-                stackElement = this.stack[index];
-                if (element === stackElement.element) {
-                    stackIndexToRemove = index;
-                    break;
+            // typically, the last item in the zero-based array will be removed
+            for (let index = stackLength - 1; index > -1; index--) {
+                if (this.stack[index]) {
+                    stackElementToRemove = this.stack[index];
+                    if (element === stackElementToRemove.element) {
+                        stackIndexToRemove = index;
+                        break;
+                    }
                 }
             }
-
-            const { element: elem, parentElement, resolve, id } = stackElement;
-            // Resolve immediately
-            resolve(result);
-            // Wait for animation out to complete.
-            // Ex: LightningModal slide up animation
-            // We need to wait until the promise.then()[PASS] or we
-            // remove the element too early, and animation gets clipped
-            if (promise) {
-                promise.then(() => {
+            if (stackElementToRemove) {
+                const {
+                    element: elem,
+                    parentElement,
+                    resolve,
+                    id,
+                } = stackElementToRemove;
+                // Resolve immediately
+                resolve(result);
+                // Wait for animation out to complete.
+                // Ex: LightningModal slide up animation
+                // We need to wait until the promise.then()[PASS] or we
+                // remove the element too early, and animation gets clipped
+                if (promise) {
+                    promise.then(() => {
+                        this.removeOverlay(
+                            elem,
+                            parentElement,
+                            stackIndexToRemove,
+                            id
+                        );
+                    });
+                } else {
+                    // No animation, so no need to wait
+                    // before removal
+                    // IE11 and prefers-reduced-motion
+                    // take this path
                     this.removeOverlay(
                         elem,
                         parentElement,
                         stackIndexToRemove,
                         id
                     );
-                });
-            } else {
-                // No animation, so no need to wait
-                // before removal
-                // IE11 and prefers-reduced-motion
-                // take this path
-                this.removeOverlay(elem, parentElement, stackIndexToRemove, id);
+                }
             }
         }
         return null;

package/src/lightning/overlayManager/overlayManager.js

@@ -362,15 +362,17 @@ export function removeOverlayFromSharedState(overlayObject) {
     // Use overlay ID to find correct overlay and remove
     // IDs may be GUID (LBC overlays) or Aura globalId (Aura overlays)
     if (overlayId) {
-        // loop from end to the front of the stack
+        // loop from end to the front of the zero-based array (stack)
         // determine which item to remove
-        for (let index = stackLength; index--; index >= 0) {
-            const {
-                overlayDetails: { id: oId },
-            } = state.stack[index];
-            if (oId && oId === overlayId) {
-                indexToRemove = index;
-                break;
+        for (let index = stackLength - 1; index > -1; index--) {
+            if (state.stack[index]) {
+                const {
+                    overlayDetails: { id: oId },
+                } = state.stack[index];
+                if (oId && oId === overlayId) {
+                    indexToRemove = index;
+                    break;
+                }
             }
         }
     }

package/src/lightning/picklist/picklist.js

@@ -25,7 +25,6 @@ export default class LightningPicklist extends LightningElement {
     @track _size = 4;
     @track _showActivityIndicator = false;
     @track _fieldLevelHelp;
-    @track _multiple;
 
     @api label;
     @api name;

package/src/lightning/positionLibrary/direction.js

@@ -180,9 +180,19 @@ export function checkFlipPossibility(parent, element, target, leftAsBoundary) {
     // If there is no space above and below, recalculate space based on window
     // when there is still no space above and below based on window then select the maximum available space
     if (!hasSpaceAbove && !hasSpaceBelow && parent) {
-        aboveSpace = referenceElemRect.top - windowViewPort.top - height;
-        belowSpace = windowViewPort.height - referenceElemRect.bottom - height;
-
+        belowSpace =
+            viewPort.height -
+            (referenceElemRect.bottom - viewPort.top) -
+            height;
+        if (belowSpace < 0) {
+            if (parent.scrollTop > 0) {
+                aboveSpace =
+                    referenceElemRect.top -
+                    viewPort.top +
+                    parent.scrollTop -
+                    height;
+            }
+        }
         hasSpaceAbove =
             aboveSpace >= 0 || (belowSpace < 0 && aboveSpace > belowSpace);
         hasSpaceBelow =