lighthouse 9.5.0-dev.20230129 → 9.5.0-dev.20230131

package/report/test/renderer/report-utils-test.js

@@ -94,176 +94,6 @@ describe('util helpers', () => {
   });
 
   describe('#prepareReportResult', () => {
-    describe('backward compatibility', () => {
-      it('corrects underscored `notApplicable` scoreDisplayMode', () => {
-        const clonedSampleResult = JSON.parse(JSON.stringify(sampleResult));
-
-        // Avoid injecting entity names into audits that would would
-        // make the diff at the end of this test difficult.
-        delete clonedSampleResult.entities;
-
-        let notApplicableCount = 0;
-        Object.values(clonedSampleResult.audits).forEach(audit => {
-          if (audit.scoreDisplayMode === 'notApplicable') {
-            notApplicableCount++;
-            audit.scoreDisplayMode = 'not_applicable';
-          }
-        });
-
-        assert.ok(notApplicableCount > 20); // Make sure something's being tested.
-
-        // Original audit results should be restored.
-        const preparedResult = ReportUtils.prepareReportResult(clonedSampleResult);
-
-        assert.deepStrictEqual(preparedResult.audits, sampleResult.audits);
-      });
-
-      it('corrects undefined auditDetails.type to `debugdata`', () => {
-        const clonedSampleResult = JSON.parse(JSON.stringify(sampleResult));
-
-        // Avoid injecting entity names into audits that would would
-        // make the diff at the end of this test difficult.
-        delete clonedSampleResult.entities;
-
-        // Delete debugdata details types.
-        let undefinedCount = 0;
-        for (const audit of Object.values(clonedSampleResult.audits)) {
-          if (audit.details && audit.details.type === 'debugdata') {
-            undefinedCount++;
-            delete audit.details.type;
-          }
-        }
-        assert.ok(undefinedCount > 4); // Make sure something's being tested.
-        assert.notDeepStrictEqual(clonedSampleResult.audits, sampleResult.audits);
-
-        // Original audit results should be restored.
-        const preparedResult = ReportUtils.prepareReportResult(clonedSampleResult);
-        assert.deepStrictEqual(preparedResult.audits, sampleResult.audits);
-      });
-
-      it('corrects `diagnostic` auditDetails.type to `debugdata`', () => {
-        const clonedSampleResult = JSON.parse(JSON.stringify(sampleResult));
-
-        // Avoid injecting entity names into audits that would would
-        // make the diff at the end of this test difficult.
-        delete clonedSampleResult.entities;
-
-        // Change debugdata details types.
-        let diagnosticCount = 0;
-        for (const audit of Object.values(clonedSampleResult.audits)) {
-          if (audit.details && audit.details.type === 'debugdata') {
-            diagnosticCount++;
-            audit.details.type = 'diagnostic';
-          }
-        }
-        assert.ok(diagnosticCount > 4); // Make sure something's being tested.
-        assert.notDeepStrictEqual(clonedSampleResult.audits, sampleResult.audits);
-
-        // Original audit results should be restored.
-        const preparedResult = ReportUtils.prepareReportResult(clonedSampleResult);
-        assert.deepStrictEqual(preparedResult.audits, sampleResult.audits);
-      });
-
-      it('corrects screenshots in the `filmstrip` auditDetails.type', () => {
-        const clonedSampleResult = JSON.parse(JSON.stringify(sampleResult));
-
-        // Avoid injecting entity names into audits that would would
-        // make the diff at the end of this test difficult.
-        delete clonedSampleResult.entities;
-
-        // Strip filmstrip screenshots of data URL prefix.
-        let filmstripCount = 0;
-        for (const audit of Object.values(clonedSampleResult.audits)) {
-          if (audit.details && audit.details.type === 'filmstrip') {
-            filmstripCount++;
-            for (const screenshot of audit.details.items) {
-              screenshot.data = screenshot.data.slice('data:image/jpeg;base64,'.length);
-            }
-          }
-        }
-        assert.ok(filmstripCount > 0); // Make sure something's being tested.
-        assert.notDeepStrictEqual(clonedSampleResult.audits, sampleResult.audits);
-
-        // Original audit results should be restored.
-        const preparedResult = ReportUtils.prepareReportResult(clonedSampleResult);
-        assert.deepStrictEqual(preparedResult.audits, sampleResult.audits);
-      });
-
-      it('moves full-page-screenshot audit', () => {
-        const clonedSampleResult = JSON.parse(JSON.stringify(sampleResult));
-
-        clonedSampleResult.audits['full-page-screenshot'] = {
-          details: {
-            type: 'full-page-screenshot',
-            ...sampleResult.fullPageScreenshot,
-          },
-        };
-        delete clonedSampleResult.fullPageScreenshot;
-        // Avoid injecting entity names into audits that would would
-        // make the diff at the end of this test difficult.
-        delete clonedSampleResult.entities;
-
-        assert.ok(clonedSampleResult.audits['full-page-screenshot'].details.nodes); // Make sure something's being tested.
-        assert.notDeepStrictEqual(clonedSampleResult.audits, sampleResult.audits);
-
-        // Original audit results should be restored.
-        const preparedResult = ReportUtils.prepareReportResult(clonedSampleResult);
-        assert.deepStrictEqual(preparedResult.audits, sampleResult.audits);
-        assert.deepStrictEqual(preparedResult.fullPageScreenshot, sampleResult.fullPageScreenshot);
-      });
-
-      it('corrects performance category without hidden group', () => {
-        const clonedSampleResult = JSON.parse(JSON.stringify(sampleResult));
-
-        clonedSampleResult.lighthouseVersion = '8.6.0';
-        delete clonedSampleResult.categoryGroups['hidden'];
-        for (const auditRef of clonedSampleResult.categories['performance'].auditRefs) {
-          if (auditRef.group === 'hidden') {
-            delete auditRef.group;
-          } else if (!auditRef.group) {
-            auditRef.group = 'diagnostics';
-          }
-        }
-        assert.notDeepStrictEqual(clonedSampleResult.categories, sampleResult.categories);
-        assert.notDeepStrictEqual(clonedSampleResult.categoryGroups, sampleResult.categoryGroups);
-
-        // Original audit results should be restored.
-        const clonedPreparedResult = ReportUtils.prepareReportResult(clonedSampleResult);
-        const preparedResult = ReportUtils.prepareReportResult(sampleResult);
-        assert.deepStrictEqual(clonedPreparedResult.categories, preparedResult.categories);
-        assert.deepStrictEqual(clonedPreparedResult.categoryGroups, preparedResult.categoryGroups);
-      });
-
-      it('converts old opportunity table column headings to consolidated table headings', () => {
-        const clonedSampleResult = JSON.parse(JSON.stringify(sampleResult));
-
-        // Avoid injecting entity names into audits that would would
-        // make the diff at the end of this test difficult.
-        delete clonedSampleResult.entities;
-
-        const auditsWithTableDetails = Object.values(clonedSampleResult.audits)
-          .filter(audit => audit.details?.type === 'table');
-        assert.notEqual(auditsWithTableDetails.length, 0);
-        for (const audit of auditsWithTableDetails) {
-          for (const heading of audit.details.headings) {
-            heading.itemType = heading.valueType;
-            heading.text = heading.label;
-            delete heading.valueType;
-            delete heading.label;
-
-            if (heading.subItemsHeading) {
-              heading.subItemsHeading.itemType = heading.subItemsHeading.valueType;
-              // @ts-expect-error
-              delete heading.subItemsHeading.valueType;
-            }
-          }
-        }
-
-        const preparedResult = ReportUtils.prepareReportResult(clonedSampleResult);
-        assert.deepStrictEqual(sampleResult.audits, preparedResult.audits);
-      });
-    });
-
     it('appends stack pack descriptions to auditRefs', () => {
       const clonedSampleResult = JSON.parse(JSON.stringify(sampleResult));
       const iconDataURL = 'data:image/svg+xml,%3Csvg xmlns="http://www.w3.org/2000/svg"%3E%3C/svg%3E';

package/report/tsconfig.json

@@ -14,6 +14,7 @@
   "include": [
     "**/*.js",
     "types/**/*.d.ts",
+    "../core/lib/lighthouse-compatibility.js",
   ],
   "exclude": [
     "generator/**/*.js",

package/shared/localization/locales/en-US.json

@@ -663,7 +663,7 @@
     "message": "Doctype name must be the string `html`"
   },
   "core/audits/dobetterweb/doctype.js | explanationLimitedQuirks": {
-    "message": "Document contains a doctype that triggers limited-quirks-mode"
+    "message": "Document contains a `doctype` that triggers `limited-quirks-mode`"
   },
   "core/audits/dobetterweb/doctype.js | explanationNoDoctype": {
     "message": "Document must contain a doctype"
@@ -675,7 +675,7 @@
     "message": "Expected systemId to be an empty string"
   },
   "core/audits/dobetterweb/doctype.js | explanationWrongDoctype": {
-    "message": "Document contains a doctype that triggers quirks-mode"
+    "message": "Document contains a `doctype` that triggers `quirks-mode`"
   },
   "core/audits/dobetterweb/doctype.js | failureTitle": {
     "message": "Page lacks the HTML doctype, thus triggering quirks-mode"
@@ -1869,7 +1869,7 @@
     "message": "Ineligible APIs were used."
   },
   "core/lib/bf-cache-strings.js | injectedJavascript": {
-    "message": "IPages that JavaScript is injected into by extensions are not currently eligible for back/forward cache."
+    "message": "Pages that JavaScript is injected into by extensions are not currently eligible for back/forward cache."
   },
   "core/lib/bf-cache-strings.js | injectedStyleSheet": {
     "message": "Pages that StyleSheet is injected into by extensions are not currently eligible for back/forward cache."

package/shared/localization/locales/en-XL.json

@@ -663,7 +663,7 @@
     "message": "D̂óĉt́ŷṕê ńâḿê ḿûśt̂ b́ê t́ĥé ŝt́r̂ín̂ǵ `html`"
   },
   "core/audits/dobetterweb/doctype.js | explanationLimitedQuirks": {
-    "message": "D̂óĉúm̂én̂t́ ĉón̂t́âín̂ś â d́ôćt̂ýp̂é t̂h́ât́ t̂ŕîǵĝér̂ś l̂ím̂ít̂éd̂-q́ûír̂ḱŝ-ḿôd́ê"
+    "message": "D̂óĉúm̂én̂t́ ĉón̂t́âín̂ś â `doctype` t́ĥát̂ t́r̂íĝǵêŕŝ `limited-quirks-mode`"
   },
   "core/audits/dobetterweb/doctype.js | explanationNoDoctype": {
     "message": "D̂óĉúm̂én̂t́ m̂úŝt́ ĉón̂t́âín̂ á d̂óĉt́ŷṕê"
@@ -675,7 +675,7 @@
     "message": "Êx́p̂éĉt́êd́ ŝýŝt́êḿÎd́ t̂ó b̂é âń êḿp̂t́ŷ śt̂ŕîńĝ"
   },
   "core/audits/dobetterweb/doctype.js | explanationWrongDoctype": {
-    "message": "D̂óĉúm̂én̂t́ ĉón̂t́âín̂ś â d́ôćt̂ýp̂é t̂h́ât́ t̂ŕîǵĝér̂ś q̂úîŕk̂ś-m̂ód̂é"
+    "message": "D̂óĉúm̂én̂t́ ĉón̂t́âín̂ś â `doctype` t́ĥát̂ t́r̂íĝǵêŕŝ `quirks-mode`"
   },
   "core/audits/dobetterweb/doctype.js | failureTitle": {
     "message": "P̂áĝé l̂áĉḱŝ t́ĥé ĤT́M̂Ĺ d̂óĉt́ŷṕê, t́ĥúŝ t́r̂íĝǵêŕîńĝ q́ûír̂ḱŝ-ḿôd́ê"
@@ -1869,7 +1869,7 @@
     "message": "Îńêĺîǵîb́l̂é ÂṔÎś ŵér̂é ûśêd́."
   },
   "core/lib/bf-cache-strings.js | injectedJavascript": {
-    "message": "ÎṔâǵêś t̂h́ât́ Ĵáv̂áŜćr̂íp̂t́ îś îńĵéĉt́êd́ îńt̂ó b̂ý êx́t̂én̂śîón̂ś âŕê ńôt́ ĉúr̂ŕêńt̂ĺŷ él̂íĝíb̂ĺê f́ôŕ b̂áĉḱ/f̂ór̂ẃâŕd̂ ćâćĥé."
+    "message": "P̂áĝéŝ t́ĥát̂ J́âv́âŚĉŕîṕt̂ íŝ ín̂j́êćt̂éd̂ ín̂t́ô b́ŷ éx̂t́êńŝíôńŝ ár̂é n̂ót̂ ćûŕr̂én̂t́l̂ý êĺîǵîb́l̂é f̂ór̂ b́âćk̂/f́ôŕŵár̂d́ ĉáĉh́ê."
   },
   "core/lib/bf-cache-strings.js | injectedStyleSheet": {
     "message": "P̂áĝéŝ t́ĥát̂ Śt̂ýl̂éŜh́êét̂ íŝ ín̂j́êćt̂éd̂ ín̂t́ô b́ŷ éx̂t́êńŝíôńŝ ár̂é n̂ót̂ ćûŕr̂én̂t́l̂ý êĺîǵîb́l̂é f̂ór̂ b́âćk̂/f́ôŕŵár̂d́ ĉáĉh́ê."

package/tsconfig.json

@@ -77,6 +77,7 @@
     "core/test/lib/i18n/i18n-test.js",
     "core/test/lib/icons-test.js",
     "core/test/lib/lh-element-test.js",
+    "core/test/lib/lighthouse-compatibility-test.js",
     "core/test/lib/manifest-parser-test.js",
     "core/test/lib/median-run-test.js",
     "core/test/lib/minification-estimator-test.js",