lighthouse 9.5.0-dev.20230121 → 9.5.0-dev.20230123

package/core/audits/bf-cache.js

@@ -15,7 +15,7 @@ const UIStrings = {
   /** Title of a diagnostic Lighthouse audit that identifies when the back/forward cache is being used. "back/forward" refers to the back and forward buttons found in modern browsers. This title is shown to users if the page attempted to restore from the back/forward cache but the back/forward cache was not used. */
   failureTitle: 'Page prevented back/forward cache restoration',
   /** Description of a diagnostic Lighthouse audit that identifies when the back/forward cache is being used. "back/forward" refers to the back and forward buttons found in modern browsers. */
-  description: 'Many navigations are performed by going back to a previous page, or forwards again. The back/forward cache (bfcache) can speed up these return navigations. [Learn more about the bfcache](https://web.dev/bfcache/)',
+  description: 'Many navigations are performed by going back to a previous page, or forwards again. The back/forward cache (bfcache) can speed up these return navigations. [Learn more about the bfcache](https://developer.chrome.com/docs/lighthouse/performance/bf-cache/)',
   /** Failure type for an error that the user should be able to address themselves. Shown in a table column with other failure types. */
   actionableFailureType: 'Actionable',
   /** Failure type for an error that the user cannot address in the page's code. Shown in a table column with other failure types. */

package/core/audits/screenshot-thumbnails.d.ts

@@ -7,9 +7,10 @@ declare class ScreenshotThumbnails extends Audit {
      * ratio of the original thumbnail.
      *
      * @param {ReturnType<SpeedlineFrame['getParsedImage']>} imageData
+     * @param {number} scaledWidth
      * @return {{width: number, height: number, data: Uint8Array}}
      */
-    static scaleImageToThumbnail(imageData: ReturnType<SpeedlineFrame['getParsedImage']>): {
+    static scaleImageToThumbnail(imageData: ReturnType<SpeedlineFrame['getParsedImage']>, scaledWidth: number): {
         width: number;
         height: number;
         data: Uint8Array;

package/core/audits/screenshot-thumbnails.js

@@ -10,8 +10,7 @@ import {Audit} from './audit.js';
 import {LighthouseError} from '../lib/lh-error.js';
 import {Speedline} from '../computed/speedline.js';
 
-const NUMBER_OF_THUMBNAILS = 10;
-const THUMBNAIL_WIDTH = 120;
+const NUMBER_OF_THUMBNAILS = 8;
 
 /** @typedef {LH.Artifacts.Speedline['frames'][0]} SpeedlineFrame */
 
@@ -34,10 +33,10 @@ class ScreenshotThumbnails extends Audit {
    * ratio of the original thumbnail.
    *
    * @param {ReturnType<SpeedlineFrame['getParsedImage']>} imageData
+   * @param {number} scaledWidth
    * @return {{width: number, height: number, data: Uint8Array}}
    */
-  static scaleImageToThumbnail(imageData) {
-    const scaledWidth = THUMBNAIL_WIDTH;
+  static scaleImageToThumbnail(imageData, scaledWidth) {
     const scaleFactor = imageData.width / scaledWidth;
     const scaledHeight = Math.floor(imageData.height / scaleFactor);
 
@@ -79,6 +78,8 @@ class ScreenshotThumbnails extends Audit {
 
     // Make the minimum time range 3s so sites that load super quickly don't get a single screenshot
     const minimumTimelineDuration = context.options.minimumTimelineDuration || 3000;
+    const numberOfThumbnails = context.options.numberOfThumbnails || NUMBER_OF_THUMBNAILS;
+    const thumbnailWidth = context.options.thumbnailWidth || null;
 
     const thumbnails = [];
     const analyzedFrames = speedline.frames.filter(frame => !frame.isProgressInterpolated());
@@ -91,13 +92,13 @@ class ScreenshotThumbnails extends Audit {
       throw new LighthouseError(LighthouseError.errors.INVALID_SPEEDLINE);
     }
 
-    for (let i = 1; i <= NUMBER_OF_THUMBNAILS; i++) {
-      const targetTimestamp = speedline.beginning + timelineEnd * i / NUMBER_OF_THUMBNAILS;
+    for (let i = 1; i <= numberOfThumbnails; i++) {
+      const targetTimestamp = speedline.beginning + timelineEnd * i / numberOfThumbnails;
 
       /** @type {SpeedlineFrame} */
       // @ts-expect-error - there will always be at least one frame by this point. TODO: use nonnullable assertion in TS2.9
       let frameForTimestamp = null;
-      if (i === NUMBER_OF_THUMBNAILS) {
+      if (i === numberOfThumbnails) {
         frameForTimestamp = analyzedFrames[analyzedFrames.length - 1];
       } else {
         analyzedFrames.forEach(frame => {
@@ -111,11 +112,15 @@ class ScreenshotThumbnails extends Audit {
       const cachedThumbnail = cachedThumbnails.get(frameForTimestamp);
       if (cachedThumbnail) {
         base64Data = cachedThumbnail;
-      } else {
+      } else if (thumbnailWidth !== null) {
         const imageData = frameForTimestamp.getParsedImage();
-        const thumbnailImageData = ScreenshotThumbnails.scaleImageToThumbnail(imageData);
+        const thumbnailImageData =
+          ScreenshotThumbnails.scaleImageToThumbnail(imageData, thumbnailWidth);
         base64Data = jpeg.encode(thumbnailImageData, 90).data.toString('base64');
         cachedThumbnails.set(frameForTimestamp, base64Data);
+      } else {
+        base64Data = frameForTimestamp.getImage().toString('base64');
+        cachedThumbnails.set(frameForTimestamp, base64Data);
       }
       thumbnails.push({
         timing: Math.round(targetTimestamp - speedline.beginning),

package/core/computed/processed-navigation.d.ts

@@ -1,15 +1,21 @@
 export { ProcessedNavigationComputed as ProcessedNavigation };
 declare const ProcessedNavigationComputed: typeof ProcessedNavigation & {
-    request: (dependencies: import("../index.js").Trace, context: import("../../types/utility-types.js").default.ImmutableObject<{
+    request: (dependencies: import("../index.js").Trace | import("../index.js").Artifacts.ProcessedTrace, context: import("../../types/utility-types.js").default.ImmutableObject<{
         computedCache: Map<string, import("../lib/arbitrary-equality-map.js").ArbitraryEqualityMap>;
     }>) => Promise<import("../index.js").Artifacts.ProcessedNavigation>;
 };
 declare class ProcessedNavigation {
     /**
-       * @param {LH.Trace} trace
-       * @param {LH.Artifacts.ComputedContext} context
-       * @return {Promise<LH.Artifacts.ProcessedNavigation>}
-      */
-    static compute_(trace: LH.Trace, context: LH.Artifacts.ComputedContext): Promise<LH.Artifacts.ProcessedNavigation>;
+     * @param {LH.Trace | LH.Artifacts.ProcessedTrace} traceOrProcessedTrace
+     * @return {traceOrProcessedTrace is LH.Artifacts.ProcessedTrace}
+     */
+    static isProcessedTrace(traceOrProcessedTrace: LH.Trace | LH.Artifacts.ProcessedTrace): traceOrProcessedTrace is import("../index.js").Artifacts.ProcessedTrace;
+    /**
+     * @param {LH.Trace | LH.Artifacts.ProcessedTrace} traceOrProcessedTrace
+     * @param {LH.Artifacts.ComputedContext} context
+     * @return {Promise<LH.Artifacts.ProcessedNavigation>}
+     */
+    static compute_(traceOrProcessedTrace: LH.Trace | LH.Artifacts.ProcessedTrace, context: LH.Artifacts.ComputedContext): Promise<LH.Artifacts.ProcessedNavigation>;
 }
+import { ProcessedTrace } from "./processed-trace.js";
 //# sourceMappingURL=processed-navigation.d.ts.map

package/core/computed/processed-navigation.js

@@ -10,12 +10,25 @@ import LHTraceProcessor from '../lib/lh-trace-processor.js';
 
 class ProcessedNavigation {
   /**
-     * @param {LH.Trace} trace
-     * @param {LH.Artifacts.ComputedContext} context
-     * @return {Promise<LH.Artifacts.ProcessedNavigation>}
-    */
-  static async compute_(trace, context) {
-    const processedTrace = await ProcessedTrace.request(trace, context);
+   * @param {LH.Trace | LH.Artifacts.ProcessedTrace} traceOrProcessedTrace
+   * @return {traceOrProcessedTrace is LH.Artifacts.ProcessedTrace}
+   */
+  static isProcessedTrace(traceOrProcessedTrace) {
+    return 'timeOriginEvt' in traceOrProcessedTrace;
+  }
+
+  /**
+   * @param {LH.Trace | LH.Artifacts.ProcessedTrace} traceOrProcessedTrace
+   * @param {LH.Artifacts.ComputedContext} context
+   * @return {Promise<LH.Artifacts.ProcessedNavigation>}
+   */
+  static async compute_(traceOrProcessedTrace, context) {
+    // TODO: Remove this backport once pubads passes in a raw trace.
+    if (this.isProcessedTrace(traceOrProcessedTrace)) {
+      return LHTraceProcessor.processNavigation(traceOrProcessedTrace);
+    }
+
+    const processedTrace = await ProcessedTrace.request(traceOrProcessedTrace, context);
     return LHTraceProcessor.processNavigation(processedTrace);
   }
 }

package/core/util.cjs

@@ -19,7 +19,7 @@
  * limitations under the License.
  */
 
-/** @template T @typedef {import('./i18n').I18n<T>} I18n */
+/** @typedef {import('./i18n-formatter').I18nFormatter} I18nFormatter */
 
 const ELLIPSIS = '\u2026';
 const NBSP = '\xa0';
@@ -42,9 +42,21 @@ const listOfTlds = [
 ];
 
 class Util {
-  /** @type {I18n<typeof UIStrings>} */
+  /** @type {I18nFormatter} */
   // @ts-expect-error: Is set in report renderer.
   static i18n = null;
+  static strings = /** @type {typeof UIStrings} */ ({});
+
+  /**
+   * @param {Record<string, string>} providedStrings
+   */
+  static applyStrings(providedStrings) {
+    this.strings = {
+      // Set missing renderer strings to default (english) values.
+      ...UIStrings,
+      ...providedStrings,
+    };
+  }
 
   static get PASS_THRESHOLD() {
     return PASS_THRESHOLD;
@@ -154,6 +166,10 @@ class Util {
             }
           }
         }
+
+        // TODO: convert printf-style displayValue.
+        // Added:   #5099, v3
+        // Removed: #6767, v4
       }
     }
 
@@ -216,6 +232,20 @@ class Util {
       });
     }
 
+    // Add some minimal stuff so older reports still work.
+    if (!clone.environment) {
+      // @ts-expect-error
+      clone.environment = {benchmarkIndex: 0};
+    }
+    if (!clone.configSettings.screenEmulation) {
+      // @ts-expect-error
+      clone.configSettings.screenEmulation = {};
+    }
+    if (!clone.i18n) {
+      // @ts-expect-error
+      clone.i18n = {};
+    }
+
     // In 10.0, full-page-screenshot became a top-level property on the LHR.
     if (clone.audits['full-page-screenshot']) {
       const details = /** @type {LH.Result.FullPageScreenshot=} */ (
@@ -511,7 +541,7 @@ class Util {
 
     switch (settings.throttlingMethod) {
       case 'provided':
-        summary = networkThrottling = cpuThrottling = Util.i18n.strings.throttlingProvided;
+        summary = networkThrottling = cpuThrottling = Util.strings.throttlingProvided;
         break;
       case 'devtools': {
         const {cpuSlowdownMultiplier, requestLatencyMs} = throttling;
@@ -526,7 +556,8 @@ class Util {
             throttling.downloadThroughputKbps === 1.6 * 1024 * 0.9 &&
             throttling.uploadThroughputKbps === 750 * 0.9;
         };
-        summary = isSlow4G() ? Util.i18n.strings.runtimeSlow4g : Util.i18n.strings.runtimeCustom;
+        summary = isSlow4G() ?
+          Util.strings.runtimeSlow4g : Util.strings.runtimeCustom;
         break;
       }
       case 'simulate': {
@@ -539,11 +570,12 @@ class Util {
         const isSlow4G = () => {
           return rttMs === 150 && throughputKbps === 1.6 * 1024;
         };
-        summary = isSlow4G() ? Util.i18n.strings.runtimeSlow4g : Util.i18n.strings.runtimeCustom;
+        summary = isSlow4G() ?
+          Util.strings.runtimeSlow4g : Util.strings.runtimeCustom;
         break;
       }
       default:
-        summary = cpuThrottling = networkThrottling = Util.i18n.strings.runtimeUnknown;
+        summary = cpuThrottling = networkThrottling = Util.strings.runtimeUnknown;
     }
 
     // devtools-entry.js always sets `screenEmulation.disabled` when using mobile emulation,
@@ -556,11 +588,11 @@ class Util {
       settings.formFactor === 'mobile' :
       settings.screenEmulation.mobile;
 
-    let deviceEmulation = Util.i18n.strings.runtimeMobileEmulation;
+    let deviceEmulation = Util.strings.runtimeMobileEmulation;
     if (isScreenEmulationDisabled) {
-      deviceEmulation = Util.i18n.strings.runtimeNoEmulation;
+      deviceEmulation = Util.strings.runtimeNoEmulation;
     } else if (!isScreenEmulationMobile) {
-      deviceEmulation = Util.i18n.strings.runtimeDesktopEmulation;
+      deviceEmulation = Util.strings.runtimeDesktopEmulation;
     }
 
     const screenEmulation = isScreenEmulationDisabled ?
@@ -805,6 +837,7 @@ const UIStrings = {
   runtimeCustom: 'Custom throttling',
 };
 Util.UIStrings = UIStrings;
+Util.strings = {...UIStrings};
 
 module.exports = {
   Util,

package/core/util.d.cts

@@ -1,7 +1,119 @@
-export type I18n<T> = any;
+export type I18nFormatter = any;
 export class Util {
-    /** @type {I18n<typeof UIStrings>} */
+    /** @type {I18nFormatter} */
     static i18n: any;
+    static strings: {
+        /** Disclaimer shown to users below the metric values (First Contentful Paint, Time to Interactive, etc) to warn them that the numbers they see will likely change slightly the next time they run Lighthouse. */
+        varianceDisclaimer: string;
+        /** Text link pointing to an interactive calculator that explains Lighthouse scoring. The link text should be fairly short. */
+        calculatorLink: string;
+        /** Label preceding a radio control for filtering the list of audits. The radio choices are various performance metrics (FCP, LCP, TBT), and if chosen, the audits in the report are hidden if they are not relevant to the selected metric. */
+        showRelevantAudits: string;
+        /** Column heading label for the listing of opportunity audits. Each audit title represents an opportunity. There are only 2 columns, so no strict character limit.  */
+        opportunityResourceColumnLabel: string;
+        /** Column heading label for the estimated page load savings of opportunity audits. Estimated Savings is the total amount of time (in seconds) that Lighthouse computed could be reduced from the total page load time, if the suggested action is taken. There are only 2 columns, so no strict character limit. */
+        opportunitySavingsColumnLabel: string;
+        /** An error string displayed next to a particular audit when it has errored, but not provided any specific error message. */
+        errorMissingAuditInfo: string;
+        /** A label, shown next to an audit title or metric title, indicating that there was an error computing it. The user can hover on the label to reveal a tooltip with the extended error message. Translation should be short (< 20 characters). */
+        errorLabel: string;
+        /** This label is shown above a bulleted list of warnings. It is shown directly below an audit that produced warnings. Warnings describe situations the user should be aware of, as Lighthouse was unable to complete all the work required on this audit. For example, The 'Unable to decode image (biglogo.jpg)' warning may show up below an image encoding audit. */
+        warningHeader: string;
+        /** Section heading shown above a list of passed audits that contain warnings. Audits under this section do not negatively impact the score, but Lighthouse has generated some potentially actionable suggestions that should be reviewed. This section is expanded by default and displays after the failing audits. */
+        warningAuditsGroupTitle: string;
+        /** Section heading shown above a list of audits that are passing. 'Passed' here refers to a passing grade. This section is collapsed by default, as the user should be focusing on the failed audits instead. Users can click this heading to reveal the list. */
+        passedAuditsGroupTitle: string;
+        /** Section heading shown above a list of audits that do not apply to the page. For example, if an audit is 'Are images optimized?', but the page has no images on it, the audit will be marked as not applicable. This is neither passing or failing. This section is collapsed by default, as the user should be focusing on the failed audits instead. Users can click this heading to reveal the list. */
+        notApplicableAuditsGroupTitle: string;
+        /** Section heading shown above a list of audits that were not computed by Lighthouse. They serve as a list of suggestions for the user to go and manually check. For example, Lighthouse can't automate testing cross-browser compatibility, so that is listed within this section, so the user is reminded to test it themselves. This section is collapsed by default, as the user should be focusing on the failed audits instead. Users can click this heading to reveal the list. */
+        manualAuditsGroupTitle: string;
+        /** Label shown preceding any important warnings that may have invalidated the entire report. For example, if the user has Chrome extensions installed, they may add enough performance overhead that Lighthouse's performance metrics are unreliable. If shown, this will be displayed at the top of the report UI. */
+        toplevelWarningsMessage: string;
+        /** String of text shown in a graphical representation of the flow of network requests for the web page. This label represents the initial network request that fetches an HTML page. This navigation may be redirected (eg. Initial navigation to http://example.com redirects to https://www.example.com). */
+        crcInitialNavigation: string;
+        /** Label of value shown in the summary of critical request chains. Refers to the total amount of time (milliseconds) of the longest critical path chain/sequence of network requests. Example value: 2310 ms */
+        crcLongestDurationLabel: string;
+        /** Label for button that shows all lines of the snippet when clicked */
+        snippetExpandButtonLabel: string;
+        /** Label for button that only shows a few lines of the snippet when clicked */
+        snippetCollapseButtonLabel: string;
+        /** Explanation shown to users below performance results to inform them that the test was done with a 4G network connection and to warn them that the numbers they see will likely change slightly the next time they run Lighthouse. 'Lighthouse' becomes link text to additional documentation. */
+        lsPerformanceCategoryDescription: string;
+        /** Title of the lab data section of the Performance category. Within this section are various speed metrics which quantify the pageload performance into values presented in seconds and milliseconds. "Lab" is an abbreviated form of "laboratory", and refers to the fact that the data is from a controlled test of a website, not measurements from real users visiting that site.  */
+        labDataTitle: string;
+        /** This label is for a checkbox above a table of items loaded by a web page. The checkbox is used to show or hide third-party (or "3rd-party") resources in the table, where "third-party resources" refers to items loaded by a web page from URLs that aren't controlled by the owner of the web page. */
+        thirdPartyResourcesLabel: string;
+        /** This label is for a button that opens a new tab to a webapp called "Treemap", which is a nested visual representation of a heierarchy of data related to the reports (script bytes and coverage, resource breakdown, etc.) */
+        viewTreemapLabel: string;
+        /** This label is for a button that will show the user a trace of the page. */
+        viewTraceLabel: string;
+        /** This label is for a button that will show the user a trace of the page. */
+        viewOriginalTraceLabel: string;
+        /** Option in a dropdown menu that opens a small, summary report in a print dialog.  */
+        dropdownPrintSummary: string;
+        /** Option in a dropdown menu that opens a full Lighthouse report in a print dialog.  */
+        dropdownPrintExpanded: string;
+        /** Option in a dropdown menu that copies the Lighthouse JSON object to the system clipboard. */
+        dropdownCopyJSON: string;
+        /** Option in a dropdown menu that saves the Lighthouse report HTML locally to the system as a '.html' file. */
+        dropdownSaveHTML: string;
+        /** Option in a dropdown menu that saves the Lighthouse JSON object to the local system as a '.json' file. */
+        dropdownSaveJSON: string;
+        /** Option in a dropdown menu that opens the current report in the Lighthouse Viewer Application. */
+        dropdownViewer: string;
+        /** Option in a dropdown menu that saves the current report as a new GitHub Gist. */
+        dropdownSaveGist: string;
+        /** Option in a dropdown menu that toggles the themeing of the report between Light(default) and Dark themes. */
+        dropdownDarkTheme: string;
+        /** Label for a row in a table that describes the kind of device that was emulated for the Lighthouse run.  Example values for row elements: 'No Emulation', 'Emulated Desktop', etc. */
+        runtimeSettingsDevice: string;
+        /** Label for a row in a table that describes the network throttling conditions that were used during a Lighthouse run, if any. */
+        runtimeSettingsNetworkThrottling: string;
+        /** Label for a row in a table that describes the CPU throttling conditions that were used during a Lighthouse run, if any.*/
+        runtimeSettingsCPUThrottling: string;
+        /** Label for a row in a table that shows the User Agent that was used to send out all network requests during the Lighthouse run. */
+        runtimeSettingsUANetwork: string;
+        /** Label for a row in a table that shows the estimated CPU power of the machine running Lighthouse. Example row values: 532, 1492, 783. */
+        runtimeSettingsBenchmark: string;
+        /** Label for a row in a table that shows the version of the Axe library used. Example row values: 2.1.0, 3.2.3 */
+        runtimeSettingsAxeVersion: string;
+        /** Label for a row in a table that shows the screen resolution and DPR that was emulated for the Lighthouse run. Example values: '800x600, DPR: 3' */
+        runtimeSettingsScreenEmulation: string;
+        /** Label for button to create an issue against the Lighthouse GitHub project. */
+        footerIssue: string;
+        /** Descriptive explanation for emulation setting when no device emulation is set. */
+        runtimeNoEmulation: string;
+        /** Descriptive explanation for emulation setting when emulating a Moto G4 mobile device. */
+        runtimeMobileEmulation: string;
+        /** Descriptive explanation for emulation setting when emulating a generic desktop form factor, as opposed to a mobile-device like form factor. */
+        runtimeDesktopEmulation: string;
+        /** Descriptive explanation for a runtime setting that is set to an unknown value. */
+        runtimeUnknown: string;
+        /** Descriptive label that this analysis run was from a single pageload of a browser (not a summary of hundreds of loads) */
+        runtimeSingleLoad: string;
+        /** Descriptive label that this analysis only considers the initial load of the page, and no interaction beyond when the page had "fully loaded" */
+        runtimeAnalysisWindow: string;
+        /** Descriptive explanation that this analysis run was from a single pageload of a browser, whereas field data often summarizes hundreds+ of page loads */
+        runtimeSingleLoadTooltip: string;
+        /** Descriptive explanation for environment throttling that was provided by the runtime environment instead of provided by Lighthouse throttling. */
+        throttlingProvided: string;
+        /** Label for an interactive control that will reveal or hide a group of content. This control toggles between the text 'Show' and 'Hide'. */
+        show: string;
+        /** Label for an interactive control that will reveal or hide a group of content. This control toggles between the text 'Show' and 'Hide'. */
+        hide: string;
+        /** Label for an interactive control that will reveal or hide a group of content. This control toggles between the text 'Expand view' and 'Collapse view'. */
+        expandView: string;
+        /** Label for an interactive control that will reveal or hide a group of content. This control toggles between the text 'Expand view' and 'Collapse view'. */
+        collapseView: string;
+        /** Label indicating that Lighthouse throttled the page to emulate a slow 4G network connection. */
+        runtimeSlow4g: string;
+        /** Label indicating that Lighthouse throttled the page using custom throttling settings. */
+        runtimeCustom: string;
+    };
+    /**
+     * @param {Record<string, string>} providedStrings
+     */
+    static applyStrings(providedStrings: Record<string, string>): void;
     static get PASS_THRESHOLD(): number;
     static get MS_DISPLAY_VALUE(): string;
     /**