lighthouse 9.5.0-dev.20221214 → 9.5.0-dev.20221216

package/cli/test/smokehouse/config/exclusions.js

@@ -14,7 +14,7 @@ const exclusions = {
   'devtools': [
     // Disabled because normal Chrome usage makes DevTools not function on
     // these poorly constructed pages
-    'errors-expired-ssl', 'errors-infinite-loop', 'dbw' /* dialog prompt */,
+    'errors-expired-ssl', 'errors-infinite-loop',
     // Disabled because Chrome will follow the redirect first, and Lighthouse will
     // only ever see/run the final URL.
     'redirects-client-paint-server', 'redirects-multiple-server',

package/core/audits/accessibility/manual/use-landmarks.js

@@ -18,7 +18,7 @@ class UseLandmarks extends ManualAudit {
   static get meta() {
     return Object.assign({
       id: 'use-landmarks',
-      description: 'Landmark elements (<main>, <nav>, etc.) are used to improve the keyboard navigation of the page for assistive technology. [Learn more about landmark elements](https://developer.chrome.com/docs/lighthouse/accessibility/use-landmarks/).',
+      description: 'Landmark elements (`<main>`, `<nav>`, etc.) are used to improve the keyboard navigation of the page for assistive technology. [Learn more about landmark elements](https://developer.chrome.com/docs/lighthouse/accessibility/use-landmarks/).',
       title: 'HTML5 landmark elements are used to improve navigation',
     }, super.partialMeta);
   }

package/core/audits/dobetterweb/doctype.js

@@ -20,6 +20,8 @@ const UIStrings = {
   explanationNoDoctype: 'Document must contain a doctype',
   /** Explanatory message stating that the document has wrong doctype */
   explanationWrongDoctype: 'Document contains a doctype that triggers quirks-mode',
+  /** Explanatory message stating that the document has wrong doctype */
+  explanationLimitedQuirks: 'Document contains a doctype that triggers limited-quirks-mode',
   /** Explanatory message stating that the publicId field is not empty. */
   explanationPublicId: 'Expected publicId to be an empty string',
   /** Explanatory message stating that the systemId field is not empty. */
@@ -41,6 +43,7 @@ class Doctype extends Audit {
       failureTitle: str_(UIStrings.failureTitle),
       description: str_(UIStrings.description),
       requiredArtifacts: ['Doctype'],
+      __internalOptionalArtifacts: ['InspectorIssues'],
     };
   }
 
@@ -61,6 +64,25 @@ class Doctype extends Audit {
     const doctypePublicId = artifacts.Doctype.publicId;
     const doctypeSystemId = artifacts.Doctype.systemId;
     const compatMode = artifacts.Doctype.documentCompatMode;
+    const quirksModeIssues = artifacts.InspectorIssues?.quirksModeIssue || [];
+
+    // Can only determine limited quirks mode with some helps from the protocol via
+    // inspector issues. But cannot get inspector issues in snapshot mode, so in that
+    // case we cannot distinguish no-quirks-mode from limited-quirks-mode.
+    const isLimitedQuirksMode = quirksModeIssues.some(issue => issue.isLimitedQuirksMode);
+
+    if (compatMode === 'CSS1Compat' && !isLimitedQuirksMode) {
+      return {
+        score: 1,
+      };
+    }
+
+    if (isLimitedQuirksMode) {
+      return {
+        score: 0,
+        explanation: str_(UIStrings.explanationLimitedQuirks),
+      };
+    }
 
     if (doctypePublicId !== '') {
       return {
@@ -87,16 +109,10 @@ class Doctype extends Audit {
 
     // Catch-all for any quirks-mode situations the above checks didn't get.
     // https://github.com/GoogleChrome/lighthouse/issues/10030
-    if (compatMode === 'BackCompat') {
-      return {
-        score: 0,
-        explanation: str_(UIStrings.explanationWrongDoctype),
-      };
-    } else {
-      return {
-        score: 1,
-      };
-    }
+    return {
+      score: 0,
+      explanation: str_(UIStrings.explanationWrongDoctype),
+    };
   }
 }
 

package/core/gather/gatherers/js-usage.js

@@ -59,6 +59,11 @@ class JsUsage extends FRGatherer {
         continue;
       }
 
+      // Scripts run via puppeteer's evaluate interface will have this url.
+      if (scriptUsage.url === '__puppeteer_evaluation_script__') {
+        continue;
+      }
+
       usageByScriptId[scriptUsage.scriptId] = scriptUsage;
     }
 

package/flow-report/test/common-test.tsx

@@ -12,9 +12,10 @@ import {FlowStepThumbnail} from '../src/common';
 
 let lhr: LH.Result;
 
-timers.useFakeTimers();
-
 describe('FlowStepThumbnail', () => {
+  before(() => timers.useFakeTimers());
+  after(() => timers.dispose());
+
   beforeEach(() => {
     global.console.warn = jestMock.fn();
 

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "9.5.0-dev.20221214",
+  "version": "9.5.0-dev.20221216",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {

package/shared/localization/locales/en-US.json

@@ -635,6 +635,9 @@
   "core/audits/dobetterweb/doctype.js | explanationBadDoctype": {
     "message": "Doctype name must be the string `html`"
   },
+  "core/audits/dobetterweb/doctype.js | explanationLimitedQuirks": {
+    "message": "Document contains a doctype that triggers limited-quirks-mode"
+  },
   "core/audits/dobetterweb/doctype.js | explanationNoDoctype": {
     "message": "Document must contain a doctype"
   },

package/shared/localization/locales/en-XL.json

@@ -635,6 +635,9 @@
   "core/audits/dobetterweb/doctype.js | explanationBadDoctype": {
     "message": "D̂óĉt́ŷṕê ńâḿê ḿûśt̂ b́ê t́ĥé ŝt́r̂ín̂ǵ `html`"
   },
+  "core/audits/dobetterweb/doctype.js | explanationLimitedQuirks": {
+    "message": "D̂óĉúm̂én̂t́ ĉón̂t́âín̂ś â d́ôćt̂ýp̂é t̂h́ât́ t̂ŕîǵĝér̂ś l̂ím̂ít̂éd̂-q́ûír̂ḱŝ-ḿôd́ê"
+  },
   "core/audits/dobetterweb/doctype.js | explanationNoDoctype": {
     "message": "D̂óĉúm̂én̂t́ m̂úŝt́ ĉón̂t́âín̂ á d̂óĉt́ŷṕê"
   },