lighthouse 9.5.0-dev.20221211 → 9.5.0-dev.20221213

package/core/lib/bfcache-strings.js

@@ -506,9 +506,13 @@ const UIStrings = {
  */
   errorDocument: 'Back/forward cache is disabled due to a document error.',
   /**
- *  @description Description text for not restored reason ErrorDocument.
+ *  @description Description text for not restored reason FencedFramesEmbedder.
  */
   fencedFramesEmbedder: 'Pages using FencedFrames cannot be stored in bfcache.',
+  /**
+ *  @description Description text for not restored reason KeepaliveRequest.
+ */
+  keepaliveRequest: 'Back/forward cache is disabled due to a keepalive request.',
 };
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
@@ -647,6 +651,7 @@ const NotRestoredReasonDescription = {
       {name: str_(UIStrings.embedderExtensionSentMessageToCachedFrame)},
   'ErrorDocument': {name: str_(UIStrings.errorDocument)},
   'FencedFramesEmbedder': {name: str_(UIStrings.fencedFramesEmbedder)},
+  'KeepaliveRequest': {name: str_(UIStrings.keepaliveRequest)},
 };
 
 export {

package/core/lib/cdt/generated/SourceMap.js

@@ -157,23 +157,25 @@ class TextSourceMap {
     }
     findEntryRanges(lineNumber, columnNumber) {
         const mappings = this.mappings();
-        const index = Platform.ArrayUtilities.upperBound(mappings, undefined, (unused, entry) => lineNumber - entry.lineNumber || columnNumber - entry.columnNumber);
-        if (!index) {
+        const endIndex = Platform.ArrayUtilities.upperBound(mappings, undefined, (unused, entry) => lineNumber - entry.lineNumber || columnNumber - entry.columnNumber);
+        if (!endIndex) {
             // If the line and column are preceding all the entries, then there is nothing to map.
             return null;
         }
-        const sourceURL = mappings[index].sourceURL;
+        // startIndex must be within mappings range because endIndex must be not falsy
+        const startIndex = endIndex - 1;
+        const sourceURL = mappings[startIndex].sourceURL;
         if (!sourceURL) {
             return null;
         }
         // Let us compute the range that contains the source position in the compiled code.
-        const endLine = index < mappings.length ? mappings[index].lineNumber : 2 ** 31 - 1;
-        const endColumn = index < mappings.length ? mappings[index].columnNumber : 2 ** 31 - 1;
-        const range = new TextUtils.TextRange.TextRange(mappings[index - 1].lineNumber, mappings[index - 1].columnNumber, endLine, endColumn);
+        const endLine = endIndex < mappings.length ? mappings[endIndex].lineNumber : 2 ** 31 - 1;
+        const endColumn = endIndex < mappings.length ? mappings[endIndex].columnNumber : 2 ** 31 - 1;
+        const range = new TextUtils.TextRange.TextRange(mappings[startIndex].lineNumber, mappings[startIndex].columnNumber, endLine, endColumn);
         // Now try to find the corresponding token in the original code.
         const reverseMappings = this.reversedMappings(sourceURL);
-        const startSourceLine = mappings[index - 1].sourceLineNumber;
-        const startSourceColumn = mappings[index - 1].sourceColumnNumber;
+        const startSourceLine = mappings[startIndex].sourceLineNumber;
+        const startSourceColumn = mappings[startIndex].sourceColumnNumber;
         const endReverseIndex = Platform.ArrayUtilities.upperBound(reverseMappings, undefined, (unused, i) => startSourceLine - mappings[i].sourceLineNumber || startSourceColumn - mappings[i].sourceColumnNumber);
         if (!endReverseIndex) {
             return null;

package/core/lib/deprecations-strings.js

@@ -38,22 +38,28 @@ const UIStrings = {
   canRequestURLHTTPContainingNewline:
       'Resource requests whose URLs contained both removed whitespace `(n|r|t)` characters and less-than characters (`<`) are blocked. Please remove newlines and encode less-than characters from places like element attribute values in order to load these resources.',
   /**
-   * @description TODO(crbug.com/1320335): Description needed for translation
+   * @description This warning occurs when the website attempts to invoke the
+   *    deprecated `chrome.loadTimes().connectionInfo` API.
    */
   chromeLoadTimesConnectionInfo:
       '`chrome.loadTimes()` is deprecated, instead use standardized API: Navigation Timing 2.',
   /**
-   * @description TODO(crbug.com/1320336): Description needed for translation
+   * @description This warning occurs when the website attempts to invoke the
+   *    deprecated `chrome.loadTimes().firstPaintAfterLoadTime` API.
    */
   chromeLoadTimesFirstPaintAfterLoadTime:
       '`chrome.loadTimes()` is deprecated, instead use standardized API: Paint Timing.',
   /**
-   * @description TODO(crbug.com/1320337): Description needed for translation
+   * @description This warning occurs when the website attempts to invoke the
+   *    deprecated `chrome.loadTimes().wasAlternateProtocolAvailable` API.
    */
   chromeLoadTimesWasAlternateProtocolAvailable:
       '`chrome.loadTimes()` is deprecated, instead use standardized API: `nextHopProtocol` in Navigation Timing 2.',
   /**
-   * @description TODO(crbug.com/1318847): Description needed for translation
+   * @description This warning occurs when the browser attempts to store a
+   *    cookie containing a banned character. Rather than the cookie string
+   *    being truncated at the banned character, the entire cookie will be
+   *    rejected now.
    */
   cookieWithTruncatingChar: 'Cookies containing a `(0|r|n)` character will be rejected instead of truncated.',
   /**
@@ -111,7 +117,9 @@ const UIStrings = {
   geolocationInsecureOriginDeprecatedNotRemoved:
       '`getCurrentPosition()` and `watchPosition()` are deprecated on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://goo.gle/chrome-insecure-origins for more details.',
   /**
-   * @description TODO(crbug.com/1318858): Description needed for translation
+   * @description This warning occurs when the `getUserMedia()` API is invoked
+   *    on an insecure (e.g., HTTP) site. This is only permitted on secure sites
+   *    (e.g., HTTPS).
    */
   getUserMediaInsecureOrigin:
       '`getUserMedia()` no longer works on insecure origins. To use this feature, you should consider switching your application to a secure origin, such as HTTPS. See https://goo.gle/chrome-insecure-origins for more details.',
@@ -127,34 +135,87 @@ const UIStrings = {
    */
   identityInCanMakePaymentEvent: 'The merchant origin and arbitrary data from the `canmakepayment` service worker event are deprecated and will be removed: `topOrigin`, `paymentRequestOrigin`, `methodData`, `modifiers`.',
   /**
-   * @description TODO(crbug.com/1320343): Description needed for translation
+   * @description This warning occurs when an insecure context (e.g., HTTP)
+   *    requests a private resource (not on open internet). This is done to
+   *    mitigate the potential for CSRF and other attacks.
    */
   insecurePrivateNetworkSubresourceRequest:
       'The website requested a subresource from a network that it could only access because of its users\' privileged network position. These requests expose non-public devices and servers to the internet, increasing the risk of a cross-site request forgery (CSRF) attack, and/or information leakage. To mitigate these risks, Chrome deprecates requests to non-public subresources when initiated from non-secure contexts, and will start blocking them.',
   /**
-   * @description A deprecation warning shown in the DevTools Issues tab.
-   * It's shown when a video conferencing website attempts to disable
-   * use of IPv6 addresses with a non-standard API.
-   */
-  legacyConstraintGoogIPv6:
-      'IPv6 is enabled-by-default and the ability to disable it using `googIPv6` is targeted to be removed in M108, after which it will be ignored. Please stop using this legacy constraint.',
-  /**
-   * @description TODO(crbug.com/1318865): Description needed for translation
+   * @description This warning occurs when a stylesheet loaded from a local
+   *    file directive does not end in the file type `.css`.
    */
   localCSSFileExtensionRejected:
       'CSS cannot be loaded from `file:` URLs unless they end in a `.css` file extension.',
   /**
-   * @description TODO(crbug.com/1320345): Description needed for translation
+   * @description This is a deprecation warning to developers that occurs when
+   * the script attempts to use the Media Source Extensions API in a way that
+   * is no longer supported by the specification for the API. The usage
+   * that is problematic is when the script calls the `SourceBuffer.abort()`
+   * method at a time when there is still processing happening in response to a
+   * previous `SourceBuffer.remove()` call for the same SourceBuffer object.
+   * More precisely, we show this warning to developers when script calls the
+   * SourceBuffer abort() method while the asynchronous processing of a remove()
+   * call on that SourceBuffer is not yet complete. Early versions of the Media
+   * Source Extensions specification allowed such aborts, but standardization of
+   * the specification resulted in disallowing the aborts. The script should
+   * instead wait for the asynchronous remove() operation to complete, which is
+   * observable by listening for the associated 'updateend' event from the
+   * SourceBuffer. A note is also included in the warning, describing when
+   * abort() is meaningful and allowed by the specification for purposes other
+   * than interrupting a remove() operation's asynchronous steps. Those
+   * supported purposes include using abort() to interrupt processing that may
+   * still be happening in response to a previous appendBuffer() call on that
+   * SourceBuffer, or using abort() to clear the internal of any unprocessed
+   * data remaining from previous appendBuffer() calls.
+   * See https://www.w3.org/TR/media-source-2/#dom-sourcebuffer-abort for the
+   * currently specified behavior, which would throw an exception once the
+   * deprecated removal abort is no longer supported.
+   * See https://github.com/w3c/media-source/issues/19 for the discussion that
+   * led to the specification change.
    */
   mediaSourceAbortRemove:
       'Using `SourceBuffer.abort()` to abort `remove()`\'s asynchronous range removal is deprecated due to specification change. Support will be removed in the future. You should listen to the `updateend` event instead. `abort()` is intended to only abort an asynchronous media append or reset parser state.',
   /**
-   * @description TODO(crbug.com/1320346): Description needed for translation
+   * @description This is a deprecation warning to developers that occurs when
+   * the script attempts to use the Media Source Extensions API in a way that is
+   * no longer supported by the specification for the API. The usage that is
+   * problematic is when the script sets the duration attribute of a MediaSource
+   * object too low. The duration attribute of a MediaSource must be longer than
+   * the actual duration of any media (audio or video) already in the
+   * MediaSource. When set too low, the MediaSource must remove audio and video
+   * content that is beyond the time indicated by the new duration. Content
+   * removal that is caused by setting the duration attribute too low is no
+   * longer allowed by the specification. The message describes the minimum
+   * allowable duration value as the "highest presentation timestamp of any
+   * buffered coded frames" as a more precise way of describing the duration of
+   * content already in the MediaSource: "coded frames" are the specification's
+   * way of describing compressed audio frames or compressed video frames, and
+   * they each have a "presentation timestamp" that describes precisely when
+   * that frame's playback occurs in the overall media presentation. Early
+   * versions of the Media Source Extensions specification allowed this to
+   * happen, but standardization of the specification resulted in disallowing
+   * this behavior. The underlying issue leading to this specification change
+   * was that setting the duration attribute should be synchronous, but setting
+   * it lower than the timestamp of something currently buffered would cause
+   * confusing removal of media between that new duration and the previous,
+   * larger, duration. The script should instead explicitly remove that range of
+   * media first, before lowering the duration.
+   * See https://www.w3.org/TR/media-source-2/#dom-mediasource-duration and
+   * https://www.w3.org/TR/media-source-2/#dom-mediasource-duration for the
+   * currently specified behavior, which would throw an exception once support
+   * is removed for deprecated implicit asynchronous range removal when duration
+   * is truncated.
+   * See both https://github.com/w3c/media-source/issues/20 and
+   * https://github.com/w3c/media-source/issues/26 for the discussion that led
+   * to the specification change.
    */
   mediaSourceDurationTruncatingBuffered:
       'Setting `MediaSource.duration` below the highest presentation timestamp of any buffered coded frames is deprecated due to specification change. Support for implicit removal of truncated buffered media will be removed in the future. You should instead perform explicit `remove(newDuration, oldDuration)` on all `sourceBuffers`, where `newDuration < oldDuration`.',
   /**
-   * @description TODO(crbug.com/1320347): Description needed for translation
+   * @description This warning occurs when the browser requests Web MIDI access
+   *    as sysex (system exclusive messages) can be allowed via prompt even if
+   *    the browser did not specifically request it.
    */
   noSysexWebMIDIWithoutPermission:
       'Web MIDI will ask a permission to use even if the sysex is not specified in the `MIDIOptions`.',
@@ -169,7 +230,9 @@ const UIStrings = {
   notificationPermissionRequestedIframe:
       'Permission for the Notification API may no longer be requested from a cross-origin iframe. You should consider requesting permission from a top-level frame or opening a new window instead.',
   /**
-   * @description TODO(crbug.com/1318867): Description needed for translation
+   * @description This warning occurs when the WebRTC protocol attempts to
+   *    negotiate a connection using an obsolete cipher and risks connection
+   *    security.
    */
   obsoleteWebRtcCipherSuite:
       'Your partner is negotiating an obsolete (D)TLS version. Please check with your partner to have this fixed.',
@@ -178,6 +241,14 @@ const UIStrings = {
    */
   openWebDatabaseInsecureContext:
       'WebSQL in non-secure contexts is deprecated and will be removed soon. Please use Web Storage or Indexed Database.',
+  /**
+   * @description Warning displayed to developers when they use the PaymentInstruments API to let them know this API is deprecated.
+   */
+  paymentInstruments: '`paymentManager.instruments` is deprecated. Please use just-in-time install for payment handlers instead.',
+  /**
+   * @description Warning displayed to developers when their Web Payment API usage violates their Content-Security-Policy (CSP) connect-src directive to let them know this CSP bypass has been deprecated.
+   */
+  paymentRequestCSPViolation: 'Your `PaymentRequest` call bypassed Content-Security-Policy (CSP) `connect-src` directive. This bypass is deprecated. Please add the payment method identifier from the `PaymentRequest` API (in `supportedMethods` field) to your CSP `connect-src` directive.',
   /**
    * @description Warning displayed to developers when persistent storage type is used to notify that storage type is deprecated.
    */
@@ -208,7 +279,8 @@ const UIStrings = {
    */
   deprecatedWithReplacement: '{PH1} is deprecated. Please use {PH2} instead.',
   /**
-   * @description TODO(crbug.com/1320357): Description needed for translation
+   * @description This warning occurs when a subresource loaded by a page
+   *    has a URL with an authority portion. These are disallowed.
    */
   requestedSubresourceWithEmbeddedCredentials:
       'Subresource requests whose URLs contain embedded credentials (e.g. `https://user:pass@host/`) are blocked.',
@@ -303,6 +375,14 @@ const UIStrings = {
    */
   xrSupportsSession:
       '`supportsSession()` is deprecated. Please use `isSessionSupported()` and check the resolved boolean value instead.',
+  /**
+   * @description Warning displayed to developers that use overflow:visible
+   * for replaced elements. This declaration was earlier ignored but will now
+   * change the element's painting based on whether the overflow value allows
+   * the element to paint outside its bounds.
+   */
+  overflowVisibleOnReplacedElement:
+      'Specifying `overflow: visible` on img, video and canvas tags may cause them to produce visual content outside of the element bounds. See https://github.com/WICG/shared-element-transitions/blob/main/debugging_overflow_on_images.md.',
 };
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
@@ -395,10 +475,6 @@ function getDescription(issueDetails) {
         feature = 5436853517811712;
         milestone = 92;
         break;
-      case 'LegacyConstraintGoogIPv6':
-        message = str_(UIStrings.legacyConstraintGoogIPv6);
-        milestone = 103;
-        break;
       case 'LocalCSSFileExtensionRejected':
         message = str_(UIStrings.localCSSFileExtensionRejected);
         milestone = 64;
@@ -411,15 +487,6 @@ function getDescription(issueDetails) {
         message = str_(UIStrings.mediaSourceDurationTruncatingBuffered);
         feature = 6107495151960064;
         break;
-      case 'NavigateEventRestoreScroll':
-        message = str_(
-            UIStrings.deprecatedWithReplacement, {PH1: 'navigateEvent.restoreScroll()', PH2: 'navigateEvent.scroll()'});
-        break;
-      case 'NavigateEventTransitionWhile':
-        message = str_(
-            UIStrings.deprecatedWithReplacement,
-            {PH1: 'navigateEvent.transitionWhile()', PH2: 'navigateEvent.intercept()'});
-        break;
       case 'NoSysexWebMIDIWithoutPermission':
         message = str_(UIStrings.noSysexWebMIDIWithoutPermission);
         feature = 5138066234671104;
@@ -441,6 +508,14 @@ function getDescription(issueDetails) {
         feature = 5175124599767040;
         milestone = 105;
         break;
+      case 'PaymentInstruments':
+        message = str_(UIStrings.paymentInstruments);
+        feature = 5099285054488576;
+        break;
+      case 'PaymentRequestCSPViolation':
+        message = str_(UIStrings.paymentRequestCSPViolation);
+        feature = 6286595631087616;
+        break;
       case 'PersistentQuotaType':
         message = str_(UIStrings.persistentQuotaType);
         feature = 5176235376246784;
@@ -498,6 +573,11 @@ function getDescription(issueDetails) {
         message = str_(UIStrings.requestedSubresourceWithEmbeddedCredentials);
         feature = 5669008342777856;
         break;
+      case 'OverflowVisibleOnReplacedElement':
+        message = str_(UIStrings.overflowVisibleOnReplacedElement);
+        feature = 5137515594383360;
+        milestone = 108;
+        break;
       case 'RTCConstraintEnableDtlsSrtpFalse':
         message = str_(UIStrings.rtcConstraintEnableDtlsSrtpFalse);
         milestone = 97;

package/core/lib/i18n/i18n.js

@@ -173,6 +173,11 @@ function lookupLocale(locales, possibleLocales) {
 function createIcuMessageFn(filename, fileStrings) {
   if (filename.startsWith('file://')) filename = url.fileURLToPath(filename);
 
+  // In the common case, `filename` is an absolute path that needs to be transformed
+  // to be relative to LH_ROOT. In other cases, `filename` might be the exact i18n identifier
+  // already (see: stack-packs.js, or bundled lighthouse).
+  if (path.isAbsolute(filename)) filename = path.relative(LH_ROOT, filename);
+
   /**
    * Combined so fn can access both caller's strings and i18n.UIStrings shared across LH.
    * @type {Record<string, string>}
@@ -189,8 +194,12 @@ function createIcuMessageFn(filename, fileStrings) {
     const keyname = Object.keys(mergedStrings).find(key => mergedStrings[key] === message);
     if (!keyname) throw new Error(`Could not locate: ${message}`);
 
-    const filenameToLookup = keyname in fileStrings ? filename : getModulePath(import.meta);
-    const unixStyleFilename = path.relative(LH_ROOT, filenameToLookup).replace(/\\/g, '/');
+    // `message` can be a UIString defined within the provided `fileStrings`, or it could be
+    // one of the common strings found in `i18n.UIStrings`.
+    const filenameToLookup = keyname in fileStrings ?
+      filename :
+      path.relative(LH_ROOT, getModulePath(import.meta));
+    const unixStyleFilename = filenameToLookup.replace(/\\/g, '/');
     const i18nId = `${unixStyleFilename} | ${keyname}`;
 
     return {

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "9.5.0-dev.20221211",
+  "version": "9.5.0-dev.20221213",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {
@@ -134,13 +134,13 @@
     "archiver": "^3.0.0",
     "c8": "^7.11.3",
     "chalk": "^2.4.1",
-    "chrome-devtools-frontend": "1.0.1040857",
+    "chrome-devtools-frontend": "1.0.1070764",
     "concurrently": "^6.4.0",
     "conventional-changelog-cli": "^2.1.1",
     "cpy": "^8.1.2",
     "cross-env": "^7.0.2",
     "csv-validator": "^0.0.3",
-    "devtools-protocol": "0.0.1034970",
+    "devtools-protocol": "0.0.1081726",
     "es-main": "^1.0.2",
     "eslint": "^8.4.1",
     "eslint-config-google": "^0.14.0",
@@ -212,8 +212,8 @@
     "yargs-parser": "^21.0.0"
   },
   "resolutions": {
-    "puppeteer/**/devtools-protocol": "0.0.1034970",
-    "puppeteer-core/**/devtools-protocol": "0.0.1034970",
+    "puppeteer/**/devtools-protocol": "0.0.1081726",
+    "puppeteer-core/**/devtools-protocol": "0.0.1081726",
     "testdouble/**/quibble": "connorjclark/quibble#fork"
   },
   "repository": "GoogleChrome/lighthouse",

package/shared/localization/locales/en-US.json

@@ -1844,6 +1844,9 @@
   "core/lib/bfcache-strings.js | JavaScriptExecution": {
     "message": "Chrome detected an attempt to execute JavaScript while in the cache."
   },
+  "core/lib/bfcache-strings.js | keepaliveRequest": {
+    "message": "Back/forward cache is disabled due to a keepalive request."
+  },
   "core/lib/bfcache-strings.js | keyboardLock": {
     "message": "Pages that use Keyboard lock are not currently eligible for back/forward cache."
   },
@@ -2138,9 +2141,6 @@
   "core/lib/deprecations-strings.js | insecurePrivateNetworkSubresourceRequest": {
     "message": "The website requested a subresource from a network that it could only access because of its users' privileged network position. These requests expose non-public devices and servers to the internet, increasing the risk of a cross-site request forgery (CSRF) attack, and/or information leakage. To mitigate these risks, Chrome deprecates requests to non-public subresources when initiated from non-secure contexts, and will start blocking them."
   },
-  "core/lib/deprecations-strings.js | legacyConstraintGoogIPv6": {
-    "message": "IPv6 is enabled-by-default and the ability to disable it using `googIPv6` is targeted to be removed in M108, after which it will be ignored. Please stop using this legacy constraint."
-  },
   "core/lib/deprecations-strings.js | localCSSFileExtensionRejected": {
     "message": "CSS cannot be loaded from `file:` URLs unless they end in a `.css` file extension."
   },
@@ -2168,6 +2168,15 @@
   "core/lib/deprecations-strings.js | openWebDatabaseInsecureContext": {
     "message": "WebSQL in non-secure contexts is deprecated and will be removed soon. Please use Web Storage or Indexed Database."
   },
+  "core/lib/deprecations-strings.js | overflowVisibleOnReplacedElement": {
+    "message": "Specifying `overflow: visible` on img, video and canvas tags may cause them to produce visual content outside of the element bounds. See https://github.com/WICG/shared-element-transitions/blob/main/debugging_overflow_on_images.md."
+  },
+  "core/lib/deprecations-strings.js | paymentInstruments": {
+    "message": "`paymentManager.instruments` is deprecated. Please use just-in-time install for payment handlers instead."
+  },
+  "core/lib/deprecations-strings.js | paymentRequestCSPViolation": {
+    "message": "Your `PaymentRequest` call bypassed Content-Security-Policy (CSP) `connect-src` directive. This bypass is deprecated. Please add the payment method identifier from the `PaymentRequest` API (in `supportedMethods` field) to your CSP `connect-src` directive."
+  },
   "core/lib/deprecations-strings.js | persistentQuotaType": {
     "message": "`StorageType.persistent` is deprecated. Please use standardized `navigator.storage` instead."
   },

package/shared/localization/locales/en-XL.json

@@ -1844,6 +1844,9 @@
   "core/lib/bfcache-strings.js | JavaScriptExecution": {
     "message": "Ĉh́r̂óm̂é d̂ét̂éĉt́êd́ âń ât́t̂ém̂ṕt̂ t́ô éx̂éĉút̂é Ĵáv̂áŜćr̂íp̂t́ ŵh́îĺê ín̂ t́ĥé ĉáĉh́ê."
   },
+  "core/lib/bfcache-strings.js | keepaliveRequest": {
+    "message": "B̂áĉḱ/f̂ór̂ẃâŕd̂ ćâćĥé îś d̂íŝáb̂ĺêd́ d̂úê t́ô á k̂éêṕâĺîv́ê ŕêq́ûéŝt́."
+  },
   "core/lib/bfcache-strings.js | keyboardLock": {
     "message": "P̂áĝéŝ t́ĥát̂ úŝé K̂éŷb́ôár̂d́ l̂óĉḱ âŕê ńôt́ ĉúr̂ŕêńt̂ĺŷ él̂íĝíb̂ĺê f́ôŕ b̂áĉḱ/f̂ór̂ẃâŕd̂ ćâćĥé."
   },
@@ -2138,9 +2141,6 @@
   "core/lib/deprecations-strings.js | insecurePrivateNetworkSubresourceRequest": {
     "message": "T̂h́ê ẃêb́ŝít̂é r̂éq̂úêśt̂éd̂ á ŝúb̂ŕêśôúr̂ćê f́r̂óm̂ á n̂ét̂ẃôŕk̂ t́ĥát̂ ít̂ ćôúl̂d́ ôńl̂ý âćĉéŝś b̂éĉáûśê óf̂ ít̂ś ûśêŕŝ' ṕr̂ív̂íl̂éĝéd̂ ńêt́ŵór̂ḱ p̂óŝít̂íôń. T̂h́êśê ŕêq́ûéŝt́ŝ éx̂ṕôśê ńôń-p̂úb̂ĺîć d̂év̂íĉéŝ án̂d́ ŝér̂v́êŕŝ t́ô t́ĥé îńt̂ér̂ńêt́, îńĉŕêáŝín̂ǵ t̂h́ê ŕîśk̂ óf̂ á ĉŕôśŝ-śît́ê ŕêq́ûéŝt́ f̂ór̂ǵêŕŷ (ĆŜŔF̂) át̂t́âćk̂, án̂d́/ôŕ îńf̂ór̂ḿât́îón̂ ĺêák̂áĝé. T̂ó m̂ít̂íĝát̂é t̂h́êśê ŕîśk̂ś, Ĉh́r̂óm̂é d̂ép̂ŕêćât́êś r̂éq̂úêśt̂ś t̂ó n̂ón̂-ṕûb́l̂íĉ śûb́r̂éŝóûŕĉéŝ ẃĥén̂ ín̂ít̂íât́êd́ f̂ŕôḿ n̂ón̂-śêćûŕê ćôńt̂éx̂t́ŝ, án̂d́ ŵíl̂ĺ ŝt́âŕt̂ b́l̂óĉḱîńĝ t́ĥém̂."
   },
-  "core/lib/deprecations-strings.js | legacyConstraintGoogIPv6": {
-    "message": "ÎṔv̂6 íŝ én̂áb̂ĺêd́-b̂ý-d̂éf̂áûĺt̂ án̂d́ t̂h́ê áb̂íl̂ít̂ý t̂ó d̂íŝáb̂ĺê ít̂ úŝín̂ǵ `googIPv6` îś t̂ár̂ǵêt́êd́ t̂ó b̂é r̂ém̂óv̂éd̂ ín̂ Ḿ108, âf́t̂ér̂ ẃĥíĉh́ ît́ ŵíl̂ĺ b̂é îǵn̂ór̂éd̂. Ṕl̂éâśê śt̂óp̂ úŝín̂ǵ t̂h́îś l̂éĝáĉý ĉón̂śt̂ŕâín̂t́."
-  },
   "core/lib/deprecations-strings.js | localCSSFileExtensionRejected": {
     "message": "ĈŚŜ ćâńn̂ót̂ b́ê ĺôád̂éd̂ f́r̂óm̂ `file:` ÚR̂Ĺŝ ún̂ĺêśŝ t́ĥéŷ én̂d́ îń â `.css` f́îĺê éx̂t́êńŝíôń."
   },
@@ -2168,6 +2168,15 @@
   "core/lib/deprecations-strings.js | openWebDatabaseInsecureContext": {
     "message": "Ŵéb̂ŚQ̂Ĺ îń n̂ón̂-śêćûŕê ćôńt̂éx̂t́ŝ íŝ d́êṕr̂éĉát̂éd̂ án̂d́ ŵíl̂ĺ b̂é r̂ém̂óv̂éd̂ śôón̂. Ṕl̂éâśê úŝé Ŵéb̂ Śt̂ór̂áĝé ôŕ Îńd̂éx̂éd̂ D́ât́âb́âśê."
   },
+  "core/lib/deprecations-strings.js | overflowVisibleOnReplacedElement": {
+    "message": "Ŝṕêćîf́ŷín̂ǵ `overflow: visible` ôń îḿĝ, v́îd́êó âńd̂ ćâńv̂áŝ t́âǵŝ ḿâý ĉáûśê t́ĥém̂ t́ô ṕr̂ód̂úĉé v̂íŝúâĺ ĉón̂t́êńt̂ óût́ŝíd̂é ôf́ t̂h́ê él̂ém̂én̂t́ b̂óûńd̂ś. Ŝéê h́t̂t́p̂ś://ĝít̂h́ûb́.ĉóm̂/ẂÎĆĜ/śĥár̂éd̂-él̂ém̂én̂t́-t̂ŕâńŝít̂íôńŝ/b́l̂ób̂/ḿâín̂/d́êb́ûǵĝín̂ǵ_ôv́êŕf̂ĺôẃ_ôń_îḿâǵêś.m̂d́."
+  },
+  "core/lib/deprecations-strings.js | paymentInstruments": {
+    "message": "`paymentManager.instruments` îś d̂ép̂ŕêćât́êd́. P̂ĺêáŝé ûśê j́ûśt̂-ín̂-t́îḿê ín̂śt̂ál̂ĺ f̂ór̂ ṕâým̂én̂t́ ĥán̂d́l̂ér̂ś îńŝt́êád̂."
+  },
+  "core/lib/deprecations-strings.js | paymentRequestCSPViolation": {
+    "message": "Ŷóûŕ `PaymentRequest` ĉál̂ĺ b̂ýp̂áŝśêd́ Ĉón̂t́êńt̂-Śêćûŕît́ŷ-Ṕôĺîćŷ (ĆŜṔ) `connect-src` d̂ír̂éĉt́îv́ê. T́ĥíŝ b́ŷṕâśŝ íŝ d́êṕr̂éĉát̂éd̂. Ṕl̂éâśê ád̂d́ t̂h́ê ṕâým̂én̂t́ m̂ét̂h́ôd́ îd́êńt̂íf̂íêŕ f̂ŕôḿ t̂h́ê `PaymentRequest` ÁP̂Í (îń `supportedMethods` f̂íêĺd̂) t́ô ýôúr̂ ĆŜṔ `connect-src` d̂ír̂éĉt́îv́ê."
+  },
   "core/lib/deprecations-strings.js | persistentQuotaType": {
     "message": "`StorageType.persistent` îś d̂ép̂ŕêćât́êd́. P̂ĺêáŝé ûśê śt̂án̂d́âŕd̂íẑéd̂ `navigator.storage` ín̂śt̂éâd́."
   },

package/shared/test/localization/format-test.js

@@ -11,6 +11,7 @@ import * as constants from '../../../core/config/constants.js';
 import * as format from '../../localization/format.js';
 import {locales} from '../../localization/locales.js';
 import {getModuleDirectory, getModulePath} from '../../../esm-utils.js';
+import {LH_ROOT} from '../../../root.js';
 
 const moduleDir = getModuleDirectory(import.meta);
 const modulePath = getModulePath(import.meta);
@@ -185,37 +186,41 @@ describe('format', () => {
       expect(formattedStr).toEqual('en-XZ cuerda!');
     });
 
-    it('overwrites existing locale strings', async () => {
-      const filename = 'core/audits/is-on-https.js';
-      const {UIStrings} = await import('../../../core/audits/is-on-https.js');
-      const str_ = i18n.createIcuMessageFn(filename, UIStrings);
-
-      // To start with, we get back the intended string..
-      const origTitle = format.getFormatted(str_(UIStrings.title), 'es-419');
-      expect(origTitle).toEqual('Usa HTTPS');
-      const origFailureTitle = format.getFormatted(str_(UIStrings.failureTitle), 'es-419');
-      expect(origFailureTitle).toEqual('No usa HTTPS');
-
-      // Now we declare and register the new string...
-      const localeData = {
-        'core/audits/is-on-https.js | title': {
-          'message': 'new string for es-419 uses https!',
-        },
-      };
-      format.registerLocaleData('es-419', localeData);
-
-      // And confirm that's what is returned
-      const newTitle = format.getFormatted(str_(UIStrings.title), 'es-419');
-      expect(newTitle).toEqual('new string for es-419 uses https!');
-
-      // Meanwhile another string that wasn't set in registerLocaleData just falls back to english
-      const newFailureTitle = format.getFormatted(str_(UIStrings.failureTitle), 'es-419');
-      expect(newFailureTitle).toEqual('Does not use HTTPS');
-
-      // Restore overwritten strings to avoid messing with other tests
-      locales['es-419'] = clonedLocales['es-419'];
-      const title = format.getFormatted(str_(UIStrings.title), 'es-419');
-      expect(title).toEqual('Usa HTTPS');
+    [
+      {label: 'relative path', filename: 'core/audits/is-on-https.js'},
+      {label: 'absolute path', filename: `${LH_ROOT}/core/audits/is-on-https.js`},
+    ].forEach(({label, filename}) => {
+      it(`overwrites existing locale strings: ${label}`, async () => {
+        const {UIStrings} = await import('../../../core/audits/is-on-https.js');
+        const str_ = i18n.createIcuMessageFn(filename, UIStrings);
+
+        // To start with, we get back the intended string..
+        const origTitle = format.getFormatted(str_(UIStrings.title), 'es-419');
+        expect(origTitle).toEqual('Usa HTTPS');
+        const origFailureTitle = format.getFormatted(str_(UIStrings.failureTitle), 'es-419');
+        expect(origFailureTitle).toEqual('No usa HTTPS');
+
+        // Now we declare and register the new string...
+        const localeData = {
+          'core/audits/is-on-https.js | title': {
+            'message': 'new string for es-419 uses https!',
+          },
+        };
+        format.registerLocaleData('es-419', localeData);
+
+        // And confirm that's what is returned
+        const newTitle = format.getFormatted(str_(UIStrings.title), 'es-419');
+        expect(newTitle).toEqual('new string for es-419 uses https!');
+
+        // Meanwhile another string that wasn't set in registerLocaleData just falls back to english
+        const newFailureTitle = format.getFormatted(str_(UIStrings.failureTitle), 'es-419');
+        expect(newFailureTitle).toEqual('Does not use HTTPS');
+
+        // Restore overwritten strings to avoid messing with other tests
+        locales['es-419'] = clonedLocales['es-419'];
+        const title = format.getFormatted(str_(UIStrings.title), 'es-419');
+        expect(title).toEqual('Usa HTTPS');
+      });
     });
   });
 

package/tsconfig.json

@@ -105,8 +105,9 @@
   ],
   "files": [
     // Opt-in to typechecking for some core tests and test-support files.
-    "core/test/audits/script-treemap-data-test.js",
     "cli/test/fixtures/static-server.js",
+    "core/test/audits/script-treemap-data-test.js",
+    "core/test/computed/metrics/interactive-test.js",
     "core/test/fixtures/config-plugins/lighthouse-plugin-simple/plugin-simple.js",
   ],
 }