lighthouse 9.5.0-dev.20221019 → 9.5.0-dev.20221020

package/core/audits/seo/plugins.js

@@ -134,7 +134,7 @@ class Plugins extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'source', itemType: 'code', text: 'Element source'},
+      {key: 'source', valueType: 'code', label: 'Element source'},
     ];
 
     const details = Audit.makeTableDetails(headings, plugins);

package/core/audits/seo/robots-txt.js

@@ -230,9 +230,9 @@ class RobotsTxt extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'index', itemType: 'text', text: 'Line #'},
-      {key: 'line', itemType: 'code', text: 'Content'},
-      {key: 'message', itemType: 'code', text: 'Error'},
+      {key: 'index', valueType: 'text', label: 'Line #'},
+      {key: 'line', valueType: 'code', label: 'Content'},
+      {key: 'message', valueType: 'code', label: 'Error'},
     ];
 
     const details = Audit.makeTableDetails(headings, validationErrors, {});

package/core/audits/seo/tap-targets.js

@@ -286,9 +286,9 @@ class TapTargets extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'tapTarget', itemType: 'node', text: str_(UIStrings.tapTargetHeader)},
-      {key: 'size', itemType: 'text', text: str_(i18n.UIStrings.columnSize)},
-      {key: 'overlappingTarget', itemType: 'node', text: str_(UIStrings.overlappingTargetHeader)},
+      {key: 'tapTarget', valueType: 'node', label: str_(UIStrings.tapTargetHeader)},
+      {key: 'size', valueType: 'text', label: str_(i18n.UIStrings.columnSize)},
+      {key: 'overlappingTarget', valueType: 'node', label: str_(UIStrings.overlappingTargetHeader)},
     ];
 
     const details = Audit.makeTableDetails(headings, tableItems);

package/core/audits/themed-omnibox.js

@@ -4,8 +4,6 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-import cssParsers from 'cssstyle/lib/parsers.js';
-
 import MultiCheckAudit from './multi-check-audit.js';
 import {ManifestValues} from '../computed/manifest-values.js';
 import * as i18n from '../lib/i18n/i18n.js';
@@ -28,8 +26,10 @@ const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
  *
  * Requirements:
  *   * manifest is not empty
- *   * manifest has a valid theme_color
- *   * HTML has a valid theme-color meta
+ *   * manifest has a theme_color
+ *   * HTML has a theme-color meta
+ *
+ * Color validity is explicitly not checked.
  */
 
 class ThemedOmnibox extends MultiCheckAudit {
@@ -47,14 +47,6 @@ class ThemedOmnibox extends MultiCheckAudit {
     };
   }
 
-  /**
-   * @param {string} color
-   * @return {boolean}
-   */
-  static isValidColor(color) {
-    return cssParsers.valueType(color) === cssParsers.TYPES.COLOR;
-  }
-
   /**
    * @param {LH.Artifacts.MetaElement|undefined} themeColorMeta
    * @param {Array<string>} failures
@@ -63,8 +55,8 @@ class ThemedOmnibox extends MultiCheckAudit {
     if (!themeColorMeta) {
       // TODO(#7238): i18n
       failures.push('No `<meta name="theme-color">` tag found');
-    } else if (!ThemedOmnibox.isValidColor(themeColorMeta.content || '')) {
-      failures.push('The theme-color meta tag did not contain a valid CSS color');
+    } else if (!themeColorMeta.content) {
+      failures.push('The theme-color meta tag did not contain a content value');
     }
   }
 

package/core/audits/third-party-facades.js

@@ -201,9 +201,9 @@ class ThirdPartyFacades extends Audit {
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
       /* eslint-disable max-len */
-      {key: 'product', itemType: 'text', subItemsHeading: {key: 'url', itemType: 'url'}, text: str_(UIStrings.columnProduct)},
-      {key: 'transferSize', itemType: 'bytes', subItemsHeading: {key: 'transferSize'}, granularity: 1, text: str_(i18n.UIStrings.columnTransferSize)},
-      {key: 'blockingTime', itemType: 'ms', subItemsHeading: {key: 'blockingTime'}, granularity: 1, text: str_(i18n.UIStrings.columnBlockingTime)},
+      {key: 'product', valueType: 'text', subItemsHeading: {key: 'url', valueType: 'url'}, label: str_(UIStrings.columnProduct)},
+      {key: 'transferSize', valueType: 'bytes', subItemsHeading: {key: 'transferSize'}, granularity: 1, label: str_(i18n.UIStrings.columnTransferSize)},
+      {key: 'blockingTime', valueType: 'ms', subItemsHeading: {key: 'blockingTime'}, granularity: 1, label: str_(i18n.UIStrings.columnBlockingTime)},
       /* eslint-enable max-len */
     ];
 

package/core/audits/third-party-summary.js

@@ -232,9 +232,9 @@ class ThirdPartySummary extends Audit {
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
       /* eslint-disable max-len */
-      {key: 'entity', itemType: 'link', text: str_(UIStrings.columnThirdParty), subItemsHeading: {key: 'url', itemType: 'url'}},
-      {key: 'transferSize', granularity: 1, itemType: 'bytes', text: str_(i18n.UIStrings.columnTransferSize), subItemsHeading: {key: 'transferSize'}},
-      {key: 'blockingTime', granularity: 1, itemType: 'ms', text: str_(i18n.UIStrings.columnBlockingTime), subItemsHeading: {key: 'blockingTime'}},
+      {key: 'entity', valueType: 'link', label: str_(UIStrings.columnThirdParty), subItemsHeading: {key: 'url', valueType: 'url'}},
+      {key: 'transferSize', granularity: 1, valueType: 'bytes', label: str_(i18n.UIStrings.columnTransferSize), subItemsHeading: {key: 'transferSize'}},
+      {key: 'blockingTime', granularity: 1, valueType: 'ms', label: str_(i18n.UIStrings.columnBlockingTime), subItemsHeading: {key: 'blockingTime'}},
       /* eslint-enable max-len */
     ];
 

package/core/audits/timing-budget.js

@@ -154,13 +154,13 @@ class TimingBudget extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headers = [
-      {key: 'label', itemType: 'text', text: str_(UIStrings.columnTimingMetric)},
+      {key: 'label', valueType: 'text', label: str_(UIStrings.columnTimingMetric)},
       /**
        * Note: SpeedIndex, unlike other timing metrics, is not measured in milliseconds.
        * The renderer applies the correct units to the 'measurement' and 'overBudget' columns for SpeedIndex.
        */
-      {key: 'measurement', itemType: 'ms', text: str_(UIStrings.columnMeasurement)},
-      {key: 'overBudget', itemType: 'ms', text: str_(i18n.UIStrings.columnOverBudget)},
+      {key: 'measurement', valueType: 'ms', label: str_(UIStrings.columnMeasurement)},
+      {key: 'overBudget', valueType: 'ms', label: str_(i18n.UIStrings.columnOverBudget)},
     ];
 
     return {

package/core/audits/unsized-images.js

@@ -146,8 +146,8 @@ class UnsizedImages extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'node', itemType: 'node', text: ''},
-      {key: 'url', itemType: 'url', text: str_(i18n.UIStrings.columnURL)},
+      {key: 'node', valueType: 'node', label: ''},
+      {key: 'url', valueType: 'url', label: str_(i18n.UIStrings.columnURL)},
     ];
 
     return {

package/core/audits/user-timings.js

@@ -89,12 +89,12 @@ class UserTimings extends Audit {
 
       /** @type {LH.Audit.Details.Table['headings']} */
       const headings = [
-        {key: 'name', itemType: 'text', text: str_(i18n.UIStrings.columnName)},
-        {key: 'timingType', itemType: 'text', text: str_(UIStrings.columnType)},
-        {key: 'startTime', itemType: 'ms', granularity: 0.01,
-          text: str_(i18n.UIStrings.columnStartTime)},
-        {key: 'duration', itemType: 'ms', granularity: 0.01,
-          text: str_(i18n.UIStrings.columnDuration)},
+        {key: 'name', valueType: 'text', label: str_(i18n.UIStrings.columnName)},
+        {key: 'timingType', valueType: 'text', label: str_(UIStrings.columnType)},
+        {key: 'startTime', valueType: 'ms', granularity: 0.01,
+          label: str_(i18n.UIStrings.columnStartTime)},
+        {key: 'duration', valueType: 'ms', granularity: 0.01,
+          label: str_(i18n.UIStrings.columnDuration)},
       ];
 
       const details = Audit.makeTableDetails(headings, tableRows);

package/core/audits/valid-source-maps.js

@@ -119,11 +119,11 @@ class ValidSourceMaps extends Audit {
       /* eslint-disable max-len */
       {
         key: 'scriptUrl',
-        itemType: 'url',
+        valueType: 'url',
         subItemsHeading: {key: 'error'},
-        text: str_(i18n.UIStrings.columnURL),
+        label: str_(i18n.UIStrings.columnURL),
       },
-      {key: 'sourceMapUrl', itemType: 'url', text: str_(UIStrings.columnMapURL)},
+      {key: 'sourceMapUrl', valueType: 'url', label: str_(UIStrings.columnMapURL)},
       /* eslint-enable max-len */
     ];
 

package/core/audits/work-during-interaction.js

@@ -184,11 +184,11 @@ class WorkDuringInteraction extends Audit {
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
       /* eslint-disable max-len */
-      {key: 'phase', itemType: 'text', subItemsHeading: {key: 'url', itemType: 'url'}, text: 'Phase'},
-      {key: 'total', itemType: 'ms', subItemsHeading: {key: 'total', granularity: 1, itemType: 'ms'}, granularity: 1, text: 'Total time'},
-      {key: null, itemType: 'ms', subItemsHeading: {key: 'scripting', granularity: 1, itemType: 'ms'}, text: 'Script evaluation'},
-      {key: null, itemType: 'ms', subItemsHeading: {key: 'layout', granularity: 1, itemType: 'ms'}, text: taskGroups.styleLayout.label},
-      {key: null, itemType: 'ms', subItemsHeading: {key: 'render', granularity: 1, itemType: 'ms'}, text: taskGroups.paintCompositeRender.label},
+      {key: 'phase', valueType: 'text', subItemsHeading: {key: 'url', valueType: 'url'}, label: 'Phase'},
+      {key: 'total', valueType: 'ms', subItemsHeading: {key: 'total', granularity: 1, valueType: 'ms'}, granularity: 1, label: 'Total time'},
+      {key: null, valueType: 'ms', subItemsHeading: {key: 'scripting', granularity: 1, valueType: 'ms'}, label: 'Script evaluation'},
+      {key: null, valueType: 'ms', subItemsHeading: {key: 'layout', granularity: 1, valueType: 'ms'}, label: taskGroups.styleLayout.label},
+      {key: null, valueType: 'ms', subItemsHeading: {key: 'render', granularity: 1, valueType: 'ms'}, label: taskGroups.paintCompositeRender.label},
       /* eslint-enable max-len */
     ];
 
@@ -208,7 +208,7 @@ class WorkDuringInteraction extends Audit {
 
     /** @type {LH.Audit.Details.Table['headings']} */
     const headings = [
-      {key: 'node', itemType: 'node', text: str_(UIStrings.eventTarget)},
+      {key: 'node', valueType: 'node', label: str_(UIStrings.eventTarget)},
     ];
     const elementItems = [{node: Audit.makeNodeItem(responsivenessElement.node)}];