lighthouse 9.5.0-dev.20220929 → 9.5.0-dev.20220930

package/core/gather/driver/target-manager.js

@@ -117,6 +117,7 @@ class TargetManager extends ProtocolEventEmitter {
       // @ts-expect-error - pptr currently typed only for single arg emits.
       const protocolListener = trueProtocolListener;
       cdpSession.on('*', protocolListener);
+      cdpSession.on('sessionattached', this._onSessionAttached);
 
       const targetWithSession = {
         target: target.targetInfo,
@@ -176,12 +177,6 @@ class TargetManager extends ProtocolEventEmitter {
 
     this._rootCdpSession.on('Page.frameNavigated', this._onFrameNavigated);
 
-    const rootConnection = this._rootCdpSession.connection();
-    if (!rootConnection) {
-      throw new Error('Connection has been closed.');
-    }
-    rootConnection.on('sessionattached', this._onSessionAttached);
-
     await this._rootCdpSession.send('Page.enable');
 
     // Start with the already attached root session.
@@ -193,11 +188,10 @@ class TargetManager extends ProtocolEventEmitter {
    */
   async disable() {
     this._rootCdpSession.off('Page.frameNavigated', this._onFrameNavigated);
-    // No need to remove listener if connection is already closed.
-    this._rootCdpSession.connection()?.off('sessionattached', this._onSessionAttached);
 
     for (const {cdpSession, protocolListener} of this._targetIdToTargets.values()) {
       cdpSession.off('*', protocolListener);
+      cdpSession.off('sessionattached', this._onSessionAttached);
     }
 
     this._enabled = false;

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "9.5.0-dev.20220929",
+  "version": "9.5.0-dev.20220930",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {
@@ -166,7 +166,7 @@
     "pako": "^2.0.3",
     "preact": "^10.7.2",
     "pretty-json-stringify": "^0.0.2",
-    "puppeteer": "^16.1.0",
+    "puppeteer": "^18.0.5",
     "resolve": "^1.20.0",
     "rollup": "^2.52.7",
     "rollup-plugin-node-resolve": "^5.2.0",
@@ -202,7 +202,7 @@
     "open": "^8.4.0",
     "parse-cache-control": "1.0.1",
     "ps-list": "^8.0.0",
-    "puppeteer-core": "^16.1.0",
+    "puppeteer-core": "^18.0.5",
     "robots-parser": "^3.0.0",
     "semver": "^5.3.0",
     "speedline-core": "^1.4.3",