lighthouse 9.5.0-dev.20220824 → 9.5.0-dev.20220825

package/cli/test/smokehouse/report-assert.js

@@ -259,6 +259,10 @@ function pruneExpectations(localConsole, lhr, expected, reportOptions) {
    * @param {*} obj
    */
   function failsChromeVersionCheck(obj) {
+    // LHR never actually run, so we can't know. Better to not prune
+    // things than to fail loudly when accessing lhr.environment.
+    if (!lhr.environment) return false;
+
     return !chromiumVersionCheck({
       version: getChromeVersionString(),
       min: obj._minChromiumVersion,

package/core/config/default-config.js

@@ -123,54 +123,49 @@ const UIStrings = {
 
 const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
-// Ensure all artifact IDs match the typedefs.
-/** @type {Record<keyof LH.FRArtifacts, string>} */
+/** @type {SelfMap<keyof LH.FRArtifacts>} */
 const artifacts = {
-  DevtoolsLog: '',
-  Trace: '',
-  Accessibility: '',
-  AnchorElements: '',
-  CacheContents: '',
-  ConsoleMessages: '',
-  CSSUsage: '',
-  Doctype: '',
-  DOMStats: '',
-  EmbeddedContent: '',
-  FontSize: '',
-  Inputs: '',
-  FullPageScreenshot: '',
-  GlobalListeners: '',
-  IFrameElements: '',
-  ImageElements: '',
-  InstallabilityErrors: '',
-  InspectorIssues: '',
-  JsUsage: '',
-  LinkElements: '',
-  MainDocumentContent: '',
-  MetaElements: '',
-  NetworkUserAgent: '',
-  OptimizedImages: '',
-  PasswordInputsWithPreventedPaste: '',
-  ResponseCompression: '',
-  RobotsTxt: '',
-  ServiceWorker: '',
-  ScriptElements: '',
-  Scripts: '',
-  SourceMaps: '',
-  Stacks: '',
-  TagsBlockingFirstPaint: '',
-  TapTargets: '',
-  TraceElements: '',
-  ViewportDimensions: '',
-  WebAppManifest: '',
-  devtoolsLogs: '',
-  traces: '',
+  DevtoolsLog: 'DevtoolsLog',
+  Trace: 'Trace',
+  Accessibility: 'Accessibility',
+  AnchorElements: 'AnchorElements',
+  CacheContents: 'CacheContents',
+  ConsoleMessages: 'ConsoleMessages',
+  CSSUsage: 'CSSUsage',
+  Doctype: 'Doctype',
+  DOMStats: 'DOMStats',
+  EmbeddedContent: 'EmbeddedContent',
+  FontSize: 'FontSize',
+  Inputs: 'Inputs',
+  FullPageScreenshot: 'FullPageScreenshot',
+  GlobalListeners: 'GlobalListeners',
+  IFrameElements: 'IFrameElements',
+  ImageElements: 'ImageElements',
+  InstallabilityErrors: 'InstallabilityErrors',
+  InspectorIssues: 'InspectorIssues',
+  JsUsage: 'JsUsage',
+  LinkElements: 'LinkElements',
+  MainDocumentContent: 'MainDocumentContent',
+  MetaElements: 'MetaElements',
+  NetworkUserAgent: 'NetworkUserAgent',
+  OptimizedImages: 'OptimizedImages',
+  PasswordInputsWithPreventedPaste: 'PasswordInputsWithPreventedPaste',
+  ResponseCompression: 'ResponseCompression',
+  RobotsTxt: 'RobotsTxt',
+  ServiceWorker: 'ServiceWorker',
+  ScriptElements: 'ScriptElements',
+  Scripts: 'Scripts',
+  SourceMaps: 'SourceMaps',
+  Stacks: 'Stacks',
+  TagsBlockingFirstPaint: 'TagsBlockingFirstPaint',
+  TapTargets: 'TapTargets',
+  TraceElements: 'TraceElements',
+  ViewportDimensions: 'ViewportDimensions',
+  WebAppManifest: 'WebAppManifest',
+  devtoolsLogs: 'devtoolsLogs',
+  traces: 'traces',
 };
 
-for (const key of Object.keys(artifacts)) {
-  artifacts[/** @type {keyof typeof artifacts} */ (key)] = key;
-}
-
 /** @type {LH.Config.Json} */
 const defaultConfig = {
   settings: constants.defaultSettings,

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "9.5.0-dev.20220824",
+  "version": "9.5.0-dev.20220825",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {