lighthouse 9.5.0-dev.20220807 → 9.5.0-dev.20220810

package/core/audits/non-composited-animations.js

@@ -46,7 +46,7 @@ const UIStrings = {
   unsupportedTimingParameters: 'Effect has unsupported timing parameters',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /**
  * Each failure reason is represented by a bit flag. The bit shift operator '<<' is used to define which bit corresponds to each failure reason.

package/core/audits/performance-budget.js

@@ -25,7 +25,7 @@ const UIStrings = {
    }`,
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /** @typedef {import('../computed/resource-summary.js').ResourceEntry} ResourceEntry */
 /** @typedef {{resourceType: LH.Budget.ResourceType, label: LH.IcuMessage, requestCount: number, transferSize: number, sizeOverBudget: number | undefined, countOverBudget: LH.IcuMessage | undefined}} BudgetItem */

package/core/audits/predictive-perf.js

@@ -18,7 +18,7 @@ import LanternLcp from '../computed/metrics/lantern-largest-contentful-paint.js'
 const SCORING_P10 = 3651;
 const SCORING_MEDIAN = 10000;
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, {});
+const str_ = i18n.createIcuMessageFn(import.meta.url, {});
 
 class PredictivePerf extends Audit {
   /**

package/core/audits/preload-fonts.js

@@ -26,7 +26,7 @@ const UIStrings = {
   description: 'Preload `optional` fonts so first-time visitors may use them. [Learn more about preloading fonts](https://web.dev/preload-optional-fonts/)',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 class PreloadFontsAudit extends Audit {
   /**

package/core/audits/preload-lcp-image.js

@@ -21,7 +21,7 @@ const UIStrings = {
     'image in order to improve LCP. [Learn more about preloading LCP elements](https://web.dev/optimize-lcp/#preload-important-resources).',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /**
  * @typedef {Array<{url: string, initiatorType: string}>} InitiatorPath

package/core/audits/redirects.js

@@ -20,7 +20,7 @@ const UIStrings = {
   description: 'Redirects introduce additional delays before the page can be loaded. [Learn how to avoid page redirects](https://web.dev/redirects/).',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 class Redirects extends Audit {
   /**

package/core/audits/resource-summary.js

@@ -22,7 +22,7 @@ const UIStrings = {
     `other {# requests • {byteCount, number, bytes} KiB}}`,
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 class ResourceSummary extends Audit {
   /**

package/core/audits/seo/canonical.js

@@ -43,7 +43,7 @@ const UIStrings = {
     'instead of an equivalent page of content',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /**
  * @typedef CanonicalURLData

package/core/audits/seo/crawlable-anchors.js

@@ -19,7 +19,7 @@ const UIStrings = {
   columnFailingLink: 'Uncrawlable Link',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 class CrawlableAnchors extends Audit {
   /**

package/core/audits/seo/font-size.js

@@ -38,7 +38,7 @@ const UIStrings = {
   columnFontSize: 'Font Size',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /**
  * @param {Array<FailingNodeData>} fontSizeArtifact

package/core/audits/seo/hreflang.js

@@ -31,7 +31,7 @@ const UIStrings = {
   notFullyQualified: 'Relative href value',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /**
  * @param {string} href

package/core/audits/seo/http-status-code.js

@@ -22,7 +22,7 @@ const UIStrings = {
   '[Learn more about HTTP status codes](https://web.dev/http-status-code/).',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 class HTTPStatusCode extends Audit {
   /**

package/core/audits/seo/is-crawlable.js

@@ -30,7 +30,7 @@ const UIStrings = {
       'if they don\'t have permission to crawl them. [Learn more about crawler directives](https://web.dev/is-crawable/).',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /**
  * Checks if given directive is a valid unavailable_after directive with a date in the past

package/core/audits/seo/link-text.js

@@ -92,7 +92,7 @@ const UIStrings = {
     }`,
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 class LinkText extends Audit {
   /**

package/core/audits/seo/manual/structured-data.js

@@ -15,7 +15,7 @@ const UIStrings = {
   title: 'Structured data is valid',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /**
  * @fileoverview Manual SEO audit to check if structured data on page is valid.

package/core/audits/seo/meta-description.js

@@ -21,7 +21,7 @@ const UIStrings = {
   explanation: 'Description text is empty.',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 class Description extends Audit {
   /**

package/core/audits/seo/plugins.js

@@ -44,7 +44,7 @@ const UIStrings = {
     '[Learn more about avoiding plugins](https://web.dev/plugins/).',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /**
  * Verifies if given MIME type matches any known plugin MIME type

package/core/audits/seo/robots-txt.js

@@ -57,7 +57,7 @@ const UIStrings = {
   explanation: 'Lighthouse was unable to download a robots.txt file',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /**
  * @param {string} directiveName

package/core/audits/seo/tap-targets.js

@@ -43,7 +43,7 @@ const UIStrings = {
   displayValue: '{decimalProportion, number, percent} appropriately sized tap targets',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 const FINGER_SIZE_PX = 48;
 // Ratio of the finger area tapping on an unintended element

package/core/audits/server-response-time.js

@@ -20,7 +20,7 @@ const UIStrings = {
   displayValue: `Root document took {timeInMs, number, milliseconds}\xa0ms`,
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 // Due to the way that DevTools throttling works we cannot see if server response took less than ~570ms.
 // We set our failure threshold to 600ms to avoid those false positives but we want devs to shoot for 100ms.

package/core/audits/service-worker.js

@@ -39,7 +39,7 @@ const UIStrings = {
     'the `start_url` ({startUrl}) is not in the service worker\'s scope ({scopeUrl})',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 class ServiceWorker extends Audit {
   /**

package/core/audits/splash-screen.js

@@ -20,7 +20,7 @@ const UIStrings = {
     '[Learn more about splash screens](https://web.dev/splash-screen/).',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /**
  * @fileoverview

package/core/audits/themed-omnibox.js

@@ -20,7 +20,7 @@ const UIStrings = {
     '[Learn more about theming the address bar](https://web.dev/themed-omnibox/).',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /**
  * @fileoverview

package/core/audits/third-party-facades.js

@@ -67,7 +67,7 @@ const UIStrings = {
   categorySocial: '{productName} (Social)',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /** @type {Record<string, string>} */
 const CATEGORY_UI_MAP = {

package/core/audits/third-party-summary.js

@@ -29,7 +29,7 @@ const UIStrings = {
     `{timeInMs, number, milliseconds}\xa0ms`,
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 // A page passes when all third-party code blocks for less than 250 ms.
 const PASS_THRESHOLD_IN_MS = 250;

package/core/audits/timing-budget.js

@@ -22,7 +22,7 @@ const UIStrings = {
   columnMeasurement: 'Measurement',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /** @typedef {{metric: LH.Budget.TimingMetric, label: LH.IcuMessage, measurement?: LH.Audit.Details.NumericValue|number, overBudget?: LH.Audit.Details.NumericValue|number}} BudgetItem */
 

package/core/audits/unsized-images.js

@@ -23,7 +23,7 @@ const UIStrings = {
   description: 'Set an explicit width and height on image elements to reduce layout shifts and improve CLS. [Learn how to set image dimensions](https://web.dev/optimize-cls/#images-without-dimensions)',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 class UnsizedImages extends Audit {
   /**

package/core/audits/user-timings.js

@@ -25,7 +25,7 @@ const UIStrings = {
   columnType: 'Type',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /** @typedef {{name: string, isMark: true, args: LH.TraceEvent['args'], startTime: number}} MarkEvent */
 /** @typedef {{name: string, isMark: false, args: LH.TraceEvent['args'], startTime: number, endTime: number, duration: number}} MeasureEvent */

package/core/audits/uses-rel-preconnect.js

@@ -52,7 +52,7 @@ const UIStrings = {
    'These should be used sparingly and only to the most important origins.',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 class UsesRelPreconnectAudit extends Audit {
   /**

package/core/audits/uses-rel-preload.js

@@ -30,7 +30,7 @@ const UIStrings = {
     'by the browser. Check that you are using the `crossorigin` attribute properly.',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 const THRESHOLD_IN_MS = 100;
 

package/core/audits/valid-source-maps.js

@@ -30,7 +30,7 @@ const UIStrings = {
     }`,
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 const LARGE_JS_BYTE_THRESHOLD = 500 * 1024;
 

package/core/audits/viewport.js

@@ -23,7 +23,7 @@ const UIStrings = {
   explanationNoTag: 'No `<meta name="viewport">` tag found',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 class Viewport extends Audit {
   /**

package/core/audits/work-during-interaction.js

@@ -44,7 +44,7 @@ const UIStrings = {
   eventTarget: 'Event target',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /**
  * @fileoverview This metric gives a high-percentile measure of responsiveness to input.

package/core/config/default-config.js

@@ -121,7 +121,7 @@ const UIStrings = {
   pwaOptimizedGroupTitle: 'PWA Optimized',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 // Ensure all artifact IDs match the typedefs.
 /** @type {Record<keyof LH.FRArtifacts, string>} */

package/core/gather/driver/environment.js

@@ -27,7 +27,7 @@ const UIStrings = {
  */
 const SLOW_CPU_BENCHMARK_INDEX_THRESHOLD = 1000;
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /**
  * @param {LH.Gatherer.FRProtocolSession} session

package/core/gather/driver/navigation.js

@@ -28,7 +28,7 @@ const UIStrings = {
   'Results may be incomplete.',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 
 // Controls how long to wait after FCP before continuing

package/core/gather/driver/storage.js

@@ -24,7 +24,7 @@ const UIStrings = {
   }`,
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 
 /**

package/core/lib/csp-evaluator.js

@@ -88,7 +88,7 @@ const UIStrings = {
     'Plain URL schemes allow scripts to be sourced from an unsafe domain.',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /** @type {Record<number, string|LH.IcuMessage|Record<string, LH.IcuMessage>>} */
 const FINDING_TO_UI_STRING = {

package/core/lib/deprecations-strings.js

@@ -269,7 +269,7 @@ const UIStrings = {
       '`supportsSession()` is deprecated. Please use `isSessionSupported()` and check the resolved boolean value instead.',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 /**
  * @param {LH.Crdp.Audits.DeprecationIssueDetails} issueDetails

package/core/lib/i18n/i18n.js

@@ -217,6 +217,4 @@ export {
   lookupLocale,
   createIcuMessageFn,
   isStringOrIcuMessage,
-  // TODO: exported for backwards compatibility. Consider removing on future breaking change.
-  createIcuMessageFn as createMessageInstanceIdFn,
 };

package/core/lib/lh-error.js

@@ -89,7 +89,7 @@ const UIStrings = {
   oldChromeDoesNotSupportFeature: 'This version of Chrome is too old to support \'{featureName}\'. Use a newer version to see full results.',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 
 /**

package/core/lib/navigation-error.js

@@ -19,7 +19,7 @@ const UIStrings = {
     'The page MIME type is XHTML: Lighthouse does not explicitly support this document type',
 };
 
-const str_ = i18n.createMessageInstanceIdFn(import.meta.url, UIStrings);
+const str_ = i18n.createIcuMessageFn(import.meta.url, UIStrings);
 
 // MIME types are case-insensitive but Chrome normalizes MIME types to be lowercase.
 const HTML_MIME_TYPE = 'text/html';

package/core/lib/stack-packs.js

@@ -86,7 +86,7 @@ function getStackPacks(pageStacks) {
     }
 
     // Create i18n handler to get translated strings.
-    const str_ = i18n.createMessageInstanceIdFn(
+    const str_ = i18n.createIcuMessageFn(
       `node_modules/lighthouse-stack-packs/packs/${matchedPack.id}.js`,
       matchedPack.UIStrings
     );

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "9.5.0-dev.20220807",
+  "version": "9.5.0-dev.20220810",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./core/index.js",
   "bin": {
@@ -168,7 +168,7 @@
     "pako": "^2.0.3",
     "preact": "^10.7.2",
     "pretty-json-stringify": "^0.0.2",
-    "puppeteer": "13.7.0",
+    "puppeteer": "^16.1.0",
     "resolve": "^1.20.0",
     "rollup": "^2.52.7",
     "rollup-plugin-node-resolve": "^5.2.0",
@@ -189,7 +189,7 @@
     "axe-core": "4.4.1",
     "chrome-launcher": "^0.15.1",
     "configstore": "^5.0.1",
-    "csp_evaluator": "1.1.0",
+    "csp_evaluator": "1.1.1",
     "cssstyle": "1.2.1",
     "enquirer": "^2.3.6",
     "http-link-header": "^0.8.0",
@@ -204,7 +204,7 @@
     "open": "^8.4.0",
     "parse-cache-control": "1.0.1",
     "ps-list": "^8.0.0",
-    "puppeteer-core": "^13.7.0",
+    "puppeteer-core": "^16.1.0",
     "robots-parser": "^3.0.0",
     "semver": "^5.3.0",
     "speedline-core": "^1.4.3",

package/shared/test/localization/format-test.js

@@ -85,7 +85,7 @@ describe('format', () => {
     it('replaces the references in the LHR', () => {
       const fakeFile = path.join(__dirname, 'fake-file-number-2.js');
       const UIStrings = {aString: 'different {x}!'};
-      const formatter = i18n.createMessageInstanceIdFn(fakeFile, UIStrings);
+      const formatter = i18n.createIcuMessageFn(fakeFile, UIStrings);
 
       const title = formatter(UIStrings.aString, {x: 1});
       const lhr = {audits: {'fake-audit': {title}}};
@@ -115,14 +115,14 @@ describe('format', () => {
   describe('#getFormatted', () => {
     it('returns the formatted string', () => {
       const UIStrings = {testMessage: 'happy test'};
-      const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings);
+      const str_ = i18n.createIcuMessageFn(__filename, UIStrings);
       const formattedStr = format.getFormatted(str_(UIStrings.testMessage), 'en');
       expect(formattedStr).toEqual('happy test');
     });
 
     it('returns the formatted string with replacements', () => {
       const UIStrings = {testMessage: 'replacement test ({errorCode})'};
-      const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings);
+      const str_ = i18n.createIcuMessageFn(__filename, UIStrings);
       const formattedStr = format.getFormatted(str_(UIStrings.testMessage,
           {errorCode: 'BOO'}), 'en');
       expect(formattedStr).toEqual('replacement test (BOO)');
@@ -131,7 +131,7 @@ describe('format', () => {
     it('throws an error for invalid locales', () => {
       // Populate a string to try to localize to a bad locale.
       const UIStrings = {testMessage: 'testy test'};
-      const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings);
+      const str_ = i18n.createIcuMessageFn(__filename, UIStrings);
 
       expect(_ => format.getFormatted(str_(UIStrings.testMessage), 'still-not-a-locale'))
         .toThrow(`Unsupported locale 'still-not-a-locale'`);
@@ -141,7 +141,7 @@ describe('format', () => {
       const UIStrings = {
         testMessage: 'needs {count, number, bytes}KB test {str} in {timeInMs, number, seconds}s',
       };
-      const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings);
+      const str_ = i18n.createIcuMessageFn(__filename, UIStrings);
 
       const replacements = {
         count: 2555,
@@ -184,7 +184,7 @@ describe('format', () => {
       format.registerLocaleData('en-XZ', localeData);
 
       const UIStrings = {testString: 'en-US string!'};
-      const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings);
+      const str_ = i18n.createIcuMessageFn(__filename, UIStrings);
       const formattedStr = format.getFormatted(str_(UIStrings.testString), 'en-XZ');
       expect(formattedStr).toEqual('en-XZ cuerda!');
     });
@@ -192,7 +192,7 @@ describe('format', () => {
     it('overwrites existing locale strings', async () => {
       const filename = 'core/audits/is-on-https.js';
       const {UIStrings} = await import('../../../core/audits/is-on-https.js');
-      const str_ = i18n.createMessageInstanceIdFn(filename, UIStrings);
+      const str_ = i18n.createIcuMessageFn(filename, UIStrings);
 
       // To start with, we get back the intended string..
       const origTitle = format.getFormatted(str_(UIStrings.title), 'es-419');
@@ -324,7 +324,7 @@ describe('format', () => {
 
     let str_;
     before(() => {
-      str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings);
+      str_ = i18n.createIcuMessageFn(__filename, UIStrings);
     });
 
     it('formats a basic message', () => {