npm - lighthouse - Versions diffs - 9.5.0-dev.20220723 → 9.5.0-dev.20220726 - Mend

lighthouse 9.5.0-dev.20220723 → 9.5.0-dev.20220726

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (9) hide show

package/lighthouse-cli/test/smokehouse/readme.md CHANGED Viewed

@@ -116,8 +116,8 @@ All pruning checks:
 - `_maxChromiumVersion`
 - `_legacyOnly`
 - `_fraggleRockOnly`
-- `_skipInBundled`
 - `_runner` (set to same value provided to CLI --runner flag, ex: `'devtools'`)
+- `_excludeRunner` (set to same value provided to CLI --runner flag, ex: `'devtools'`)
 ## Pipeline

package/lighthouse-cli/test/smokehouse/report-assert.js CHANGED Viewed

@@ -217,11 +217,10 @@ function makeComparison(name, actualResult, expectedResult) {
  * @param {LocalConsole} localConsole
  * @param {LH.Result} lhr
  * @param {Smokehouse.ExpectedRunnerResult} expected
- * @param {{runner?: string, isBundled?: boolean, useLegacyNavigation?: boolean}=} reportOptions
+ * @param {{runner?: string, useLegacyNavigation?: boolean}=} reportOptions
  */
 function pruneExpectations(localConsole, lhr, expected, reportOptions) {
   const isLegacyNavigation = reportOptions?.useLegacyNavigation;
-  const isBundled = reportOptions?.isBundled;
   /**
    * Lazily compute the Chrome version because some reports are explicitly asserting error conditions.
@@ -289,15 +288,15 @@ function pruneExpectations(localConsole, lhr, expected, reportOptions) {
           `Actual channel: ${lhr.configSettings.channel}`,
         ].join(' '));
         remove(key);
-      } else if (value._skipInBundled && !isBundled) {
+      } else if (value._runner && reportOptions?.runner !== value._runner) {
         localConsole.log([
-          `[${key}] marked as skip in bundled and runner is bundled, pruning expectation:`,
+          `[${key}] is only for runner ${value._runner}, pruning expectation:`,
           JSON.stringify(value, null, 2),
         ].join(' '));
         remove(key);
-      } else if (value._runner && reportOptions?.runner !== value._runner) {
+      } else if (value._excludeRunner && reportOptions?.runner === value._excludeRunner) {
         localConsole.log([
-          `[${key}] is only for runner ${value._runner}, pruning expectation:`,
+          `[${key}] is excluded for runner ${value._excludeRunner}, pruning expectation:`,
           JSON.stringify(value, null, 2),
         ].join(' '));
         remove(key);
@@ -312,6 +311,7 @@ function pruneExpectations(localConsole, lhr, expected, reportOptions) {
     delete obj._minChromiumVersion;
     delete obj._maxChromiumVersion;
     delete obj._runner;
+    delete obj._excludeRunner;
   }
   const cloned = cloneDeep(expected);
@@ -459,7 +459,7 @@ function reportAssertion(localConsole, assertion) {
  * summary. Returns count of passed and failed tests.
  * @param {{lhr: LH.Result, artifacts: LH.Artifacts, networkRequests?: string[]}} actual
  * @param {Smokehouse.ExpectedRunnerResult} expected
- * @param {{runner?: string, isDebug?: boolean, isBundled?: boolean, useLegacyNavigation?: boolean}=} reportOptions
+ * @param {{runner?: string, isDebug?: boolean, useLegacyNavigation?: boolean}=} reportOptions
  * @return {{passed: number, failed: number, log: string}}
  */
 function getAssertionReport(actual, expected, reportOptions = {}) {

package/lighthouse-core/computed/metrics/cumulative-layout-shift.js CHANGED Viewed

@@ -7,7 +7,6 @@
 import {makeComputedArtifact} from '../computed-artifact.js';
 import ProcessedTrace from '../processed-trace.js';
-import {LighthouseError} from '../../lib/lh-error.js';
 /** @typedef {{ts: number, isMainFrame: boolean, weightedScore: number}} LayoutShiftEvent */
@@ -37,13 +36,10 @@ class CumulativeLayoutShift {
         continue;
       }
-      // For all-frames CLS calculation, we rely on `weighted_score_delta`, which
-      // was added in Chrome 90: https://crbug.com/1173139
+      // For all-frames CLS calculation, we rely on `weighted_score_delta`
+      // All layout shift events should have this since M90: https://crbug.com/1173139
       if (event.args.data.weighted_score_delta === undefined) {
-        throw new LighthouseError(
-          LighthouseError.errors.UNSUPPORTED_OLD_CHROME,
-          {featureName: 'Cumulative Layout Shift'}
-        );
+        throw new Error('CLS missing weighted_score_delta');
       }
       if (event.args.data.had_recent_input) {

package/lighthouse-core/config/default-config.js CHANGED Viewed

@@ -100,10 +100,10 @@ const UIStrings = {
   pwaCategoryTitle: 'PWA',
   /** Description of the Progressive Web Application (PWA) category. This is displayed at the top of a list of audits focused on topics related to whether or not a site is a progressive web app, e.g. responds offline, uses a service worker, is on https, etc. No character length limits. 'Learn More' becomes link text to additional documentation. */
   pwaCategoryDescription: 'These checks validate the aspects of a Progressive Web App. ' +
-  '[Learn more](https://developers.google.com/web/progressive-web-apps/checklist).',
+  '[Learn more](https://web.dev/pwa-checklist/).',
   /** Description of the Progressive Web Application (PWA) manual checks category, containing a list of additional validators must be run by hand in order to check all PWA best practices. This is displayed at the top of a list of manually run audits focused on topics related to whether or not a site is a progressive web app, e.g. responds offline, uses a service worker, is on https, etc.. No character length limits. */
   pwaCategoryManualDescription: 'These checks are required by the baseline ' +
-  '[PWA Checklist](https://developers.google.com/web/progressive-web-apps/checklist) but are ' +
+  '[PWA Checklist](https://web.dev/pwa-checklist/) but are ' +
   'not automatically checked by Lighthouse. They do not affect your score but it\'s important that you verify them manually.',
   /** Title of the Best Practices category of audits. This is displayed at the top of a list of audits focused on topics related to following web development best practices and accepted guidelines. Also used as a label of a score gauge; try to limit to 20 characters. */
   bestPracticesCategoryTitle: 'Best Practices',

package/package.json CHANGED Viewed

@@ -1,7 +1,7 @@
 {
   "name": "lighthouse",
   "type": "module",
-  "version": "9.5.0-dev.20220723",
+  "version": "9.5.0-dev.20220726",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./lighthouse-core/index.js",
   "bin": {
@@ -159,7 +159,7 @@
     "jsdom": "^12.2.0",
     "jsonld": "^5.2.0",
     "jsonlint-mod": "^1.7.6",
-    "lighthouse-plugin-publisher-ads": "^1.5.4",
+    "lighthouse-plugin-publisher-ads": "^1.5.6",
     "magic-string": "^0.25.7",
     "mime-types": "^2.1.30",
     "mocha": "^10.0.0",

package/shared/localization/locales/en-US.json CHANGED Viewed

@@ -1791,10 +1791,10 @@
     "message": "Performance"
   },
   "lighthouse-core/config/default-config.js | pwaCategoryDescription": {
-    "message": "These checks validate the aspects of a Progressive Web App. [Learn more](https://developers.google.com/web/progressive-web-apps/checklist)."
+    "message": "These checks validate the aspects of a Progressive Web App. [Learn more](https://web.dev/pwa-checklist/)."
   },
   "lighthouse-core/config/default-config.js | pwaCategoryManualDescription": {
-    "message": "These checks are required by the baseline [PWA Checklist](https://developers.google.com/web/progressive-web-apps/checklist) but are not automatically checked by Lighthouse. They do not affect your score but it's important that you verify them manually."
+    "message": "These checks are required by the baseline [PWA Checklist](https://web.dev/pwa-checklist/) but are not automatically checked by Lighthouse. They do not affect your score but it's important that you verify them manually."
   },
   "lighthouse-core/config/default-config.js | pwaCategoryTitle": {
     "message": "PWA"

package/shared/localization/locales/en-XL.json CHANGED Viewed

@@ -1791,10 +1791,10 @@
     "message": "P̂ér̂f́ôŕm̂án̂ćê"
   },
   "lighthouse-core/config/default-config.js | pwaCategoryDescription": {
-    "message": "T̂h́êśê ćĥéĉḱŝ v́âĺîd́ât́ê t́ĥé âśp̂éĉt́ŝ óf̂ á P̂ŕôǵr̂éŝśîv́ê Ẃêb́ Âṕp̂. [Ĺêár̂ń m̂ór̂é](https://developers.google.com/web/progressive-web-apps/checklist)."
+    "message": "T̂h́êśê ćĥéĉḱŝ v́âĺîd́ât́ê t́ĥé âśp̂éĉt́ŝ óf̂ á P̂ŕôǵr̂éŝśîv́ê Ẃêb́ Âṕp̂. [Ĺêár̂ń m̂ór̂é](https://web.dev/pwa-checklist/)."
   },
   "lighthouse-core/config/default-config.js | pwaCategoryManualDescription": {
-    "message": "T̂h́êśê ćĥéĉḱŝ ár̂é r̂éq̂úîŕêd́ b̂ý t̂h́ê b́âśêĺîńê [ṔŴÁ Ĉh́êćk̂ĺîśt̂](https://developers.google.com/web/progressive-web-apps/checklist) b́ût́ âŕê ńôt́ âút̂óm̂át̂íĉál̂ĺŷ ćĥéĉḱêd́ b̂ý L̂íĝh́t̂h́ôúŝé. T̂h́êý d̂ó n̂ót̂ áf̂f́êćt̂ ýôúr̂ śĉór̂é b̂út̂ ít̂'ś îḿp̂ór̂t́âńt̂ t́ĥát̂ ýôú v̂ér̂íf̂ý t̂h́êḿ m̂án̂úâĺl̂ý."
+    "message": "T̂h́êśê ćĥéĉḱŝ ár̂é r̂éq̂úîŕêd́ b̂ý t̂h́ê b́âśêĺîńê [ṔŴÁ Ĉh́êćk̂ĺîśt̂](https://web.dev/pwa-checklist/) b́ût́ âŕê ńôt́ âút̂óm̂át̂íĉál̂ĺŷ ćĥéĉḱêd́ b̂ý L̂íĝh́t̂h́ôúŝé. T̂h́êý d̂ó n̂ót̂ áf̂f́êćt̂ ýôúr̂ śĉór̂é b̂út̂ ít̂'ś îḿp̂ór̂t́âńt̂ t́ĥát̂ ýôú v̂ér̂íf̂ý t̂h́êḿ m̂án̂úâĺl̂ý."
   },
   "lighthouse-core/config/default-config.js | pwaCategoryTitle": {
     "message": "P̂ẂÂ"

package/types/smokehouse.d.ts CHANGED Viewed

@@ -15,7 +15,7 @@ declare global {
       requestedUrl: string;
       finalUrl: string | RegExp;
       userAgent?: string | RegExp;
-      runWarnings?: Array<string|RegExp> | {length: string | number};
+      runWarnings?: any;
       runtimeError?: {
         code?: any;
         message?: any;
@@ -28,7 +28,7 @@ declare global {
     export type ExpectedRunnerResult = {
       lhr: ExpectedLHR,
       artifacts?: Partial<Record<keyof Artifacts|'_maxChromiumVersion'|'_minChromiumVersion', any>>
-      networkRequests?: {length: number, _legacyOnly?: boolean, _fraggleRockOnly?: boolean};
+      networkRequests?: any;
     }
     export interface TestDfn {

package/lighthouse-core/computed/trace-of-tab.js DELETED Viewed

@@ -1,31 +0,0 @@
-/**
- * @license Copyright 2019 The Lighthouse Authors. All Rights Reserved.
- * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
- * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
- */
-'use strict';
-/** @fileoverview This file is no longer used internally, but remains here for backcompat with plugins. */
-import log from 'lighthouse-logger';
-import {makeComputedArtifact} from './computed-artifact.js';
-import ProcessedTrace from './processed-trace.js';
-import ProcessedNavigation from './processed-navigation.js';
-class TraceOfTab {
-  /**
-     * @param {LH.Trace} trace
-     * @param {LH.Artifacts.ComputedContext} context
-     * @return {Promise<any>}
-    */
-  static async compute_(trace, context) {
-    const processedTrace = await ProcessedTrace.request(trace, context);
-    const processedNavigation = await ProcessedNavigation.request(processedTrace, context);
-    return {...processedTrace, ...processedNavigation};
-  }
-}
-log.warn(`trace-of-tab`, `trace-of-tab is deprecated, use processed-trace / processed-navigation instead`); // eslint-disable-line max-len
-export default makeComputedArtifact(TraceOfTab, null);