lighthouse 9.5.0-dev.20220712 → 9.5.0-dev.20220713

package/lighthouse-core/lib/script-helpers.js

@@ -26,4 +26,7 @@ function getRequestForScript(networkRecords, script) {
   return networkRequest;
 }
 
-module.exports = {getRequestForScript, isInline};
+export {
+  getRequestForScript,
+  isInline,
+};

package/lighthouse-core/lib/sentry.js

@@ -5,7 +5,7 @@
  */
 'use strict';
 
-const log = require('lighthouse-logger');
+import log from 'lighthouse-logger';
 
 /** @typedef {import('@sentry/node').Breadcrumb} Breadcrumb */
 /** @typedef {import('@sentry/node').NodeClient} NodeClient */
@@ -48,7 +48,7 @@ const sentryDelegate = {
  * When called, replaces noops with actual Sentry implementation.
  * @param {{url: string, flags: LH.CliFlags, environmentData: NodeOptions}} opts
  */
-function init(opts) {
+async function init(opts) {
   // If error reporting is disabled, leave the functions as a noop
   if (!opts.flags.enableErrorReporting) {
     return;
@@ -60,7 +60,7 @@ function init(opts) {
   }
 
   try {
-    const Sentry = require('@sentry/node');
+    const Sentry = await import('@sentry/node');
     Sentry.init({
       ...opts.environmentData,
       dsn: SENTRY_URL,
@@ -141,4 +141,4 @@ function init(opts) {
   }
 }
 
-module.exports = sentryDelegate;
+export const Sentry = sentryDelegate;

package/lighthouse-core/lib/stack-packs.js

@@ -5,9 +5,9 @@
  */
 'use strict';
 
-const log = require('lighthouse-logger');
-const stackPacks = require('lighthouse-stack-packs');
-const i18n = require('./i18n/i18n.js');
+import log from 'lighthouse-logger';
+import stackPacks from 'lighthouse-stack-packs';
+import * as i18n from './i18n/i18n.js';
 
 /**
  * Pairs consisting of a stack pack's ID and the set of stacks needed to be
@@ -114,7 +114,7 @@ function getStackPacks(pageStacks) {
   return packs;
 }
 
-module.exports = {
+export {
   getStackPacks,
   stackPacksToInclude,
 };

package/lighthouse-core/lib/statistics.js

@@ -98,7 +98,7 @@ function linearInterpolation(x0, y0, x1, y1, x) {
   return y0 + (x - x0) * slope;
 }
 
-module.exports = {
+export {
   linearInterpolation,
   getLogNormalScore,
 };

package/lighthouse-core/lib/tappable-rects.js

@@ -5,7 +5,7 @@
  */
 'use strict';
 
-const RectHelpers = require('./rect-helpers.js');
+import * as RectHelpers from './rect-helpers.js';
 
 /**
  * Merge client rects together and remove small ones. This may result in a larger overall
@@ -94,6 +94,6 @@ function mergeTouchingClientRects(clientRects) {
   return clientRects;
 }
 
-module.exports = {
+export {
   getTappableRectsFromClientRects,
 };

package/lighthouse-core/lib/third-party-web.js

@@ -5,7 +5,7 @@
  */
 'use strict';
 
-const thirdPartyWeb = require('third-party-web/httparchive-nostats-subset');
+import thirdPartyWeb from 'third-party-web/httparchive-nostats-subset.js';
 
 /** @typedef {import("third-party-web").IEntity} ThirdPartyEntity */
 /** @typedef {import("third-party-web").IProduct} ThirdPartyProduct */
@@ -45,7 +45,7 @@ function isFirstParty(url, mainDocumentEntity) {
   return !isThirdParty(url, mainDocumentEntity);
 }
 
-module.exports = {
+export default {
   getEntity,
   getProduct,
   isThirdParty,

package/lighthouse-core/lib/timing-trace-saver.js

@@ -94,4 +94,4 @@ ${events.map(evt => JSON.stringify(evt)).join(',\n')}
   return jsonStr;
 }
 
-module.exports = {generateTraceEvents, createTraceString};
+export {generateTraceEvents, createTraceString};

package/lighthouse-core/lib/tracehouse/cpu-profile-model.js

@@ -5,7 +5,7 @@
  */
 'use strict';
 
-const MainThreadTasks = require('./main-thread-tasks.js');
+import {MainThreadTasks} from './main-thread-tasks.js';
 
 const SAMPLER_TRACE_EVENT_NAME = 'FunctionCall-SynthesizedByProfilerModel';
 
@@ -48,7 +48,7 @@ const SAMPLER_TRACE_EVENT_NAME = 'FunctionCall-SynthesizedByProfilerModel';
 /** @typedef {LH.TraceEvent & {args: {data: {_syntheticProfilerRange: ProfilerRange}}}} SynthethicEvent */
 /** @typedef {Omit<LH.Artifacts.TaskNode, 'event'> & {event: SynthethicEvent, endEvent: SynthethicEvent}} SynthethicTaskNode */
 
-class CpuProfilerModel {
+class CpuProfileModel {
   /**
    * @param {CpuProfile} profile
    */
@@ -193,8 +193,8 @@ class CpuProfilerModel {
    * @return {task is SynthethicTaskNode}
    */
   static isSyntheticTask(task) {
-    return CpuProfilerModel.isSyntheticEvent(task.event) &&
-      CpuProfilerModel.isSyntheticEvent(task.endEvent);
+    return CpuProfileModel.isSyntheticEvent(task.event) &&
+      CpuProfileModel.isSyntheticEvent(task.endEvent);
   }
 
   /**
@@ -474,7 +474,7 @@ class CpuProfilerModel {
       const allEventsAtTs = syntheticEventsByTs.get(event.ts);
       if (!allEventsAtTs) throw new Error('Impossible - we just mapped every event');
 
-      const effectiveTimestampData = CpuProfilerModel._findEffectiveTimestamp({
+      const effectiveTimestampData = CpuProfileModel._findEffectiveTimestamp({
         eventType: event.ph === 'B' ? 'start' : 'end',
         syntheticTask,
         allEventsAtTs,
@@ -524,7 +524,7 @@ class CpuProfilerModel {
       // We'll also create tasks for our naive events so we have the B/E pairs readily available.
       const naiveProfilerTasks = MainThreadTasks.getMainThreadTasks(naiveEvents, [], Infinity)
         .map(rebaseTaskTime(naiveEvents[0].ts))
-        .filter(CpuProfilerModel.isSyntheticTask);
+        .filter(CpuProfileModel.isSyntheticTask);
       if (!naiveProfilerTasks.length) throw new Error('Failed to create naive profiler tasks');
 
       finalEvents = this._refineTraceEventsWithTasks(knownTasks, naiveProfilerTasks, naiveEvents);
@@ -541,7 +541,7 @@ class CpuProfilerModel {
    * @return {Array<LH.TraceEvent>}
    */
   static synthesizeTraceEvents(profile, tasks) {
-    const model = new CpuProfilerModel(profile);
+    const model = new CpuProfileModel(profile);
     return model.synthesizeTraceEvents(tasks);
   }
 
@@ -589,4 +589,4 @@ class CpuProfilerModel {
   }
 }
 
-module.exports = CpuProfilerModel;
+export {CpuProfileModel};

package/lighthouse-core/lib/tracehouse/main-thread-tasks.js

@@ -5,7 +5,7 @@
  */
 'use strict';
 
-const {taskGroups, taskNameToGroup} = require('./task-groups.js');
+import {taskGroups, taskNameToGroup} from './task-groups.js';
 
 /**
  * @fileoverview
@@ -684,4 +684,4 @@ class MainThreadTasks {
   }
 }
 
-module.exports = MainThreadTasks;
+export {MainThreadTasks};

package/lighthouse-core/lib/tracehouse/task-groups.js

@@ -106,7 +106,7 @@ for (const group of Object.values(taskGroups)) {
   }
 }
 
-module.exports = {
+export {
   taskGroups,
   taskNameToGroup,
 };

package/lighthouse-core/lib/tracehouse/task-summary.js

@@ -9,7 +9,7 @@
  * @fileoverview Utility functions for grouping and summarizing tasks.
  */
 
-const NetworkRequest = require('../network-request.js');
+import {NetworkRequest} from '../network-request.js';
 
 // These trace events, when not triggered by a script inside a particular task, are just general Chrome overhead.
 const BROWSER_TASK_NAMES_SET = new Set([
@@ -80,7 +80,7 @@ function getExecutionTimingsByURL(tasks, networkRecords) {
   return result;
 }
 
-module.exports = {
+export {
   getJavaScriptURLs,
   getAttributableURLForTask,
   getExecutionTimingsByURL,

package/lighthouse-core/lib/tracehouse/trace-processor.js

@@ -22,7 +22,7 @@
 /** @typedef {Omit<LH.TraceEvent, 'name'|'args'> & {name: 'largestContentfulPaint::Invalidate'|'largestContentfulPaint::Candidate', args: {data?: {size?: number}, frame: string}}} LCPEvent */
 /** @typedef {Omit<LH.TraceEvent, 'name'|'args'> & {name: 'largestContentfulPaint::Candidate', args: {data: {size: number}, frame: string}}} LCPCandidateEvent */
 
-const log = require('lighthouse-logger');
+import log from 'lighthouse-logger';
 
 const ACCEPTABLE_NAVIGATION_URL_REGEX = /^(chrome|https?):/;
 
@@ -951,8 +951,7 @@ class TraceProcessor {
   }
 }
 
-module.exports = TraceProcessor;
-
+export {TraceProcessor};
 
 /**
  * @typedef ToplevelEvent

package/lighthouse-core/lib/traces/pwmetrics-events.js

@@ -5,8 +5,8 @@
  */
 'use strict';
 
-const log = require('lighthouse-logger');
-const TraceProcessor = require('../tracehouse/trace-processor.js');
+import log from 'lighthouse-logger';
+import {TraceProcessor} from '../tracehouse/trace-processor.js';
 
 /**
  * @param {LH.Result['audits']} auditResults
@@ -197,4 +197,5 @@ class Metrics {
   }
 }
 
-module.exports = Metrics;
+// TODO(esmodule): rename?
+export {Metrics};

package/lighthouse-core/lib/url-shim.js

@@ -9,10 +9,11 @@
  * URL shim so we keep our code DRY
  */
 
-const {Util} = require('../util-commonjs.js');
-const LighthouseError = require('../lib/lh-error.js');
+import {Util} from '../util.cjs';
 
-/** @typedef {import('./network-request.js')} NetworkRequest */
+import {LighthouseError} from '../lib/lh-error.js';
+
+/** @typedef {import('./network-request.js').NetworkRequest} NetworkRequest */
 
 const allowedProtocols = [
   'https:', 'http:', 'chrome:', 'chrome-extension:',
@@ -271,4 +272,5 @@ URLShim.INVALID_URL_DEBUG_STRING =
     'Lighthouse was unable to determine the URL of some script executions. ' +
     'It\'s possible a Chrome extension or other eval\'d code is the source.';
 
-module.exports = URLShim;
+// TODO(esmodules): don't use default export
+export default URLShim;

package/lighthouse-core/package.json

@@ -0,0 +1,4 @@
+{
+  "type": "module",
+  "//": "Any directory that uses `import ... from` or `export ...` must be type module. Temporary file until root package.json is type: module"
+}

package/lighthouse-core/runner.js

@@ -5,24 +5,27 @@
  */
 'use strict';
 
-const isDeepEqual = require('lodash/isEqual.js');
-const Driver = require('./gather/driver.js');
-const GatherRunner = require('./gather/gather-runner.js');
-const ReportScoring = require('./scoring.js');
-const Audit = require('./audits/audit.js');
-const log = require('lighthouse-logger');
-const format = require('../shared/localization/format.js');
-const stackPacks = require('./lib/stack-packs.js');
-const assetSaver = require('./lib/asset-saver.js');
-const fs = require('fs');
-const path = require('path');
-const Sentry = require('./lib/sentry.js');
-const generateReport = require('../report/generator/report-generator.js').generateReport;
-const LighthouseError = require('./lib/lh-error.js');
-const {version: lighthouseVersion} = require('../package.json');
-
-/** @typedef {import('./gather/connections/connection.js')} Connection */
-/** @typedef {import('./lib/arbitrary-equality-map.js')} ArbitraryEqualityMap */
+import isDeepEqual from 'lodash/isEqual.js';
+import {Driver} from './gather/driver.js';
+import {GatherRunner} from './gather/gather-runner.js';
+import {ReportScoring} from './scoring.js';
+import {Audit} from './audits/audit.js';
+import log from 'lighthouse-logger';
+import format from '../shared/localization/format.js';
+import * as stackPacks from './lib/stack-packs.js';
+import * as assetSaver from './lib/asset-saver.js';
+import fs from 'fs';
+import path from 'path';
+import {Sentry} from './lib/sentry.js';
+import ReportGenerator from '../report/generator/report-generator.js';
+import {LighthouseError} from './lib/lh-error.js';
+import {lighthouseVersion} from '../root.js';
+import {getModuleDirectory} from '../esm-utils.js';
+
+const moduleDir = getModuleDirectory(import.meta);
+
+/** @typedef {import('./gather/connections/connection.js').Connection} Connection */
+/** @typedef {import('./lib/arbitrary-equality-map.js').ArbitraryEqualityMap} ArbitraryEqualityMap */
 /** @typedef {LH.Config.Config} Config */
 
 class Runner {
@@ -123,7 +126,7 @@ class Runner {
       }
 
       // Create the HTML, JSON, and/or CSV string
-      const report = generateReport(lhr, settings.output);
+      const report = ReportGenerator.generateReport(lhr, settings.output);
 
       return {lhr, artifacts, report};
     } catch (err) {
@@ -364,7 +367,7 @@ class Runner {
         // If artifact was an error, output error result on behalf of audit.
         if (artifacts[artifactName] instanceof Error) {
           /** @type {Error} */
-          // @ts-expect-error An artifact *could* be an Error, but caught here, so ignore elsewhere.
+          // @ts-expect-error: TODO why is this a type error now?
           const artifactError = artifacts[artifactName];
 
           Sentry.captureException(artifactError, {
@@ -436,8 +439,10 @@ class Runner {
     ];
 
     for (const possibleErrorArtifact of possibleErrorArtifacts) {
+      const isError = possibleErrorArtifact instanceof LighthouseError;
+
       // eslint-disable-next-line max-len
-      if (possibleErrorArtifact instanceof LighthouseError && possibleErrorArtifact.lhrRuntimeError) {
+      if (isError && possibleErrorArtifact.lhrRuntimeError) {
         const errorMessage = possibleErrorArtifact.friendlyMessage || possibleErrorArtifact.message;
 
         return {
@@ -465,18 +470,18 @@ class Runner {
     ];
 
     const fileList = [
-      ...fs.readdirSync(path.join(__dirname, './audits')),
-      ...fs.readdirSync(path.join(__dirname, './audits/dobetterweb')).map(f => `dobetterweb/${f}`),
-      ...fs.readdirSync(path.join(__dirname, './audits/metrics')).map(f => `metrics/${f}`),
-      ...fs.readdirSync(path.join(__dirname, './audits/seo')).map(f => `seo/${f}`),
-      ...fs.readdirSync(path.join(__dirname, './audits/seo/manual')).map(f => `seo/manual/${f}`),
-      ...fs.readdirSync(path.join(__dirname, './audits/accessibility'))
+      ...fs.readdirSync(path.join(moduleDir, './audits')),
+      ...fs.readdirSync(path.join(moduleDir, './audits/dobetterweb')).map(f => `dobetterweb/${f}`),
+      ...fs.readdirSync(path.join(moduleDir, './audits/metrics')).map(f => `metrics/${f}`),
+      ...fs.readdirSync(path.join(moduleDir, './audits/seo')).map(f => `seo/${f}`),
+      ...fs.readdirSync(path.join(moduleDir, './audits/seo/manual')).map(f => `seo/manual/${f}`),
+      ...fs.readdirSync(path.join(moduleDir, './audits/accessibility'))
           .map(f => `accessibility/${f}`),
-      ...fs.readdirSync(path.join(__dirname, './audits/accessibility/manual'))
+      ...fs.readdirSync(path.join(moduleDir, './audits/accessibility/manual'))
           .map(f => `accessibility/manual/${f}`),
-      ...fs.readdirSync(path.join(__dirname, './audits/byte-efficiency'))
+      ...fs.readdirSync(path.join(moduleDir, './audits/byte-efficiency'))
           .map(f => `byte-efficiency/${f}`),
-      ...fs.readdirSync(path.join(__dirname, './audits/manual')).map(f => `manual/${f}`),
+      ...fs.readdirSync(path.join(moduleDir, './audits/manual')).map(f => `manual/${f}`),
     ];
     return fileList.filter(f => {
       return /\.js$/.test(f) && !ignoredFiles.includes(f);
@@ -489,9 +494,9 @@ class Runner {
    */
   static getGathererList() {
     const fileList = [
-      ...fs.readdirSync(path.join(__dirname, './gather/gatherers')),
-      ...fs.readdirSync(path.join(__dirname, './gather/gatherers/seo')).map(f => `seo/${f}`),
-      ...fs.readdirSync(path.join(__dirname, './gather/gatherers/dobetterweb'))
+      ...fs.readdirSync(path.join(moduleDir, './gather/gatherers')),
+      ...fs.readdirSync(path.join(moduleDir, './gather/gatherers/seo')).map(f => `seo/${f}`),
+      ...fs.readdirSync(path.join(moduleDir, './gather/gatherers/dobetterweb'))
           .map(f => `dobetterweb/${f}`),
     ];
     return fileList.filter(f => /\.js$/.test(f) && f !== 'gatherer.js').sort();
@@ -513,4 +518,5 @@ class Runner {
   }
 }
 
-module.exports = Runner;
+// TODO(esmodules): make this not a class.
+export {Runner};

package/lighthouse-core/scoring.js

@@ -6,7 +6,7 @@
 
 'use strict';
 
-const Audit = require('./audits/audit.js');
+import {Audit} from './audits/audit.js';
 
 /**
  * Clamp figure to 2 decimal places
@@ -90,4 +90,4 @@ class ReportScoring {
   }
 }
 
-module.exports = ReportScoring;
+export {ReportScoring};

package/package.json

@@ -1,6 +1,7 @@
 {
   "name": "lighthouse",
-  "version": "9.5.0-dev.20220712",
+  "type": "module",
+  "version": "9.5.0-dev.20220713",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./lighthouse-core/index.js",
   "bin": {
@@ -214,7 +215,8 @@
   },
   "resolutions": {
     "puppeteer/**/devtools-protocol": "0.0.995287",
-    "puppeteer-core/**/devtools-protocol": "0.0.995287"
+    "puppeteer-core/**/devtools-protocol": "0.0.995287",
+    "testdouble/**/quibble": "connorjclark/quibble#mod-cache"
   },
   "repository": "GoogleChrome/lighthouse",
   "keywords": [

package/report/test/generator/report-generator-test.js

@@ -13,9 +13,10 @@ const fs = require('fs');
 const csvValidator = require('csv-validator');
 
 const ReportGenerator = require('../../generator/report-generator.js');
-const {readJson} = require('../../../root.js');
-
-const sampleResults = readJson('lighthouse-core/test/results/sample_v2.json');
+// const {readJson} = require('../../../root.js');
+// TODO(esmodules): remove when this folder is esm
+// const sampleResults = readJson('lighthouse-core/test/results/sample_v2.json');
+const sampleResults = require('../../../lighthouse-core/test/results/sample_v2.json');
 
 describe('ReportGenerator', () => {
   describe('#replaceStrings', () => {

package/report/test/renderer/report-renderer-axe-test.js

@@ -7,7 +7,7 @@
 import puppeteer from 'puppeteer';
 
 import reportGenerator from '../../generator/report-generator.js';
-import axeLib from '../../../lighthouse-core/lib/axe.js';
+import {axeSource} from '../../../lighthouse-core/lib/axe.js';
 import {readJson} from '../../../lighthouse-core/test/test-utils.js';
 
 const sampleResults = readJson('../../../lighthouse-core/test/results/sample_v2.json', import.meta);
@@ -52,7 +52,7 @@ describe('ReportRendererAxe', () => {
         },
       };
 
-      await page.evaluate(axeLib.source);
+      await page.evaluate(axeSource);
       // eslint-disable-next-line no-undef
       const axeResults = await page.evaluate(config => axe.run(config), config);
 

package/root.js

@@ -5,6 +5,14 @@
  */
 'use strict';
 
-module.exports = {
-  LH_ROOT: __dirname,
+import fs from 'fs';
+import {getModuleDirectory} from './esm-utils.js';
+
+const LH_ROOT = getModuleDirectory(import.meta);
+const pkg = JSON.parse(fs.readFileSync(`${LH_ROOT}/package.json`, 'utf-8'));
+const lighthouseVersion = pkg.version;
+
+export {
+  LH_ROOT,
+  lighthouseVersion,
 };

package/shared/package.json

@@ -0,0 +1,4 @@
+{
+  "type": "commonjs",
+  "//": "Preserve commonjs in this directory. Temporary file until converted to type: module"
+}

package/shared/test/localization/format-test.js

@@ -8,10 +8,16 @@
 const path = require('path');
 
 const format = require('../../localization/format.js');
-const i18n = require('../../../lighthouse-core/lib/i18n/i18n.js');
-const constants = require('../../../lighthouse-core/config/constants.js');
 const locales = require('../../localization/locales.js');
 
+// TODO(esmodules): remove when shared/ is esm
+let i18n;
+let constants;
+before(async () => {
+  i18n = await import('../../../lighthouse-core/lib/i18n/i18n.js');
+  constants = await import('../../../lighthouse-core/config/constants.js');
+});
+
 describe('format', () => {
   describe('DEFAULT_LOCALE', () => {
     it('is the same as the default config locale', () => {
@@ -183,9 +189,9 @@ describe('format', () => {
       expect(formattedStr).toEqual('en-XZ cuerda!');
     });
 
-    it('overwrites existing locale strings', () => {
+    it('overwrites existing locale strings', async () => {
       const filename = 'lighthouse-core/audits/is-on-https.js';
-      const UIStrings = require('../../../lighthouse-core/audits/is-on-https.js').UIStrings;
+      const {UIStrings} = await import('../../../lighthouse-core/audits/is-on-https.js');
       const str_ = i18n.createMessageInstanceIdFn(filename, UIStrings);
 
       // To start with, we get back the intended string..
@@ -305,17 +311,21 @@ describe('format', () => {
       helloWorldMultiReplace: '{hello} {world}',
       helloPlural: '{itemCount, plural, =1{1 hello} other{hellos}}',
       helloPluralNestedICU: '{itemCount, plural, ' +
-        '=1{1 hello {in, number, bytes}} ' +
-        'other{hellos {in, number, bytes}}}',
+      '=1{1 hello {in, number, bytes}} ' +
+      'other{hellos {in, number, bytes}}}',
       helloPluralNestedPluralAndICU: '{itemCount, plural, ' +
-        '=1{{innerItemCount, plural, ' +
-          '=1{1 hello 1 goodbye {in, number, bytes}} ' +
-          'other{1 hello, goodbyes {in, number, bytes}}}} ' +
-        'other{{innerItemCount, plural, ' +
-          '=1{hellos 1 goodbye {in, number, bytes}} ' +
-          'other{hellos, goodbyes {in, number, bytes}}}}}',
+      '=1{{innerItemCount, plural, ' +
+      '=1{1 hello 1 goodbye {in, number, bytes}} ' +
+      'other{1 hello, goodbyes {in, number, bytes}}}} ' +
+      'other{{innerItemCount, plural, ' +
+      '=1{hellos 1 goodbye {in, number, bytes}} ' +
+      'other{hellos, goodbyes {in, number, bytes}}}}}',
     };
-    const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings);
+
+    let str_;
+    before(() => {
+      str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings);
+    });
 
     it('formats a basic message', () => {
       const helloStr = str_(UIStrings.helloWorld);

package/shared/test/localization/swap-locale-test.js

@@ -8,6 +8,7 @@
 const swapLocale = require('../../localization/swap-locale.js');
 
 const lhr = require('../../../lighthouse-core/test/results/sample_v2.json');
+
 describe('swap-locale', () => {
   it('does not mutate the original lhr', () => {
     /** @type {LH.Result} */

package/third-party/axe/valid-langs.js

@@ -107,4 +107,4 @@ function validLangs(langArray) {
   return codes;
 }
 
-module.exports = {isValidLang};
+export {isValidLang};

package/third-party/chromium-synchronization/inspector-issueAdded-types-test.js

@@ -5,9 +5,9 @@
  */
 'use strict';
 
-const fs = require('fs');
-const fetch = require('node-fetch');
-const {LH_ROOT} = require('../../root.js');
+import fs from 'fs';
+import fetch from 'node-fetch';
+import { LH_ROOT } from '../../root.js';
 
 const inspectorIssuesGathererPath = LH_ROOT +
   '/lighthouse-core/gather/gatherers/inspector-issues.js';

package/third-party/chromium-synchronization/installability-errors-test.js

@@ -5,9 +5,9 @@
  */
 'use strict';
 
-const fetch = require('node-fetch');
+import fetch from 'node-fetch';
 
-const InstallableManifestAudit = require('../../lighthouse-core/audits/installable-manifest.js');
+import {UIStrings} from '../../lighthouse-core/audits/installable-manifest.js';
 
 describe('installabilityErrors', () => {
   let chromiumErrorIds;
@@ -74,7 +74,7 @@ Array [
   });
 
   it('are each handled explicitly in the gatherer', () => {
-    const errorStrings = Object.keys(InstallableManifestAudit.UIStrings)
+    const errorStrings = Object.keys(UIStrings)
       .filter(key => chromiumErrorIds.includes(key))
       .sort();
     expect(errorStrings).toEqual(chromiumErrorIds);

package/third-party/download-content-shell/download-content-shell.js

@@ -7,11 +7,12 @@
 
 // Grabbed from https://github.com/ChromeDevTools/devtools-frontend/commit/26bb5ad91b147e9c918819711542ec2337d6b268
 
-const fs = require('fs');
-const path = require('path');
-const shell = require('child_process').execSync;
-const utils = require('./utils.js');
-const {LH_ROOT} = require('../../root.js');
+import fs from 'fs';
+
+import path from 'path';
+import { execSync as shell } from 'child_process';
+import * as utils from './utils.js';
+import { LH_ROOT } from '../../root.js';
 
 const TARGET = 'Release';
 const CONTENT_SHELL_ZIP = 'content-shell.zip';