npm - lighthouse - Versions diffs - 9.5.0-dev.20220619 → 9.5.0-dev.20220622 - Mend

lighthouse 9.5.0-dev.20220619 → 9.5.0-dev.20220622

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (29) hide show

package/third-party/devtools-tests/README.md ADDED Viewed

@@ -0,0 +1,14 @@
+# Devtools e2e Tests
+These tests are rolled into the Chromium DevTools Frontend codebase. They "belong" to the devtools frontend, but are truly defined in this Lighthouse repo.
+Run with `sh lighthouse-core/test/devtools-tests/test-locally.sh`.
+See `lighthouse-core/test/chromium-web-tests/README.md` for more.
+## Sync
+```sh
+rsync -ahvz --exclude='OWNERS' --exclude='BUILD.gn' ~/src/devtools/devtools-frontend/test/e2e/lighthouse/ third-party/devtools-tests/e2e/lighthouse/
+rsync -ahvz --exclude='OWNERS' --exclude='BUILD.gn' ~/src/devtools/devtools-frontend/test/e2e/resources/lighthouse/ third-party/devtools-tests/e2e/resources/lighthouse/
+```

package/third-party/devtools-tests/e2e/lighthouse/generate-report_test.ts ADDED Viewed

@@ -0,0 +1,29 @@
+// Copyright 2020 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+import {assert} from 'chai';
+import {goToResource} from '../../shared/helper.js';
+import {describe, it} from '../../shared/mocha-extensions.js';
+import {isGenerateReportButtonDisabled, navigateToLighthouseTab} from '../helpers/lighthouse-helpers.js';
+describe('The Lighthouse Tab', function() {
+  this.timeout(20_000);
+  it('shows a button to generate a new report', async () => {
+    await navigateToLighthouseTab('empty.html');
+    const disabled = await isGenerateReportButtonDisabled();
+    assert.isFalse(disabled, 'The Generate Report button should not be disabled');
+  });
+  // Broken on non-debug runs
+  it.skip('[crbug.com/1057948] shows generate report button even when navigating to an unreachable page', async () => {
+    await navigateToLighthouseTab('empty.html');
+    await goToResource('network/unreachable.rawresponse');
+    const disabled = await isGenerateReportButtonDisabled();
+    assert.isTrue(disabled, 'The Generate Report button should be disabled');
+  });
+});

package/third-party/devtools-tests/e2e/lighthouse/indexeddb-warning_test.ts ADDED Viewed

@@ -0,0 +1,29 @@
+// Copyright 2022 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+import {assert} from 'chai';
+import {waitFor} from '../../shared/helper.js';
+import {describe, it} from '../../shared/mocha-extensions.js';
+import {navigateToLighthouseTab} from '../helpers/lighthouse-helpers.js';
+describe('IndexedDB warning', function() {
+  this.timeout(20_000);
+  it('displays when important data may affect performance', async () => {
+    await navigateToLighthouseTab('empty.html');
+    let warningElem = await waitFor('.lighthouse-warning-text.hidden');
+    const warningText1 = await warningElem.evaluate(node => node.textContent?.trim());
+    assert.strictEqual(warningText1, '');
+    await navigateToLighthouseTab('lighthouse/lighthouse-storage.html');
+    warningElem = await waitFor('.lighthouse-warning-text:not(.hidden)');
+    const expected =
+        'There may be stored data affecting loading performance in this location: IndexedDB. Audit this page in an incognito window to prevent those resources from affecting your scores.';
+    const warningText2 = await warningElem.evaluate(node => node.textContent?.trim());
+    assert.strictEqual(warningText2, expected);
+  });
+});

package/third-party/devtools-tests/e2e/resources/lighthouse/lighthouse-storage.html ADDED Viewed

@@ -0,0 +1,11 @@
+<!DOCTYPE html>
+<head>
+  <meta charset="UTF-8">
+  <script>
+    // Indexeddb
+    window.indexedDB.open("DataBase", 3);
+  </script>
+</head>
+<body>
+  hi
+</body>

package/third-party/download-content-shell/README.md CHANGED Viewed

@@ -6,3 +6,4 @@ Some minor patches on top from the Lighthouse Authors:
 * deleting code we don't need
 * changing output path
+* --resolve-executable-path

package/third-party/download-content-shell/download-content-shell.js CHANGED Viewed

@@ -34,7 +34,6 @@ function main() {
     console.log('Unable to download because of error:', error);
   }
 }
-main();
 function onUploadedCommitPosition(commitPosition) {
   const contentShellDirPath = path.resolve(CACHE_PATH, commitPosition, 'out', TARGET);
@@ -176,3 +175,9 @@ function getContentShellBinaryPath(dirPath) {
     return path.resolve(dirPath, 'Content Shell.app', 'Contents', 'MacOS', 'Content Shell');
   }
 }
+if (process.argv[2] === '--resolve-executable-path') {
+  console.log(getContentShellBinaryPath(process.argv[3]));
+} else {
+  main();
+}

package/types/gatherer.d.ts CHANGED Viewed

@@ -28,8 +28,6 @@ declare module Gatherer {
     setNextProtocolTimeout(ms: number): void;
     on<TEvent extends keyof LH.CrdpEvents>(event: TEvent, callback: (...args: LH.CrdpEvents[TEvent]) => void): void;
     once<TEvent extends keyof LH.CrdpEvents>(event: TEvent, callback: (...args: LH.CrdpEvents[TEvent]) => void): void;
-    addProtocolMessageListener(callback: (payload: Protocol.RawEventMessage) => void): void
-    removeProtocolMessageListener(callback: (payload: Protocol.RawEventMessage) => void): void
     off<TEvent extends keyof LH.CrdpEvents>(event: TEvent, callback: (...args: LH.CrdpEvents[TEvent]) => void): void;
     sendCommand<TMethod extends keyof LH.CrdpCommands>(method: TMethod, ...params: LH.CrdpCommands[TMethod]['paramsType']): Promise<LH.CrdpCommands[TMethod]['returnType']>;
     dispose(): Promise<void>;
@@ -41,6 +39,11 @@ declare module Gatherer {
     executionContext: ExecutionContext;
     fetcher: Fetcher;
     url: () => Promise<string>;
+    targetManager: {
+      rootSession(): FRProtocolSession;
+      on(event: 'protocolevent', callback: (payload: Protocol.RawEventMessage) => void): void
+      off(event: 'protocolevent', callback: (payload: Protocol.RawEventMessage) => void): void
+    };
   }
   /** The limited context interface shared between pre and post Fraggle Rock Lighthouse. */

package/types/protocol.d.ts CHANGED Viewed

@@ -5,6 +5,23 @@
  */
 declare module Protocol {
+  /**
+   * An intermediate type, used to create a record of all possible Crdp raw event
+   * messages, keyed on method. e.g. {
+   *   'Domain.method1Name': {method: 'Domain.method1Name', params: EventPayload1},
+   *   'Domain.method2Name': {method: 'Domain.method2Name', params: EventPayload2},
+   * }
+   */
+  type RawEventMessageRecord = {
+    [K in keyof LH.CrdpEvents]: {
+      method: K,
+      // Drop [] for `undefined` (so a JS value is valid).
+      params: LH.CrdpEvents[K] extends [] ? undefined: LH.CrdpEvents[K][number]
+      // If sessionId is not set, it means the event was from the root target.
+      sessionId?: string;
+    };
+  }
   /**
    * Union of raw (over the wire) message format of all possible Crdp events,
    * of the form `{method: 'Domain.event', params: eventPayload}`.
@@ -50,24 +67,9 @@ declare module Protocol {
     once<E extends keyof TEventRecord>(event: E, listener: (...args: TEventRecord[E]) => void): void;
     emit<E extends keyof TEventRecord>(event: E, ...request: TEventRecord[E]): void;
-  }
-}
-/**
- * An intermediate type, used to create a record of all possible Crdp raw event
- * messages, keyed on method. e.g. {
- *   'Domain.method1Name': {method: 'Domain.method1Name', params: EventPayload1},
- *   'Domain.method2Name': {method: 'Domain.method2Name', params: EventPayload2},
- * }
- */
-type RawEventMessageRecord = {
-  [K in keyof LH.CrdpEvents]: {
-    method: K,
-    // Drop [] for `undefined` (so a JS value is valid).
-    params: LH.CrdpEvents[K] extends [] ? undefined: LH.CrdpEvents[K][number]
-    // If sessionId is not set, it means the event was from the root target.
-    sessionId?: string;
-  };
+    listenerCount<E extends keyof TEventRecord>(event: E): number;
+  }
 }
 export default Protocol;