lighthouse 9.5.0-dev.20220612 → 9.5.0-dev.20220615

package/changelog.md

@@ -1,6 +1,6 @@
 <a name="9.5.0"></a>
 # 9.5.0 (2022-03-09)
-[Full Changelog](https://github.com/compare/v9.4.0...v9.5.0)
+[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.4.0...v9.5.0)
 
 We expect this release to ship in the DevTools of [Chrome 101](https://chromiumdash.appspot.com/schedule), and to PageSpeed Insights within 2 weeks.
 
@@ -54,7 +54,7 @@ Thanks to our new contributor 👽🐷🐰🐯🐻!
 
 <a name="9.4.0"></a>
 # 9.4.0 (2022-02-16)
-[Full Changelog](https://github.com/compare/v9.3.1...v9.4.0)
+[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.3.1...v9.4.0)
 
 We expect this release to ship in the DevTools of [Chrome 100](https://chromiumdash.appspot.com/schedule), and to PageSpeed Insights within 2 weeks.
 
@@ -99,7 +99,7 @@ We expect this release to ship in the DevTools of [Chrome 100](https://chromiumd
 
 <a name="9.3.1"></a>
 # 9.3.1 (2022-01-31)
-[Full Changelog](https://github.com/compare/v9.3.0...v9.3.1)
+[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.3.0...v9.3.1)
 
 ## Report
 
@@ -107,7 +107,7 @@ We expect this release to ship in the DevTools of [Chrome 100](https://chromiumd
 
 <a name="9.3.0"></a>
 # 9.3.0 (2022-01-31)
-[Full Changelog](https://github.com/compare/v9.2.0...v9.3.0)
+[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v9.2.0...v9.3.0)
 
 We expect this release to ship in the DevTools of [Chrome 100](https://chromiumdash.appspot.com/schedule), and to PageSpeed Insights within 2 weeks.
 

package/lighthouse-core/audits/metrics/largest-contentful-paint.js

@@ -8,7 +8,6 @@
 const Audit = require('../audit.js');
 const i18n = require('../../lib/i18n/i18n.js');
 const ComputedLcp = require('../../computed/metrics/largest-contentful-paint.js');
-const LHError = require('../../lib/lh-error.js');
 
 const UIStrings = {
   /** Description of the Largest Contentful Paint (LCP) metric, which marks the time at which the largest text or image is painted by the browser. This is displayed within a tooltip when the user hovers on the metric name to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */
@@ -77,28 +76,9 @@ class LargestContentfulPaint extends Audit {
     const metricComputationData = {trace, devtoolsLog, gatherContext,
       settings: context.settings, URL: artifacts.URL};
 
-    let metricResult;
-    try {
-      metricResult = await ComputedLcp.request(metricComputationData, context);
-    } catch (err) {
-      const match = artifacts.HostUserAgent.match(/Chrome\/(\d+)/);
-      if (!match) throw err;
-      const milestone = Number(match[1]);
-
-      // m79 is the minimum version which supports LCP
-      // https://chromium.googlesource.com/chromium/src/+/master/docs/speed/metrics_changelog/lcp.md
-      if (milestone < 79 && err.code === 'NO_LCP') {
-        throw new LHError(
-          LHError.errors.UNSUPPORTED_OLD_CHROME,
-          {featureName: 'Largest Contentful Paint'}
-        );
-      }
-      throw err;
-    }
-
+    const metricResult = await ComputedLcp.request(metricComputationData, context);
     const options = context.options[context.settings.formFactor];
 
-
     return {
       score: Audit.computeLogNormalScore(
         options.scoring,

package/lighthouse-core/fraggle-rock/config/filters.js

@@ -294,6 +294,8 @@ function filterConfigByExplicitFilters(config, filters) {
     baseAuditIds = getAuditIdsInCategories(config.categories, onlyCategories);
   } else if (onlyAudits) {
     baseAuditIds = new Set();
+  } else if (!config.categories || !Object.keys(config.categories).length) {
+    baseAuditIds = new Set(config.audits?.map(audit => audit.implementation.meta.id));
   }
 
   const auditIdsToKeep = new Set(

package/lighthouse-core/fraggle-rock/gather/navigation-runner.js

@@ -327,6 +327,7 @@ async function navigationGather(requestor, options) {
   const artifacts = await Runner.gather(
     async () => {
       let {page} = options;
+      const normalizedRequestor = isCallback ? requestor : URL.normalizeUrl(requestor);
 
       // For navigation mode, we shouldn't connect to a browser in audit mode,
       // therefore we connect to the browser in the gatherFn callback.
@@ -340,7 +341,7 @@ async function navigationGather(requestor, options) {
       const context = {
         driver,
         config,
-        requestor: isCallback ? requestor : URL.normalizeUrl(requestor),
+        requestor: normalizedRequestor,
         options: internalOptions,
       };
       const {baseArtifacts} = await _setup(context);

package/lighthouse-core/fraggle-rock/user-flow.js

@@ -108,13 +108,64 @@ class UserFlow {
    */
   async navigate(requestor, stepOptions) {
     if (this.currentTimespan) throw new Error('Timespan already in progress');
+    if (this.currentNavigation) throw new Error('Navigation already in progress');
 
     const options = this._getNextNavigationOptions(stepOptions);
     const gatherResult = await navigationGather(requestor, options);
 
     this._addGatherStep(gatherResult, options);
+  }
+
+  /**
+   * This is an alternative to `navigate()` that can be used to analyze a navigation triggered by user interaction.
+   * For more on user triggered navigations, see https://github.com/GoogleChrome/lighthouse/blob/master/docs/user-flows.md#triggering-a-navigation-via-user-interactions.
+   *
+   * @param {StepOptions=} stepOptions
+   */
+  async startNavigation(stepOptions) {
+    /** @type {(value: () => void) => void} */
+    let completeSetup;
+    /** @type {(value: any) => void} */
+    let rejectDuringSetup;
+
+    // This promise will resolve once the setup is done
+    // and Lighthouse is waiting for a page navigation to be triggered.
+    const navigationSetupPromise = new Promise((resolve, reject) => {
+      completeSetup = resolve;
+      rejectDuringSetup = reject;
+    });
+
+    // The promise in this callback will not resolve until `continueNavigation` is invoked,
+    // because `continueNavigation` is passed along to `navigateSetupPromise`
+    // and extracted into `continueAndAwaitResult` below.
+    const navigationResultPromise = this.navigate(
+      () => new Promise(continueNavigation => completeSetup(continueNavigation)),
+      stepOptions
+    ).catch(err => {
+      if (this.currentNavigation) {
+        // If the navigation already started, re-throw the error so it is emitted when `navigationResultPromise` is awaited.
+        throw err;
+      } else {
+        // If the navigation has not started, reject the `navigationSetupPromise` so the error throws when it is awaited in `startNavigation`.
+        rejectDuringSetup(err);
+      }
+    });
+
+    const continueNavigation = await navigationSetupPromise;
 
-    return gatherResult;
+    async function continueAndAwaitResult() {
+      continueNavigation();
+      await navigationResultPromise;
+    }
+
+    this.currentNavigation = {continueAndAwaitResult};
+  }
+
+  async endNavigation() {
+    if (this.currentTimespan) throw new Error('Timespan already in progress');
+    if (!this.currentNavigation) throw new Error('No navigation in progress');
+    await this.currentNavigation.continueAndAwaitResult();
+    this.currentNavigation = undefined;
   }
 
   /**
@@ -122,6 +173,7 @@ class UserFlow {
    */
   async startTimespan(stepOptions) {
     if (this.currentTimespan) throw new Error('Timespan already in progress');
+    if (this.currentNavigation) throw new Error('Navigation already in progress');
 
     const options = {...this.options, ...stepOptions};
     const timespan = await startTimespanGather(options);
@@ -130,14 +182,13 @@ class UserFlow {
 
   async endTimespan() {
     if (!this.currentTimespan) throw new Error('No timespan in progress');
+    if (this.currentNavigation) throw new Error('Navigation already in progress');
 
     const {timespan, options} = this.currentTimespan;
     const gatherResult = await timespan.endTimespanGather();
     this.currentTimespan = undefined;
 
     this._addGatherStep(gatherResult, options);
-
-    return gatherResult;
   }
 
   /**
@@ -145,13 +196,12 @@ class UserFlow {
    */
   async snapshot(stepOptions) {
     if (this.currentTimespan) throw new Error('Timespan already in progress');
+    if (this.currentNavigation) throw new Error('Navigation already in progress');
 
     const options = {...this.options, ...stepOptions};
     const gatherResult = await snapshotGather(options);
 
     this._addGatherStep(gatherResult, options);
-
-    return gatherResult;
   }
 
   /**

package/lighthouse-core/gather/gatherers/scripts.js

@@ -65,29 +65,15 @@ class Scripts extends FRGatherer {
 
   constructor() {
     super();
-    this.onProtocolMessage = this.onProtocolMessage.bind(this);
+    this.onScriptParsed = this.onScriptParsed.bind(this);
   }
 
   /**
-   * @param {LH.Protocol.RawEventMessage} event
+   * @param {LH.Crdp.Debugger.ScriptParsedEvent} params
    */
-  onProtocolMessage(event) {
-    // Go read the comments in network-recorder.js _findRealRequestAndSetSession.
-    let sessionId = event.sessionId;
-    if (this._mainSessionId === null) {
-      this._mainSessionId = sessionId;
-    }
-    if (this._mainSessionId === sessionId) {
-      sessionId = undefined;
-    }
-
-    // We want to ignore scripts from OOPIFs. In reality, this does more than block just OOPIFs,
-    // it also blocks scripts from the same origin but that happen to run in a different process,
-    // like a worker.
-    if (event.method === 'Debugger.scriptParsed' && !sessionId) {
-      if (!isLighthouseRuntimeEvaluateScript(event.params)) {
-        this._scriptParsedEvents.push(event.params);
-      }
+  onScriptParsed(params) {
+    if (!isLighthouseRuntimeEvaluateScript(params)) {
+      this._scriptParsedEvents.push(params);
     }
   }
 
@@ -96,7 +82,7 @@ class Scripts extends FRGatherer {
    */
   async startInstrumentation(context) {
     const session = context.driver.defaultSession;
-    session.addProtocolMessageListener(this.onProtocolMessage);
+    session.on('Debugger.scriptParsed', this.onScriptParsed);
     await session.sendCommand('Debugger.enable');
   }
 
@@ -107,7 +93,7 @@ class Scripts extends FRGatherer {
     const session = context.driver.defaultSession;
     const formFactor = context.baseArtifacts.HostFormFactor;
 
-    session.removeProtocolMessageListener(this.onProtocolMessage);
+    session.off('Debugger.scriptParsed', this.onScriptParsed);
 
     // Without this line the Debugger domain will be off in FR runner,
     // because only the legacy gatherer has special handling for multiple,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "lighthouse",
-  "version": "9.5.0-dev.20220612",
+  "version": "9.5.0-dev.20220615",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./lighthouse-core/index.js",
   "bin": {