lighthouse 9.5.0-dev.20220610 → 9.5.0-dev.20220613

package/lighthouse-core/audits/metrics/largest-contentful-paint.js

@@ -8,7 +8,6 @@
 const Audit = require('../audit.js');
 const i18n = require('../../lib/i18n/i18n.js');
 const ComputedLcp = require('../../computed/metrics/largest-contentful-paint.js');
-const LHError = require('../../lib/lh-error.js');
 
 const UIStrings = {
   /** Description of the Largest Contentful Paint (LCP) metric, which marks the time at which the largest text or image is painted by the browser. This is displayed within a tooltip when the user hovers on the metric name to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */
@@ -77,28 +76,9 @@ class LargestContentfulPaint extends Audit {
     const metricComputationData = {trace, devtoolsLog, gatherContext,
       settings: context.settings, URL: artifacts.URL};
 
-    let metricResult;
-    try {
-      metricResult = await ComputedLcp.request(metricComputationData, context);
-    } catch (err) {
-      const match = artifacts.HostUserAgent.match(/Chrome\/(\d+)/);
-      if (!match) throw err;
-      const milestone = Number(match[1]);
-
-      // m79 is the minimum version which supports LCP
-      // https://chromium.googlesource.com/chromium/src/+/master/docs/speed/metrics_changelog/lcp.md
-      if (milestone < 79 && err.code === 'NO_LCP') {
-        throw new LHError(
-          LHError.errors.UNSUPPORTED_OLD_CHROME,
-          {featureName: 'Largest Contentful Paint'}
-        );
-      }
-      throw err;
-    }
-
+    const metricResult = await ComputedLcp.request(metricComputationData, context);
     const options = context.options[context.settings.formFactor];
 
-
     return {
       score: Audit.computeLogNormalScore(
         options.scoring,

package/lighthouse-core/fraggle-rock/config/filters.js

@@ -294,6 +294,8 @@ function filterConfigByExplicitFilters(config, filters) {
     baseAuditIds = getAuditIdsInCategories(config.categories, onlyCategories);
   } else if (onlyAudits) {
     baseAuditIds = new Set();
+  } else if (!config.categories || !Object.keys(config.categories).length) {
+    baseAuditIds = new Set(config.audits?.map(audit => audit.implementation.meta.id));
   }
 
   const auditIdsToKeep = new Set(

package/lighthouse-core/fraggle-rock/gather/navigation-runner.js

@@ -327,6 +327,7 @@ async function navigationGather(requestor, options) {
   const artifacts = await Runner.gather(
     async () => {
       let {page} = options;
+      const normalizedRequestor = isCallback ? requestor : URL.normalizeUrl(requestor);
 
       // For navigation mode, we shouldn't connect to a browser in audit mode,
       // therefore we connect to the browser in the gatherFn callback.
@@ -340,7 +341,7 @@ async function navigationGather(requestor, options) {
       const context = {
         driver,
         config,
-        requestor: isCallback ? requestor : URL.normalizeUrl(requestor),
+        requestor: normalizedRequestor,
         options: internalOptions,
       };
       const {baseArtifacts} = await _setup(context);

package/lighthouse-core/gather/gatherers/scripts.js

@@ -65,29 +65,15 @@ class Scripts extends FRGatherer {
 
   constructor() {
     super();
-    this.onProtocolMessage = this.onProtocolMessage.bind(this);
+    this.onScriptParsed = this.onScriptParsed.bind(this);
   }
 
   /**
-   * @param {LH.Protocol.RawEventMessage} event
+   * @param {LH.Crdp.Debugger.ScriptParsedEvent} params
    */
-  onProtocolMessage(event) {
-    // Go read the comments in network-recorder.js _findRealRequestAndSetSession.
-    let sessionId = event.sessionId;
-    if (this._mainSessionId === null) {
-      this._mainSessionId = sessionId;
-    }
-    if (this._mainSessionId === sessionId) {
-      sessionId = undefined;
-    }
-
-    // We want to ignore scripts from OOPIFs. In reality, this does more than block just OOPIFs,
-    // it also blocks scripts from the same origin but that happen to run in a different process,
-    // like a worker.
-    if (event.method === 'Debugger.scriptParsed' && !sessionId) {
-      if (!isLighthouseRuntimeEvaluateScript(event.params)) {
-        this._scriptParsedEvents.push(event.params);
-      }
+  onScriptParsed(params) {
+    if (!isLighthouseRuntimeEvaluateScript(params)) {
+      this._scriptParsedEvents.push(params);
     }
   }
 
@@ -96,7 +82,7 @@ class Scripts extends FRGatherer {
    */
   async startInstrumentation(context) {
     const session = context.driver.defaultSession;
-    session.addProtocolMessageListener(this.onProtocolMessage);
+    session.on('Debugger.scriptParsed', this.onScriptParsed);
     await session.sendCommand('Debugger.enable');
   }
 
@@ -107,7 +93,7 @@ class Scripts extends FRGatherer {
     const session = context.driver.defaultSession;
     const formFactor = context.baseArtifacts.HostFormFactor;
 
-    session.removeProtocolMessageListener(this.onProtocolMessage);
+    session.off('Debugger.scriptParsed', this.onScriptParsed);
 
     // Without this line the Debugger domain will be off in FR runner,
     // because only the legacy gatherer has special handling for multiple,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "lighthouse",
-  "version": "9.5.0-dev.20220610",
+  "version": "9.5.0-dev.20220613",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./lighthouse-core/index.js",
   "bin": {