lighthouse 9.5.0-dev.20220517 → 9.5.0-dev.20220520

package/lighthouse-core/gather/driver/execution-context.js

@@ -215,6 +215,7 @@ class ExecutionContext {
       window.__nativePerformance = window.performance;
       window.__nativeFetch = window.fetch;
       window.__ElementMatches = window.Element.prototype.matches;
+      window.__HTMLElementBoundingClientRect = window.HTMLElement.prototype.getBoundingClientRect;
       // Ensure the native `performance.now` is not overwritable.
       const performance = window.performance;
       const performanceNow = window.performance.now;

package/lighthouse-core/gather/driver/navigation.js

@@ -131,7 +131,10 @@ async function gotoURL(driver, requestor, options) {
   let requestedUrl = navigationUrls.requestedUrl;
   if (typeof requestor === 'string') {
     if (requestedUrl && !URL.equalWithExcludedFragments(requestor, requestedUrl)) {
-      log.error('Navigation', 'Provided URL did not match initial navigation URL');
+      log.error(
+        'Navigation',
+        `Provided URL (${requestor}) did not match initial navigation URL (${requestedUrl})`
+      );
     }
     requestedUrl = requestor;
   }

package/lighthouse-core/gather/gatherers/iframe-elements.js

@@ -17,10 +17,13 @@ const pageFunctions = require('../../lib/page-functions.js');
  */
 /* c8 ignore start */
 function collectIFrameElements() {
+  const realBoundingClientRect = window.__HTMLElementBoundingClientRect ||
+    window.HTMLElement.prototype.getBoundingClientRect;
+
   // @ts-expect-error - put into scope via stringification
   const iFrameElements = getElementsInDocument('iframe'); // eslint-disable-line no-undef
   return iFrameElements.map(/** @param {HTMLIFrameElement} node */ (node) => {
-    const clientRect = node.getBoundingClientRect();
+    const clientRect = realBoundingClientRect.call(node);
     const {top, bottom, left, right, width, height} = clientRect;
     return {
       id: node.id,

package/lighthouse-core/gather/gatherers/image-elements.js

@@ -258,6 +258,7 @@ class ImageElements extends FRGatherer {
         driver.defaultSession.setNextProtocolTimeout(250);
         size = await driver.executionContext.evaluate(determineNaturalSize, {
           args: [url],
+          useIsolation: true,
         });
         this._naturalSizeCache.set(url, size);
       } catch (_) {
@@ -340,6 +341,7 @@ class ImageElements extends FRGatherer {
 
     const elements = await executionContext.evaluate(collectImageElementInfo, {
       args: [],
+      useIsolation: true,
       deps: [
         pageFunctions.getElementsInDocumentString,
         pageFunctions.getBoundingClientRectString,

package/lighthouse-core/lib/page-functions.js

@@ -434,8 +434,10 @@ function getNodeLabel(element) {
  * @return {LH.Artifacts.Rect}
  */
 function getBoundingClientRect(element) {
+  const realBoundingClientRect = window.__HTMLElementBoundingClientRect ||
+    window.HTMLElement.prototype.getBoundingClientRect;
   // The protocol does not serialize getters, so extract the values explicitly.
-  const rect = element.getBoundingClientRect();
+  const rect = realBoundingClientRect.call(element);
   return {
     top: Math.round(rect.top),
     bottom: Math.round(rect.bottom),

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "lighthouse",
-  "version": "9.5.0-dev.20220517",
+  "version": "9.5.0-dev.20220520",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./lighthouse-core/index.js",
   "bin": {

package/types/externs.d.ts

@@ -23,6 +23,7 @@ declare global {
     __nativeFetch: typeof fetch,
     __nativeURL: typeof URL;
     __ElementMatches: Element['matches'];
+    __HTMLElementBoundingClientRect: HTMLElement['getBoundingClientRect'];
 
     /** Used for monitoring long tasks in the test page. */
     ____lastLongTask?: number;