lighthouse 9.5.0-dev.20220510 → 9.5.0-dev.20220513

package/report/renderer/details-renderer.js

@@ -26,7 +26,6 @@
 
 import {Util} from './util.js';
 import {CriticalRequestChainRenderer} from './crc-details-renderer.js';
-import {SnippetRenderer} from './snippet-renderer.js';
 import {ElementScreenshotRenderer} from './element-screenshot-renderer.js';
 
 const URL_PREFIXES = ['http://', 'https://', 'data:'];
@@ -472,15 +471,16 @@ export class DetailsRenderer {
   }
 
   /**
-   * @param {LH.Audit.Details.List} details
+   * @param {LH.FormattedIcu<LH.Audit.Details.List>} details
    * @return {Element}
    */
   _renderList(details) {
     const listContainer = this._dom.createElement('div', 'lh-list');
 
     details.items.forEach(item => {
-      const snippetEl = SnippetRenderer.render(this._dom, item, this);
-      listContainer.appendChild(snippetEl);
+      const listItem = this.render(item);
+      if (!listItem) return;
+      listContainer.append(listItem);
     });
 
     return listContainer;

package/report/test/clients/bundle-test.js

@@ -4,7 +4,6 @@
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
 
-
 import fs from 'fs';
 
 import jsdom from 'jsdom';

package/report/test/renderer/details-renderer-test.js

@@ -188,24 +188,24 @@ describe('DetailsRenderer', () => {
     });
 
     it('renders lists', () => {
-      const snippet = {
-        type: 'snippet',
-        lines: [{lineNumber: 1, content: ''}],
-        title: 'Some snippet',
-        lineMessages: [],
-        generalMessages: [],
-        lineCount: 100,
+      const table = {
+        type: 'table',
+        headings: [{text: '', key: 'numeric', itemType: 'numeric'}],
+        items: [{numeric: 1234.567}],
       };
 
       const el = renderer.render({
         type: 'list',
-        items: [snippet, snippet],
+        items: [table, table],
       });
 
       assert.equal(el.localName, 'div');
       assert.ok(el.classList.contains('lh-list'), 'has list class');
       assert.ok(el.children.length, 2, 'renders all items');
-      assert.ok(el.children[0].textContent.includes('Some snippet'), 'renders item content');
+      for (const child of el.children) {
+        assert.ok(child.classList.contains('lh-table'));
+        assert.equal(child.textContent, '1,234.6');
+      }
     });
 
     it('does not render internal-only screenshot details', () => {

package/shared/localization/locales/en-US.json

@@ -1664,6 +1664,9 @@
   "lighthouse-core/audits/work-during-interaction.js | displayValue": {
     "message": "{timeInMs, number, milliseconds} ms spent on event '{interactionType}'"
   },
+  "lighthouse-core/audits/work-during-interaction.js | eventTarget": {
+    "message": "Event target"
+  },
   "lighthouse-core/audits/work-during-interaction.js | failureTitle": {
     "message": "Minimize work during key interaction"
   },
@@ -1673,8 +1676,8 @@
   "lighthouse-core/audits/work-during-interaction.js | presentationDelay": {
     "message": "Presentation delay"
   },
-  "lighthouse-core/audits/work-during-interaction.js | processingDelay": {
-    "message": "Processing delay"
+  "lighthouse-core/audits/work-during-interaction.js | processingTime": {
+    "message": "Processing time"
   },
   "lighthouse-core/audits/work-during-interaction.js | title": {
     "message": "Minimizes work during key interaction"

package/shared/localization/locales/en-XL.json

@@ -1664,6 +1664,9 @@
   "lighthouse-core/audits/work-during-interaction.js | displayValue": {
     "message": "{timeInMs, number, milliseconds} m̂ś ŝṕêńt̂ ón̂ év̂én̂t́ '{interactionType}'"
   },
+  "lighthouse-core/audits/work-during-interaction.js | eventTarget": {
+    "message": "Êv́êńt̂ t́âŕĝét̂"
+  },
   "lighthouse-core/audits/work-during-interaction.js | failureTitle": {
     "message": "M̂ín̂ím̂íẑé ŵór̂ḱ d̂úr̂ín̂ǵ k̂éŷ ín̂t́êŕâćt̂íôń"
   },
@@ -1673,8 +1676,8 @@
   "lighthouse-core/audits/work-during-interaction.js | presentationDelay": {
     "message": "P̂ŕêśêńt̂át̂íôń d̂él̂áŷ"
   },
-  "lighthouse-core/audits/work-during-interaction.js | processingDelay": {
-    "message": "P̂ŕôćêśŝín̂ǵ d̂él̂áŷ"
+  "lighthouse-core/audits/work-during-interaction.js | processingTime": {
+    "message": "P̂ŕôćêśŝín̂ǵ t̂ím̂é"
   },
   "lighthouse-core/audits/work-during-interaction.js | title": {
     "message": "M̂ín̂ím̂íẑéŝ ẃôŕk̂ d́ûŕîńĝ ḱêý îńt̂ér̂áĉt́îón̂"

package/types/artifacts.d.ts

@@ -573,7 +573,7 @@ declare module Artifacts {
   }
 
   interface TraceElement {
-    traceEventType: 'largest-contentful-paint'|'layout-shift'|'animation';
+    traceEventType: 'largest-contentful-paint'|'layout-shift'|'animation'|'responsiveness';
     score?: number;
     node: NodeDetails;
     nodeId?: number;

package/types/lhr/audit-details.d.ts

@@ -58,7 +58,9 @@ declare module Details {
 
   interface List {
     type: 'list';
-    items: SnippetValue[]
+    // NOTE: any `Details` type *should* be usable in `items`, but check
+    // styles/report-ui-features are good before adding.
+    items: Array<Table | DebugData>;
   }
 
   interface Opportunity {