lighthouse 9.5.0-dev.20220510 → 9.5.0-dev.20220511

package/report/test/renderer/details-renderer-test.js

@@ -188,24 +188,24 @@ describe('DetailsRenderer', () => {
     });
 
     it('renders lists', () => {
-      const snippet = {
-        type: 'snippet',
-        lines: [{lineNumber: 1, content: ''}],
-        title: 'Some snippet',
-        lineMessages: [],
-        generalMessages: [],
-        lineCount: 100,
+      const table = {
+        type: 'table',
+        headings: [{text: '', key: 'numeric', itemType: 'numeric'}],
+        items: [{numeric: 1234.567}],
       };
 
       const el = renderer.render({
         type: 'list',
-        items: [snippet, snippet],
+        items: [table, table],
       });
 
       assert.equal(el.localName, 'div');
       assert.ok(el.classList.contains('lh-list'), 'has list class');
       assert.ok(el.children.length, 2, 'renders all items');
-      assert.ok(el.children[0].textContent.includes('Some snippet'), 'renders item content');
+      for (const child of el.children) {
+        assert.ok(child.classList.contains('lh-table'));
+        assert.equal(child.textContent, '1,234.6');
+      }
     });
 
     it('does not render internal-only screenshot details', () => {

package/shared/localization/locales/en-US.json

@@ -1664,6 +1664,9 @@
   "lighthouse-core/audits/work-during-interaction.js | displayValue": {
     "message": "{timeInMs, number, milliseconds} ms spent on event '{interactionType}'"
   },
+  "lighthouse-core/audits/work-during-interaction.js | eventTarget": {
+    "message": "Event target"
+  },
   "lighthouse-core/audits/work-during-interaction.js | failureTitle": {
     "message": "Minimize work during key interaction"
   },

package/shared/localization/locales/en-XL.json

@@ -1664,6 +1664,9 @@
   "lighthouse-core/audits/work-during-interaction.js | displayValue": {
     "message": "{timeInMs, number, milliseconds} m̂ś ŝṕêńt̂ ón̂ év̂én̂t́ '{interactionType}'"
   },
+  "lighthouse-core/audits/work-during-interaction.js | eventTarget": {
+    "message": "Êv́êńt̂ t́âŕĝét̂"
+  },
   "lighthouse-core/audits/work-during-interaction.js | failureTitle": {
     "message": "M̂ín̂ím̂íẑé ŵór̂ḱ d̂úr̂ín̂ǵ k̂éŷ ín̂t́êŕâćt̂íôń"
   },

package/types/artifacts.d.ts

@@ -573,7 +573,7 @@ declare module Artifacts {
   }
 
   interface TraceElement {
-    traceEventType: 'largest-contentful-paint'|'layout-shift'|'animation';
+    traceEventType: 'largest-contentful-paint'|'layout-shift'|'animation'|'responsiveness';
     score?: number;
     node: NodeDetails;
     nodeId?: number;

package/types/lhr/audit-details.d.ts

@@ -58,7 +58,9 @@ declare module Details {
 
   interface List {
     type: 'list';
-    items: SnippetValue[]
+    // NOTE: any `Details` type *should* be usable in `items`, but check
+    // styles/report-ui-features are good before adding.
+    items: Array<Table | DebugData>;
   }
 
   interface Opportunity {