lighthouse 9.5.0-dev.20220509 → 9.6.1

package/report/test/generator/report-generator-test.js

@@ -5,8 +5,6 @@
  */
 'use strict';
 
-/* eslint-disable no-irregular-whitespace */
-
 const assert = require('assert').strict;
 const fs = require('fs');
 
@@ -15,6 +13,8 @@ const csvValidator = require('csv-validator');
 const ReportGenerator = require('../../generator/report-generator.js');
 const sampleResults = require('../../../lighthouse-core/test/results/sample_v2.json');
 
+/* eslint-env jest */
+
 describe('ReportGenerator', () => {
   describe('#replaceStrings', () => {
     it('should replace all occurrences', () => {
@@ -81,33 +81,28 @@ describe('ReportGenerator', () => {
 
     it('creates CSV for results', async () => {
       const path = './.results-as-csv.csv';
+      const headers = {
+        category: '',
+        name: '',
+        title: '',
+        type: '',
+        score: 42,
+      };
 
       const csvOutput = ReportGenerator.generateReport(sampleResults, 'csv');
       fs.writeFileSync(path, csvOutput);
 
       const lines = csvOutput.split('\n');
       expect(lines.length).toBeGreaterThan(100);
-      expect(lines.slice(0, 15).join('\n')).toMatchInlineSnapshot(`
-"\\"requestedUrl\\",\\"finalUrl\\",\\"fetchTime\\",\\"gatherMode\\"
-\\"http://localhost:10200/dobetterweb/dbw_tester.html\\",\\"http://localhost:10200/dobetterweb/dbw_tester.html\\",\\"2021-09-07T20:11:11.853Z\\",\\"navigation\\"
-
-category,score
-\\"performance\\",\\"0.26\\"
-\\"accessibility\\",\\"0.78\\"
-\\"best-practices\\",\\"0.25\\"
-\\"seo\\",\\"0.67\\"
-\\"pwa\\",\\"0.3\\"
-
-category,audit,score,displayValue,description
-\\"performance\\",\\"first-contentful-paint\\",\\"0.01\\",\\"6.8 s\\",\\"First Contentful Paint marks the time at which the first text or image is painted. [Learn more](https://web.dev/first-contentful-paint/).\\"
-\\"performance\\",\\"interactive\\",\\"0.41\\",\\"8.2 s\\",\\"Time to interactive is the amount of time it takes for the page to become fully interactive. [Learn more](https://web.dev/interactive/).\\"
-\\"performance\\",\\"speed-index\\",\\"0.21\\",\\"8.1 s\\",\\"Speed Index shows how quickly the contents of a page are visibly populated. [Learn more](https://web.dev/speed-index/).\\"
-\\"performance\\",\\"total-blocking-time\\",\\"0.2\\",\\"1,220 ms\\",\\"Sum of all time periods between FCP and Time to Interactive, when task length exceeded 50ms, expressed in milliseconds. [Learn more](https://web.dev/lighthouse-total-blocking-time/).\\"
+      expect(lines.slice(0, 3).join('\n')).toMatchInlineSnapshot(`
+"requestedUrl,finalUrl,category,name,title,type,score
+\\"http://localhost:10200/dobetterweb/dbw_tester.html\\",\\"http://localhost:10200/dobetterweb/dbw_tester.html\\",\\"Performance\\",\\"performance-score\\",\\"Overall Performance Category Score\\",\\"numeric\\",\\"0.26\\"
+\\"http://localhost:10200/dobetterweb/dbw_tester.html\\",\\"http://localhost:10200/dobetterweb/dbw_tester.html\\",\\"Performance\\",\\"first-contentful-paint\\",\\"First Contentful Paint\\",\\"numeric\\",\\"0.01\\"
 "
 `);
 
       try {
-        await csvValidator(path);
+        await csvValidator(path, headers);
       } catch (err) {
         assert.fail('CSV parser error:\n' + err.join('\n'));
       } finally {
@@ -115,13 +110,13 @@ category,audit,score,displayValue,description
       }
     });
 
-    it('creates CSV for results including categories', () => {
+    it('creates CSV for results including overall category scores', () => {
       const csvOutput = ReportGenerator.generateReport(sampleResults, 'csv');
-      expect(csvOutput).toContain('performance');
-      expect(csvOutput).toContain('accessibility');
-      expect(csvOutput).toContain('best-practices');
-      expect(csvOutput).toContain('seo');
-      expect(csvOutput).toContain('pwa');
+      expect(csvOutput).toContain('performance-score');
+      expect(csvOutput).toContain('accessibility-score');
+      expect(csvOutput).toContain('best-practices-score');
+      expect(csvOutput).toContain('seo-score');
+      expect(csvOutput).toContain('pwa-score');
     });
 
     it('writes extended info', () => {

package/report/test/renderer/category-renderer-test.js

@@ -3,6 +3,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
+'use strict';
+
+/* eslint-env jest */
 
 import {strict as assert} from 'assert';
 

package/report/test/renderer/components-test.js

@@ -3,6 +3,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
+'use strict';
+
+/* eslint-env jest */
 
 import fs from 'fs';
 

package/report/test/renderer/crc-details-renderer-test.js

@@ -3,6 +3,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
+'use strict';
+
+/* eslint-env jest */
 
 import {strict as assert} from 'assert';
 

package/report/test/renderer/details-renderer-test.js

@@ -3,6 +3,7 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
+'use strict';
 
 import {strict as assert} from 'assert';
 
@@ -13,6 +14,8 @@ import {Util} from '../../renderer/util.js';
 import {I18n} from '../../renderer/i18n.js';
 import {DetailsRenderer} from '../../renderer/details-renderer.js';
 
+/* eslint-env jest */
+
 describe('DetailsRenderer', () => {
   let renderer;
 
@@ -84,55 +87,6 @@ describe('DetailsRenderer', () => {
           '--thumbnail not set');
     });
 
-    it('renders with default granularity', () => {
-      const el = renderer.render({
-        type: 'table',
-        headings: [
-          {text: '', key: 'bytes', itemType: 'bytes'},
-          {text: '', key: 'numeric', itemType: 'numeric'},
-          {text: '', key: 'ms', itemType: 'ms'},
-          // Verify that 0 is ignored.
-          {text: '', key: 'ms', itemType: 'ms', granularity: 0},
-        ],
-        items: [
-          {
-            bytes: 1234.567,
-            numeric: 1234.567,
-            ms: 1234.567,
-          },
-        ],
-      });
-
-      assert.equal(el.querySelectorAll('td').length, 4, 'did not render table cells');
-      assert.equal(el.querySelectorAll('td')[0].textContent, '1.2\xa0KiB');
-      assert.equal(el.querySelectorAll('td')[1].textContent, '1,234.6');
-      assert.equal(el.querySelectorAll('td')[2].textContent, '1,230\xa0ms');
-      assert.equal(el.querySelectorAll('td')[3].textContent, '1,230\xa0ms');
-    });
-
-    it('renders with custom granularity', () => {
-      const el = renderer.render({
-        type: 'table',
-        headings: [
-          {text: '', key: 'bytes', itemType: 'bytes', granularity: 0.01},
-          {text: '', key: 'numeric', itemType: 'numeric', granularity: 100},
-          {text: '', key: 'ms', itemType: 'ms', granularity: 1},
-        ],
-        items: [
-          {
-            bytes: 1234.567,
-            numeric: 1234.567,
-            ms: 1234.567,
-          },
-        ],
-      });
-
-      assert.equal(el.querySelectorAll('td').length, 3, 'did not render table cells');
-      assert.equal(el.querySelectorAll('td')[0].textContent, '1.21\xa0KiB');
-      assert.equal(el.querySelectorAll('td')[1].textContent, '1,200');
-      assert.equal(el.querySelectorAll('td')[2].textContent, '1,235\xa0ms');
-    });
-
     it('renders critical request chains', () => {
       const details = {
         type: 'criticalrequestchain',
@@ -188,24 +142,24 @@ describe('DetailsRenderer', () => {
     });
 
     it('renders lists', () => {
-      const snippet = {
-        type: 'snippet',
-        lines: [{lineNumber: 1, content: ''}],
-        title: 'Some snippet',
-        lineMessages: [],
-        generalMessages: [],
-        lineCount: 100,
+      const table = {
+        type: 'table',
+        headings: [{text: '', key: 'numeric', itemType: 'numeric'}],
+        items: [{numeric: 1234.567}],
       };
 
       const el = renderer.render({
         type: 'list',
-        items: [snippet, snippet],
+        items: [table, table],
       });
 
       assert.equal(el.localName, 'div');
       assert.ok(el.classList.contains('lh-list'), 'has list class');
       assert.ok(el.children.length, 2, 'renders all items');
-      assert.ok(el.children[0].textContent.includes('Some snippet'), 'renders item content');
+      for (const child of el.children) {
+        assert.ok(child.classList.contains('lh-table'));
+        assert.equal(child.textContent, '1,234.6');
+      }
     });
 
     it('does not render internal-only screenshot details', () => {

package/report/test/renderer/dom-test.js

@@ -3,6 +3,7 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
+'use strict';
 
 import {strict as assert} from 'assert';
 
@@ -13,6 +14,8 @@ import {DOM} from '../../renderer/dom.js';
 import {Util} from '../../renderer/util.js';
 import {I18n} from '../../renderer/i18n.js';
 
+/* eslint-env jest */
+
 describe('DOM', () => {
   /** @type {DOM} */
   let dom;

package/report/test/renderer/element-screenshot-renderer-test.js

@@ -3,6 +3,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
+'use strict';
+
+/* eslint-env jest */
 
 import jsdom from 'jsdom';
 
@@ -63,8 +66,7 @@ describe('ElementScreenshotRenderer', () => {
     /* eslint-disable max-len */
     expect(htmlFormatted).toMatchInlineSnapshot(`
 " 
-<div class=\\"lh-element-screenshot__content\\"> 
-<div class=\\"lh-element-screenshot__image\\" style=\\"width: 500px; height: 500px; background-position-y: 0px; background-position-x: 0px; background-size: 1000px 1000px;\\"> 
+<div class=\\"lh-element-screenshot__content\\" style=\\"top: -500px;\\"> 
 <div class=\\"lh-element-screenshot__mask\\" style=\\"width: 500px; height: 500px; clip-path: url(#clip-0);\\"> 
 <svg height=\\"0\\" width=\\"0\\"> <defs> 
 <clipPath clipPathUnits=\\"objectBoundingBox\\" id=\\"clip-0\\">
@@ -72,7 +74,8 @@ describe('ElementScreenshotRenderer', () => {
 <polygon points=\\"0,0.7     1,0.7    1,1               0,1\\"></polygon>
 <polygon points=\\"0,0.1        0.1,0.1 0.1,0.7 0,0.7\\"></polygon>
 <polygon points=\\"0.5,0.1 1,0.1       1,0.7       0.5,0.7\\"></polygon></clipPath>  </defs> </svg> </div> 
-<div class=\\"lh-element-screenshot__element-marker\\" style=\\"width: 200px; height: 300px; left: 50px; top: 50px;\\"></div> </div> </div> "
+<div class=\\"lh-element-screenshot__image\\" style=\\"width: 500px; height: 500px; background-position-y: 0px; background-position-x: 0px; background-size: 1000px 1000px;\\"></div> 
+<div class=\\"lh-element-screenshot__element-marker\\" style=\\"width: 200px; height: 300px; left: 50px; top: 50px;\\"></div> </div> "
 `);
     /* eslint-enable max-len */
   });

package/report/test/renderer/i18n-test.js

@@ -3,6 +3,7 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
+'use strict';
 
 import {strict as assert} from 'assert';
 
@@ -16,33 +17,14 @@ import '../../../lighthouse-core/lib/i18n/i18n.js';
 
 const NBSP = '\xa0';
 
+/* eslint-env jest */
+
 describe('util helpers', () => {
   it('formats a number', () => {
     const i18n = new I18n('en', {...Util.UIStrings});
     assert.strictEqual(i18n.formatNumber(10), '10');
-    assert.strictEqual(i18n.formatNumber(100.01), '100.01');
-    assert.strictEqual(i18n.formatNumber(13000.456), '13,000.456');
-    assert.strictEqual(i18n.formatNumber(13000.456444), '13,000.456');
-
-    assert.strictEqual(i18n.formatNumber(10, 0.1), '10.0');
-    assert.strictEqual(i18n.formatNumber(100.01, 0.1), '100.0');
-    assert.strictEqual(i18n.formatNumber(13000.456, 0.1), '13,000.5');
-
-    assert.strictEqual(i18n.formatNumber(0), '0');
-    assert.strictEqual(i18n.formatNumber(-0), '0');
-    assert.strictEqual(i18n.formatNumber(-0, 0.1), '0.0');
-    assert.strictEqual(i18n.formatNumber(0.000001), '0');
-    assert.strictEqual(i18n.formatNumber(-0.000001), '0');
-    assert.strictEqual(i18n.formatNumber(0.000001, 0.1), '0.0');
-    assert.strictEqual(i18n.formatNumber(-0.000001, 0.1), '0.0');
-
-    assert.strictEqual(i18n.formatNumber(10), '10');
-    assert.strictEqual(i18n.formatNumber(100.01), '100.01');
-    assert.strictEqual(i18n.formatNumber(13000.456, 0.1), '13,000.5');
-
-    assert.strictEqual(i18n.formatInteger(10), '10');
-    assert.strictEqual(i18n.formatInteger(100.01), '100');
-    assert.strictEqual(i18n.formatInteger(13000.6), '13,001');
+    assert.strictEqual(i18n.formatNumber(100.01), '100');
+    assert.strictEqual(i18n.formatNumber(13000.456), '13,000.5');
   });
 
   it('formats a date', () => {
@@ -57,10 +39,9 @@ describe('util helpers', () => {
 
   it('formats bytes', () => {
     const i18n = new I18n('en', {...Util.UIStrings});
-    assert.equal(i18n.formatBytesToKiB(100), `0.098${NBSP}KiB`);
-    assert.equal(i18n.formatBytesToKiB(100, 0.1), `0.1${NBSP}KiB`);
-    assert.equal(i18n.formatBytesToKiB(2000, 0.1), `2.0${NBSP}KiB`);
-    assert.equal(i18n.formatBytesToKiB(1014 * 1024, 0.1), `1,014.0${NBSP}KiB`);
+    assert.equal(i18n.formatBytesToKiB(100), `0.1${NBSP}KiB`);
+    assert.equal(i18n.formatBytesToKiB(2000), `2.0${NBSP}KiB`);
+    assert.equal(i18n.formatBytesToKiB(1014 * 1024), `1,014.0${NBSP}KiB`);
   });
 
   it('formats bytes with different granularities', () => {
@@ -76,6 +57,11 @@ describe('util helpers', () => {
     assert.strictEqual(i18n.formatBytes(15.12345, granularity), `15${NBSP}bytes`);
     assert.strictEqual(i18n.formatBytes(15.54321, granularity), `16${NBSP}bytes`);
 
+    granularity = 0.5;
+    assert.strictEqual(i18n.formatBytes(15.0, granularity), `15.0${NBSP}bytes`);
+    assert.strictEqual(i18n.formatBytes(15.12345, granularity), `15.0${NBSP}bytes`);
+    assert.strictEqual(i18n.formatBytes(15.54321, granularity), `15.5${NBSP}bytes`);
+
     granularity = 0.1;
     assert.strictEqual(i18n.formatBytes(15.0, granularity), `15.0${NBSP}bytes`);
     assert.strictEqual(i18n.formatBytes(15.12345, granularity), `15.1${NBSP}bytes`);
@@ -87,21 +73,6 @@ describe('util helpers', () => {
     assert.strictEqual(i18n.formatBytes(15.19999, granularity), `15.20${NBSP}bytes`);
   });
 
-  it('formats bytes with invalid granularity', () => {
-    const i18n = new I18n('en', {...Util.UIStrings});
-    const granularity = 0.5;
-    const originalWarn = console.warn;
-
-    try {
-      console.warn = () => {};
-      assert.strictEqual(i18n.formatBytes(15.0, granularity), `15${NBSP}bytes`);
-      assert.strictEqual(i18n.formatBytes(15.12345, granularity), `15${NBSP}bytes`);
-      assert.strictEqual(i18n.formatBytes(15.54321, granularity), `16${NBSP}bytes`);
-    } finally {
-      console.warn = originalWarn;
-    }
-  });
-
   it('formats kibibytes with different granularities', () => {
     const i18n = new I18n('en', {...Util.UIStrings});
 
@@ -122,7 +93,7 @@ describe('util helpers', () => {
 
   it('formats ms', () => {
     const i18n = new I18n('en', {...Util.UIStrings});
-    assert.equal(i18n.formatMilliseconds(123, 10), `120${NBSP}ms`);
+    assert.equal(i18n.formatMilliseconds(123), `120${NBSP}ms`);
     assert.equal(i18n.formatMilliseconds(2456.5, 0.1), `2,456.5${NBSP}ms`);
     assert.equal(i18n.formatMilliseconds(0.000001), `0${NBSP}ms`);
     assert.equal(i18n.formatMilliseconds(-0.000001), `0${NBSP}ms`);
@@ -130,25 +101,9 @@ describe('util helpers', () => {
 
   it('formats a duration', () => {
     const i18n = new I18n('en', {...Util.UIStrings});
-    assert.equal(i18n.formatDuration(60 * 1000), '1m');
-    assert.equal(i18n.formatDuration(60 * 60 * 1000 + 5000), '1h 5s');
-    assert.equal(i18n.formatDuration(28 * 60 * 60 * 1000 + 5000), '1d 4h 5s');
-  });
-
-  it('formats a duration based on locale', () => {
-    let i18n = new I18n('de', {...Util.UIStrings});
-    assert.equal(i18n.formatDuration(60 * 1000), `1${NBSP}Min.`);
-    assert.equal(i18n.formatDuration(60 * 60 * 1000 + 5000), `1${NBSP}Std. 5${NBSP}Sek.`);
-    assert.equal(
-      i18n.formatDuration(28 * 60 * 60 * 1000 + 5000), `1${NBSP}T 4${NBSP}Std. 5${NBSP}Sek.`);
-
-    // Yes, this is actually backwards (s h d).
-    i18n = new I18n('ar', {...Util.UIStrings});
-    /* eslint-disable no-irregular-whitespace */
-    assert.equal(i18n.formatDuration(60 * 1000), `١${NBSP}د`);
-    assert.equal(i18n.formatDuration(60 * 60 * 1000 + 5000), `١${NBSP}س ٥${NBSP}ث`);
-    assert.equal(i18n.formatDuration(28 * 60 * 60 * 1000 + 5000), `١ ي ٤ س ٥ ث`);
-    /* eslint-enable no-irregular-whitespace */
+    assert.equal(i18n.formatDuration(60 * 1000), `1${NBSP}m`);
+    assert.equal(i18n.formatDuration(60 * 60 * 1000 + 5000), `1${NBSP}h 5${NBSP}s`);
+    assert.equal(i18n.formatDuration(28 * 60 * 60 * 1000 + 5000), `1${NBSP}d 4${NBSP}h 5${NBSP}s`);
   });
 
   it('formats numbers based on locale', () => {
@@ -156,10 +111,10 @@ describe('util helpers', () => {
     const number = 12346.858558;
 
     const i18n = new I18n('de', {...Util.UIStrings});
-    assert.strictEqual(i18n.formatNumber(number), '12.346,859');
-    assert.strictEqual(i18n.formatBytesToKiB(number, 0.1), `12,1${NBSP}KiB`);
-    assert.strictEqual(i18n.formatMilliseconds(number, 10), `12.350${NBSP}ms`);
-    assert.strictEqual(i18n.formatSeconds(number), `12,347${NBSP}Sek.`);
+    assert.strictEqual(i18n.formatNumber(number), '12.346,9');
+    assert.strictEqual(i18n.formatBytesToKiB(number), `12,1${NBSP}KiB`);
+    assert.strictEqual(i18n.formatMilliseconds(number), `12.350${NBSP}ms`);
+    assert.strictEqual(i18n.formatSeconds(number), `12,3${NBSP}s`);
   });
 
   it('uses decimal comma with en-XA test locale', () => {
@@ -167,10 +122,10 @@ describe('util helpers', () => {
     const number = 12346.858558;
 
     const i18n = new I18n('en-XA', {...Util.UIStrings});
-    assert.strictEqual(i18n.formatNumber(number), '12.346,859');
-    assert.strictEqual(i18n.formatBytesToKiB(number, 0.1), `12,1${NBSP}KiB`);
-    assert.strictEqual(i18n.formatMilliseconds(number, 100), `12.300${NBSP}ms`);
-    assert.strictEqual(i18n.formatSeconds(number, 1), `12${NBSP}Sek.`);
+    assert.strictEqual(i18n.formatNumber(number), '12.346,9');
+    assert.strictEqual(i18n.formatBytesToKiB(number), `12,1${NBSP}KiB`);
+    assert.strictEqual(i18n.formatMilliseconds(number), `12.350${NBSP}ms`);
+    assert.strictEqual(i18n.formatSeconds(number), `12,3${NBSP}s`);
   });
 
   it('should not crash on unknown locales', () => {

package/report/test/renderer/performance-category-renderer-test.js

@@ -3,6 +3,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
+'use strict';
+
+/* eslint-env jest */
 
 import {strict as assert} from 'assert';
 
@@ -357,7 +360,7 @@ Array [
       }
     });
 
-    it('uses null if the metric\'s value is undefined', () => {
+    it('uses null if the metric is missing its value', () => {
       const categoryClone = JSON.parse(JSON.stringify(category));
       const lcp = categoryClone.auditRefs.find(audit => audit.id === 'largest-contentful-paint');
       lcp.result.numericValue = undefined;
@@ -365,16 +368,6 @@ Array [
       const href = renderer._getScoringCalculatorHref(categoryClone.auditRefs);
       expect(href).toContain('LCP=null');
     });
-
-    it('uses null if the metric\'s value is null (LR)', () => {
-      const categoryClone = JSON.parse(JSON.stringify(category));
-      const lcp = categoryClone.auditRefs.find(audit => audit.id === 'largest-contentful-paint');
-      // In LR, we think there might be some case where undefined becomes null, but we can't prove it.
-      lcp.result.numericValue = null;
-      lcp.result.score = null;
-      const href = renderer._getScoringCalculatorHref(categoryClone.auditRefs);
-      expect(href).toContain('LCP=null');
-    });
   });
 
   // This is done all in CSS, but tested here.

package/report/test/renderer/pwa-category-renderer-test.js

@@ -3,6 +3,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
+'use strict';
+
+/* eslint-env jest */
 
 import {strict as assert} from 'assert';
 

package/report/test/renderer/report-renderer-axe-test.js

@@ -3,6 +3,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
+'use strict';
+
+/* eslint-env jest */
 
 import puppeteer from 'puppeteer';
 

package/report/test/renderer/report-renderer-test.js

@@ -3,6 +3,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
+'use strict';
+
+/* eslint-env jest */
 
 import {strict as assert} from 'assert';
 

package/report/test/renderer/report-ui-features-test.js

@@ -3,6 +3,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
+'use strict';
+
+/* eslint-env jest */
 
 import {strict as assert} from 'assert';
 

package/report/test/renderer/snippet-renderer-test.js

@@ -3,6 +3,9 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
+'use strict';
+
+/* eslint-env jest */
 
 import {strict as assert} from 'assert';
 

package/report/test/renderer/text-encoding-test.js

@@ -3,6 +3,7 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
+'use strict';
 
 import fs from 'fs';
 
@@ -11,6 +12,8 @@ import pako from 'pako';
 import {TextEncoding} from '../../renderer/text-encoding.js';
 import {LH_ROOT} from '../../../root.js';
 
+/* eslint-env jest */
+
 describe('TextEncoding', () => {
   beforeAll(() => {
     global.window = {pako};

package/report/test/renderer/util-test.js

@@ -3,6 +3,7 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
+'use strict';
 
 import {strict as assert} from 'assert';
 
@@ -10,6 +11,8 @@ import {Util} from '../../renderer/util.js';
 import {I18n} from '../../renderer/i18n.js';
 import sampleResult from '../../../lighthouse-core/test/results/sample_v2.json';
 
+/* eslint-env jest */
+
 describe('util helpers', () => {
   beforeEach(() => {
     Util.i18n = new I18n('en', {...Util.UIStrings});
@@ -54,7 +57,7 @@ describe('util helpers', () => {
     });
 
     // eslint-disable-next-line max-len
-    assert.equal(descriptions.networkThrottling, '565\xa0ms HTTP RTT, 1,400\xa0kb/s down, 600\xa0kb/s up (DevTools)');
+    assert.equal(descriptions.networkThrottling, '565\xa0ms HTTP RTT, 1,400\xa0Kbps down, 600\xa0Kbps up (DevTools)');
     assert.equal(descriptions.cpuThrottling, '4.5x slowdown (DevTools)');
   });
 
@@ -69,7 +72,7 @@ describe('util helpers', () => {
     });
 
     // eslint-disable-next-line max-len
-    assert.equal(descriptions.networkThrottling, '150\xa0ms TCP RTT, 1,600\xa0kb/s throughput (Simulated)');
+    assert.equal(descriptions.networkThrottling, '150\xa0ms TCP RTT, 1,600\xa0Kbps throughput (Simulated)');
     assert.equal(descriptions.cpuThrottling, '2x slowdown (Simulated)');
   });
 

package/report/test-assets/faux-psi.js

@@ -3,6 +3,7 @@
  * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0
  * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
  */
+'use strict';
 
 /** @fileoverview This file exercises two LH reports within the same DOM. */
 
@@ -65,8 +66,6 @@ async function renderLHReport() {
           metaItemsEl,
           reportRootEl.querySelector('.lh-buttons')
         );
-        reportRootEl.querySelector('.lh-metrics-container')?.closest('.lh-category')?.classList
-            .add('lh--hoisted-meta');
       }
 
       container.append(reportRootEl);