lighthouse 9.5.0-dev.20220502 → 9.5.0-dev.20220503

package/dist/report/bundle.esm.js

@@ -6108,4 +6108,6 @@ function renderReport(lhr, opts = {}) {
   return rootEl;
 }
 
-export { DOM, ReportRenderer, ReportUIFeatures, renderReport };
+const swapLocale = _ => {}; const format = _ => {};
+
+export { DOM, ReportRenderer, ReportUIFeatures, format, renderReport, swapLocale };

package/jest.config.js

@@ -6,7 +6,7 @@
 'use strict';
 
 module.exports = {
-  setupFilesAfterEnv: ['./lighthouse-core/test/test-utils.js'],
+  setupFilesAfterEnv: ['./lighthouse-core/test/jest-setup/setup.js'],
   testEnvironment: 'node',
   testMatch: [
     '**/lighthouse-core/**/*-test.js',

package/lighthouse-cli/cli-flags.js

@@ -123,10 +123,10 @@ function getFlags(manualArgv, options = {}) {
           type: 'boolean',
           describe: 'Pause after page load to wait for permission to continue the run, evaluate `continueLighthouseRun` in the console to continue.',
         },
-        'fraggle-rock': {
+        'legacy-navigation': {
           type: 'boolean',
           default: false,
-          describe: '[EXPERIMENTAL] Use the new Fraggle Rock navigation runner to gather results.',
+          describe: '[DEPRECATED] Use the legacy navigation runner to gather results. Only use this if you are using a pre-10.0 custom Lighthouse config, or if Lighthouse unexpectedly fails after updating to 10.0. Please file a bug if you need this flag for Lighthouse to work.',
         },
         'additional-trace-categories': {
           type: 'string',

package/lighthouse-cli/run.js

@@ -225,15 +225,16 @@ async function runLighthouse(url, flags, config) {
       flags.port = launchedChrome.port;
     }
 
-    if (flags.fraggleRock) {
-      flags.channel = 'fraggle-rock-cli';
+    if (flags.legacyNavigation) {
+      log.warn('CLI', 'Legacy navigation CLI is deprecated');
+      flags.channel = 'legacy-navigation-cli';
     } else {
       flags.channel = 'cli';
     }
 
-    const runnerResult = flags.fraggleRock ?
-       await lighthouse(url, flags, config) :
-       await lighthouse.legacyNavigation(url, flags, config);
+    const runnerResult = flags.legacyNavigation ?
+       await lighthouse.legacyNavigation(url, flags, config) :
+       await lighthouse(url, flags, config);
 
     // If in gatherMode only, there will be no runnerResult.
     if (runnerResult) {

package/lighthouse-cli/test/smokehouse/lighthouse-runners/cli.js

@@ -82,8 +82,9 @@ async function internalRun(url, tmpPath, configJson, options) {
   ];
 
   if (useFraggleRock) {
-    args.push('--fraggle-rock');
     configJson = convertToFraggleRockConfig(configJson);
+  } else {
+    args.push('--legacy-navigation');
   }
 
   // Config can be optionally provided.

package/lighthouse-core/audits/accessibility/listitem.js

@@ -15,13 +15,13 @@ const i18n = require('../../lib/i18n/i18n.js');
 
 const UIStrings = {
   /** Title of an accesibility audit that evaluates if any list item elements do not have list parent elements. This title is descriptive of the successful state and is shown to users when no user action is required. */
-  title: 'List items (`<li>`) are contained within `<ul>` or `<ol>` parent elements',
+  title: 'List items (`<li>`) are contained within `<ul>`, `<ol>` or `<menu>` parent elements',
   /** Title of an accesibility audit that evaluates if any list item elements do not have list parent elements. This title is descriptive of the failing state and is shown to users when there is a failure that needs to be addressed. */
-  failureTitle: 'List items (`<li>`) are not contained within `<ul>` ' +
-      'or `<ol>` parent elements.',
+  failureTitle: 'List items (`<li>`) are not contained within `<ul>`, ' +
+      '`<ol>` or `<menu>` parent elements.',
   /** Description of a Lighthouse audit that tells the user *why* they should try to pass. This is displayed after a user expands the section to see more. No character length limits. 'Learn More' becomes link text to additional documentation. */
   description: 'Screen readers require list items (`<li>`) to be contained within a ' +
-      'parent `<ul>` or `<ol>` to be announced properly. ' +
+      'parent `<ul>`, `<ol>` or `<menu>` to be announced properly. ' +
       '[Learn more](https://dequeuniversity.com/rules/axe/4.4/listitem).',
 };
 

package/lighthouse-core/computed/critical-request-chains.js

@@ -117,6 +117,9 @@ class CriticalRequestChains {
       // Ignore if some ancestor is not a critical request.
       if (networkPath.some(r => !CriticalRequestChains.isCritical(r, mainResource))) return;
 
+      // Ignore non-network things (like data urls).
+      if (NetworkRequest.isNonNetworkRequest(node.record)) return;
+
       addChain(networkPath);
     }, getNextNodes);
 

package/lighthouse-core/fraggle-rock/gather/session.js

@@ -96,7 +96,7 @@ class ProtocolSession {
     /** @param {LH.Puppeteer.CDPSession} session */
     const listener = session => callback(new ProtocolSession(session));
     this._callbackMap.set(callback, listener);
-    this._session.connection().on('sessionattached', listener);
+    this._getConnection().on('sessionattached', listener);
   }
 
   /**
@@ -106,7 +106,7 @@ class ProtocolSession {
   removeSessionAttachedListener(callback) {
     const listener = this._callbackMap.get(callback);
     if (!listener) return;
-    this._session.connection().off('sessionattached', listener);
+    this._getConnection().off('sessionattached', listener);
   }
 
   /**
@@ -171,6 +171,12 @@ class ProtocolSession {
     this._session.removeAllListeners();
     await this._session.detach();
   }
+
+  _getConnection() {
+    const connection = this._session.connection();
+    if (!connection) throw new Error('Connection has been closed.');
+    return connection;
+  }
 }
 
 module.exports = ProtocolSession;

package/lighthouse-core/index.js

@@ -94,7 +94,7 @@ lighthouse.generateConfig = generateConfig;
 lighthouse.getAuditList = Runner.getAuditList;
 lighthouse.traceCategories = require('./gather/driver.js').traceCategories;
 lighthouse.Audit = require('./audits/audit.js');
-lighthouse.Gatherer = require('./gather/gatherers/gatherer.js');
+lighthouse.Gatherer = require('./fraggle-rock/gather/base-gatherer.js');
 
 // Explicit type reference (hidden by makeComputedArtifact) for d.ts export.
 // TODO(esmodules): should be a workaround for module.export and can be removed when in esm.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "lighthouse",
-  "version": "9.5.0-dev.20220502",
+  "version": "9.5.0-dev.20220503",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./lighthouse-core/index.js",
   "bin": {
@@ -163,7 +163,7 @@
     "pako": "^2.0.3",
     "preact": "^10.5.14",
     "pretty-json-stringify": "^0.0.2",
-    "puppeteer": "10.2.0",
+    "puppeteer": "13.7.0",
     "resolve": "^1.20.0",
     "rollup": "^2.52.7",
     "rollup-plugin-node-resolve": "^5.2.0",
@@ -199,7 +199,7 @@
     "open": "^8.4.0",
     "parse-cache-control": "1.0.1",
     "ps-list": "^8.0.0",
-    "puppeteer-core": "^10.2.0",
+    "puppeteer-core": "^13.7.0",
     "robots-parser": "^3.0.0",
     "semver": "^5.3.0",
     "speedline-core": "^1.4.3",

package/report/clients/bundle.js

@@ -15,3 +15,4 @@ export {DOM} from '../renderer/dom.js';
 export {ReportRenderer} from '../renderer/report-renderer.js';
 export {ReportUIFeatures} from '../renderer/report-ui-features.js';
 export {renderReport} from '../renderer/api.js';
+export {swapLocale, format} from '../../shared/localization/i18n-module.js';

package/report/test/renderer/__snapshots__/report-renderer-axe-test.js.snap

@@ -1,107 +1,15 @@
 // Jest Snapshot v1, https://goo.gl/fbAQLP
 
-exports[`ReportRendererAxe with aXe renders without axe violations 2`] = `
+exports[`ReportRendererAxe with aXe renders without axe violations 1`] = `
 Array [
   Object {
-    "description": "Ensures every id attribute value is unique",
-    "help": "id attribute value must be unique",
-    "helpUrl": "https://dequeuniversity.com/rules/axe/4.4/duplicate-id?application=axeAPI",
     "id": "duplicate-id",
-    "impact": "minor",
-    "nodes": Array [
-      Object {
-        "all": Array [],
-        "any": Array [
-          Object {
-            "data": "viewport",
-            "id": "duplicate-id",
-            "impact": "minor",
-            "message": "Document has multiple static elements with the same id attribute: viewport",
-            "relatedNodes": Array [
-              Object {
-                "html": "<div class=\\"lh-audit lh-audit--binary lh-audit--pass\\" id=\\"viewport\\">",
-                "target": Array [
-                  "#seo > .lh-audit-group:nth-child(4) > .lh-clump--passed.lh-clump > .lh-audit--binary.lh-audit--pass.lh-audit:nth-child(2)",
-                ],
-              },
-              Object {
-                "html": "<div class=\\"lh-audit lh-audit--binary lh-audit--pass\\" id=\\"viewport\\">",
-                "target": Array [
-                  ".lh-audit-group--pwa-optimized > .lh-audit--binary.lh-audit--pass.lh-audit:nth-child(6)",
-                ],
-              },
-            ],
-          },
-        ],
-        "failureSummary": "Fix any of the following:
-  Document has multiple static elements with the same id attribute: viewport",
-        "html": "<div class=\\"lh-audit lh-audit--binary lh-audit--pass\\" id=\\"viewport\\">",
-        "impact": "minor",
-        "none": Array [],
-        "target": Array [
-          ".lh-audit--binary.lh-audit--pass.lh-audit:nth-child(20)",
-        ],
-      },
-      Object {
-        "all": Array [],
-        "any": Array [
-          Object {
-            "data": "image-alt",
-            "id": "duplicate-id",
-            "impact": "minor",
-            "message": "Document has multiple static elements with the same id attribute: image-alt",
-            "relatedNodes": Array [
-              Object {
-                "html": "<div class=\\"lh-audit lh-audit--binary lh-audit--fail\\" id=\\"image-alt\\">",
-                "target": Array [
-                  ".lh-audit-group--seo-content > .lh-audit--fail.lh-audit--binary.lh-audit:nth-child(3)",
-                ],
-              },
-            ],
-          },
-        ],
-        "failureSummary": "Fix any of the following:
-  Document has multiple static elements with the same id attribute: image-alt",
-        "html": "<div class=\\"lh-audit lh-audit--binary lh-audit--fail\\" id=\\"image-alt\\">",
-        "impact": "minor",
-        "none": Array [],
-        "target": Array [
-          ".lh-audit-group--a11y-names-labels > .lh-audit--fail.lh-audit--binary.lh-audit:nth-child(2)",
-        ],
-      },
-      Object {
-        "all": Array [],
-        "any": Array [
-          Object {
-            "data": "document-title",
-            "id": "duplicate-id",
-            "impact": "minor",
-            "message": "Document has multiple static elements with the same id attribute: document-title",
-            "relatedNodes": Array [
-              Object {
-                "html": "<div class=\\"lh-audit lh-audit--binary lh-audit--pass\\" id=\\"document-title\\">",
-                "target": Array [
-                  "#seo > .lh-audit-group:nth-child(4) > .lh-clump--passed.lh-clump > .lh-audit--binary.lh-audit--pass.lh-audit:nth-child(3)",
-                ],
-              },
-            ],
-          },
-        ],
-        "failureSummary": "Fix any of the following:
+    "message": "Fix any of the following:
+  Document has multiple static elements with the same id attribute: viewport
+Fix any of the following:
+  Document has multiple static elements with the same id attribute: image-alt
+Fix any of the following:
   Document has multiple static elements with the same id attribute: document-title",
-        "html": "<div class=\\"lh-audit lh-audit--binary lh-audit--pass\\" id=\\"document-title\\">",
-        "impact": "minor",
-        "none": Array [],
-        "target": Array [
-          ".lh-audit--binary.lh-audit--pass.lh-audit:nth-child(13)",
-        ],
-      },
-    ],
-    "tags": Array [
-      "cat.parsing",
-      "wcag2a",
-      "wcag411",
-    ],
   },
 ]
 `;

package/report/test/renderer/report-renderer-axe-test.js

@@ -45,6 +45,8 @@ describe('ReportRendererAxe', () => {
           'heading-order': {enabled: true},
           'meta-viewport': {enabled: true},
           'aria-treeitem-name': {enabled: true},
+          // TODO: re-enable. https://github.com/GoogleChrome/lighthouse/issues/13918
+          'color-contrast': {enabled: false},
         },
       };
 
@@ -75,21 +77,7 @@ describe('ReportRendererAxe', () => {
           message: v.nodes.map((n) => n.failureSummary).join('\n'),
         };
       });
-      expect(axeSummary).toMatchInlineSnapshot(`
-Array [
-  Object {
-    "id": "duplicate-id",
-    "message": "Fix any of the following:
-  Document has multiple static elements with the same id attribute: viewport
-Fix any of the following:
-  Document has multiple static elements with the same id attribute: image-alt
-Fix any of the following:
-  Document has multiple static elements with the same id attribute: document-title",
-  },
-]
-`);
-
-      expect(axeResults.violations).toMatchSnapshot();
+      expect(axeSummary).toMatchSnapshot();
     },
     // This test takes 10s on fast hardware, but can take longer in CI.
     // https://github.com/dequelabs/axe-core/tree/b573b1c1/doc/examples/jest_react#timeout-issues

package/report/test-assets/faux-psi-template.html

@@ -119,7 +119,7 @@ body {
   border-width: 1px 0;
   padding: 4px;
 }
-button {
+#reanalyze {
   background-color: hsl(216deg 100% 50%);
   border-radius: 4px;
   color: white;
@@ -133,8 +133,9 @@ button {
 </head>
 <body >
   <noscript>PSI requires JavaScript. Please enable.</noscript>
+  <button type=button id="translate">→ Español</button>
   <div class="page">
-    <button type=button>Reanalyze</button>
+    <button type=button id="reanalyze">Reanalyze</button>
     <div class="tabset">
       <input type="radio" name="tabset" id="tab1" aria-controls="mobile" checked />
       <label for="tab1">Mobile</label>

package/report/test-assets/faux-psi.js

@@ -17,7 +17,12 @@ const wait = (ms = 100) => new Promise(resolve => setTimeout(resolve, ms));
 (async function __initPsiReports__() {
   renderLHReport();
 
-  document.querySelector('button')?.addEventListener('click', () => {
+  document.querySelector('button#reanalyze')?.addEventListener('click', () => {
+    renderLHReport();
+  });
+
+  document.querySelector('button#translate')?.addEventListener('click', async () => {
+    await swapLhrLocale('es');
     renderLHReport();
   });
 })();
@@ -82,6 +87,22 @@ async function renderLHReport() {
   }
 }
 
+/**
+ * @param {LH.Locale} locale
+ */
+async function swapLhrLocale(locale) {
+  const response = await fetch(`https://www.gstatic.com/pagespeed/insights/ui/locales/${locale}.json`);
+  /** @type {import('../../shared/localization/locales').LhlMessages} */
+  const lhlMessages = await response.json();
+  console.log(lhlMessages);
+  if (!lhlMessages) throw new Error(`could not fetch data for locale: ${locale}`);
+
+  lighthouseRenderer.format.registerLocaleData(locale, lhlMessages);
+  // @ts-expect-error LHR global
+  window.__LIGHTHOUSE_JSON__ = lighthouseRenderer.swapLocale(window.__LIGHTHOUSE_JSON__, locale)
+    .lhr;
+}
+
 
 /**
  * Tweak the LHR to make the desktop and mobile reports easier to identify.

package/shared/localization/locales/en-US.json

@@ -450,13 +450,13 @@
     "message": "Lists contain only `<li>` elements and script supporting elements (`<script>` and `<template>`)."
   },
   "lighthouse-core/audits/accessibility/listitem.js | description": {
-    "message": "Screen readers require list items (`<li>`) to be contained within a parent `<ul>` or `<ol>` to be announced properly. [Learn more](https://dequeuniversity.com/rules/axe/4.4/listitem)."
+    "message": "Screen readers require list items (`<li>`) to be contained within a parent `<ul>`, `<ol>` or `<menu>` to be announced properly. [Learn more](https://dequeuniversity.com/rules/axe/4.4/listitem)."
   },
   "lighthouse-core/audits/accessibility/listitem.js | failureTitle": {
-    "message": "List items (`<li>`) are not contained within `<ul>` or `<ol>` parent elements."
+    "message": "List items (`<li>`) are not contained within `<ul>`, `<ol>` or `<menu>` parent elements."
   },
   "lighthouse-core/audits/accessibility/listitem.js | title": {
-    "message": "List items (`<li>`) are contained within `<ul>` or `<ol>` parent elements"
+    "message": "List items (`<li>`) are contained within `<ul>`, `<ol>` or `<menu>` parent elements"
   },
   "lighthouse-core/audits/accessibility/meta-refresh.js | description": {
     "message": "Users do not expect a page to refresh automatically, and doing so will move focus back to the top of the page. This may create a frustrating or confusing experience. [Learn more](https://dequeuniversity.com/rules/axe/4.4/meta-refresh)."

package/shared/localization/locales/en-XL.json

@@ -450,13 +450,13 @@
     "message": "L̂íŝt́ŝ ćôńt̂áîń ôńl̂ý `<li>` êĺêḿêńt̂ś âńd̂ śĉŕîṕt̂ śûṕp̂ór̂t́îńĝ él̂ém̂én̂t́ŝ (`<script>` án̂d́ `<template>`)."
   },
   "lighthouse-core/audits/accessibility/listitem.js | description": {
-    "message": "Ŝćr̂éêń r̂éâd́êŕŝ ŕêq́ûír̂é l̂íŝt́ ît́êḿŝ (`<li>`) t́ô b́ê ćôńt̂áîńêd́ ŵít̂h́îń â ṕâŕêńt̂ `<ul>` ór̂ `<ol>` t́ô b́ê án̂ńôún̂ćêd́ p̂ŕôṕêŕl̂ý. [L̂éâŕn̂ ḿôŕê](https://dequeuniversity.com/rules/axe/4.4/listitem)."
+    "message": "Ŝćr̂éêń r̂éâd́êŕŝ ŕêq́ûír̂é l̂íŝt́ ît́êḿŝ (`<li>`) t́ô b́ê ćôńt̂áîńêd́ ŵít̂h́îń â ṕâŕêńt̂ `<ul>`, `<ol>` ór̂ `<menu>` t́ô b́ê án̂ńôún̂ćêd́ p̂ŕôṕêŕl̂ý. [L̂éâŕn̂ ḿôŕê](https://dequeuniversity.com/rules/axe/4.4/listitem)."
   },
   "lighthouse-core/audits/accessibility/listitem.js | failureTitle": {
-    "message": "L̂íŝt́ ît́êḿŝ (`<li>`) ár̂é n̂ót̂ ćôńt̂áîńêd́ ŵít̂h́îń `<ul>` ôŕ `<ol>` p̂ár̂én̂t́ êĺêḿêńt̂ś."
+    "message": "L̂íŝt́ ît́êḿŝ (`<li>`) ár̂é n̂ót̂ ćôńt̂áîńêd́ ŵít̂h́îń `<ul>`, `<ol>` ôŕ `<menu>` p̂ár̂én̂t́ êĺêḿêńt̂ś."
   },
   "lighthouse-core/audits/accessibility/listitem.js | title": {
-    "message": "L̂íŝt́ ît́êḿŝ (`<li>`) ár̂é ĉón̂t́âín̂éd̂ ẃît́ĥín̂ `<ul>` ór̂ `<ol>` ṕâŕêńt̂ él̂ém̂én̂t́ŝ"
+    "message": "L̂íŝt́ ît́êḿŝ (`<li>`) ár̂é ĉón̂t́âín̂éd̂ ẃît́ĥín̂ `<ul>`, `<ol>` ór̂ `<menu>` ṕâŕêńt̂ él̂ém̂én̂t́ŝ"
   },
   "lighthouse-core/audits/accessibility/meta-refresh.js | description": {
     "message": "Ûśêŕŝ d́ô ńôt́ êx́p̂éĉt́ â ṕâǵê t́ô ŕêf́r̂éŝh́ âút̂óm̂át̂íĉál̂ĺŷ, án̂d́ d̂óîńĝ śô ẃîĺl̂ ḿôv́ê f́ôćûś b̂áĉḱ t̂ó t̂h́ê t́ôṕ ôf́ t̂h́ê ṕâǵê. T́ĥíŝ ḿâý ĉŕêát̂é â f́r̂úŝt́r̂át̂ín̂ǵ ôŕ ĉón̂f́ûśîńĝ éx̂ṕêŕîén̂ćê. [Ĺêár̂ń m̂ór̂é](https://dequeuniversity.com/rules/axe/4.4/meta-refresh)."

package/types/externs.d.ts

@@ -149,8 +149,8 @@ export interface CliFlags extends Flags {
   quiet: boolean;
   /** A flag to print the normalized config for the given config and options, then exit. */
   printConfig: boolean;
-  /** Use the new Fraggle Rock navigation runner to gather CLI results. */
-  fraggleRock: boolean;
+  /** Use the legacy navigation runner to gather CLI results. */
+  legacyNavigation: boolean;
   /** Path to the file where precomputed lantern data should be read from. */
   precomputedLanternDataPath?: string;
   /** Path to the file where precomputed lantern data should be written to. */