lighthouse 9.2.0-dev.20211217 → 9.2.0-dev.20211221

package/lighthouse-core/config/config.js

@@ -161,7 +161,7 @@ class Config {
   constructor(configJSON, flags) {
     const status = {msg: 'Create config', id: 'lh:init:config'};
     log.time(status, 'verbose');
-    let configPath = flags && flags.configPath;
+    let configPath = flags?.configPath;
 
     if (!configJSON) {
       configJSON = defaultConfig;

package/lighthouse-core/fraggle-rock/config/filters.js

@@ -5,6 +5,8 @@
  */
 'use strict';
 
+const log = require('lighthouse-logger');
+
 const Audit = require('../../audits/audit.js');
 
 /** @type {Record<keyof LH.FRBaseArtifacts, string>} */
@@ -45,7 +47,7 @@ function getAuditIdsInCategories(allCategories, onlyCategories) {
 
   onlyCategories = onlyCategories || Object.keys(allCategories);
   const categories = onlyCategories.map(categoryId => allCategories[categoryId]);
-  const auditRefs = categories.flatMap(category => category.auditRefs);
+  const auditRefs = categories.flatMap(category => category?.auditRefs || []);
   return new Set(auditRefs.map(auditRef => auditRef.id));
 }
 
@@ -194,6 +196,24 @@ function filterCategoriesByExplicitFilters(categories, onlyCategories) {
   return Object.fromEntries(categoriesToKeep);
 }
 
+/**
+ * Logs a warning if any specified onlyCategory is not a known category that can
+ * be included.
+ *
+ * @param {LH.Config.Config['categories']} allCategories
+ * @param {string[] | null} onlyCategories
+ * @return {void}
+ */
+function warnOnUnknownOnlyCategories(allCategories, onlyCategories) {
+  if (!onlyCategories) return;
+
+  for (const onlyCategoryId of onlyCategories) {
+    if (!allCategories?.[onlyCategoryId]) {
+      log.warn('config', `unrecognized category in 'onlyCategories': ${onlyCategoryId}`);
+    }
+  }
+}
+
 /**
  * Filters a categories object and their auditRefs down to the set that can be computed using
  * only the specified audits.
@@ -266,6 +286,8 @@ function filterConfigByGatherMode(config, mode) {
 function filterConfigByExplicitFilters(config, filters) {
   const {onlyAudits, onlyCategories, skipAudits} = filters;
 
+  warnOnUnknownOnlyCategories(config.categories, onlyCategories);
+
   let baseAuditIds = getAuditIdsInCategories(config.categories, undefined);
   if (onlyCategories) {
     baseAuditIds = getAuditIdsInCategories(config.categories, onlyCategories);

package/lighthouse-core/fraggle-rock/config/validation.js

@@ -49,7 +49,7 @@ function assertValidPluginName(configJSON, pluginName) {
     throw new Error(`plugin name '${pluginName}' does not start with 'lighthouse-plugin-'`);
   }
 
-  if (configJSON.categories && configJSON.categories[pluginName]) {
+  if (configJSON.categories?.[pluginName]) {
     throw new Error(`plugin name '${pluginName}' not allowed because it is the id of a category already found in config`); // eslint-disable-line max-len
   }
 }
@@ -123,7 +123,7 @@ function assertValidFRNavigations(navigationsDefn) {
 function assertValidAudit(auditDefinition) {
   const {implementation, path: auditPath} = auditDefinition;
   const auditName = auditPath ||
-    (implementation && implementation.meta && implementation.meta.id) ||
+    implementation?.meta?.id ||
     'Unknown audit';
 
   if (typeof implementation.audit !== 'function' || implementation.audit === Audit.audit) {

package/lighthouse-core/fraggle-rock/gather/navigation-runner.js

@@ -136,11 +136,11 @@ async function _collectDebugData(navigationContext, phaseState) {
   await collectPhaseArtifacts({...phaseState, phase: 'getArtifact', artifactDefinitions});
   const getArtifactState = phaseState.artifactState.getArtifact;
 
-  const devtoolsLogArtifactId = devtoolsLogArtifactDefn && devtoolsLogArtifactDefn.id;
+  const devtoolsLogArtifactId = devtoolsLogArtifactDefn?.id;
   const devtoolsLog = devtoolsLogArtifactId && await getArtifactState[devtoolsLogArtifactId];
   const records = devtoolsLog && await NetworkRecords.request(devtoolsLog, navigationContext);
 
-  const traceArtifactId = traceArtifactDefn && traceArtifactDefn.id;
+  const traceArtifactId = traceArtifactDefn?.id;
   const trace = traceArtifactId && await getArtifactState[traceArtifactId];
 
   return {devtoolsLog, records, trace};

package/lighthouse-core/fraggle-rock/user-flow.js

@@ -23,7 +23,7 @@ class UserFlow {
     /** @type {FrOptions} */
     this.options = {page, ...options};
     /** @type {string|undefined} */
-    this.name = options && options.name;
+    this.name = options?.name;
     /** @type {LH.FlowResult.Step[]} */
     this.steps = [];
   }
@@ -90,7 +90,7 @@ class UserFlow {
     const result = await navigation(this._getNextNavigationOptions(url, stepOptions));
     if (!result) throw Error('Navigation returned undefined');
 
-    const providedName = stepOptions && stepOptions.stepName;
+    const providedName = stepOptions?.stepName;
     this.steps.push({
       lhr: result.lhr,
       name: providedName || this._getDefaultStepName(result.lhr),
@@ -118,7 +118,7 @@ class UserFlow {
     this.currentTimespan = undefined;
     if (!result) throw Error('Timespan returned undefined');
 
-    const providedName = options && options.stepName;
+    const providedName = options?.stepName;
     this.steps.push({
       lhr: result.lhr,
       name: providedName || this._getDefaultStepName(result.lhr),
@@ -137,7 +137,7 @@ class UserFlow {
     const result = await snapshot(options);
     if (!result) throw Error('Snapshot returned undefined');
 
-    const providedName = stepOptions && stepOptions.stepName;
+    const providedName = stepOptions?.stepName;
     this.steps.push({
       lhr: result.lhr,
       name: providedName || this._getDefaultStepName(result.lhr),

package/lighthouse-core/gather/connections/connection.js

@@ -148,7 +148,7 @@ class Connection {
     } else {
       // In DevTools we receive responses to commands we did not send which we cannot act on, so we
       // just log these occurrences.
-      const error = object.error && object.error.message;
+      const error = object.error?.message;
       log.formatProtocol(`disowned method <= browser ${error ? 'ERR' : 'OK'}`,
           {method: 'UNKNOWN', params: error || object.result}, 'verbose');
     }

package/lighthouse-core/gather/driver/execution-context.js

@@ -121,7 +121,7 @@ class ExecutionContext {
         new Error('Runtime.evaluate response did not contain a "result" object'));
     }
     const value = response.result.value;
-    if (value && value.__failedInBrowser) {
+    if (value?.__failedInBrowser) {
       return Promise.reject(Object.assign(new Error(), value));
     } else {
       return value;

package/lighthouse-core/gather/driver/network-monitor.js

@@ -144,7 +144,7 @@ class NetworkMonitor {
     const finalNavigation = mainFrameNavigations[mainFrameNavigations.length - 1];
     if (!finalNavigation) log.warn('NetworkMonitor', 'No detected navigations');
 
-    return finalNavigation && finalNavigation.url;
+    return finalNavigation?.url;
   }
 
   /**
@@ -172,7 +172,7 @@ class NetworkMonitor {
     if (!this._networkRecorder) return false;
     const requests = this._networkRecorder.getRawRecords();
     const rootFrameRequest = requests.find(r => r.resourceType === 'Document');
-    const rootFrameId = rootFrameRequest && rootFrameRequest.frameId;
+    const rootFrameId = rootFrameRequest?.frameId;
 
     return this._isActiveIdlePeriod(
       0,

package/lighthouse-core/gather/driver/target-manager.js

@@ -49,7 +49,7 @@ class TargetManager {
   async _onSessionAttached(session) {
     try {
       const target = await session.sendCommand('Target.getTargetInfo').catch(() => null);
-      const targetType = target && target.targetInfo && target.targetInfo.type;
+      const targetType = target?.targetInfo?.type;
       const hasValidTargetType = targetType === 'page' || targetType === 'iframe';
       if (!target || !hasValidTargetType) return;
 

package/lighthouse-core/gather/driver.js

@@ -425,7 +425,7 @@ class Driver {
    * @return {Promise<void>}
    */
   async beginTrace(settings) {
-    const additionalCategories = (settings && settings.additionalTraceCategories &&
+    const additionalCategories = (settings?.additionalTraceCategories &&
         settings.additionalTraceCategories.split(',')) || [];
     const traceCategories = TraceGatherer.getDefaultTraceCategories().concat(additionalCategories);
 

package/lighthouse-core/gather/gatherers/console-messages.js

@@ -66,7 +66,7 @@ class ConsoleMessages extends FRGatherer {
     }
 
     const {url, lineNumber, columnNumber} =
-      event.stackTrace && event.stackTrace.callFrames[0] || {};
+      event.stackTrace?.callFrames[0] || {};
     /** @type {LH.Artifacts.ConsoleMessage} */
     const consoleMessage = {
       eventType: 'consoleAPI',
@@ -117,7 +117,7 @@ class ConsoleMessages extends FRGatherer {
 
     // JS events have a stack trace, which we use to get the column.
     // CSS/HTML events only expose a line number.
-    const {columnNumber} = event.entry.stackTrace && event.entry.stackTrace.callFrames[0] || {};
+    const {columnNumber} = event.entry.stackTrace?.callFrames[0] || {};
 
     this._logEntries.push({
       eventType: 'protocolLog',

package/lighthouse-core/gather/gatherers/inspector-issues.js

@@ -76,7 +76,7 @@ class InspectorIssues extends FRGatherer {
     for (const issue of this._issues) {
       if (issue.details.mixedContentIssueDetails) {
         const issueDetails = issue.details.mixedContentIssueDetails;
-        const issueReqId = issueDetails.request && issueDetails.request.requestId;
+        const issueReqId = issueDetails.request?.requestId;
         // Duplicate issues can occur for the same request; only use the one with a matching networkRequest.
         if (issueReqId &&
           networkRecords.find(req => req.requestId === issueReqId)) {
@@ -85,7 +85,7 @@ class InspectorIssues extends FRGatherer {
       }
       if (issue.details.sameSiteCookieIssueDetails) {
         const issueDetails = issue.details.sameSiteCookieIssueDetails;
-        const issueReqId = issueDetails.request && issueDetails.request.requestId;
+        const issueReqId = issueDetails.request?.requestId;
         // Duplicate issues can occur for the same request; only use the one with a matching networkRequest.
         if (issueReqId &&
           networkRecords.find(req => req.requestId === issueReqId)) {
@@ -94,7 +94,7 @@ class InspectorIssues extends FRGatherer {
       }
       if (issue.details.blockedByResponseIssueDetails) {
         const issueDetails = issue.details.blockedByResponseIssueDetails;
-        const issueReqId = issueDetails.request && issueDetails.request.requestId;
+        const issueReqId = issueDetails.request?.requestId;
         // Duplicate issues can occur for the same request; only use the one with a matching networkRequest.
         if (issueReqId &&
           networkRecords.find(req => req.requestId === issueReqId)) {

package/lighthouse-core/gather/gatherers/js-usage.js

@@ -116,7 +116,7 @@ class JsUsage extends FRGatherer {
       let url = scriptUsage.url;
       const scriptParsedEvent =
         this._scriptParsedEvents.find(e => e.scriptId === scriptUsage.scriptId);
-      if (scriptParsedEvent && scriptParsedEvent.embedderName) {
+      if (scriptParsedEvent?.embedderName) {
         url = scriptParsedEvent.embedderName;
       }
 

package/lighthouse-core/gather/gatherers/seo/font-size.js

@@ -355,7 +355,7 @@ class FontSize extends FRGatherer {
     // For the nodes whose computed style we could attribute to a stylesheet, assign
     // the stylsheet to the data.
     analyzedFailingNodesData
-      .filter(data => data.cssRule && data.cssRule.styleSheetId)
+      .filter(data => data.cssRule?.styleSheetId)
       // @ts-expect-error - guaranteed to exist from the filter immediately above
       .forEach(data => (data.cssRule.stylesheet = stylesheets.get(data.cssRule.styleSheetId)));
 

package/lighthouse-core/gather/gatherers/trace-elements.js

@@ -60,42 +60,6 @@ class TraceElements extends FRGatherer {
     if (name) this.animationIdToName.set(id, name);
   }
 
-  /**
-   * @param {LH.TraceEvent | undefined} event
-   * @return {number | undefined}
-   */
-  static getNodeIDFromTraceEvent(event) {
-    return event && event.args &&
-      event.args.data && event.args.data.nodeId;
-  }
-
-  /**
-   * @param {LH.TraceEvent | undefined} event
-   * @return {string | undefined}
-   */
-  static getAnimationIDFromTraceEvent(event) {
-    return event && event.args &&
-      event.args.data && event.args.data.id;
-  }
-
-  /**
-   * @param {LH.TraceEvent | undefined} event
-   * @return {number | undefined}
-   */
-  static getFailureReasonsFromTraceEvent(event) {
-    return event && event.args &&
-      event.args.data && event.args.data.compositeFailed;
-  }
-
-  /**
-   * @param {LH.TraceEvent | undefined} event
-   * @return {string[] | undefined}
-   */
-  static getUnsupportedPropertiesFromTraceEvent(event) {
-    return event && event.args &&
-      event.args.data && event.args.data.unsupportedProperties;
-  }
-
   /**
    * @param {Array<number>} rect
    * @return {LH.Artifacts.Rect}
@@ -124,7 +88,7 @@ class TraceElements extends FRGatherer {
     const clsPerNode = new Map();
     const shiftEvents = mainThreadEvents
       .filter(e => e.name === 'LayoutShift')
-      .map(e => e.args && e.args.data);
+      .map(e => e.args?.data);
     const indexFirstEventWithoutInput =
       shiftEvents.findIndex(event => event && !event.had_recent_input);
 
@@ -207,11 +171,12 @@ class TraceElements extends FRGatherer {
     /** @type {Map<number, Set<{animationId: string, failureReasonsMask?: number, unsupportedProperties?: string[]}>>} */
     const elementAnimations = new Map();
     for (const {begin, status} of animationPairs.values()) {
-      const nodeId = TraceElements.getNodeIDFromTraceEvent(begin);
-      const animationId = TraceElements.getAnimationIDFromTraceEvent(begin);
-      const failureReasonsMask = TraceElements.getFailureReasonsFromTraceEvent(status);
-      const unsupportedProperties = TraceElements.getUnsupportedPropertiesFromTraceEvent(status);
+      const nodeId = begin?.args?.data?.nodeId;
+      const animationId = begin?.args?.data?.id;
+      const failureReasonsMask = status?.args?.data?.compositeFailed;
+      const unsupportedProperties = status?.args?.data?.unsupportedProperties;
       if (!nodeId || !animationId) continue;
+
       const animationIds = elementAnimations.get(nodeId) || new Set();
       animationIds.add({animationId, failureReasonsMask, unsupportedProperties});
       elementAnimations.set(nodeId, animationIds);
@@ -270,7 +235,7 @@ class TraceElements extends FRGatherer {
       });
     const {mainThreadEvents} = processedTrace;
 
-    const lcpNodeId = TraceElements.getNodeIDFromTraceEvent(largestContentfulPaintEvt);
+    const lcpNodeId = largestContentfulPaintEvt?.args?.data?.nodeId;
     const clsNodeData = TraceElements.getTopLayoutShiftElements(mainThreadEvents);
     const animatedElementData =
       await this.getAnimatedElements(mainThreadEvents);
@@ -308,7 +273,7 @@ class TraceElements extends FRGatherer {
           continue;
         }
 
-        if (response && response.result && response.result.value) {
+        if (response?.result?.value) {
           traceElements.push({
             traceEventType,
             ...response.result.value,

package/lighthouse-core/lib/arbitrary-equality-map.js

@@ -40,7 +40,7 @@ class ArbitraryEqualityMap {
    */
   get(key) {
     const entry = this._entries[this._findIndexOf(key)];
-    return entry && entry.value;
+    return entry?.value;
   }
 
   /**

package/lighthouse-core/lib/dependency-graph/simulator/connection-pool.js

@@ -109,7 +109,7 @@ module.exports = class ConnectionPool {
       }
 
       // This connection is a match and is available! Update our max if it has a larger congestionWindow
-      const currentMax = (maxConnection && maxConnection.congestionWindow) || -Infinity;
+      const currentMax = (maxConnection?.congestionWindow) || -Infinity;
       if (connection.congestionWindow > currentMax) maxConnection = connection;
     }
 

package/lighthouse-core/lib/dependency-graph/simulator/network-analyzer.js

@@ -390,7 +390,7 @@ class NetworkAnalyzer {
     // downloading those bytes. We slice up all the network records into start/end boundaries, so
     // it's easier to deal with the gaps in downloading.
     const timeBoundaries = networkRecords.reduce((boundaries, record) => {
-      const scheme = record.parsedURL && record.parsedURL.scheme;
+      const scheme = record.parsedURL?.scheme;
       // Requests whose bodies didn't come over the network or didn't completely finish will mess
       // with the computation, just skip over them.
       if (scheme === 'data' || record.failed || !record.finished ||

package/lighthouse-core/lib/emulation.js

@@ -25,7 +25,7 @@ const NO_CPU_THROTTLE_METRICS = {
  */
 function parseUseragentIntoMetadata(userAgent, formFactor) {
   const match = userAgent.match(/Chrome\/([\d.]+)/); // eg 'Chrome/(71.0.3577.0)'
-  const fullVersion = (match && match[1]) || '99.0.1234.0';
+  const fullVersion = match?.[1] || '99.0.1234.0';
   const [version] = fullVersion.split('.', 1);
   const brands = [
     {brand: 'Chromium', version},

package/lighthouse-core/lib/icons.js

@@ -73,8 +73,7 @@ function pngSizedAtLeast(sizeRequirement, manifest) {
 function containsMaskableIcon(manifest) {
   const iconValues = manifest.icons.value;
   return iconValues.some(icon => {
-    return icon.value.purpose &&
-      icon.value.purpose.value &&
+    return icon.value.purpose?.value &&
       icon.value.purpose.value.includes('maskable');
   });
 }

package/lighthouse-core/lib/median-run.js

@@ -6,8 +6,7 @@
 'use strict';
 
 /** @param {LH.Result} lhr @param {string} auditName */
-const getNumericValue = (lhr, auditName) =>
-  (lhr.audits[auditName] && lhr.audits[auditName].numericValue) || NaN;
+const getNumericValue = (lhr, auditName) => lhr.audits[auditName]?.numericValue || NaN;
 
 /**
  * @param {Array<number>} numbers

package/lighthouse-core/lib/network-recorder.js

@@ -251,8 +251,8 @@ class NetworkRecorder extends EventEmitter {
     if (record.redirectSource) {
       return record.redirectSource;
     }
-    const stackFrames = (record.initiator.stack && record.initiator.stack.callFrames) || [];
-    const initiatorURL = record.initiator.url || (stackFrames[0] && stackFrames[0].url);
+    const stackFrames = record.initiator.stack?.callFrames || [];
+    const initiatorURL = record.initiator.url || stackFrames[0]?.url;
 
     let candidates = recordsByURL.get(initiatorURL) || [];
     // The initiator must come before the initiated request.

package/lighthouse-core/lib/network-request.js

@@ -510,7 +510,7 @@ class NetworkRequest {
 
     const reasonHeader = record.responseHeaders
       .find(header => header.name === 'Non-Authoritative-Reason');
-    const reason = reasonHeader && reasonHeader.value;
+    const reason = reasonHeader?.value;
     return reason === 'HSTS' && NetworkRequest.isSecureRequest(destination);
   }
 

package/lighthouse-core/lib/tracehouse/cpu-profile-model.js

@@ -184,8 +184,7 @@ class CpuProfilerModel {
     if (!event) return false;
     return Boolean(
       event.name === SAMPLER_TRACE_EVENT_NAME &&
-      event.args.data &&
-      event.args.data._syntheticProfilerRange
+      event.args.data?._syntheticProfilerRange
     );
   }
 
@@ -562,9 +561,8 @@ class CpuProfilerModel {
 
       // `Profile` or `ProfileChunk` can partially define these across multiple events.
       // We'll fallback to empty values and worry about validation in the `synthesizeTraceEvents` phase.
-      const cpuProfileArg = (event.args.data && event.args.data.cpuProfile) || {};
-      const timeDeltas =
-        (event.args.data && event.args.data.timeDeltas) || cpuProfileArg.timeDeltas;
+      const cpuProfileArg = event.args.data?.cpuProfile || {};
+      const timeDeltas = event.args.data?.timeDeltas || cpuProfileArg.timeDeltas;
       let profile = profiles.get(event.id);
 
       if (event.name === 'Profile') {
@@ -572,7 +570,7 @@ class CpuProfilerModel {
           id: event.id,
           pid: event.pid,
           tid: event.tid,
-          startTime: (event.args.data && event.args.data.startTime) || event.ts,
+          startTime: event.args.data?.startTime || event.ts,
           nodes: cpuProfileArg.nodes || [],
           samples: cpuProfileArg.samples || [],
           timeDeltas: timeDeltas || [],

package/lighthouse-core/lib/tracehouse/main-thread-tasks.js

@@ -234,7 +234,7 @@ class MainThreadTasks {
       // Do bookkeeping on XHR requester data.
       if (nextTask.event.name === 'XHRReadyStateChange') {
         const data = nextTask.event.args.data;
-        const url = data && data.url;
+        const url = data?.url;
         if (data && url && data.readyState === 1) priorTaskData.xhrs.set(url, nextTask);
       }
 

package/lighthouse-core/lib/tracehouse/trace-processor.js

@@ -425,15 +425,14 @@ class TraceProcessor {
   static findMainFrameIds(events) {
     // Prefer the newer TracingStartedInBrowser event first, if it exists
     const startedInBrowserEvt = events.find(e => e.name === 'TracingStartedInBrowser');
-    if (startedInBrowserEvt && startedInBrowserEvt.args.data &&
-        startedInBrowserEvt.args.data.frames) {
+    if (startedInBrowserEvt?.args.data?.frames) {
       const mainFrame = startedInBrowserEvt.args.data.frames.find(frame => !frame.parent);
-      const frameId = mainFrame && mainFrame.frame;
-      const pid = mainFrame && mainFrame.processId;
+      const frameId = mainFrame?.frame;
+      const pid = mainFrame?.processId;
 
       const threadNameEvt = events.find(e => e.pid === pid && e.ph === 'M' &&
         e.cat === '__metadata' && e.name === 'thread_name' && e.args.name === 'CrRendererMain');
-      const tid = threadNameEvt && threadNameEvt.tid;
+      const tid = threadNameEvt?.tid;
 
       if (pid && tid && frameId) {
         return {
@@ -448,7 +447,7 @@ class TraceProcessor {
     // The first TracingStartedInPage in the trace is definitely our renderer thread of interest
     // Beware: the tracingStartedInPage event can appear slightly after a navigationStart
     const startedInPageEvt = events.find(e => e.name === 'TracingStartedInPage');
-    if (startedInPageEvt && startedInPageEvt.args && startedInPageEvt.args.data) {
+    if (startedInPageEvt?.args?.data) {
       const frameId = startedInPageEvt.args.data.page;
       if (frameId) {
         return {
@@ -463,12 +462,12 @@ class TraceProcessor {
     // If we can't find either TracingStarted event, then we'll fallback to the first navStart that
     // looks like it was loading the main frame with a real URL. Because the schema for this event
     // has changed across Chrome versions, we'll be extra defensive about finding this case.
-    const navStartEvt = events.find(e => Boolean(e.name === 'navigationStart' && e.args &&
-      e.args.data && e.args.data.isLoadingMainFrame && e.args.data.documentLoaderURL));
+    const navStartEvt = events.find(e => Boolean(e.name === 'navigationStart' &&
+      e.args?.data?.isLoadingMainFrame && e.args.data.documentLoaderURL));
     // Find the first resource that was requested and make sure it agrees on the id.
     const firstResourceSendEvt = events.find(e => e.name === 'ResourceSendRequest');
     // We know that these properties exist if we found the events, but TSC doesn't.
-    if (navStartEvt && navStartEvt.args && navStartEvt.args.data &&
+    if (navStartEvt?.args?.data &&
         firstResourceSendEvt &&
         firstResourceSendEvt.pid === navStartEvt.pid &&
         firstResourceSendEvt.tid === navStartEvt.tid) {
@@ -503,7 +502,7 @@ class TraceProcessor {
   static isLCPEvent(evt) {
     if (evt.name !== 'largestContentfulPaint::Invalidate' &&
         evt.name !== 'largestContentfulPaint::Candidate') return false;
-    return Boolean(evt.args && evt.args.frame);
+    return Boolean(evt.args?.frame);
   }
 
   /**
@@ -513,8 +512,7 @@ class TraceProcessor {
   static isLCPCandidateEvent(evt) {
     return Boolean(
       evt.name === 'largestContentfulPaint::Candidate' &&
-      evt.args &&
-      evt.args.frame &&
+      evt.args?.frame &&
       evt.args.data &&
       evt.args.data.size !== undefined
     );
@@ -613,8 +611,7 @@ class TraceProcessor {
       .filter(/** @return {evt is FrameCommittedEvent} */ evt => {
         return Boolean(
           evt.name === 'FrameCommittedInBrowser' &&
-          evt.args.data &&
-          evt.args.data.frame &&
+          evt.args.data?.frame &&
           evt.args.data.url
         );
       })
@@ -723,7 +720,7 @@ class TraceProcessor {
         firstContentfulPaintAllFrames: getTiming(fcpAllFramesEvt.ts),
         firstMeaningfulPaint: frameTimings.timings.firstMeaningfulPaint,
         largestContentfulPaint: frameTimings.timings.largestContentfulPaint,
-        largestContentfulPaintAllFrames: maybeGetTiming(lcpAllFramesEvt && lcpAllFramesEvt.ts),
+        largestContentfulPaintAllFrames: maybeGetTiming(lcpAllFramesEvt?.ts),
         load: frameTimings.timings.load,
         domContentLoaded: frameTimings.timings.domContentLoaded,
         traceEnd: timings.traceEnd,
@@ -735,7 +732,7 @@ class TraceProcessor {
         firstContentfulPaintAllFrames: fcpAllFramesEvt.ts,
         firstMeaningfulPaint: frameTimings.timestamps.firstMeaningfulPaint,
         largestContentfulPaint: frameTimings.timestamps.largestContentfulPaint,
-        largestContentfulPaintAllFrames: lcpAllFramesEvt && lcpAllFramesEvt.ts,
+        largestContentfulPaintAllFrames: lcpAllFramesEvt?.ts,
         load: frameTimings.timestamps.load,
         domContentLoaded: frameTimings.timestamps.domContentLoaded,
         traceEnd: timestamps.traceEnd,
@@ -886,7 +883,7 @@ class TraceProcessor {
     );
 
     /** @param {{ts: number}=} event */
-    const getTimestamp = (event) => event && event.ts;
+    const getTimestamp = (event) => event?.ts;
     /** @type {TraceNavigationTimesForFrame} */
     const timestamps = {
       timeOrigin: timeOriginEvt.ts,

package/lighthouse-core/runner.js

@@ -49,7 +49,7 @@ class Runner {
       Sentry.captureBreadcrumb({
         message: 'Run started',
         category: 'lifecycle',
-        data: sentryContext && sentryContext.extra,
+        data: sentryContext?.extra,
       });
 
       // User can run -G solo, -A solo, or -GA together
@@ -116,7 +116,7 @@ class Runner {
 
       // Use version from gathering stage.
       // If accessibility gatherer didn't run or errored, it won't be in credits.
-      const axeVersion = artifacts.Accessibility && artifacts.Accessibility.version;
+      const axeVersion = artifacts.Accessibility?.version;
       const credits = {
         'axe-core': axeVersion,
       };
@@ -213,7 +213,7 @@ class Runner {
       };
     }).sort((a, b) => a.startTime - b.startTime);
     const runnerEntry = timingEntries.find(e => e.name === 'lh:runner:run');
-    return {entries: timingEntries, total: runnerEntry && runnerEntry.duration || 0};
+    return {entries: timingEntries, total: runnerEntry?.duration || 0};
   }
 
   /**
@@ -367,7 +367,7 @@ class Runner {
           return narrowedArtifacts;
         }, /** @type {LH.Artifacts} */ ({}));
       const product = await audit.audit(narrowedArtifacts, auditContext);
-      runWarnings.push(...product.runWarnings || []);
+      runWarnings.push(...(product.runWarnings || []));
 
       auditResult = Audit.generateAuditResult(audit, product);
     } catch (err) {