lighthouse 9.1.0-dev.20211213 → 9.1.0-dev.20211214

package/lighthouse-core/audits/apple-touch-icon.js

@@ -56,8 +56,8 @@ class AppleTouchIcon extends Audit {
     const passed = appleTouchIcons.length !== 0;
 
     const warnings = [];
-    if (appleTouchIcons.filter(el => el.rel === 'apple-touch-icon-precomposed').length !== 0
-      && appleTouchIcons.filter(el => el.rel === 'apple-touch-icon').length === 0) {
+    if (appleTouchIcons.filter(el => el.rel === 'apple-touch-icon-precomposed').length !== 0 &&
+      appleTouchIcons.filter(el => el.rel === 'apple-touch-icon').length === 0) {
       warnings.push(str_(UIStrings.precomposedWarning));
     }
 

package/lighthouse-core/audits/byte-efficiency/legacy-javascript.js

@@ -178,8 +178,6 @@ class LegacyJavascript extends ByteEfficiencyAudit {
       ['Array.isArray', 'es6.array.is-array'],
       ['Array.prototype.map', 'es6.array.map'],
       ['Array.of', 'es6.array.of'],
-      ['Array.prototype.reduce', 'es6.array.reduce'],
-      ['Array.prototype.reduceRight', 'es6.array.reduce-right'],
       ['Array.prototype.some', 'es6.array.some'],
       ['Date.now', 'es6.date.now'],
       ['Date.prototype.toISOString', 'es6.date.to-iso-string'],
@@ -188,7 +186,6 @@ class LegacyJavascript extends ByteEfficiencyAudit {
       ['Function.prototype.name', 'es6.function.name'],
       ['Number.isInteger', 'es6.number.is-integer'],
       ['Number.isSafeInteger', 'es6.number.is-safe-integer'],
-      ['Number.parseInt', 'es6.number.parse-int'],
       ['Object.defineProperties', 'es6.object.define-properties'],
       ['Object.defineProperty', 'es6.object.define-property'],
       ['Object.freeze', 'es6.object.freeze'],

package/lighthouse-core/audits/no-unload-listeners.js

@@ -15,7 +15,7 @@ const UIStrings = {
   /** Descriptive title of a Lighthouse audit that checks if a web page has 'unload' event listeners and finds that it is using them. */
   failureTitle: 'Registers an `unload` listener',
   /** Description of a Lighthouse audit that tells the user why pages should not use the 'unload' event. This is displayed after a user expands the section to see more. 'Learn More' becomes link text to additional documentation. */
-  description: 'The `unload` event does not fire reliably and listening for it can prevent browser optimizations like the Back-Forward Cache. Consider using the `pagehide` or `visibilitychange` events instead. [Learn more](https://developers.google.com/web/updates/2018/07/page-lifecycle-api#the-unload-event)',
+  description: 'The `unload` event does not fire reliably and listening for it can prevent browser optimizations like the Back-Forward Cache. Use `pagehide` or `visibilitychange` events instead. [Learn more](https://web.dev/bfcache/#never-use-the-unload-event)',
 };
 
 const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings);

package/lighthouse-core/computed/critical-request-chains.js

@@ -41,8 +41,8 @@ class CriticalRequestChains {
     }
 
     // Iframes are considered High Priority but they are not render blocking
-    const isIframe = request.resourceType === NetworkRequest.TYPES.Document
-      && request.frameId !== mainResource.frameId;
+    const isIframe = request.resourceType === NetworkRequest.TYPES.Document &&
+      request.frameId !== mainResource.frameId;
     // XHRs are fetched at High priority, but we exclude them, as they are unlikely to be critical
     // Images are also non-critical.
     // Treat any missed images, primarily favicons, as non-critical resources

package/lighthouse-core/computed/unused-css.js

@@ -98,9 +98,9 @@ class UnusedCSS {
       const firstRuleStart = preview.indexOf('{');
       const firstRuleEnd = preview.indexOf('}');
 
-      if (firstRuleStart === -1 || firstRuleEnd === -1
-          || firstRuleStart > firstRuleEnd
-          || firstRuleStart > PREVIEW_LENGTH) {
+      if (firstRuleStart === -1 || firstRuleEnd === -1 ||
+          firstRuleStart > firstRuleEnd ||
+          firstRuleStart > PREVIEW_LENGTH) {
         // We couldn't determine the first rule-set or it's not within the preview
         preview = preview.slice(0, PREVIEW_LENGTH) + '...';
       } else if (firstRuleEnd < PREVIEW_LENGTH) {

package/lighthouse-core/config/default-config.js

@@ -463,6 +463,7 @@ const defaultConfig = {
         {id: 'non-composited-animations', weight: 0},
         {id: 'unsized-images', weight: 0},
         {id: 'viewport', weight: 0},
+        {id: 'no-unload-listeners', weight: 0},
 
         // Budget audits.
         {id: 'performance-budget', weight: 0, group: 'budgets'},
@@ -566,7 +567,6 @@ const defaultConfig = {
         {id: 'doctype', weight: 1, group: 'best-practices-browser-compat'},
         {id: 'charset', weight: 1, group: 'best-practices-browser-compat'},
         // General Group
-        {id: 'no-unload-listeners', weight: 1, group: 'best-practices-general'},
         {id: 'js-libraries', weight: 0, group: 'best-practices-general'},
         {id: 'deprecations', weight: 1, group: 'best-practices-general'},
         {id: 'errors-in-console', weight: 1, group: 'best-practices-general'},

package/lighthouse-core/fraggle-rock/gather/base-gatherer.js

@@ -17,7 +17,7 @@
  */
 class FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
-  meta = {supportedModes: []}
+  meta = {supportedModes: []};
 
   /**
    * Method to start observing a page for an arbitrary period of time.

package/lighthouse-core/gather/driver/wait-for-condition.js

@@ -5,7 +5,7 @@
  */
 'use strict';
 
-/* global window, performance */
+/* global window */
 
 const log = require('lighthouse-logger');
 const LHError = require('../../lib/lh-error.js');

package/lighthouse-core/gather/gatherers/accessibility.js

@@ -148,7 +148,7 @@ class Accessibility extends FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['snapshot', 'navigation'],
-  }
+  };
 
   /**
    * @param {LH.Gatherer.FRTransitionalContext} passContext

package/lighthouse-core/gather/gatherers/anchor-elements.js

@@ -94,7 +94,7 @@ class AnchorElements extends FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['snapshot', 'navigation'],
-  }
+  };
 
   /**
    * @param {LH.Gatherer.FRTransitionalContext} passContext

package/lighthouse-core/gather/gatherers/cache-contents.js

@@ -41,7 +41,7 @@ class CacheContents extends FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['snapshot', 'navigation'],
-  }
+  };
 
   /**
    * Creates an array of cached URLs.

package/lighthouse-core/gather/gatherers/console-messages.js

@@ -34,7 +34,7 @@ class ConsoleMessages extends FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['timespan', 'navigation'],
-  }
+  };
 
   constructor() {
     super();

package/lighthouse-core/gather/gatherers/dobetterweb/doctype.js

@@ -28,7 +28,7 @@ class Doctype extends FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['snapshot', 'navigation'],
-  }
+  };
 
   /**
    * @param {LH.Gatherer.FRTransitionalContext} passContext

package/lighthouse-core/gather/gatherers/dobetterweb/domstats.js

@@ -80,7 +80,7 @@ class DOMStats extends FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['snapshot', 'navigation'],
-  }
+  };
 
   /**
    * @param {LH.Gatherer.FRTransitionalContext} passContext

package/lighthouse-core/gather/gatherers/dobetterweb/optimized-images.js

@@ -38,7 +38,7 @@ class OptimizedImages extends FRGatherer {
   meta = {
     supportedModes: ['timespan', 'navigation'],
     dependencies: {DevtoolsLog: DevtoolsLog.symbol},
-  }
+  };
 
   constructor() {
     super();

package/lighthouse-core/gather/gatherers/dobetterweb/password-inputs-with-prevented-paste.js

@@ -32,7 +32,7 @@ class PasswordInputsWithPreventedPaste extends FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['snapshot', 'navigation'],
-  }
+  };
 
   /**
    * @param {LH.Gatherer.FRTransitionalContext} passContext

package/lighthouse-core/gather/gatherers/dobetterweb/response-compression.js

@@ -43,7 +43,7 @@ class ResponseCompression extends FRGatherer {
   meta = {
     supportedModes: ['timespan', 'navigation'],
     dependencies: {DevtoolsLog: DevtoolsLog.symbol},
-  }
+  };
 
   /**
    * @param {LH.Artifacts.NetworkRequest[]} networkRecords

package/lighthouse-core/gather/gatherers/dobetterweb/tags-blocking-first-paint.js

@@ -22,7 +22,7 @@ const NetworkRecords = require('../../../computed/network-records.js');
 const DevtoolsLog = require('../devtools-log.js');
 const FRGatherer = require('../../../fraggle-rock/gather/base-gatherer.js');
 
-/* global document, window, performance, HTMLLinkElement, SVGScriptElement */
+/* global document, window, HTMLLinkElement, SVGScriptElement */
 
 /** @typedef {{href: string, media: string, msSinceHTMLEnd: number, matches: boolean}} MediaChange */
 /** @typedef {{tagName: 'LINK', url: string, href: string, rel: string, media: string, disabled: boolean, mediaChanges: Array<MediaChange>}} LinkTag */
@@ -119,7 +119,7 @@ class TagsBlockingFirstPaint extends FRGatherer {
   meta = {
     supportedModes: ['navigation'],
     dependencies: {DevtoolsLog: DevtoolsLog.symbol},
-  }
+  };
 
   /**
    * @param {Array<LH.Artifacts.NetworkRequest>} networkRecords

package/lighthouse-core/gather/gatherers/form-elements.js

@@ -49,8 +49,8 @@ function collectFormElements() {
       forms.set(parentFormElement, newFormObj);
     }
     const formObj = forms.get(parentFormElement) || formlessObj;
-    if (child instanceof HTMLInputElement || child instanceof HTMLTextAreaElement
-      || child instanceof HTMLSelectElement) {
+    if (child instanceof HTMLInputElement || child instanceof HTMLTextAreaElement ||
+      child instanceof HTMLSelectElement) {
       formObj.inputs.push({
         id: child.id,
         name: child.name,
@@ -89,7 +89,7 @@ class FormElements extends FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['snapshot', 'navigation'],
-  }
+  };
 
   /**
    * @param {LH.Gatherer.FRTransitionalContext} passContext

package/lighthouse-core/gather/gatherers/full-page-screenshot.js

@@ -46,7 +46,7 @@ class FullPageScreenshot extends FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['snapshot', 'timespan', 'navigation'],
-  }
+  };
 
   /**
    * @param {LH.Gatherer.FRTransitionalContext} context

package/lighthouse-core/gather/gatherers/global-listeners.js

@@ -18,7 +18,7 @@ class GlobalListeners extends FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['snapshot', 'timespan', 'navigation'],
-  }
+  };
 
   /**
    * @param {LH.Crdp.DOMDebugger.EventListener} listener

package/lighthouse-core/gather/gatherers/iframe-elements.js

@@ -39,7 +39,7 @@ class IFrameElements extends FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['snapshot', 'navigation'],
-  }
+  };
 
   /**
    * @param {LH.Gatherer.FRTransitionalContext} passContext

package/lighthouse-core/gather/gatherers/inspector-issues.js

@@ -19,7 +19,7 @@ class InspectorIssues extends FRGatherer {
   meta = {
     supportedModes: ['timespan', 'navigation'],
     dependencies: {DevtoolsLog: DevtoolsLog.symbol},
-  }
+  };
 
   constructor() {
     super();

package/lighthouse-core/gather/gatherers/js-usage.js

@@ -14,7 +14,7 @@ class JsUsage extends FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['snapshot', 'timespan', 'navigation'],
-  }
+  };
 
   constructor() {
     super();

package/lighthouse-core/gather/gatherers/main-document-content.js

@@ -19,7 +19,7 @@ class MainDocumentContent extends FRGatherer {
   meta = {
     supportedModes: ['navigation'],
     dependencies: {DevtoolsLog: DevtoolsLog.symbol},
-  }
+  };
 
   /**
    *

package/lighthouse-core/gather/gatherers/meta-elements.js

@@ -43,7 +43,7 @@ class MetaElements extends FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['snapshot', 'navigation'],
-  }
+  };
 
   /**
    * @param {LH.Gatherer.FRTransitionalContext} passContext

package/lighthouse-core/gather/gatherers/script-elements.js

@@ -70,7 +70,7 @@ class ScriptElements extends FRGatherer {
   meta = {
     supportedModes: ['timespan', 'navigation'],
     dependencies: {DevtoolsLog: DevtoolsLog.symbol},
-  }
+  };
 
   /**
    * @param {LH.Gatherer.FRTransitionalContext} context

package/lighthouse-core/gather/gatherers/seo/embedded-content.js

@@ -44,7 +44,7 @@ class EmbeddedContent extends FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['snapshot', 'navigation'],
-  }
+  };
 
   /**
    * @param {LH.Gatherer.FRTransitionalContext} passContext

package/lighthouse-core/gather/gatherers/seo/font-size.js

@@ -182,7 +182,7 @@ class FontSize extends FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['snapshot', 'navigation'],
-  }
+  };
 
   /**
    * @param {LH.Gatherer.FRProtocolSession} session

package/lighthouse-core/gather/gatherers/seo/robots-txt.js

@@ -30,7 +30,7 @@ class RobotsTxt extends FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['snapshot', 'navigation'],
-  }
+  };
 
   /**
    * @param {LH.Gatherer.FRTransitionalContext} passContext

package/lighthouse-core/gather/gatherers/service-worker.js

@@ -12,7 +12,7 @@ class ServiceWorker extends FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['navigation'],
-  }
+  };
 
   /**
    * @param {LH.Gatherer.PassContext} passContext

package/lighthouse-core/gather/gatherers/source-maps.js

@@ -15,7 +15,7 @@ class SourceMaps extends FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['timespan', 'navigation'],
-  }
+  };
 
   constructor() {
     super();

package/lighthouse-core/gather/gatherers/trace-elements.js

@@ -45,7 +45,7 @@ class TraceElements extends FRGatherer {
   meta = {
     supportedModes: ['timespan', 'navigation'],
     dependencies: {Trace: Trace.symbol},
-  }
+  };
 
   /** @type {Map<string, string>} */
   animationIdToName = new Map();

package/lighthouse-core/gather/gatherers/viewport-dimensions.js

@@ -31,7 +31,7 @@ class ViewportDimensions extends FRGatherer {
   /** @type {LH.Gatherer.GathererMeta} */
   meta = {
     supportedModes: ['snapshot', 'timespan', 'navigation'],
-  }
+  };
 
   /**
    * @param {LH.Gatherer.FRTransitionalContext} passContext

package/lighthouse-core/lib/dependency-graph/simulator/network-analyzer.js

@@ -198,8 +198,9 @@ class NetworkAnalyzer {
       if (!Number.isFinite(timing.receiveHeadersEnd) || timing.receiveHeadersEnd < 0) return;
       if (!record.resourceType) return;
 
-      const serverResponseTimePercentage = SERVER_RESPONSE_PERCENTAGE_OF_TTFB[record.resourceType]
-        || DEFAULT_SERVER_RESPONSE_PERCENTAGE;
+      const serverResponseTimePercentage =
+        SERVER_RESPONSE_PERCENTAGE_OF_TTFB[record.resourceType] ||
+        DEFAULT_SERVER_RESPONSE_PERCENTAGE;
       const estimatedServerResponseTime = timing.receiveHeadersEnd * serverResponseTimePercentage;
 
       // When connection was reused...

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "lighthouse",
-  "version": "9.1.0-dev.20211213",
+  "version": "9.1.0-dev.20211214",
   "description": "Automated auditing, performance metrics, and best practices for the web.",
   "main": "./lighthouse-core/index.js",
   "bin": {
@@ -111,7 +111,7 @@
     "@types/chrome": "^0.0.154",
     "@types/configstore": "^4.0.0",
     "@types/cpy": "^5.1.0",
-    "@types/eslint": "^4.16.6",
+    "@types/eslint": "^8.2.1",
     "@types/estree": "^0.0.50",
     "@types/gh-pages": "^2.0.0",
     "@types/google.analytics": "0.0.39",
@@ -132,8 +132,8 @@
     "@types/ws": "^7.0.0",
     "@types/yargs": "^16.0.0",
     "@types/yargs-parser": "^15.0.0",
-    "@typescript-eslint/eslint-plugin": "^4.30.0",
-    "@typescript-eslint/parser": "^4.30.0",
+    "@typescript-eslint/eslint-plugin": "^5.6.0",
+    "@typescript-eslint/parser": "^5.6.0",
     "acorn": "^8.5.0",
     "angular": "^1.7.4",
     "archiver": "^3.0.0",
@@ -146,10 +146,11 @@
     "csv-validator": "^0.0.3",
     "devtools-protocol": "0.0.939404",
     "es-main": "^1.0.2",
-    "eslint": "^7.23.0",
-    "eslint-config-google": "^0.9.1",
-    "eslint-plugin-import": "^2.24.2",
-    "eslint-plugin-local-rules": "0.1.0",
+    "eslint": "^8.4.1",
+    "eslint-config-google": "^0.14.0",
+    "eslint-formatter-codeframe": "^7.32.1",
+    "eslint-plugin-import": "^2.25.3",
+    "eslint-plugin-local-rules": "1.1.0",
     "event-target-shim": "^6.0.2",
     "firebase": "^9.0.2",
     "gh-pages": "^2.0.1",

package/shared/localization/locales/en-US.json

@@ -1218,7 +1218,7 @@
     "message": "Server Backend Latencies"
   },
   "lighthouse-core/audits/no-unload-listeners.js | description": {
-    "message": "The `unload` event does not fire reliably and listening for it can prevent browser optimizations like the Back-Forward Cache. Consider using the `pagehide` or `visibilitychange` events instead. [Learn more](https://developers.google.com/web/updates/2018/07/page-lifecycle-api#the-unload-event)"
+    "message": "The `unload` event does not fire reliably and listening for it can prevent browser optimizations like the Back-Forward Cache. Use `pagehide` or `visibilitychange` events instead. [Learn more](https://web.dev/bfcache/#never-use-the-unload-event)"
   },
   "lighthouse-core/audits/no-unload-listeners.js | failureTitle": {
     "message": "Registers an `unload` listener"

package/shared/localization/locales/en-XL.json

@@ -1218,7 +1218,7 @@
     "message": "Ŝér̂v́êŕ B̂áĉḱêńd̂ Ĺât́êńĉíêś"
   },
   "lighthouse-core/audits/no-unload-listeners.js | description": {
-    "message": "T̂h́ê `unload` év̂én̂t́ d̂óêś n̂ót̂ f́îŕê ŕêĺîáb̂ĺŷ án̂d́ l̂íŝt́êńîńĝ f́ôŕ ît́ ĉán̂ ṕr̂év̂én̂t́ b̂ŕôẃŝér̂ óp̂t́îḿîźât́îón̂ś l̂ík̂é t̂h́ê B́âćk̂-F́ôŕŵár̂d́ Ĉáĉh́ê. Ćôńŝíd̂ér̂ úŝín̂ǵ t̂h́ê `pagehide` ór̂ `visibilitychange` év̂én̂t́ŝ ín̂śt̂éâd́. [L̂éâŕn̂ ḿôŕê](https://developers.google.com/web/updates/2018/07/page-lifecycle-api#the-unload-event)"
+    "message": "T̂h́ê `unload` év̂én̂t́ d̂óêś n̂ót̂ f́îŕê ŕêĺîáb̂ĺŷ án̂d́ l̂íŝt́êńîńĝ f́ôŕ ît́ ĉán̂ ṕr̂év̂én̂t́ b̂ŕôẃŝér̂ óp̂t́îḿîźât́îón̂ś l̂ík̂é t̂h́ê B́âćk̂-F́ôŕŵár̂d́ Ĉáĉh́ê. Úŝé `pagehide` ôŕ `visibilitychange` êv́êńt̂ś îńŝt́êád̂. [Ĺêár̂ń m̂ór̂é](https://web.dev/bfcache/#never-use-the-unload-event)"
   },
   "lighthouse-core/audits/no-unload-listeners.js | failureTitle": {
     "message": "R̂éĝíŝt́êŕŝ án̂ `unload` ĺîśt̂én̂ér̂"